Bug#897429: [Pkg-tcltk-devel] Bug#897429: ppc64el: Shared Object not available in the platform

[Breno Leitao]

Hi Sergei,

On Wed, May 02, 2018 at 06:25:55PM +, Sergei Golovan wrote:
> Hi Bruno,
> 
> If you have access to the ppc64el hardware, could you test the fix (I've
> attached a diff, which is to be applied to the 2.1.0-15 sources)? If it's
> okay, I'll ask the release team about a stable update.

Yes, I was able to test it and it is working as expected:

➜  dpkg -c tcl-tclreadline_2.1.0-15+deb9u1_ppc64el.deb | grep so
-rw-r--r-- root/root 67664 2016-10-08 05:04 
./usr/lib/powerpc64le-linux-gnu/libtclreadline-2.1.0.so
lrwxrwxrwx root/root 0 2016-10-08 05:04 
./usr/lib/powerpc64le-linux-gnu/libtclreadline.so -> libtclreadline-2.1.0.so

Thanks for working on it,
Breno

Bug#897429: [Pkg-tcltk-devel] Bug#897429: ppc64el: Shared Object not available in the platform

[Sergei Golovan]

Hi Bruno,

If you have access to the ppc64el hardware, could you test the fix (I've
attached a diff, which is to be applied to the 2.1.0-15 sources)? If it's
okay, I'll ask the release team about a stable update.

Cheers!
-- 
Sergei Golovan
diff -Nru tclreadline-2.1.0/debian/changelog tclreadline-2.1.0/debian/changelog
--- tclreadline-2.1.0/debian/changelog	2016-10-08 12:04:28.0 +0300
+++ tclreadline-2.1.0/debian/changelog	2016-10-08 12:04:28.0 +0300
@@ -1,3 +1,10 @@
+tclreadline (2.1.0-15+deb9u1) stretch; urgency=medium
+
+  * Add a patch by Breno Leitao which fixes building the shared library for
+   the ppc64el architecture (closes: #897429).
+
+ -- Sergei Golovan   Sat, 08 Oct 2016 12:04:28 +0300
+
 tclreadline (2.1.0-15) unstable; urgency=low
 
   * Fixed implicit function declararion warning (replaced the deprecated
diff -Nru tclreadline-2.1.0/debian/patches/ppc64el.patch tclreadline-2.1.0/debian/patches/ppc64el.patch
--- tclreadline-2.1.0/debian/patches/ppc64el.patch	1970-01-01 03:00:00.0 +0300
+++ tclreadline-2.1.0/debian/patches/ppc64el.patch	2016-10-08 12:04:28.0 +0300
@@ -0,0 +1,15 @@
+Author: Breno Leitao
+Description: Patch fixes building the shared library for ppc64el.
+Last-Modified: Wed, 02 May 2018 21:11:16 +0300
+Debian-Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=897429
+
+--- a/aux/ltconfig
 b/aux/ltconfig
+@@ -2000,7 +2000,6 @@
+   else
+ # Only the GNU ld.so supports shared libraries on MkLinux.
+ case "$host_cpu" in
+-powerpc*) dynamic_linker=no ;;
+ *) dynamic_linker='Linux ld.so' ;;
+ esac
+   fi
diff -Nru tclreadline-2.1.0/debian/patches/series tclreadline-2.1.0/debian/patches/series
--- tclreadline-2.1.0/debian/patches/series	2016-10-08 12:04:28.0 +0300
+++ tclreadline-2.1.0/debian/patches/series	2016-10-08 12:04:28.0 +0300
@@ -12,3 +12,4 @@
 functions.patch
 ding.patch
 stubs.patch
+ppc64el.patch

Bug#897429: [Pkg-tcltk-devel] Bug#897429: ppc64el: Shared Object not available in the platform

[Sergei Golovan]

tags 897429 + stretch
fixed 897429 2.3.1+dfsg-1
thanks

Hi Breno,

On Wed, May 2, 2018 at 5:12 PM Breno Leitao  wrote:

> Dear maintainer,

> I just found that this package is not generating the shared object for
> ppc64el platform, as showed below:

>dpkg -c tcl-tclreadline_2.1.0-15_ppc64el.deb | grep
lib/powerpc64le-linux-gnu
>drwxr-xr-x root/root 0 2016-10-08 05:04
./usr/lib/powerpc64le-linux-gnu/
>-rw-r--r-- root/root 25340 2016-10-08 05:04
./usr/lib/powerpc64le-linux-gnu/libtclreadline.a

Right, it's missing.


> Looking at the 'configure' process, I see the failure on detecting if
> the shared object should be built. This is the build log line and
> explains the problem.

>checking whether to build shared libraries... no

> I checked against unstable/buster version (2.3) and this problem does
> not happen anymore. So, this fix will only need to make Stretch.

> The real cause of this problem is realted to the following exemption of
> powerpc, which might be removed.

> case "$host_cpu" in
>  powerpc*) dynamic_linker=no ;
>  *) dynamic_linker='Linux ld.so' ;;


> With the patch above, I can see the shared objects being generated:

Thank you for the analysis and for the bugreport. I'll release the fix and
update the package in stretch in a few days.

Cheers!
-- 
Sergei Golovan