Bug#902004: /usr/sbin/xrdp-build-pulse-modules: incorrect usage of dget

2018-08-08 Thread Jonathan Lane
Package: xrdp-pulseaudio-installer
Version: 0.9.6-1~bpo9+1
Followup-For: Bug #902004

Dear Maintainer,

The issue is on lines 22-34 of the script /usr/sbin/xrdp-build-pulse-modules.  
The text parsing to automatically populate the $pulseaudio_version, 
$pulseaudio_upstream_version, $mirror, and $suite variables is all wrong, 
possibly due to output format changes in "apt show" and "dpkg-query".  Hard 
coding the correct values and re-running the script produces xrdp pulseaudio 
modules that operate as expected.



-- System Information:
Debian Release: 9.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: arm64 (aarch64)

Kernel: Linux 4.9.0-6-arm64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xrdp-pulseaudio-installer depends on:
ii  build-essential  12.3
ii  devscripts   2.17.6+deb9u2
ii  intltool 0.51.0-3
ii  libasound2-dev   1.1.3-5
ii  libasyncns-dev   0.8-6
ii  libavahi-client-dev  0.6.32-2
ii  libbluetooth-dev 5.43-2+deb9u1
ii  libcap-dev   1:2.25-1
ii  libfftw3-dev 3.3.5-3
ii  libgconf2-dev3.2.6-4+b1
ii  libglib2.0-dev   2.50.3-2
ii  libgtk-3-dev 3.22.11-1
ii  libice-dev   2:1.0.9-2
ii  libjack-dev  1:0.125.0-2
ii  libjson-c-dev0.12.1-1.1
ii  liblirc-dev [liblircclient-dev]  0.9.4c-9
ii  liblircclient-dev0.9.4c-9
ii  libltdl-dev  2.4.6-2
ii  liborc-0.4-dev   1:0.4.26-2
ii  libsamplerate0-dev   0.1.8-8+b2
ii  libsbc-dev   1.3-2
ii  libsndfile1-dev  1.0.27-3
ii  libsoxr-dev  0.1.2-2
ii  libspeexdsp-dev  1.2~rc1.2-1+b2
ii  libssl-dev   1.1.0f-3+deb9u2
ii  libsystemd-dev   232-25+deb9u4
ii  libtdb-dev   1.3.11-2
ii  libudev-dev  232-25+deb9u4
ii  libwebrtc-audio-processing-dev   0.3-1
ii  libwrap0-dev 7.6.q-26
ii  libx11-xcb-dev   2:1.6.4-3
ii  libxcb1-dev  1.12-1
ii  libxtst-dev  2:1.2.3-1
ii  pulseaudio   10.0-1+deb9u1

xrdp-pulseaudio-installer recommends no packages.

xrdp-pulseaudio-installer suggests no packages.

-- no debconf information



Bug#902004: /usr/sbin/xrdp-build-pulse-modules: incorrect usage of dget

2018-06-21 Thread Willem Mulder
Package: xrdp-pulseaudio-installer
Version: 0.9.6-1
Severity: grave
File: /usr/sbin/xrdp-build-pulse-modules
Justification: renders package unusable

Dear Maintainer,

When executing xrdp-build-pulse-modules, dget is used incorrectly, as
indicated by the usage information dget prints. This renders this
package practically unusable. Below is the output of
xrdp-build-pulse-modules (indented with 4 spaces):

+ mktemp -d
+ tmp=/tmp/tmp.efpcYuYQxy
+ cd /tmp/tmp.efpcYuYQxy
+ dpkg-query -W -f=${source:Version} pulseaudio
+ pulseaudio_version=11.1-5
+ dpkg-query -W -f=${source:Upstream-Version} pulseaudio
+ pulseaudio_upstream_version=11.1
+ test -x /usr/bin/apt
+ apt show pulseaudio=11.1-5
+ set -- Package: pulseaudio Version: 11.1-5 Priority: optional Section: 
sound Maintainer: Pulseaudio maintenance team 
 Installed-Size: 6,248 kB 
Depends: libasound2 (>= 1.0.24.1), libc6 (>= 2.27), libcap2 (>= 1:2.10), 
libdbus-1-3 (>= 1.9.14), libgcc1 (>= 1:3.0), libice6 (>= 1:1.0.0), libltdl7 (>= 
2.4.6), liborc-0.4-0 (>= 1:0.4.25), libpulse0 (= 11.1-5), libsm6, libsndfile1 
(>= 1.0.20), libsoxr0 (>= 0.1.0), libspeexdsp1 (>= 1.2~beta3.2-1), libstdc++6 
(>= 4.1.1), libsystemd0, libtdb1 (>= 1.2.7+git20101214), libudev1 (>= 183), 
libwebrtc-audio-processing1, libx11-6, libx11-xcb1, libxcb1, libxtst6, adduser, 
lsb-base (>= 3.2-13), libasound2-plugins, pulseaudio-utils Recommends: rtkit, 
libpam-systemd, dbus-user-session Suggests: udev, pavumeter, pavucontrol, 
paman, paprefs Homepage: http://www.pulseaudio.org Tag: implemented-in::c, 
interface::daemon, network::client, network::server, protocol::tcp, 
role::program, works-with::audio Download-Size: 1,115 kB APT-Manual-Installed: 
no APT-Sources: http://ftp.nl.debian.org/debian unstable/main amd64 Packages 
Description: PulseAudio sound server PulseAudio, previously known as 
Polypaudio, is a sound server for POSIX and WIN32 systems. It is a drop in 
replacement for the ESD sound server with much better latency, 
mixing/re-sampling quality and overall architecture. . These are some of 
PulseAudio's features: . * High quality software mixing of multiple audio 
streams with support for more than one sink/source. May be used to combine 
multiple sound cards into one (with sample rate adjustment). . * Wide range of 
supported client libraries. ESD, ALSA, oss, libao and GStreamer client 
applications are supported as-is. Native PulseAudio plug-ins are also available 
for xmms and mplayer. . * Good low latency behaviour and very accurate latency 
measurement for playback and recording. Ability to fully synchronize multiple 
playback streams. . * Network transparency, allowing an application to play 
back or record audio on a different machine than the one it is running on. . * 
Extensible plug-in architecture with plug-ins for jackd, multicast-rtp lirc and 
avahi, just to name a few. . This package contains the daemon and basic module 
set.
+ mirror=pulseaudio
+ suite=Version:
+ test xpulseaudio = x
+ dget pulseaudio/pool/Version:/p/pulseaudio/pulseaudio_11.1-5.dsc
Usage: dget [options] URL ...
   dget [options] [--all] package[=version] ...

Downloads Debian packages (source and binary) from the specified URLs 
(first form),
or using the mirror configured in /etc/apt/sources.list(.d) (second form).
It is capable of downloading several packages at once.

   -a, --all   Package is a source package; download all binary packages
   -b, --backupMove files that would be overwritten to ./backup
   -q, --quiet Suppress wget/curl output
   -d, --download-only
   Do not extract downloaded source
   -x, --extract   Unpack downloaded source (default)
   -u, --allow-unauthenticated
   Do no attempt to verify source package signature
   --build Build package with dpkg-buildpackage after download
   --path DIR  Check these directories in addition to the apt archive;
   if DIR='' then clear current list (may be used multiple
   times)
   --insecure  Do not check SSL certificates when downloading
   --no-cache  Disable server-side HTTP cache
   --no-conf   Don't read devscripts config files;
   must be the first option given
   -h, --help  This message
   -V, --version   Version information

Default settings modified by devscripts configuration files:
  (none)
+ cd pulseaudio-11.1
/usr/sbin/xrdp-build-pulse-modules: 40: cd: can't cd to pulseaudio-11.1

Kind regards,

Willem Mulder

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB.U