Bug#905674: Ready for closing?

2018-12-02 Thread Rogério Brito
Super thanks, Didier.

I'm extremely busy right now!

Thanks once again,

Rogério.

-- 
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

Em sáb, 1 de dez de 2018 20:57, Didier 'OdyX' Raboud  Control: tags -1 +pending
>
> Le dimanche, 21 octobre 2018, 18.59:26 h CET Ole Tange a écrit :
> > Upgrading from 20141022 to 20180922 seems to address all issues.
> >
> > Can we close this ticket?
>
> Live from the Bern BSP.
>
> I have taken a long look at this bugreport log, and have concluded that
> under
> GPL, Debian can as well just remove the concerned "parallel --citation"
> functionality, and keep "parallel" in Debian main.
>
> I have therefore uploaded a DELAYED/0 NMU with version 20161222-1.1 fixing
> this bug through removal of all the citation mechanism. The full debdiff
> is
> attached.
>
> Cheers,
> OdyX


Bug#905674: Ready for closing?

2018-12-01 Thread Didier 'OdyX' Raboud
Control: tags -1 +pending

Le dimanche, 21 octobre 2018, 18.59:26 h CET Ole Tange a écrit :
> Upgrading from 20141022 to 20180922 seems to address all issues.
> 
> Can we close this ticket?

Live from the Bern BSP. 

I have taken a long look at this bugreport log, and have concluded that under 
GPL, Debian can as well just remove the concerned "parallel --citation" 
functionality, and keep "parallel" in Debian main.

I have therefore uploaded a DELAYED/0 NMU with version 20161222-1.1 fixing 
this bug through removal of all the citation mechanism. The full debdiff is 
attached.

Cheers,
OdyXdiff -Nru parallel-20161222/debian/changelog parallel-20161222/debian/changelog
--- parallel-20161222/debian/changelog	2016-12-31 14:24:10.0 +0100
+++ parallel-20161222/debian/changelog	2018-12-01 23:18:34.0 +0100
@@ -1,3 +1,11 @@
+parallel (20161222-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Update Vcs-* to point to salsa
+  * Remove citation requirements completely (Closes: #905674)
+
+ -- Didier Raboud   Sat, 01 Dec 2018 23:18:34 +0100
+
 parallel (20161222-1) unstable; urgency=medium
 
   [ Rogério Brito ]
diff -Nru parallel-20161222/debian/control parallel-20161222/debian/control
--- parallel-20161222/debian/control	2016-12-31 14:24:10.0 +0100
+++ parallel-20161222/debian/control	2018-12-01 21:08:59.0 +0100
@@ -10,8 +10,8 @@
texinfo
 Standards-Version: 3.9.6
 Homepage: https://www.gnu.org/software/parallel/
-Vcs-Git: https://anonscm.debian.org/git/collab-maint/parallel.git
-Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/parallel.git
+Vcs-Git: https://salsa.debian.org/debian/parallel.git
+Vcs-Browser: https://salsa.debian.org/debian/parallel
 
 Package: parallel
 Architecture: all
diff -Nru parallel-20161222/debian/patches/remove-overreaching-citation-request.patch parallel-20161222/debian/patches/remove-overreaching-citation-request.patch
--- parallel-20161222/debian/patches/remove-overreaching-citation-request.patch	1970-01-01 01:00:00.0 +0100
+++ parallel-20161222/debian/patches/remove-overreaching-citation-request.patch	2018-12-01 23:11:50.0 +0100
@@ -0,0 +1,169 @@
+Description: Remove overreaching citation notice
+ Quoting the gpl-faq:
+ .
+ > Does the GPL allow me to add terms that would require citation or
+ > acknowledgment in research papers which use the GPL-covered software or its
+ > output? (#RequireCitation)
+ > .
+ > No, this is not permitted under the terms of the GPL. While we recognize
+ > that proper citation is an important part of academic publications,
+ > citation cannot be added as an additional requirement to the GPL. Requiring
+ > citation in research papers which made use of GPL'd software goes beyond
+ > what would be an acceptable additional requirement under section 7(b) of
+ > GPLv3, and therefore would be considered an additional restriction under
+ > Section 7 of the GPL. And copyright law does not allow you to place such a
+ > requirement on the output of software, regardless of whether it is licensed
+ > under the terms of the GPL or some other license.
+ .
+ Therefore, removing this to make parallel GPL-compliant.
+
+Author: Didier Raboud 
+Bug-Debian: https://bugs.debian.org/905674
+
+Last-Update: 2018-12-01
+
+--- a/src/parallel
 b/src/parallel
+@@ -906,7 +906,6 @@
+ 	 "gnu" => \$opt::gnu,
+ 	 "link|xapply" => \$opt::link,
+ 	 "linkinputsource|xapplyinputsource=i" => \@opt::linkinputsource,
+-	 "bibtex|citation" => \$opt::citation,
+ 	 "wc|willcite|will-cite|nn|nonotice|no-notice" => \$opt::willcite,
+ 	 # Termination and retries
+ 	 "halt-on-error|halt=s" => \$opt::halt,
+@@ -1040,7 +1039,6 @@
+ print Limits::Command::real_max_length(),"\n"; wait_and_exit(0);
+ }
+ if(defined $opt::version) { version(); wait_and_exit(0); }
+-if(defined $opt::citation) { citation(); wait_and_exit(0); }
+ if(defined $opt::record_env) { record_env(); wait_and_exit(0); }
+ if(defined $opt::show_limits) { show_limits(); }
+ if(@opt::sshlogin) { @Global::sshlogin = @opt::sshlogin; }
+@@ -1181,7 +1179,6 @@
+ if(defined $opt::bar) {
+ $opt::progress = $opt::bar;
+ }
+-citation_notice();
+ 
+ parse_halt();
+ parse_sshlogin();
+@@ -3801,43 +3798,9 @@
+ 	 "  O. Tange (2011): GNU Parallel - The Command-Line Power Tool,",
+ 	 "  ;login: The USENIX Magazine, February 2011:42-47.",
+ 	 "",
+-	 "This helps funding further development; AND IT WON'T COST YOU A CENT.",
+-	 "If you pay 1 EUR you should feel free to use GNU Parallel without citing.",
+-	 "",
+ 	 "",);
+ }
+ 
+-sub citation_notice {
+-# if --will-cite or --plain: do nothing
+-# if stderr redirected: do nothing
+-# if ~/.parallel/will-cite: do nothing
+-# else: print citation notice to stderr
+-if($opt::willcite
+-   or
+-   $opt::plain
+-   or
+-   not -t $Global::original_stderr
+-   or
+-   -e $ENV{'HOME'}."/.parallel/will-cite") {
+-	# ski

Bug#905674: Ready for closing?

2018-10-21 Thread Ole Tange
Upgrading from 20141022 to 20180922 seems to address all issues.

Can we close this ticket?

#884793 was due to user error, thus not breaking scripts. I still have
not seen a single situation in which the current behaviour (version
20180922) breaks scripts when used correctly. Make a Minimal,
Complete, Verifiable Example to change my mind.

--citation was never designed to be used with any other parameter, but
only to be run on its own:

   parallel --citation
   :
   > will cite

After running this the citation notice is silenced for future runs. In
other words: It is optional and takes literally less than 10 seconds
to do; thus it is comparable to clicking 'OK, do not show this message
again' in a GUI tool.

The current (version 20280922) wording of the citation notice has been
cleared by Richard M. Stallman and is deemed not in conflict with
https://www.gnu.org/licenses/gpl-faq.en.html#RequireCitation because
citing is a matter of honor - not law. Thus it does not restrict
anyone from making use of the program in a specific field of endeavor,
but simply conveys that you will be taking away future funding for
development if you do not cite.

As Nadia Eghbal puts it in
https://www.slideshare.net/NadiaEghbal/consider-the-maintainer:

"Is it alright to compromise, or even deliberately ignore, the
happiness of maintainers so we that can enjoy free and open source
software?"


/Ole