Bug#907993: lyx: FTBFS with Qt 5.11

[Dr. Tobias Quathamer]

Am 06.09.2018 um 09:26 schrieb Juhani Numminen:
> This patch fixes the FTBFS, and is in use by LyX upstream, Gentoo and Fedora.

Hi Juhani,

thanks for the pointer, I'm preparing a new upload.

Regards,
Tobias



signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#907993: lyx: FTBFS with Qt 5.11

[Debian Bug Tracking System]

Processing control commands:

> tags -1 patch fixed-upstream
Bug #907993 [src:lyx] lyx: FTBFS with Qt 5.11
Added tag(s) fixed-upstream and patch.

-- 
907993: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907993
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#907993: lyx: FTBFS with Qt 5.11

[Juhani Numminen]

Control: tags -1 patch fixed-upstream

On Tue, 04 Sep 2018 21:44:31 + Santiago Vila  wrote:
> Package: src:lyx
> Version: 2.3.0-2
> Severity: serious
> Tags: ftbfs
> 
> Dear maintainer:
> 
> I tried to build this package in buster but it failed:

> [... snipped ...]
> 
>  from ../../../../src/frontends/qt4/GuiDocument.cpp:14:
> /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note: 
> forward declaration of 'class QButtonGroup'
>  class QButtonGroup;
>^~~~
> ../../../../src/frontends/qt4/GuiDocument.cpp:1245:15: error: invalid use of 
> incomplete type 'class QButtonGroup'

This patch fixes the FTBFS, and is in use by LyX upstream, Gentoo and Fedora.

https://www.lyx.org/trac/changeset/5394481071824b39b521d67e2acd7d509e68d0f8/lyxgit
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-office/lyx/files/lyx-2.3.0-qt-5.11.patch
https://src.fedoraproject.org/rpms/lyx/blob/master/f/0175-Upstreaming-compilation-patch-needed-for-Gentoo.patch


Cheers,
Juhani

Bug#907993: lyx: FTBFS with Qt 5.11

[Santiago Vila]

Package: src:lyx
Version: 2.3.0-2
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:


[...]
 debian/rules build-indep
dh build-indep --with python2,tex --builddirectory
   dh_update_autotools_config -i -O--builddirectory
   dh_autoreconf -i -O--builddirectory
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<>'
dh_auto_configure -- \
--disable-silent-rules \
--disable-rpath \
--enable-warnings \
--enable-nls \
--enable-qt5 \
--with-gnu-ld \
--without-aspell \

[... snipped ...]

 from ../../../../src/frontends/qt4/GuiDocument.cpp:14:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note: 
forward declaration of 'class QButtonGroup'
 class QButtonGroup;
   ^~~~
../../../../src/frontends/qt4/GuiDocument.cpp:1245:15: error: invalid use of 
incomplete type 'class QButtonGroup'
   packageGroup->addButton(alwaysRB);
   ^~
In file included from 
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qcheckbox.h:44,
 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QCheckBox:1,
 from ./ui_BulletsUi.h:14,
 from ../../../../src/frontends/qt4/BulletsModule.h:15,
 from ../../../../src/frontends/qt4/GuiDocument.h:17,
 from ../../../../src/frontends/qt4/GuiDocument.cpp:14:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note: 
forward declaration of 'class QButtonGroup'
 class QButtonGroup;
   ^~~~
../../../../src/frontends/qt4/GuiDocument.cpp:1246:15: error: invalid use of 
incomplete type 'class QButtonGroup'
   packageGroup->addButton(neverRB);
   ^~
In file included from 
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qcheckbox.h:44,
 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QCheckBox:1,
 from ./ui_BulletsUi.h:14,
 from ../../../../src/frontends/qt4/BulletsModule.h:15,
 from ../../../../src/frontends/qt4/GuiDocument.h:17,
 from ../../../../src/frontends/qt4/GuiDocument.cpp:14:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractbutton.h:53:7: note: 
forward declaration of 'class QButtonGroup'
 class QButtonGroup;
   ^~~~
make[7]: *** [Makefile:1069: GuiDocument.o] Error 1
make[7]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/src/frontends/qt4'
make[6]: *** [Makefile:902: all] Error 2
make[6]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/src/frontends/qt4'
make[5]: *** [Makefile:786: all-recursive] Error 1
make[5]: Leaving directory '/<>/obj-x86_64-linux-gnu/src/frontends'
make[4]: *** [Makefile:2650: all-recursive] Error 1
make[4]: Leaving directory '/<>/obj-x86_64-linux-gnu/src'
make[3]: *** [Makefile:1880: all] Error 2
make[3]: Leaving directory '/<>/obj-x86_64-linux-gnu/src'
make[2]: *** [Makefile:575: all-recursive] Error 1
make[2]: Leaving directory '/<>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:470: all] Error 2
make[1]: Leaving directory '/<>/obj-x86_64-linux-gnu'
dh_auto_build: cd obj-x86_64-linux-gnu && make -j1 returned exit code 2
make: *** [debian/rules:9: build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit 
status 2


The build was made in my autobuilder with "dpkg-buildpackage -A"
but it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/lyx.html

where you can get a full build log if you need it.

Thanks.