Bug#915476: ledmon FTBFS with glibc 2.28

2018-12-10 Thread Juhani Numminen
On Tue, 04 Dec 2018 01:44:28 +0200 Adrian Bunk  wrote:
> Source: ledmon
> Version: 0.79-2
> Severity: serious
> Tags: ftbfs buster sid
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ledmon.html
> 
> ...
> smp.c: In function '_open_smp_device':
> smp.c:301:46: warning: implicit declaration of function 'makedev' 
> [-Wimplicit-function-declaration]
>   if (mknod(buf, S_IFCHR | S_IRUSR | S_IWUSR, makedev(dmaj, dmin)) < 0)
>   ^~~
> ...
> ./src/smp.c:301: undefined reference to `makedev'

This will likely just require a including sys/sysmacros.h i.e. this commit
https://github.com/intel/ledmon/commit/e51e1a855df80e34e166984373dce7d765d61d52

Quoting https://lists.gnu.org/archive/html/info-gnu/2018-08/msg0.html:
"The macros 'major', 'minor', and 'makedev' are now only available from
the header "

--
Juhani



Bug#915476: ledmon FTBFS with glibc 2.28

2018-12-03 Thread Adrian Bunk
Source: ledmon
Version: 0.79-2
Severity: serious
Tags: ftbfs buster sid

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ledmon.html

...
smp.c: In function '_open_smp_device':
smp.c:301:46: warning: implicit declaration of function 'makedev' 
[-Wimplicit-function-declaration]
  if (mknod(buf, S_IFCHR | S_IRUSR | S_IWUSR, makedev(dmaj, dmin)) < 0)
  ^~~
...
cc  /build/1st/ledmon-0.79/src/_build/ledmon.o 
/build/1st/ledmon-0.79/src/_build/pidfile.o 
/build/1st/ledmon-0.79/src/_build/ahci.o 
/build/1st/ledmon-0.79/src/_build/block.o 
/build/1st/ledmon-0.79/src/_build/cntrl.o 
/build/1st/ledmon-0.79/src/_build/enclosure.o 
/build/1st/ledmon-0.79/src/_build/list.o 
/build/1st/ledmon-0.79/src/_build/raid.o 
/build/1st/ledmon-0.79/src/_build/scsi.o 
/build/1st/ledmon-0.79/src/_build/slave.o 
/build/1st/ledmon-0.79/src/_build/status.o 
/build/1st/ledmon-0.79/src/_build/sysfs.o 
/build/1st/ledmon-0.79/src/_build/smp.o 
/build/1st/ledmon-0.79/src/_build/dellssd.o 
/build/1st/ledmon-0.79/src/_build/utils.o -o ledmon -Wl,-z,relro -lsgutils2
/usr/bin/ld: /build/1st/ledmon-0.79/src/_build/smp.o: in function 
`_open_smp_device':
./src/smp.c:301: undefined reference to `makedev'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:72: ledmon] Error 1