Bug#917057: [3dprinter-general] Bug#917057: libpolyclipping-dev: pjg-config file contains bogus includedir

[Gregor Riepl]

> Thanks for spotting. That was not the cause however. The upstream
> polycipping.pc.in relies on very weired assignments of standard cmake
> variables, those assignments were removed in
> debian/patches/1000-fix-multiarch-paths.patch, which was added in the
> same upload that fixed #915267.
>
> The attached patch adapts polycipping.pc.in to cope with
> 1000-fix-multiarch-paths.patch.

Thanks, Helmut.
I totally missed this.

Since upstream[1] is practically dead, we're pretty much on our own here...

I'll make sure the patch is included with the next upload.

[1] https://sourceforge.net/p/polyclipping/

Processed: Re: Bug#917057: libpolyclipping-dev: pjg-config file contains bogus includedir

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + patch
Bug #917057 [libpolyclipping-dev] libpolyclipping-dev: pkg-config file contains 
bogus includedir
Added tag(s) patch.

-- 
917057: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917057
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#917057: libpolyclipping-dev: pjg-config file contains bogus includedir

[Helmut Grohne]

Control: tags -1 + patch

On Sat, Dec 22, 2018 at 02:53:14AM +0200, Adrian Bunk wrote:
> Root cause:
> 
> $  cat /usr/lib/x86_64-linux-gnu/pkgconfig/polyclipping.pc
> prefix=/usr
> exec_prefix=/usr
> libdir=lib/x86_64-linux-gnu
> sharedlibdir=lib/x86_64-linux-gnu
> includedir=include
> ...
> 
> 
> I would suspect the #915267 change as root cause.

Thanks for spotting. That was not the cause however. The upstream
polycipping.pc.in relies on very weired assignments of standard cmake
variables, those assignments were removed in
debian/patches/1000-fix-multiarch-paths.patch, which was added in the
same upload that fixed #915267.

The attached patch adapts polycipping.pc.in to cope with
1000-fix-multiarch-paths.patch.

Helmut
--- libpolyclipping-6.4.2.orig/cpp/polyclipping.pc.cmakein
+++ libpolyclipping-6.4.2/cpp/polyclipping.pc.cmakein
@@ -1,8 +1,8 @@
 prefix=@CMAKE_INSTALL_PREFIX@
-exec_prefix=@CMAKE_INSTALL_PREFIX@
-libdir=@CMAKE_INSTALL_LIBDIR@
-sharedlibdir=@CMAKE_INSTALL_LIBDIR@
-includedir=@CMAKE_INSTALL_INCLUDEDIR@
+exec_prefix=${prefix}
+libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
+sharedlibdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
+includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@/polyclipping
 
 Name: polyclipping
 Description: polygon clipping library

Bug#917057: libpolyclipping-dev: pjg-config file contains bogus includedir

[Adrian Bunk]

Package: libpolyclipping-dev
Version: 6.4.2-4
Severity: serious
Control: affects -1 src:cura-engine

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/cura-engine.html

...
CMake Error at 
/usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Polyclipping (missing: Polyclipping_INCLUDE_DIRS)
Call Stack (most recent call first):
  /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 
(_FPHSA_FAILURE_MESSAGE)
  cmake/FindPolyclipping.cmake:60 (find_package_handle_standard_args)
  CMakeLists.txt:20 (find_package)


-- Configuring incomplete, errors occurred!


Root cause:

$  cat /usr/lib/x86_64-linux-gnu/pkgconfig/polyclipping.pc
prefix=/usr
exec_prefix=/usr
libdir=lib/x86_64-linux-gnu
sharedlibdir=lib/x86_64-linux-gnu
includedir=include
...


I would suspect the #915267 change as root cause.