Bug#917492: fam: FTBFS ('minor' was not declared in this scope)

2019-01-08 Thread Logan Rosen
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/19_glibc_2.28.patch: Fix FTBFS with glibc 2.28.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: buster/sid
  APT prefers cosmic-updates
  APT policy: (500, 'cosmic-updates'), (500, 'cosmic-security'), (500, 
'cosmic'), (400, 'cosmic-proposed'), (100, 'cosmic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-13-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
only in patch2:
unchanged:
--- fam-2.7.0.orig/debian/patches/19_glibc_2.28.patch
+++ fam-2.7.0/debian/patches/19_glibc_2.28.patch
@@ -0,0 +1,17 @@
+## Description: Fix FTBFS against glibc 2.28
+## Origin/Author: Logan Rosen 
+## Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=917492
+diff -Nur -x '*.orig' -x '*~' fam-2.7.0/build-tree/fam-2.7.0/src/DNotify.c++ 
fam-2.7.0.new/build-tree/fam-2.7.0/src/DNotify.c++
+--- fam-2.7.0/src/DNotify.c++  2019-01-08 23:35:20.513574095 -0500
 fam-2.7.0/src/DNotify.c++  2019-01-08 23:36:37.568605429 -0500
+@@ -36,6 +36,10 @@
+ #include 
+ #include 
+ 
++#ifdef __GNU_LIBRARY__
++#include 
++#endif
++
+ #include "DNotify.h"
+ 
+ #include "Interest.h"


Bug#917492: fam: FTBFS ('minor' was not declared in this scope)

2018-12-27 Thread Santiago Vila
Package: src:fam
Version: 2.7.0-17.2
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:


[...]
 debian/rules build-indep
CDBS: parsing fam-2.7.0.tar.gz ...
CDBS WARNING:tarball.mk is deprecated since 0.4.85 - please use source 
format 3.0 instead
CDBS WARNING:simple-patchsys.mk is deprecated since 0.4.85 - please use 
source format 3.0 (quilt) instead
test -x debian/rules
mkdir -p "build-tree/fam-2.7.0"
CDBS WARNING:DEB_UPDATE_RCD_PARAMS is deprecated since 0.4.85
tar -C build-tree  -x -z -f fam-2.7.0.tar.gz
touch debian/stamp-fam-2.7.0.tar.gz
if test -e /usr/share/misc/config.guess ; then \
for i in fam-2.7.0/config.guess ; do \
cp --remove-destination /usr/share/misc/config.guess \
build-tree/$i ; \
done ; \

[... snipped ...]

 ^
DNotify.c++:536:32: error: 'minor' was not declared in this scope
 major(status->st_dev), minor(status->st_dev),
^
DNotify.c++:536:32: note: suggested alternative: 'mknod'
 major(status->st_dev), minor(status->st_dev),
^
mknod
DNotify.c++:486:9: warning: unused variable 'res' [-Wunused-variable]
 int res;
 ^~~
DNotify.c++: In static member function 'static void DNotify::read_handler(int, 
void*)':
DNotify.c++:641:11: error: 'major' was not declared in this scope
   major(dw->dir_dev), minor(dw->dir_dev), dw->dir_ino);
   ^
DNotify.c++:641:31: error: 'minor' was not declared in this scope
   major(dw->dir_dev), minor(dw->dir_dev), dw->dir_ino);
   ^
DNotify.c++:641:31: note: suggested alternative: 'mknod'
   major(dw->dir_dev), minor(dw->dir_dev), dw->dir_ino);
   ^
   mknod
DNotify.c++:602:16: warning: unused variable 'fw' [-Wunused-variable]
 FileWatch *fw;
^~
DNotify.c++: In static member function 'static void 
DNotify::overflow_signal_handler(int, siginfo_t*, void*)':
DNotify.c++:233:11: warning: ignoring return value of 'ssize_t write(int, const 
void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
 write (STDERR_FILENO, str, strlen(str));
 ~~^
DNotify.c++:239:12: warning: ignoring return value of 'ssize_t write(int, const 
void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
   write(pipe_write_fd, , 1);
   ~^~
DNotify.c++: In static member function 'static void 
DNotify::signal_handler(int, siginfo_t*, void*)':
DNotify.c++:260:8: warning: ignoring return value of 'ssize_t write(int, const 
void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
  write (STDERR_FILENO, str, strlen(str));
  ~~^
DNotify.c++:270:12: warning: ignoring return value of 'ssize_t write(int, const 
void*, size_t)', declared with attribute warn_unused_result [-Wunused-result]
   write(pipe_write_fd, , 1);
   ~^~
make[3]: *** [Makefile:453: DNotify.o] Error 1
make[3]: Leaving directory '/<>/build-tree/fam-2.7.0/src'
make[2]: *** [Makefile:327: all-recursive] Error 1
make[2]: Leaving directory '/<>/build-tree/fam-2.7.0'
make[1]: *** [Makefile:258: all] Error 2
make[1]: Leaving directory '/<>/build-tree/fam-2.7.0'
make: *** [/usr/share/cdbs/1/class/makefile.mk:77: debian/stamp-makefile-build] 
Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit 
status 2


The build was made in my autobuilder with "dpkg-buildpackage -A"
but it also fails here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/fam.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and 
affects,
so that this is still visible in the BTS web page for this package.

Thanks.