Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
Ok, so... On 2/24/19 3:39 PM, Santiago Vila wrote: >> All of this seems to be related to the dh-exec usage for putting files >> in the xen-utils-common package with a different name. This is the first >> time this package is using dh-exec. >> >> [...] >> >> Interestingly, 'etc/default/xencommons => /etc/default/xen' does not >> result in a similar error? >> >> I also found this one, which seems to be related: >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831786 >> >> Do you have an idea / suggestion how we can deal with this? > > Based on your analysis, maybe applying the patch below. > > After all, the "fail-missing" thing is just an extra protection which > helps avoiding mistakes when installing things, but in this case > it seems to be more troublesome than helpful. > > --- a/debian/rules > +++ b/debian/rules > @@ -307,8 +307,11 @@ override_dh_compress: > > # By default, files in debian/tmp which are not handled by anything > # in rules are ignored. This makes them into errors. > -override_dh_missing: > - dh_missing --fail-missing > +# > +# Disabled because of Bug #831786 > +# > +# override_dh_missing: > +#dh_missing --fail-missing > > > # We are dropping the config file /etc/default/xen which appeared in Oh right. This accidentally quoted line helped me find out that etc/default/xencommons is listed in debian/not-installed because it was not installed before. However, now it is again, but it was not removed from not-installed, and this solves the mystery of dh_missing not complaining about it. It seems useful to me to keep the dh_missing --fail-missing, so the workaround for the dh-exec bug will now be to also list etc/bash_completion.d/xl.sh in not-installed, with a short explanation in a comment. Now I can do dpkg-buildpackage -A without the error. https://salsa.debian.org/xen-team/debian-xen/commit/69f65e1f7676cb387c9742a4e8ab96ee53e36d1d (this commit hash will likely disapper again later, but today it'll be there :) ). Hans
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
> All of this seems to be related to the dh-exec usage for putting files > in the xen-utils-common package with a different name. This is the first > time this package is using dh-exec. > > [...] > > Interestingly, 'etc/default/xencommons => /etc/default/xen' does not > result in a similar error? > > I also found this one, which seems to be related: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831786 > > Do you have an idea / suggestion how we can deal with this? Based on your analysis, maybe applying the patch below. After all, the "fail-missing" thing is just an extra protection which helps avoiding mistakes when installing things, but in this case it seems to be more troublesome than helpful. --- a/debian/rules +++ b/debian/rules @@ -307,8 +307,11 @@ override_dh_compress: # By default, files in debian/tmp which are not handled by anything # in rules are ignored. This makes them into errors. -override_dh_missing: - dh_missing --fail-missing +# +# Disabled because of Bug #831786 +# +# override_dh_missing: +# dh_missing --fail-missing # We are dropping the config file /etc/default/xen which appeared in Thanks.
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
Hi Santiago, First of all, apologies because the tone in my previous message yesterday may sound a bit hostile. I was tired and happy that we had a productive day yesterday, getting ~30 bts closed and an upload with a lot of fixes done, I just did my own rebuild for stretch-backports, and then the report that it ftbfs came in, and I was too quick with thinking "no way, I just built it!". :) Thanks for your report. On 2/23/19 7:04 AM, Santiago Vila wrote: > On Sat, Feb 23, 2019 at 01:15:49AM +0100, Hans van Kranenburg wrote: > >> Can you please help me by formulating a clear problem / question and if >> possible some expected things that you would like to have as a result? > > Sure. This is a packaging bug in debian/rules. Packages must build for the > end user with plain "dpkg-buildpackage" but also in the official > autobuilders by doing "dpkg-buildpackage -A" (to generate arch-all > packages) or "dpkg-buildpackage -B" (to generate arch-indep packages). I can indeed reproduce the error by doing dpkg-buildpackage -A: >8 dh_missing --fail-missing dh_missing: etc/bash_completion.d/xl.sh exists in debian/tmp but is not installed to anywhere >8 This file is installed into the xen-utils-common package as /usr/share/bash-completion/completions/xl. From debian/xen-utils-common.install: >8 #! /usr/bin/dh-exec --with=install [...] etc/bash_completion.d/xl.sh => usr/share/bash-completion/completions/xl >8 > Either of those failing is a FTBFS bug, hence the serious severity. > > To reproduce the problem, please try building the package with > "dpkg-buildpackage -A", which is exactly what the arch:all > autobuilder would do if the package was uploaded in source-only form. > > The hint of splitting dh_foo into dh_foo-arch and dh_foo-indep usually > works for packages that use dh and have this bug, i.e. for packages > which build ok when built with plain "dpkg-buildpackage" but not with > "dpkg-buildpackage -A" or "dpkg-buildpackage -B". All of this seems to be related to the dh-exec usage for putting files in the xen-utils-common package with a different name. This is the first time this package is using dh-exec. If I change the following, dpkg-buildpackage -A completes: >8 diff --git a/debian/xen-utils-common.install b/debian/xen-utils-common.install index 60642c9a9c..e83dc0740b 100755 --- a/debian/xen-utils-common.install +++ b/debian/xen-utils-common.install @@ -2,7 +2,7 @@ etc/xen/scripts etc/xen/xl* -etc/bash_completion.d/xl.sh => usr/share/bash-completion/completions/xl +etc/bash_completion.d/xl.sh usr/share/bash-completion/completions etc/default/xendomains etc/default/xencommons => /etc/default/xen >8 Interestingly, 'etc/default/xencommons => /etc/default/xen' does not result in a similar error? I also found this one, which seems to be related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831786 Do you have an idea / suggestion how we can deal with this? Hans
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
Correction. I said: > "dpkg-buildpackage -B" (to generate arch-indep packages). but really meant this: "dpkg-buildpackage -B" (to generate arch-dep packages). Sorry for the confusion.
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
On Sat, Feb 23, 2019 at 01:15:49AM +0100, Hans van Kranenburg wrote: > Can you please help me by formulating a clear problem / question and if > possible some expected things that you would like to have as a result? Sure. This is a packaging bug in debian/rules. Packages must build for the end user with plain "dpkg-buildpackage" but also in the official autobuilders by doing "dpkg-buildpackage -A" (to generate arch-all packages) or "dpkg-buildpackage -B" (to generate arch-indep packages). Either of those failing is a FTBFS bug, hence the serious severity. To reproduce the problem, please try building the package with "dpkg-buildpackage -A", which is exactly what the arch:all autobuilder would do if the package was uploaded in source-only form. The hint of splitting dh_foo into dh_foo-arch and dh_foo-indep usually works for packages that use dh and have this bug, i.e. for packages which build ok when built with plain "dpkg-buildpackage" but not with "dpkg-buildpackage -A" or "dpkg-buildpackage -B". Thanks.
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
On 2/23/19 1:15 AM, Hans van Kranenburg wrote: > Hi, > > On 2/23/19 12:59 AM, Santiago Vila wrote: >> >>> Hint: Try splitting override_dh_compress into override_dh_compress-arch >>> and override_dh_compress-indep. >> >> Not really sure that this is a good hint in this case. The first rule >> showing an >> error is certainly this one: >> >> find: 'debian/xen-hypervisor-*/usr/lib/debug': No such file or directory >> >> but maybe it's override_dh_missing the one that would benefit from an >> -arch/-indep split. > > Can you please help me by formulating a clear problem / question and if > possible some expected things that you would like to have as a result? > > What I see flying by is: A B C and also X Y Z and you might R S T, and > also, by the way: F G H. Also, your new bts results in an... "Serious (policy violations or makes package unfit for release)" ...listed for our packages, which is not nice, in this phase of the release freeze cycle, because... The whole thing builds just fine in sid and also in stretch here. Can you explain why you want to do this? Hans
Bug#923013: [Pkg-xen-devel] Bug#923013: xen: FTBFS when built with dpkg-buildpackage -A
Hi, On 2/23/19 12:59 AM, Santiago Vila wrote: > >> Hint: Try splitting override_dh_compress into override_dh_compress-arch >> and override_dh_compress-indep. > > Not really sure that this is a good hint in this case. The first rule showing > an > error is certainly this one: > > find: 'debian/xen-hypervisor-*/usr/lib/debug': No such file or directory > > but maybe it's override_dh_missing the one that would benefit from an > -arch/-indep split. Can you please help me by formulating a clear problem / question and if possible some expected things that you would like to have as a result? What I see flying by is: A B C and also X Y Z and you might R S T, and also, by the way: F G H. Hans
