Bug#925754: Fixed in newer release of libopenshot / libopenshot-audio

[John Scott]

Control: block 925754 by 925755
Control: notforwarded 925754
Control: forwarded 925755 
https://github.com/OpenShot/libopenshot-audio/issues/33

Hi,

> On Wed, 29 Jan 2020 10:08:55 +0100 Matthias Klose  wrote:
> > libopenshot-audio 0.1.8 still fails to build
> 
> Quite right, sorry. libopenshot-audio-0.1.8 fixed building with GCC *less
> than* 9,
> but GCC9 coming along broke it again.
> 
> On Fedora / RPM Fusion we were building with commit 7001b68[1],
> which was at the time an unreleased commit on the development branch.
> 
> However, since then both 0.1.9 and 0.2.0 have been released,
> including fixes to build with GCC 9 and 10 respectively, IIRC.
> (I know 0.2.0 builds with GCC 10 for sure, since I've done it myself.)
> 
> Current releases:
> 
> libopenshot-audio-0.2.0:
> https://github.com/OpenShot/libopenshot-audio/archive/v0.2.0.tar.gz
> 
> libopenshot-0.2.5:
> https://github.com/OpenShot/libopenshot/archive/v0.2.5.tar.gz
> 
> OpenShot 2.5.1 (openshot-qt):
> https://github.com/OpenShot/openshot-qt/archive/v2.5.1.tar.gz
> 
> 
> [1]:
> https://github.com/OpenShot/libopenshot-audio/commit/7001b68787c0881a44bcafba98cccae509a31644

libopenshot-audio builds with Clang without any modifications. Using this
OpenShot (again with Clang) gets a bit farther:
/usr/include/libopenshot-audio/JuceLibraryCode/modules/juce_audio_basics/../juce_core/unit_tests/juce_UnitTest.h:73:17:
 note: candidate found by name lookup is 'juce::UnitTest'
class JUCE_API  UnitTest
^
/<>/tests/Cache_Tests.cpp:50:2: error: reference to 'UnitTest' is 
ambiguous

I've seen this is fixed in a commit upstream, and I think cherrypicking it
helped, but the -audio Debian package uses the Juce embedded code copies
instead of the ones in juce-modules-source as best as I can tell.

I'm uneasy about this and hope that a new release of OpenShot made with the
practices described in /usr/share/doc/juce-modules-source/README.Debian will
make an elegant solution.

signature.asc
Description: This is a digitally signed message part.

Bug#925754: Fixed in newer release of libopenshot / libopenshot-audio

[FeRD]

On Wed, 29 Jan 2020 10:08:55 +0100 Matthias Klose  wrote:
> libopenshot-audio 0.1.8 still fails to build

Quite right, sorry. libopenshot-audio-0.1.8 fixed building with GCC *less
than* 9,
but GCC9 coming along broke it again.

On Fedora / RPM Fusion we were building with commit 7001b68[1],
which was at the time an unreleased commit on the development branch.

However, since then both 0.1.9 and 0.2.0 have been released,
including fixes to build with GCC 9 and 10 respectively, IIRC.
(I know 0.2.0 builds with GCC 10 for sure, since I've done it myself.)

Current releases:

libopenshot-audio-0.2.0:
https://github.com/OpenShot/libopenshot-audio/archive/v0.2.0.tar.gz

libopenshot-0.2.5:
https://github.com/OpenShot/libopenshot/archive/v0.2.5.tar.gz

OpenShot 2.5.1 (openshot-qt):
https://github.com/OpenShot/openshot-qt/archive/v2.5.1.tar.gz


[1]:
https://github.com/OpenShot/libopenshot-audio/commit/7001b68787c0881a44bcafba98cccae509a31644

Bug#925754: Fixed in newer release of libopenshot / libopenshot-audio

[Matthias Klose]

libopenshot-audio 0.1.8 still fails to build with:

In file included from
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/../juce_gui_basics/../juce_graphics/juce_graphics.h:82,
 from
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/../juce_gui_basics/juce_gui_basics.h:28,
 from
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/juce_audio_processors.h:28,
 from
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/juce_audio_processors.cpp:39:
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/../juce_gui_basics/../juce_graphics/colour/juce_PixelFormats.h:
In member function ‘juce::uint8& juce::PixelARGB
::getAlpha()’:
/packages/tmp/p/libopenshot-audio-0.1.8/JuceLibraryCode/modules/juce_audio_processors/../juce_gui_basics/../juce_graphics/colour/juce_PixelFormats.h:113:77:
error: cannot bind packed field ‘((juce::
PixelARGB*)this)->juce::PixelARGB::.juce::PixelARGBcomps[3]’ to ‘juce::uint8&’ {aka ‘unsigned char&’}
  113 | forcedinline uint8& getAlpha() noexcept   { return comps
[indexA]; }
  |
~^

Bug#925754: Fixed in newer release of libopenshot / libopenshot-audio

[FeRD]

This issue was fixed with the simultaneous release of libopenshot-0.2.3 and
libopenshot-audio-0.1.8 on 2019-03-22. The new releases use an upgraded and
streamlined build of the Juce library sources, removing the problematic
modules which were causing FTBFS issues with GCC 9. See upstream issue
https://github.com/OpenShot/libopenshot-audio/issues/33 .

libopenshot-audio-0.1.8 release:
https://github.com/OpenShot/libopenshot-audio/releases/tag/v0.1.8
libopenshot-0.2.3 release:
https://github.com/OpenShot/libopenshot/releases/tag/v0.2.3

(The OpenShot application also released version 2.4.4 at that time:
https://github.com/OpenShot/openshot-qt/releases/tag/v2.4.4 )