Bug#928991: marked as done (t50 Makefile is failing to detect right architecture and using cpu specific flags)

2019-05-23 Thread Debian Bug Tracking System
Your message dated Thu, 23 May 2019 22:36:05 +0100
with message-id 

and subject line 
has caused the Debian Bug report #928991,
regarding t50 Makefile is failing to detect right architecture and using cpu 
specific flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
928991: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928991
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: t50
Severity: serious
Version:  5.8.3-1
Fixed: 5.8.3-2

We found out that version 5.8.3-1 of t50 is trying to detect the
architecture its being build to on Makefile but it fails to do that on some
cases, this was detected thanks to the reproducible builds project.

It is known that t50's upstream adds lots of cpu specific code to it, and
the main indicator for that has always been the failure to build in a
reproducible way.

A few days ago I raised a discussion about this problem on the security
tools team's list, and we found out that t50 was using the "-ftree-vectorize"
flag, while at the same time failing to check the correct architecture it
was being build upon.

The fix consisted of removing any CPU specific code from the Makefile, thus
making the build reproducible and fixing the problems with the build.

This is the discussion on the team's mailing list[0]

[0]https://lists.debian.org/debian-security-tools/2019/05/msg1.html

-- 
Samuel Henrique 
--- End Message ---
--- Begin Message ---
Fixed on buster and sid
--- End Message ---


Bug#928991:

2019-05-14 Thread Samuel Henrique
Control: fixed -1 t50/5.8.3-2
thanks

Yeah our tooling is not that great :/


--
Samuel Henrique 


Bug#928991:

2019-05-14 Thread Samuel Henrique
fixed -1 t50/5.8.3-2
thanks


--
Samuel Henrique 


Bug#928991: t50 Makefile is failing to detect right architecture and using cpu specific flags

2019-05-14 Thread Samuel Henrique
Package: t50
Severity: serious
Version:  5.8.3-1
Fixed: 5.8.3-2

We found out that version 5.8.3-1 of t50 is trying to detect the
architecture its being build to on Makefile but it fails to do that on some
cases, this was detected thanks to the reproducible builds project.

It is known that t50's upstream adds lots of cpu specific code to it, and
the main indicator for that has always been the failure to build in a
reproducible way.

A few days ago I raised a discussion about this problem on the security
tools team's list, and we found out that t50 was using the "-ftree-vectorize"
flag, while at the same time failing to check the correct architecture it
was being build upon.

The fix consisted of removing any CPU specific code from the Makefile, thus
making the build reproducible and fixing the problems with the build.

This is the discussion on the team's mailing list[0]

[0]https://lists.debian.org/debian-security-tools/2019/05/msg1.html

-- 
Samuel Henrique