Bug#935086: insighttoolkit4 REMOVED from testing

2019-10-08 Thread Gilles Filippini 
Control: tags -1 + patch

Hi,

Michael Crusoe a écrit le 04/10/2019 à 16:01 :
> Attached is a patch to force gcc 8; so far it has gotten farther than
> the previous failure for me (but my local build is still at 86%)

Looking at the related lines of /usr/include/c++/9/bits/stl_function.h,
it seems that __builtin_is_constant_evaluated is used only for C++
standard greater or equal to c++14:
> #if __cplusplus >= 201402L
> #ifdef _GLIBCXX_HAVE_BUILTIN_IS_CONSTANT_EVALUATED
>   if (__builtin_is_constant_evaluated())
> #else
>   if (__builtin_constant_p(__x > __y))
> #endif
> return __x > __y;
> #endif
>   return (__UINTPTR_TYPE__)__x > (__UINTPTR_TYPE__)__y;


Then I tried using '-std=c++11' and the build was successful.

Patch attached.

Thanks,

_g.
diff -Nru insighttoolkit4-4.12.2-dfsg1/debian/changelog 
insighttoolkit4-4.12.2-dfsg1/debian/changelog
--- insighttoolkit4-4.12.2-dfsg1/debian/changelog   2018-08-28 
16:27:47.0 +0200
+++ insighttoolkit4-4.12.2-dfsg1/debian/changelog   2019-10-07 
21:50:28.0 +0200
@@ -1,3 +1,10 @@
+insighttoolkit4 (4.12.2-dfsg1-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Force -std=c++11 to fix FTBFS with GCC-9 (closes: #935086)
+
+ -- Gilles Filippini   Mon, 07 Oct 2019 21:50:28 +0200
+
 insighttoolkit4 (4.12.2-dfsg1-4) unstable; urgency=medium
 
   * d/rules: Remove build dir right after installation
diff -Nru insighttoolkit4-4.12.2-dfsg1/debian/rules 
insighttoolkit4-4.12.2-dfsg1/debian/rules
--- insighttoolkit4-4.12.2-dfsg1/debian/rules   2018-08-28 16:27:47.0 
+0200
+++ insighttoolkit4-4.12.2-dfsg1/debian/rules   2019-10-07 21:50:28.0 
+0200
@@ -25,6 +25,9 @@
   ENABLE_UNSIGNED_LONG=ON 
 endif 
 
+# Fix for #935086
+export DEB_CXXFLAGS_MAINT_APPEND+=-std=c++11
+
 CMAKE_FLAGS = \
-DBUILD_EXAMPLES:BOOL=ON \
-DBUILD_SHARED_LIBS:BOOL=ON \


signature.asc
Description: OpenPGP digital signature

Processed: Re: Bug#935086: insighttoolkit4 REMOVED from testing

2019-10-08 Thread Debian Bug Tracking System 
Processing control commands:

> tags -1 + patch
Bug #935086 [src:insighttoolkit4] insighttoolkit4: FTBFS with GCC-9: use of 
undeclared identifier '__builtin_is_constant_evaluated'
Added tag(s) patch.

-- 
935086: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935086
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#935086: insighttoolkit4 REMOVED from testing

2019-10-04 Thread Michael Crusoe 
Attached is a patch to force gcc 8; so far it has gotten farther than the
previous failure for me (but my local build is still at 86%)



On Fri, Oct 4, 2019 at 7:57 AM Andreas Tille  wrote:

> Hi Steve and Gert,
>
> since I have no idea about itk I have ignored this issue.  Is there
> any chance to get this fixed soon to make sure this package and its
> rdepends will migrate back to testing soon?
>
> Kind regards
>
>   Andreas.
>
> On Fri, Oct 04, 2019 at 04:39:19AM +, Debian testing watch wrote:
> > FYI: The status of the insighttoolkit4 source package
> > in Debian's testing distribution has changed.
> >
> >   Previous version: 4.12.2-dfsg1-4
> >   Current version:  (not in testing)
> >   Hint: 
> > Bug #935086: insighttoolkit4: FTBFS with GCC-9: use of undeclared
> identifier '__builtin_is_constant_evaluated'
> >
> > The script that generates this mail tries to extract removal
> > reasons from comments in the britney hint files. Those comments
> > were not originally meant to be machine readable, so if the
> > reason for removing your package seems to be nonsense, it is
> > probably the reporting script that got confused. Please check the
> > actual hints file before you complain about meaningless removals.
> >
> > --
> > This email is automatically generated once a day.  As the installation of
> > new packages into testing happens multiple times a day you will receive
> > later changes on the next day.
> > See https://release.debian.org/testing-watch/ for more information.
> >
> > ___
> > Debian-med-packaging mailing list
> > debian-med-packag...@alioth-lists.debian.net
> >
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging
>
> --
> http://fam-tille.de
>
>

-- 
Michael R. Crusoe
Co-founder & Lead, Common Workflow Language project

https://orcid.org/-0002-2961-9670

m...@commonwl.org
+1 480 627 9108
commit 6947f1988913e72dd25345eb346e9e8386b88ef7
Author: Michael R. Crusoe 
Date:   Fri Oct 4 12:59:33 2019 +0200

Force the use of gcc/g++ 8

diff --git a/debian/changelog b/debian/changelog
index 7edae471..daf82bbd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+insighttoolkit4 (4.12.2-dfsg1-5) UNRELEASED; urgency=medium
+
+  * Force the use of gcc/g++ 8.
+
+ -- Michael R. Crusoe   Fri, 04 Oct 2019 12:20:29 +0200
+
 insighttoolkit4 (4.12.2-dfsg1-4) unstable; urgency=medium
 
   * d/rules: Remove build dir right after installation
diff --git a/debian/control b/debian/control
index cbc59fa8..932f5d3b 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,9 @@ Build-Depends: debhelper (>= 9),
 libnifti-dev, 
 	libhdf5-dev,
 	dh-python,	
-	python-all-dev
+	python-all-dev,
+g++-8,
+gcc-8
 #	libvtk6-dev -- only needed if we enable one of the following modules:
 # VtkGlue, LevelSetsv4Visualization
 Standards-Version: 4.1.4
diff --git a/debian/rules b/debian/rules
index f8c50710..f49eb4aa 100755
--- a/debian/rules
+++ b/debian/rules
@@ -86,7 +86,7 @@ pkg_python = insighttoolkit$(VER_MAJOR)-python
 override_dh_auto_configure-indep:
 
 override_dh_auto_configure-arch: pre-build
-	dh_auto_configure -- $(CMAKE_FLAGS)
+	CC=gcc-8 CXX=g++-8 dh_auto_configure -- $(CMAKE_FLAGS)
 
 override_dh_auto_build-indep:

Bug#935086: insighttoolkit4 REMOVED from testing

2019-10-03 Thread Andreas Tille 
Hi Steve and Gert,

since I have no idea about itk I have ignored this issue.  Is there
any chance to get this fixed soon to make sure this package and its
rdepends will migrate back to testing soon?

Kind regards

  Andreas.

On Fri, Oct 04, 2019 at 04:39:19AM +, Debian testing watch wrote:
> FYI: The status of the insighttoolkit4 source package
> in Debian's testing distribution has changed.
> 
>   Previous version: 4.12.2-dfsg1-4
>   Current version:  (not in testing)
>   Hint: 
> Bug #935086: insighttoolkit4: FTBFS with GCC-9: use of undeclared 
> identifier '__builtin_is_constant_evaluated'
> 
> The script that generates this mail tries to extract removal
> reasons from comments in the britney hint files. Those comments
> were not originally meant to be machine readable, so if the
> reason for removing your package seems to be nonsense, it is
> probably the reporting script that got confused. Please check the
> actual hints file before you complain about meaningless removals.
> 
> -- 
> This email is automatically generated once a day.  As the installation of
> new packages into testing happens multiple times a day you will receive
> later changes on the next day.
> See https://release.debian.org/testing-watch/ for more information.
> 
> ___
> Debian-med-packaging mailing list
> debian-med-packag...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de