Processed: Re: Bug#964377: bumblebee: please runtime depend on pciutils

[Debian Bug Tracking System]

Processing control commands:

> severity -1 important
Bug #964377 [src:bumblebee] bumblebee: please runtime depend on pciutils
Severity set to 'important' from 'serious'

-- 
964377: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964377
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#964377: bumblebee: please runtime depend on pciutils

[Adrian Bunk]

Control: severity -1 important

On Mon, Jul 06, 2020 at 02:40:37PM +0200, Andreas Beckmann wrote:
> On 7/6/20 1:14 PM, Gianfranco Costamagna wrote:
> > Hello, bumblebee and bumblebee-nvidia (in Ubuntu) use lspci in their 
> > postinst files, without
> > a dependency on it
> 
> Good catch!
> Should there be a lintian test for it? I remember fixing the same thing in
> firmware-b43-installer recently.

In bumblebee this seems to be an Ubuntu-only problem:

debian/bumblebee-nvidia.postinst.Ubuntu:
  busid=$(lspci -d10de: -nn | grep '\[030[02]\]' | cut -d' ' -f1 | tr . : | 
head -1)

debian/bumblebee.postinst:
# Raring specific issue
# Also, do not rely solely on dpkg-vendor (see LP: #1061769)
if (which dpkg-vendor >/dev/null && dpkg-vendor --derives-from Ubuntu) || \
  [ -e /etc/dpkg/origins/ubuntu ]; then
# assume first device to be discrete in nvidia/nvidia
busid=$(lspci -d10de: -nn | grep '\[030[02]\]' | cut -d' ' -f1 | tr . : 
| head -1)


> Andreas

cu
Adrian

Bug#964377: bumblebee: please runtime depend on pciutils

[Gianfranco Costamagna]

Hello,

> Good catch!
> Should there be a lintian test for it? I remember fixing the same thing 
> in firmware-b43-installer recently.
> 
it would probably help a lot, yes :)

but a quick and incomplete look shows...
https://codesearch.debian.net/search?q=lspci+path%3Apostinst%24=0

only two packages affected?

G.

Bug#964377: bumblebee: please runtime depend on pciutils

[Andreas Beckmann]

On 7/6/20 1:14 PM, Gianfranco Costamagna wrote:

Hello, bumblebee and bumblebee-nvidia (in Ubuntu) use lspci in their postinst 
files, without
a dependency on it


Good catch!
Should there be a lintian test for it? I remember fixing the same thing 
in firmware-b43-installer recently.



Andreas

Bug#964377: bumblebee: please runtime depend on pciutils

[Gianfranco Costamagna]

Source: bumblebee
Version: 3.2.1-23
Severity: serious

Hello, bumblebee and bumblebee-nvidia (in Ubuntu) use lspci in their postinst 
files, without
a dependency on it

./debian/bumblebee.postinst:busid=$(lspci -d10de: -nn | grep 
'\[030[02]\]' | cut -d' ' -f1 | tr . : | head -1)
./debian/bumblebee-nvidia.postinst.Ubuntu:  busid=$(lspci -d10de: -nn | 
grep '\[030[02]\]' | cut -d' ' -f1 | tr . : | head -1)

I think depending on pciutils might be a sane thing to do!
(I think the severity is RC, but feel free to downgrade, I don't know what is 
the severity for this bug)

cheers,

Gianfranco