Bug#971754: ABI breakage from 1.4.1 to 1.4.2
On Sat, 2021-01-16 at 14:05 +0100, Paul Gevers wrote: > > I was expecting a new upstream release to be incorporated, but I > understand upstream didn't release anything new yet. For whatever > it's worth, your MR doesn't look too weird. Thanks, I've uploaded it to delayed/1 in case someone disagrees. Otherwise it'll be on the NEW queue tomorrow for the new binary packages, and once it's done there a binNMU for gst-plugins-bad1.0 can happen and everything can migrate to testing. signature.asc Description: This is a digitally signed message part
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Hi Sebastian, On 16-01-2021 09:41, Sebastian Dröge wrote: > On Fri, 2021-01-15 at 22:37 +0100, Paul Gevers wrote: >> >> Can you do this please? srt is orphaned, your package depend on it, >> could you please help us get us out of this situation? (if this >> happens soon, we'll accept the transition to fix this). > > I've created a MR in salsa for this change: > https://salsa.debian.org/debian/libsrt/-/merge_requests/2 > > If that looks acceptable and correct to you then I'll upload it. I was expecting a new upstream release to be incorporated, but I understand upstream didn't release anything new yet. For whatever it's worth, your MR doesn't look too weird. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Hi Paul, On Fri, 2021-01-15 at 22:37 +0100, Paul Gevers wrote: > > Can you do this please? srt is orphaned, your package depend on it, > could you please help us get us out of this situation? (if this > happens soon, we'll accept the transition to fix this). I've created a MR in salsa for this change: https://salsa.debian.org/debian/libsrt/-/merge_requests/2 If that looks acceptable and correct to you then I'll upload it. signature.asc Description: This is a digitally signed message part
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
On Fri, 2021-01-15 at 22:37 +0100, Paul Gevers wrote: > Hi Sebastian, > > On Thu, 14 Jan 2021 11:39:24 +0200 Sebastian =?ISO-8859-1?Q?Dr=F6ge?= > wrote: > > Upstream fixed this now by making the soversion 1.4 and from now on > > guaranteeing that patch versions (1.4.0 -> 1.4.X) do not break ABI. > > > > It would make sense to backport that fix and then rename the > > library package accordingly to libsrt1.4. > > > > For gst-plugins-bad1.0 only a binNMU would be needed once this is > > all > > sorted out here. > > Can you do this please? srt is orphaned, your package depend on it, > could you please help us get us out of this situation? (if this > happens soon, we'll accept the transition to fix this). I'll try to have some time for that this weekend. signature.asc Description: This is a digitally signed message part
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Hi Sebastian, On Thu, 14 Jan 2021 11:39:24 +0200 Sebastian =?ISO-8859-1?Q?Dr=F6ge?= wrote: > Upstream fixed this now by making the soversion 1.4 and from now on > guaranteeing that patch versions (1.4.0 -> 1.4.X) do not break ABI. > > It would make sense to backport that fix and then rename the library > package accordingly to libsrt1.4. > > For gst-plugins-bad1.0 only a binNMU would be needed once this is all > sorted out here. Can you do this please? srt is orphaned, your package depend on it, could you please help us get us out of this situation? (if this happens soon, we'll accept the transition to fix this). Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
On Wed, 13 Jan 2021 17:42:27 +0100 Andreas Beckmann wrote: > Control: tag -1 patch > > Hi, > > On Thu, 7 Jan 2021 20:52:39 +0100 Paul Gevers wrote: > > On Tue, 06 Oct 2020 16:38:49 +0300 =?utf-8?q?Sebastian_Dr=C3=B6ge?= > > wrote: > > > 1.4.2 broke ABI by adding some fields to the CBytePerfMon structure. > > > See https://github.com/Haivision/srt/issues/1592 for details. > > > > Any progress on this? The freeze for bullseye is around the corner, and > > this bug is already impacting other packages that fail to migrate to > > testing due to srt not migrating. > > given the freeze timing and uncertain date for an upstream fix, I'd > suggest the attached patch: > * bump SOVERSION from 1 to 1.4.2 (that won't conflict with whatever > upstream chooses to solve this in the upcoming 1.4.3 release, be it > SOVERSION 1.4 or 1.4.3) > * rename the packages accordingly > > That will require a late transition involving only 1 package: > gst-plugins-bad1.0 Upstream fixed this now by making the soversion 1.4 and from now on guaranteeing that patch versions (1.4.0 -> 1.4.X) do not break ABI. It would make sense to backport that fix and then rename the library package accordingly to libsrt1.4. For gst-plugins-bad1.0 only a binNMU would be needed once this is all sorted out here. signature.asc Description: This is a digitally signed message part
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Control: tag -1 patch
Hi,
On Thu, 7 Jan 2021 20:52:39 +0100 Paul Gevers wrote:
> On Tue, 06 Oct 2020 16:38:49 +0300 =?utf-8?q?Sebastian_Dr=C3=B6ge?=
> wrote:
> > 1.4.2 broke ABI by adding some fields to the CBytePerfMon structure.
> > See https://github.com/Haivision/srt/issues/1592 for details.
>
> Any progress on this? The freeze for bullseye is around the corner, and
> this bug is already impacting other packages that fail to migrate to
> testing due to srt not migrating.
given the freeze timing and uncertain date for an upstream fix, I'd
suggest the attached patch:
* bump SOVERSION from 1 to 1.4.2 (that won't conflict with whatever
upstream chooses to solve this in the upcoming 1.4.3 release, be it
SOVERSION 1.4 or 1.4.3)
* rename the packages accordingly
That will require a late transition involving only 1 package:
gst-plugins-bad1.0
Andreas
>From 1a78394d5bd2c50ada11074841531a2b8c1ca7a1 Mon Sep 17 00:00:00 2001
From: Andreas Beckmann
Date: Wed, 13 Jan 2021 17:28:16 +0100
Subject: [PATCH] bump SOVERSION to 1.4.2 due to upstream ABI changes
---
debian/changelog | 7 +--
debian/control| 20 ---
...tls.install => libsrt1.4.2-gnutls.install} | 0
...sl.install => libsrt1.4.2-openssl.install} | 0
debian/patches/series | 1 +
debian/patches/soversion.patch| 11 ++
6 files changed, 25 insertions(+), 14 deletions(-)
rename debian/{libsrt1-gnutls.install => libsrt1.4.2-gnutls.install} (100%)
rename debian/{libsrt1-openssl.install => libsrt1.4.2-openssl.install} (100%)
create mode 100644 debian/patches/soversion.patch
diff --git a/debian/changelog b/debian/changelog
index cee8bd8..46802b2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,9 +1,12 @@
-srt (1:1.4.2-1) UNRELEASED; urgency=medium
+srt (1.4.2-2) UNRELEASED; urgency=medium
- * Bump up version number due to API change (Closes: #971754)
+ [ Federico Ceratto ]
* Pass flags to cmake (Closes: #971811)
Thanks to Helmut Grohne
+ [ Andreas Beckmann ]
+ * Bump SOVERSION to 1.4.2 due to upstream ABI changes. (Closes: #971754)
+
-- Federico Ceratto Sat, 02 Jan 2021 19:19:33 +
srt (1.4.2-1) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index ab67299..be80904 100644
--- a/debian/control
+++ b/debian/control
@@ -17,14 +17,10 @@ Vcs-Browser: https://salsa.debian.org/debian/libsrt
Vcs-Git: https://salsa.debian.org/debian/libsrt.git
Rules-Requires-Root: no
-Package: libsrt1-openssl
+Package: libsrt1.4.2-openssl
Architecture: any
-Breaks: libsrt1 (<< 1.4.1-3)
-Replaces: libsrt1 (<< 1.4.1-3)
Multi-Arch: same
Depends: ${shlibs:Depends}, ${misc:Depends}
-Conflicts: libsrt1
-Provides: libsrt1 (= ${binary:Version})
Description: Secure Reliable Transport UDP streaming library (OpenSSL flavour)
SRT is a latency-aware UDP transport mechanism optimized for video streams.
It detects and compensates for jitter and bandwidth fluctuations due to
@@ -32,7 +28,7 @@ Description: Secure Reliable Transport UDP streaming library (OpenSSL flavour)
.
SSL support is provided by OpenSSL.
-Package: libsrt1-gnutls
+Package: libsrt1.4.2-gnutls
Architecture: any
Multi-Arch: same
Depends: ${shlibs:Depends}, ${misc:Depends}
@@ -50,14 +46,14 @@ Replaces: libsrt-dev (<< 1.4.1-2)
Architecture: any
Multi-Arch: same
Conflicts: libsrt-gnutls-dev, libsrt-dev
-Depends: libsrt1-openssl (= ${binary:Version}), ${misc:Depends}
+Depends: libsrt1.4.2-openssl (= ${binary:Version}), ${misc:Depends}
Suggests: libsrt-doc (= ${binary:Version}), libssl-dev (>= 1.1)
Description: Secure Reliable Transport UDP streaming library
SRT is a latency-aware UDP transport mechanism optimized for video streams.
It detects and compensates for jitter and bandwidth fluctuations due to
network congestion. It mitigates packet loss and supports AES encryption.
.
- This package contains development files for libsrt1
+ This package contains development files for libsrt1.4.2
SSL support is provided by OpenSSL.
Package: libsrt-gnutls-dev
@@ -67,14 +63,14 @@ Replaces: libsrt-dev (<< 1.4.1-2)
Architecture: any
Multi-Arch: same
Conflicts: libsrt-openssl-dev, libsrt-dev
-Depends: libsrt1-gnutls (= ${binary:Version}), ${misc:Depends}
+Depends: libsrt1.4.2-gnutls (= ${binary:Version}), ${misc:Depends}
Suggests: libsrt-doc (= ${binary:Version}), libgnutls28-dev
Description: Secure Reliable Transport UDP streaming library
SRT is a latency-aware UDP transport mechanism optimized for video streams.
It detects and compensates for jitter and bandwidth fluctuations due to
network congestion. It mitigates packet loss and supports AES encryption.
.
- This package contains development files for libsrt1-gnutls
+ This package contains development files for libsrt1.4.2-gnutls
SSL support is provided by GnuTLS.
Package: libsrt-doc
@@ -86,13 +82,13 @@ Description: Secure Reliable Transport UDP
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Hi Federico, On Tue, 06 Oct 2020 16:38:49 +0300 =?utf-8?q?Sebastian_Dr=C3=B6ge?= wrote: > 1.4.2 broke ABI by adding some fields to the CBytePerfMon structure. > See https://github.com/Haivision/srt/issues/1592 for details. Any progress on this? The freeze for bullseye is around the corner, and this bug is already impacting other packages that fail to migrate to testing due to srt not migrating. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#971754: ABI breakage from 1.4.1 to 1.4.2
Source: srt Version: 1.4.2-1 Severity: serious Tags: upstream 1.4.2 broke ABI by adding some fields to the CBytePerfMon structure. See https://github.com/Haivision/srt/issues/1592 for details. There were also other ABI breakages in previous versions that are not reflected by the binary package name of the library. -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (700, 'unstable'), (500, 'unstable-debug'), (100, 'experimental'), (1, 'experimental-debug') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.8.0-2-amd64 (SMP w/8 CPU threads) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
