Bug#976620: marked as done (xlrd: if defusedxml installed, AttributeError: 'ElementTree' object has no attribute 'getiterator')

2021-01-17 Thread Debian Bug Tracking System
Your message dated Sun, 17 Jan 2021 20:39:16 +
with message-id 
and subject line Bug#976620: fixed in python-xlrd 1.2.0-2
has caused the Debian Bug report #976620,
regarding xlrd: if defusedxml installed, AttributeError: 'ElementTree' object 
has no attribute 'getiterator'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
976620: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976620
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

Package: python3-xlrd
Version: 1.2.0-1
Tags: patch

xlrd 1.2.0 started using defusedxml if available.

As defusedxml.cElementTree does not have a top-level ElementTree 
attribute, Element_has_iter gets set to False 
(https://sources.debian.org/src/python-xlrd/1.2.0-1/xlrd/xlsx.py/#L59). 
However, ET.parse returns a standard library ElementTree, which does 
have iter and not getiterator.  This causes the error:


E   AttributeError: 'ElementTree' object has no attribute 'getiterator'

/usr/lib/python3/dist-packages/xlrd/xlsx.py:266: AttributeError

This shows up in the pandas autopkgtest, as python3-pandas 
recommends/test-depends on python3-odf and hence python3-defusedxml.


Untested fix:

--- /usr/lib/python3/dist-packages/xlrd/xlsx.py.old 2020-12-05 
22:07:52.009976382 +
+++ /usr/lib/python3/dist-packages/xlrd/xlsx.py 2020-12-05 
22:13:19.330486195 +

@@ -56,7 +56,7 @@ def ensure_elementtree_imported(verbosit
 ET_has_iterparse = True
 except NotImplementedError:
 pass
-Element_has_iter = hasattr(ET, 'ElementTree') and 
hasattr(ET.ElementTree, 'iter')
+Element_has_iter = hasattr(ET.parse(BYTES_IO(b'')), 
'iter')

 if verbosity:
 etree_version = repr([
 (item, getattr(ET, item))

Known upstream as https://github.com/python-excel/xlrd/pull/360, which 
suggests basically the same fix.
--- End Message ---
--- Begin Message ---
Source: python-xlrd
Source-Version: 1.2.0-2
Done: Josue Ortega 

We believe that the bug you reported is fixed in the latest version of
python-xlrd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 976...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josue Ortega  (supplier of updated python-xlrd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Sun, 17 Jan 2021 13:56:21 -0600
Source: python-xlrd
Architecture: source
Version: 1.2.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team 
Changed-By: Josue Ortega 
Closes: 976573 976620
Changes:
 python-xlrd (1.2.0-2) unstable; urgency=medium
 .
   * Team upload.
   * Add patch 0002-fix-python39-compat: In order to fix FTBS issue.
 Closes: #976573
   * Add 0003-python39-compat-iter-detection.patch in order to fix iter()
 call when defusedxml is installed. Closes: #976620
   * Bump Standards-Version to 4.5.1. No changes required
   * debian/watch: Bump file standard version  to 4
   * debian/control: Document Rules-Requires-Root field as 'no'
Checksums-Sha1:
 f52ac3383da787a2757c79f7a2ec5f4ec865741b 2143 python-xlrd_1.2.0-2.dsc
 a83a56ad625e6ed7469f1ce08923b89b63921fa9 7420 python-xlrd_1.2.0-2.debian.tar.xz
 f0bbf58fd4760bb6fb82b2d3f79da19315ec8223 7490 
python-xlrd_1.2.0-2_amd64.buildinfo
Checksums-Sha256:
 cb3489a6697cac03d919d20c6ad304ac31959aeab9413bccad95de21e70525e1 2143 
python-xlrd_1.2.0-2.dsc
 4cce60cea03c274015235102930f216bd4f5c3952ece983647c167880f78efda 7420 
python-xlrd_1.2.0-2.debian.tar.xz
 3e325bf108ef5bb529e3af998fcee141c2faa3ed6e448023d62dbbbf2609417e 7490 
python-xlrd_1.2.0-2_amd64.buildinfo
Files:
 b3097a7b946161dc3d81b6d5440142a8 2143 python optional python-xlrd_1.2.0-2.dsc
 59cea77e4283a7a2f571e92996ba7134 7420 python optional 
python-xlrd_1.2.0-2.debian.tar.xz
 d3892ae54c9572aef737139b84936693 7490 python optional 
python-xlrd_1.2.0-2_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQJFBAEBCgAvFiEEdzOzKNJ5X1viMlrdAVCdXKtK/T8FAmAEl7ERHGpvc3VlQGRl
Ymlhbi5vcmcACgkQAVCdXKtK/T89CxAAj4uRTsvVUpqcIa426CHc+JAuK7Tl+DWS
ffyW45jkhCRDdzQrWsnt9SHZNHXRJq0Vq1plvkNYl3CkcTpjLJggK+RmK/iyMcFh
QtpQAAM1McFzgQ+VoOBlb+Qzqf1JOcZ3445Q89x9ce/EAJ2oRduk4mNAHULFbrXm

Bug#976620: marked as done (xlrd: if defusedxml installed, AttributeError: 'ElementTree' object has no attribute 'getiterator')

2021-01-17 Thread Debian Bug Tracking System
Your message dated Sun, 17 Jan 2021 20:39:16 +
with message-id 
and subject line Bug#976573: fixed in python-xlrd 1.2.0-2
has caused the Debian Bug report #976573,
regarding xlrd: if defusedxml installed, AttributeError: 'ElementTree' object 
has no attribute 'getiterator'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
976573: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976573
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

Package: python3-xlrd
Version: 1.2.0-1
Tags: patch

xlrd 1.2.0 started using defusedxml if available.

As defusedxml.cElementTree does not have a top-level ElementTree 
attribute, Element_has_iter gets set to False 
(https://sources.debian.org/src/python-xlrd/1.2.0-1/xlrd/xlsx.py/#L59). 
However, ET.parse returns a standard library ElementTree, which does 
have iter and not getiterator.  This causes the error:


E   AttributeError: 'ElementTree' object has no attribute 'getiterator'

/usr/lib/python3/dist-packages/xlrd/xlsx.py:266: AttributeError

This shows up in the pandas autopkgtest, as python3-pandas 
recommends/test-depends on python3-odf and hence python3-defusedxml.


Untested fix:

--- /usr/lib/python3/dist-packages/xlrd/xlsx.py.old 2020-12-05 
22:07:52.009976382 +
+++ /usr/lib/python3/dist-packages/xlrd/xlsx.py 2020-12-05 
22:13:19.330486195 +

@@ -56,7 +56,7 @@ def ensure_elementtree_imported(verbosit
 ET_has_iterparse = True
 except NotImplementedError:
 pass
-Element_has_iter = hasattr(ET, 'ElementTree') and 
hasattr(ET.ElementTree, 'iter')
+Element_has_iter = hasattr(ET.parse(BYTES_IO(b'')), 
'iter')

 if verbosity:
 etree_version = repr([
 (item, getattr(ET, item))

Known upstream as https://github.com/python-excel/xlrd/pull/360, which 
suggests basically the same fix.
--- End Message ---
--- Begin Message ---
Source: python-xlrd
Source-Version: 1.2.0-2
Done: Josue Ortega 

We believe that the bug you reported is fixed in the latest version of
python-xlrd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 976...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Josue Ortega  (supplier of updated python-xlrd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Sun, 17 Jan 2021 13:56:21 -0600
Source: python-xlrd
Architecture: source
Version: 1.2.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Team 
Changed-By: Josue Ortega 
Closes: 976573 976620
Changes:
 python-xlrd (1.2.0-2) unstable; urgency=medium
 .
   * Team upload.
   * Add patch 0002-fix-python39-compat: In order to fix FTBS issue.
 Closes: #976573
   * Add 0003-python39-compat-iter-detection.patch in order to fix iter()
 call when defusedxml is installed. Closes: #976620
   * Bump Standards-Version to 4.5.1. No changes required
   * debian/watch: Bump file standard version  to 4
   * debian/control: Document Rules-Requires-Root field as 'no'
Checksums-Sha1:
 f52ac3383da787a2757c79f7a2ec5f4ec865741b 2143 python-xlrd_1.2.0-2.dsc
 a83a56ad625e6ed7469f1ce08923b89b63921fa9 7420 python-xlrd_1.2.0-2.debian.tar.xz
 f0bbf58fd4760bb6fb82b2d3f79da19315ec8223 7490 
python-xlrd_1.2.0-2_amd64.buildinfo
Checksums-Sha256:
 cb3489a6697cac03d919d20c6ad304ac31959aeab9413bccad95de21e70525e1 2143 
python-xlrd_1.2.0-2.dsc
 4cce60cea03c274015235102930f216bd4f5c3952ece983647c167880f78efda 7420 
python-xlrd_1.2.0-2.debian.tar.xz
 3e325bf108ef5bb529e3af998fcee141c2faa3ed6e448023d62dbbbf2609417e 7490 
python-xlrd_1.2.0-2_amd64.buildinfo
Files:
 b3097a7b946161dc3d81b6d5440142a8 2143 python optional python-xlrd_1.2.0-2.dsc
 59cea77e4283a7a2f571e92996ba7134 7420 python optional 
python-xlrd_1.2.0-2.debian.tar.xz
 d3892ae54c9572aef737139b84936693 7490 python optional 
python-xlrd_1.2.0-2_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQJFBAEBCgAvFiEEdzOzKNJ5X1viMlrdAVCdXKtK/T8FAmAEl7ERHGpvc3VlQGRl
Ymlhbi5vcmcACgkQAVCdXKtK/T89CxAAj4uRTsvVUpqcIa426CHc+JAuK7Tl+DWS
ffyW45jkhCRDdzQrWsnt9SHZNHXRJq0Vq1plvkNYl3CkcTpjLJggK+RmK/iyMcFh
QtpQAAM1McFzgQ+VoOBlb+Qzqf1JOcZ3445Q89x9ce/EAJ2oRduk4mNAHULFbrXm