Bug#980023: petri-foo: FTBFS with GCC 10

[Bastian Germann]

Control: forwarded -1 https://github.com/petri-foo/Petri-Foo/pull/43

This is essentially the same patch.

Bug#980023: petri-foo: FTBFS with GCC 10

[Bastian Germann]

The last release which contained petri-foo was stretch and upstream is going 
nowhere.
I suggest to file a RM bug and if nobody reacts on this I am going to file one 
in a month.

Bug#980023: petri-foo: FTBFS with GCC 10

[Logan Rosen]

Source: petri-foo
Version: 0.1.87-4
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch
X-Debbugs-Cc: lo...@ubuntu.com

Hi,

petri-foo currently FTBFS on rebuild in unstable with GCC 10 as default
because of a variable being defined multiple times.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/gcc-10.patch: Fix FTBFS with GCC 10.

Thanks for considering the patch.

Logan
diff -Nru petri-foo-0.1.87/debian/control petri-foo-0.1.87/debian/control
--- petri-foo-0.1.87/debian/control 2018-02-05 11:51:44.0 -0500
+++ petri-foo-0.1.87/debian/control 2021-01-12 22:37:28.0 -0500
@@ -1,8 +1,7 @@
 Source: petri-foo
 Section: sound
 Priority: optional
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: Debian Multimedia Maintainers 

+Maintainer: Debian Multimedia Maintainers 

 Uploaders:
  Alessio Treglia ,
  Jaromír Mikeš 
diff -Nru petri-foo-0.1.87/debian/patches/gcc-10.patch 
petri-foo-0.1.87/debian/patches/gcc-10.patch
--- petri-foo-0.1.87/debian/patches/gcc-10.patch1969-12-31 
19:00:00.0 -0500
+++ petri-foo-0.1.87/debian/patches/gcc-10.patch2021-01-12 
22:37:27.0 -0500
@@ -0,0 +1,21 @@
+--- a/gui/gui.c
 b/gui/gui.c
+@@ -93,6 +93,8 @@
+ /* current patch, makes passing patch id to sample editor easier */
+ static int cur_patch = -1;
+ 
++GtkRecentManager *recent_manager;
++
+ 
+ GtkWidget* gui_title_new(const char* msg)
+ {
+--- a/gui/gui.h
 b/gui/gui.h
+@@ -107,6 +107,6 @@
+ 
+ void gui_set_session_mode(void);
+ 
+-GtkRecentManager *recent_manager;
++extern GtkRecentManager *recent_manager;
+  
+ #endif /* __GUI_H__ */
diff -Nru petri-foo-0.1.87/debian/patches/series 
petri-foo-0.1.87/debian/patches/series
--- petri-foo-0.1.87/debian/patches/series  2016-12-23 10:09:46.0 
-0500
+++ petri-foo-0.1.87/debian/patches/series  2021-01-12 22:36:12.0 
-0500
@@ -1,2 +1,3 @@
 0003-desktop_file_fix.patch
 0005-spelling.patch
+gcc-10.patch