Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2022-05-03 Thread Paul Gevers

Control: block 977311 by -1

On Sun, 14 Mar 2021 11:44:31 +0530 Pirate Praveen 
 wrote:

2. Yadd already discussed about node-uglifyjs-webpack-plugin with release team.


I don't recall that discussion now, can somebody please add a pointer to 
this bug report such that we can judge what to do with this RC bug for 
bookworm?


Paul


OpenPGP_signature
Description: OpenPGP digital signature


Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2021-03-13 Thread Pirate Praveen
[Ccing debian-release]

On Wed, 17 Feb 2021 14:01:40 + Julian Gilbey  wrote:
> On Sun, Feb 14, 2021 at 02:26:30PM +0100, Jonas Smedegaard wrote:
> > I still recommend to request release team to ignore for this release 
> > instead of lowering sverity, but don't care anough about this particular 
> > mess to discuss further...
> 
> Has the release team been contacted yet?  Once it is dropped from
> testing, it will not be reaccepted for bullseye.
> 

1. It is not marked for auto removal in tracker, so it will need a manual 
action from release team and they will see this bug before they remove. 

2. Yadd already discussed about node-uglifyjs-webpack-plugin with release team.

So in my understanding this package will be in bullseye.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2021-02-17 Thread Julian Gilbey
On Sun, Feb 14, 2021 at 02:26:30PM +0100, Jonas Smedegaard wrote:
> Quoting Pirate Praveen (2021-02-14 13:32:36)
> > On 2021, ഫെബ്രുവരി 14 2:55:33 PM IST, Jonas Smedegaard  
> > wrote:
> > >Quoting Pirate Praveen (2021-02-14 08:32:08)
> > >No, we should not hide the true severity of issues in our packages: 
> > >The issue _is_ serious and has been for some time.
> [...]
> > It also just a wrapper for calling uglify-js or terser directly from 
> > webpack.
> 
> Sorry, I now realize that we are talking about bug#977311 - I thought we 
> were talking about bug#952367
> 
> I still recommend to request release team to ignore for this release 
> instead of lowering sverity, but don't care anough about this particular 
> mess to discuss further...

Has the release team been contacted yet?  Once it is dropped from
testing, it will not be reaccepted for bullseye.

Best wishes,

   Julian



Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2021-02-14 Thread Jonas Smedegaard
Quoting Pirate Praveen (2021-02-14 13:32:36)
> 
> 
> On 2021, ഫെബ്രുവരി 14 2:55:33 PM IST, Jonas Smedegaard  wrote:
> >Quoting Pirate Praveen (2021-02-14 08:32:08)
> >> 
> >> 
> >> On 2021, ഫെബ്രുവരി 14 12:44:09 PM IST, Julian Gilbey  
> >> wrote:
> >> >webpack depends on node-uglifyjs-webpack-plugin, which in turn has a 
> >> >serious bug report against it because it is abandoned upstream.
> >> 
> >> We should reduce severity of that bug or add bullseye-ignore tag and 
> >> maintain it without upstream support.
> >
> >No, we should not hide the true severity of issues in our packages: 
> >The issue _is_ serious and has been for some time.
[...]
> It also just a wrapper for calling uglify-js or terser directly from 
> webpack.

Sorry, I now realize that we are talking about bug#977311 - I thought we 
were talking about bug#952367

I still recommend to request release team to ignore for this release 
instead of lowering sverity, but don't care anough about this particular 
mess to discuss further...


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature


Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2021-02-14 Thread Pirate Praveen



On 2021, ഫെബ്രുവരി 14 2:55:33 PM IST, Jonas Smedegaard  wrote:
>Quoting Pirate Praveen (2021-02-14 08:32:08)
>> 
>> 
>> On 2021, ഫെബ്രുവരി 14 12:44:09 PM IST, Julian Gilbey  wrote:
>> >webpack depends on node-uglifyjs-webpack-plugin, which in turn has a 
>> >serious bug report against it because it is abandoned upstream.
>> 
>> We should reduce severity of that bug or add bullseye-ignore tag and 
>> maintain it without upstream support.
>
>No, we should not hide the true severity of issues in our packages: The 
>issue _is_ serious and has been for some time.

It is perfectly working and nothing is broken. Only in case of some future 
bugs, we will have to fix it ourselves without upstream help. It also just a 
wrapper for calling uglify-js or terser directly from webpack. We will have to 
replace it for next release, but I don't think it is release critical when 
there are people willing to maintain it and nothing is broken currently.

>
>> >According to webpack/package.json, webpack does not seem to actually 
>> >depend on this plugin, so it should be find to just remove this 
>> >dependency.
>> >
>> >If this dependency is left, node-webpack will be dropped from 
>> >bullseye.
>
>@Praveen, do you have any comments on the proposed change?

I don't agree to removing webpack (which means removing a large number of node 
packages as well). My proposed solution is to ignore it for bullseye.
>
> - Jonas
>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



Bug#982766: [Pkg-javascript-devel] Bug#982766: Bug#982766: node-webpack: remove dependency on node-uglifyjs-webpack-plugin

2021-02-14 Thread Jonas Smedegaard
Quoting Pirate Praveen (2021-02-14 08:32:08)
> 
> 
> On 2021, ഫെബ്രുവരി 14 12:44:09 PM IST, Julian Gilbey  wrote:
> >webpack depends on node-uglifyjs-webpack-plugin, which in turn has a 
> >serious bug report against it because it is abandoned upstream.
> 
> We should reduce severity of that bug or add bullseye-ignore tag and 
> maintain it without upstream support.

No, we should not hide the true severity of issues in our packages: The 
issue _is_ serious and has been for some time.


> >According to webpack/package.json, webpack does not seem to actually 
> >depend on this plugin, so it should be find to just remove this 
> >dependency.
> >
> >If this dependency is left, node-webpack will be dropped from 
> >bullseye.

@Praveen, do you have any comments on the proposed change?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature