Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Bernard, Dennis, > Indeed: > > ii libsoci-core4.0:amd64 4.0.1-5 ... > ii libsoci-sqlite3-4.0:amd64 4.0.1-5 ... > > solved the problem: I now see the chat msgs history when I launch the > app. I didn't have a chance to send a new msg yet, because it's the > middle of the night for nearly all my contacts, and I don't want to > inadvertently 'awake' someone, but I am pretty sure its ok, will try > tomorrow ... I did try and here is happened: I sent a message, but no 'trace' (for me, the sender), that I did send the msg ... normally, when we send a msg, using the AppImage, linphone sends it and displays a feedback, in the top right corner of the message 'box' ! error, the msgs couldn't be sent ... v grey color, msgs delivered, but not read yet blue, the recipient did read the msg But with linphone debian, nothing is displayed 'at all', although the msg was sent, the recipient did receive it, and later responded, even after that though, no 'v', nor grey, nor 'blue' ... I wonder why and if this is a (separate) bug? Thanks, David ps: by the way, crossing my bug reports, the date is still wrong, fwiw, the attempt i made today, March the 18th are all labeled, on top/center of the messages I sent (to two diff recipients to try ...) Wednesday, March 17, 2021 time(which the correct local time) my message... pgp9NOE9R_1Iy.pgp Description: OpenPGP digital signature
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Hello Bernard, Dennis, > > Please make sure you also test a file transfer, which is part of the > > chat message interface [I couldn't try since the chat msgs itself > > didn't work ...], The file transfer functionality is absolutely > > essential as well, afaic at least > soci 4.0.1-5 has migrated to testing yesterday. The bug should be > fixed now for a fully up-to-date Bullseye system. Indeed: ii libsoci-core4.0:amd64 4.0.1-5 ... ii libsoci-sqlite3-4.0:amd64 4.0.1-5 ... solved the problem: I now see the chat msgs history when I launch the app. I didn't have a chance to send a new msg yet, because it's the middle of the night for nearly all my contacts, and I don't want to inadvertently 'awake' someone, but I am pretty sure its ok, will try tomorrow ... Thanks to both of you! David pgpp18y3FaiKy.pgp Description: OpenPGP digital signature
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Dear David, >>> I finally found the bug: ... > > Excellent! > > Please make sure you also test a file transfer, which is part of the > chat message interface [I couldn't try since the chat msgs itself > didn't work ...], The file transfer functionality is absolutely > essential as well, afaic at least soci 4.0.1-5 has migrated to testing yesterday. The bug should be fixed now for a fully up-to-date Bullseye system. Bernhard
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
On Thu, Mar 04, 2021 at 12:32:20AM +0100, Bernhard Schmidt wrote: > Cool, thanks. Would you mind discussing your findings with upstream at > https://gitlab.linphone.org/BC/public/liblinphone ? We will need a > freeze exception for this, having this bug confirmed by upstream would > help a lot, cherry-picking a commit from upstream would be even better. > > Right now I don't plan to upload src:linphone before 4.4.21-2 has > migrated to testing, in order to have a minimum amount of changes to be > discussed for the freeze exception. I'll talk to BC once my account is activated. Also I just filed #984534 against soci with a two-line patch that would fix the issue, too. The only change needed here then would be updated dependency info. Regards, Dennis
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Hi Bernhard, DEnnis, > > I finally found the bug: ... Excellent! Please make sure you also test a file transfer, which is part of the chat message interface [I couldn't try since the chat msgs itself didn't work ...], The file transfer functionality is absolutely essential as well, afaic at least Thanks, David pgpn4RmQpxO7P.pgp Description: OpenPGP digital signature
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Am 03.03.21 um 18:55 schrieb Dennis Filder: Hi Dennis, > On Sun, Feb 28, 2021 at 11:07:31PM +0100, Bernhard Schmidt wrote: >> an updated liblinphone has been uploaded to sid yesterday. Could you >> please try liblinphone10 and liblinphone++10 from sid (4.4.21-2) and >> report back? If it does not work you might need libsoci-core4.0 and >> libsoci-sqlite3-4.0 from unstable as well (4.0.1-4). > > I finally found the bug: libsoci_sqlite3 sometimes returns string > where liblinphone unconditionally expects int, long, double etc. which > led to silent std::bad_cast exceptions. I can't say who is actually > to blame (I feel soci should do that conversion already as it knows > what type the user requested, or at least not throw silently), but the > attached patches remedy the issue through some conditional string > conversion and make chat history actually work again in the GUI. They > should really have separated the sqlite3 database code better from the > MySQL code. > > I put this in two separate patches to make it easier to remove the > changes to the code for the legacy DB migration in case it causes > problems. Cool, thanks. Would you mind discussing your findings with upstream at https://gitlab.linphone.org/BC/public/liblinphone ? We will need a freeze exception for this, having this bug confirmed by upstream would help a lot, cherry-picking a commit from upstream would be even better. Right now I don't plan to upload src:linphone before 4.4.21-2 has migrated to testing, in order to have a minimum amount of changes to be discussed for the freeze exception. Bernhard
Bug#983365: [PATCH] Re: Bug#983365: linphone-desktop: chat messages
Control: tag -1 + patch upstream - help Control: reassign -1 linphone On Sun, Feb 28, 2021 at 11:07:31PM +0100, Bernhard Schmidt wrote: > an updated liblinphone has been uploaded to sid yesterday. Could you > please try liblinphone10 and liblinphone++10 from sid (4.4.21-2) and > report back? If it does not work you might need libsoci-core4.0 and > libsoci-sqlite3-4.0 from unstable as well (4.0.1-4). I finally found the bug: libsoci_sqlite3 sometimes returns string where liblinphone unconditionally expects int, long, double etc. which led to silent std::bad_cast exceptions. I can't say who is actually to blame (I feel soci should do that conversion already as it knows what type the user requested, or at least not throw silently), but the attached patches remedy the issue through some conditional string conversion and make chat history actually work again in the GUI. They should really have separated the sqlite3 database code better from the MySQL code. I put this in two separate patches to make it easier to remove the changes to the code for the legacy DB migration in case it causes problems. Regards, Dennis 0001-string-conversions.patch.gz Description: application/gzip 0002-string-conversions-legacydb.patch.gz Description: application/gzip
