Bug#984063: [Debian-med-packaging] Bug#984063: Please lets coordinate itk4/itk5 issues (Was: Bug#984063)

2021-12-09 Thread Adrian Bunk
On Tue, Nov 09, 2021 at 11:34:13PM +0100, Étienne Mollier wrote:
> Étienne Mollier, on 2021-11-08:
> > I haven't pushed investigations further for the moment.  This
> > possibly appeared with tiff 4.3.0, and probably got fixed in
> > ITKv5 as well.
> 
> Or not, the embedded copy is still libtiff 4.0.3 in ITKv5
> instead of the version 4.3.0.  Maybe something went wrong with
> our system tiff library, or the way it is called needs change;
> it's probably worth pinging upstream.
>...

ITKv5 appears to build, how was it fixed there?

The other problem is #984284, which seems to require a rename
of the libinsighttoolkit4.13 package.

> In hope this helps,
> Kind Regards,

cu
Adrian



Bug#984063: Please lets coordinate itk4/itk5 issues (Was: Bug#984063)

2021-11-08 Thread Steven Robbins
On Monday, November 8, 2021 1:09:43 A.M. CST Andreas Tille wrote:
> Hi,
> 
> this mail from Jose
> 
> Am Sat, Nov 06, 2021 at 01:33:29AM +0100 schrieb Jose Luis Rivero:
> > Hello! Gazebo maintainer here, affected by this RC bug. Looking into
> > upstream repository there is a potential commit that can be used to patch
> > this problem until new versions land in Debian:
> > 
> > https://github.com/InsightSoftwareConsortium/ITK/commit/840f22feb351739359
> > a8fdb55304124823a3a8c9

Are you saying this will allow ITKv4 to be built with current gcc?  At 
present, ITK is about to be removed from testing tomorrow because it won't 
build.

> caused me having a look into the Git repository of insighttoolkit4[1].
> It is missing the NMU 4.13.3withdata-dfsg1-4.1 by Andreas Beckmann and
> there are now the first commits done by Steve for insighttoolkit5
> version 5.2.1 which was ITPed by Ghislain[2].

Yep, I've already uploaded ITK 5 to Debian.
https://ftp-master.debian.org/new/insighttoolkit5_5.2.1-1.html

> I think we need to discuss whether
> 
>   1. We want to simply replace insighttoolkit4 (which makes the
>  usage of the existing repository[1] sensible - but please inject
>  the NMU changes at least in d/changelog

Yes.  This is what I've communicated already 2-3 times on the list -- going 
back a year -- and in Ghislain's ITP.

https://lists.debian.org/debian-med/2020/11/msg00212.html
https://lists.debian.org/debian-med/2021/10/msg00149.html
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995829#10


>   2. We should start ITK5 in a new repository and maintain both
>  versions at least for some time in parallel until all packages
>  that currently use ITK4 are migrated.

If we can get ITK4 to build with current compilers, my suggestion would be to 
make a v4 branch in the current repository.  On the other hand, it's kind of 
11th hour here.  I'm much more focused on replacing v4 with v5 -- which, to be 
fair is already more than two years old.  ITK v4 is no longer supported 
upstream.
 
> In any case people who are interested in ITK should coordinate their
> work and talk to each other which I'd like to kindly invite you to
> do here on the Debian Med mailing list (any other channel is fine for
> sure).

Yes, I've always used debian-med for communications.  Additional hands are 
always welcomed.

-Steve


signature.asc
Description: This is a digitally signed message part.


Bug#984063: Please lets coordinate itk4/itk5 issues (Was: Bug#984063)

2021-11-07 Thread Andreas Tille
Hi,

this mail from Jose 

Am Sat, Nov 06, 2021 at 01:33:29AM +0100 schrieb Jose Luis Rivero:
> Hello! Gazebo maintainer here, affected by this RC bug. Looking into
> upstream repository there is a potential commit that can be used to patch
> this problem until new versions land in Debian:
> 
> https://github.com/InsightSoftwareConsortium/ITK/commit/840f22feb351739359a8fdb55304124823a3a8c9

caused me having a look into the Git repository of insighttoolkit4[1].
It is missing the NMU 4.13.3withdata-dfsg1-4.1 by Andreas Beckmann and
there are now the first commits done by Steve for insighttoolkit5
version 5.2.1 which was ITPed by Ghislain[2].

I think we need to discuss whether

  1. We want to simply replace insighttoolkit4 (which makes the
 usage of the existing repository[1] sensible - but please inject
 the NMU changes at least in d/changelog

  2. We should start ITK5 in a new repository and maintain both
 versions at least for some time in parallel until all packages
 that currently use ITK4 are migrated.

In any case people who are interested in ITK should coordinate their
work and talk to each other which I'd like to kindly invite you to
do here on the Debian Med mailing list (any other channel is fine for
sure).

> Let me know if you need more help or assistance.

Every assistance is welcome.  BTW, I tried to apply the mentioned patch
to insighttoolkit4  4.13.3withdata-dfsg1-4.1  but it does not apply.  I
did not investigated why since I think some things should be clarified
first.

Kind regards

  Andreas.

[1] https://salsa.debian.org/med-team/insighttoolkit
[2] https://bugs.debian.org/995829

-- 
http://fam-tille.de