Your message dated Sun, 11 Jul 2021 20:17:00 +0000
with message-id <e1m2fsq-000gyc...@fasolo.debian.org>
and subject line Bug#990911: fixed in liferea 1.13.5-3
has caused the Debian Bug report #990911,
regarding liferea: Segfaults when selecting a news bin
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
990911: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990911
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: liferea
Version: 1.13.5-1
Severity: important
Tags: upstream, fixed-upstream, patch
liferea 1.13.5 will immediately segfault when selecting a news bin in
the left pane. (And if a news bin was the last selected item before
upgrading, it will then automatically crash on startup. I'd argue this
would justify a bump to serious; you be the judge.)
The bug is in feed_add_xml_attributes(), where node->subscription gets
dereferenced at the end, even if it was found to be NULL beforehand.
This was fixed upstream in 49cf235, by moving the last three lines
inside the if(), where they belong. That patch does not apply cleanly
to 1.13.5 (due to 9db267f), so I'm attaching a revised version.
-- System Information:
Debian Release: 11.0
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable-debug'), (500,
'testing-debug'), (100, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 5.10.0-5-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
>From dd9ede21cd822989e9fafecadefb4fc410a7c0e7 Mon Sep 17 00:00:00 2001
From: Lars Windolf <lars.wind...@gmx.de>
Date: Fri, 2 Apr 2021 01:22:24 +0200
Subject: [PATCH] Fix crash on selecting news bins
---
src/feed.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/feed.c b/src/feed.c
index 585ed82a..97848f9f 100644
--- a/src/feed.c
+++ b/src/feed.c
@@ -165,9 +165,14 @@ feed_add_xml_attributes (nodePtr node, xmlNodePtr feedNode)
xmlNewTextChild (feedNode, NULL, "feedId", node_get_id (node));
xmlNewTextChild (feedNode, NULL, "feedTitle", node_get_title (node));
- if (node->subscription)
+ if (node->subscription) {
subscription_to_xml (node->subscription, feedNode);
+ tmp = g_strdup_printf("%d", node->subscription->error);
+ xmlNewTextChild(feedNode, NULL, "error", tmp);
+ g_free(tmp);
+ }
+
tmp = g_strdup_printf("%d", node->available?1:0);
xmlNewTextChild(feedNode, NULL, "feedStatus", tmp);
g_free(tmp);
@@ -178,10 +183,6 @@ feed_add_xml_attributes (nodePtr node, xmlNodePtr feedNode)
if(feed->parseErrors && (strlen(feed->parseErrors->str) > 0))
xmlNewTextChild(feedNode, NULL, "parseError",
feed->parseErrors->str);
-
- tmp = g_strdup_printf("%d", node->subscription->error);
- xmlNewTextChild(feedNode, NULL, "error", tmp);
- g_free(tmp);
}
xmlDocPtr
--
2.30.2
--- End Message ---
--- Begin Message ---
Source: liferea
Source-Version: 1.13.5-3
Done: Paul Gevers <elb...@debian.org>
We believe that the bug you reported is fixed in the latest version of
liferea, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 990...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Paul Gevers <elb...@debian.org> (supplier of updated liferea package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 11 Jul 2021 21:37:39 +0200
Source: liferea
Architecture: source
Version: 1.13.5-3
Distribution: unstable
Urgency: medium
Maintainer: David Michael Smith <sidic...@gmail.com>
Changed-By: Paul Gevers <elb...@debian.org>
Closes: 990911
Changes:
liferea (1.13.5-3) unstable; urgency=medium
.
[ Frédéric Brière ]
* Add 0001-Fix-crash-on-selecting-news-bins.patch (Closes: #990911)
Checksums-Sha1:
142fc0026be345fb6b632869e980ffadfa189a72 2075 liferea_1.13.5-3.dsc
8f7e71b691c9b94c8b01c6b9202efe9180f90c29 28192 liferea_1.13.5-3.debian.tar.xz
Checksums-Sha256:
d4e5de34641324ebd50c5828e8a0ab80c6875177a3dd87b6b303d46e9794fa3d 2075
liferea_1.13.5-3.dsc
7cc539d49ced5b7d1cf809dcb3a500362be2df35d43fc28b864956d0b744664c 28192
liferea_1.13.5-3.debian.tar.xz
Files:
0763fef9eb883a9268c9e7bf8a628f0a 2075 web optional liferea_1.13.5-3.dsc
869ec9cc980768934fa80dbbeda5deaf 28192 web optional
liferea_1.13.5-3.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAmDrShsACgkQnFyZ6wW9
dQrkdwf/Ya868rL5TIQvDxjpJTvwwqBhoMeIKMLl5iZW+rBTO5AsGpJJl9Yn+GXR
zGXVp5ykzf/MwfjvZ9teyhlSWPSgge1mP97GXJtqSqDfMXcMU/pLo/WNQvs6vLkU
caVjCq0n36EFLL4kjQ9+ZBwgEYcxOolZupu9DPnuj7HjBDiKiTeD6yV1JLEApAB/
NUZ5VLQSOU0CRXdGroScEY3V7u8NX7Vxg9t8X70n+uuiv5fvPDoyjw89O6TLeAr7
Kywa9mpqqYGzYQgsx/Xg6mtoXTy9MLDVkPYJ+qWqHUSk6rWvetlWLai1m25+99A2
vuCnRrpvktdus1bEgXx+55fZ0OhGHw==
=cCPH
-----END PGP SIGNATURE-----
--- End Message ---
