Bug#536312: task overrides for stable appear to be updated when unstable changes - no network-manager etc in default debian 5.0r2 install

2009-07-10 Thread Frans Pop
Here's an (untested) patch that should avoid this issue for the future.
It determines the codename for testing from the testing symlink.

A manual cleanup for the current incorrect override files (for both lenny 
and squeeze) will still be needed of course.

Cheers,
FJP

--- mk-extra-overrides.sh.orig  2009-07-10 08:34:29.0 +
+++ mk-extra-overrides.sh   2009-07-10 08:51:53.0 +
@@ -5,8 +5,23 @@

 x=build-essential tag task
 opath=/org/ftp.debian.org/scripts/override
+apath=/org/ftp.debian.org/ftp/dists

-for s in lenny sid; do
+if [ ! -d $apath ]; then
+  echo $0: invalid path to archive 2
+  exit 1
+elif [ ! -L $apath/testing ]; then
+  echo $0: symlink for testing suite does not exist 2
+  exit 1
+fi
+
+codename_testing=$(basename $(readlink $apath/testing))
+if [ -z $codename_testing ] || [ ! -d $apath/$codename_testing ]; 
then
+  echo $0: invalid codename for testing suite ('$codename_testing') 2
+  exit 1
+fi
+
+for s in $codename_testing sid; do
   for c in main contrib non-free; do
 echo Making $opath/override.$s.extra.$c
 if [ $c = main ]; then


-- 
To UNSUBSCRIBE, email to debian-cd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Bug#536312: task overrides for stable appear to be updated when unstable changes - no network-manager etc in default debian 5.0r2 install

2009-07-10 Thread Frans Pop
On Friday 10 July 2009, Frans Pop wrote:
 Here's an (untested) patch that should avoid this issue for the future.
 It determines the codename for testing from the testing symlink.

As the script is maybe not under version control, attached the full new 
version.



mk-extra-overrides.sh
Description: application/shellscript


Bug#536312: task overrides for stable appear to be updated when unstable changes - no network-manager etc in default debian 5.0r2 install

2009-07-08 Thread Joey Hess
Package: ftp.debian.org
Severity: grave
Tags: d-i

The Task field overrides for stable are supposed to be based on the task
data contained in the tasksel in stable. However, they seem to be being
based on those in unstable, which results in newly installed 5.0r2
systems missing important packages including network-manager-gnome,
pidgin, and gstreamer0.10-ffmpeg.

None of these packages have a Task: gnome-desktop field in stable, and
all of them should. All of these packages were removed from that task in
tasksel 2.79, which is in unstable.

Additionally, pm-utils is in the desktop and laptop tasks, a change that
was only made in unstable. hibernate is missing from the laptop task,
which was also only done in unstable.

Additionally, the kde-desktop task is likely 100% hosed, since
unstable's version has been updated for kde 4.

I have not checked 5.0r2 CD images to see if their tasks are also
broken, but based on tasksel's upload date and when 5.0r2 was released,
it seems likely they are.


Ftpmasters: Task override updating is handled by an autobyhand script
fjp wrote, /srv/ftp.debian.org/dak/scripts/debian/byhand-task. I don't
have access to look at what's on ftpmaster, but looking at the patches
fjp posted about this, it seems to update
/srv/ftp.debian.org/scripts/external-overrides/task with the file
from tasksel, and then run mk-extra-overrides.sh in the same directory.
Perhaps the issue of keeping differing overrides for stable and unstable
separate was entirely overlooked? Although IIRC ftpmaster had a
different set of task override files for stable.


Recommendation: Fix tasks, on ftpmaster immediatly, throw out all
5.0r2 CD images, and maybe try to deal with upgrading brokenly
installed systems? Then figure out how the autobyhand script failed
and fix it..

-- 
see shy jo


signature.asc
Description: Digital signature


Re: Bug#536312: task overrides for stable appear to be updated when unstable changes - no network-manager etc in default debian 5.0r2 install

2009-07-08 Thread Frans Pop
On Thursday 09 July 2009, Joey Hess wrote:
 Ftpmasters: Task override updating is handled by an autobyhand script
 fjp wrote, /srv/ftp.debian.org/dak/scripts/debian/byhand-task. I don't
 have access to look at what's on ftpmaster,

AFAIK everything can also be found on merkel though.

 but looking at the patches fjp posted about this, it seems to update
 /srv/ftp.debian.org/scripts/external-overrides/task with the file
 from tasksel, and then run mk-extra-overrides.sh in the same directory.
 Perhaps the issue of keeping differing overrides for stable and
 unstable separate was entirely overlooked? Although IIRC ftpmaster had
 a different set of task override files for stable.

I doubt that that is the cause as I do remember considering that aspect 
when we made the change. For that reason my patches also still force a 
real by-hand for uploads of tasksel to stable.

/me looks on merkel...

Hmmm, mk-extra-overrides.sh has this:
for s in lenny sid; do
  for c in main contrib non-free; do
echo Making $opath/override.$s.extra.$c

So it looks like the problem is that that script should have been updated 
to 'for s in squeeze sid; do' when lenny was released, but that this was 
forgotten.

Perhaps the releases to act on should not be hardcoded but instead taken 
from some configuration file?

Cheers,
FJP


signature.asc
Description: This is a digitally signed message part.