Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
(No need to CC me on replies.)
On Friday 07 August 2009, Ian Campbell wrote:
show_usage() {
- echo Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all]
BC|NETINST|CD|DVD [ARCH ...]
+ echo Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] [-v
VARIANTS] BC|NETINST|CD|DVD [ARCH ...] }
This line is getting too long now. Suggest changing it to:
echo Usage: $(basename $0) [OPTIONS] BC|NETINST|CD|DVD [ARCH ...]
echo Options:
echo -d gnome|kde|lxde|xfce|light|all : desktop variant (task) to use
echo -v variant : ...
echo -h help
@@ -25,7 +25,8 @@ if [ $# -eq 0 ]; then
fi
desktop=
-while getopts d:h OPT ; do
+VARIANTS=
+while getopts d:hV: OPT ; do
Why capital V instead of lower case v as shown in usage?
case $OPT in
d)
case $OPTARG in
@@ -38,11 +39,13 @@ while getopts d:h OPT ; do
exit 1
;;
esac ;;
+ V) VARIANTS=$VARIANTS $OPTARG ;;
Idem.
Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
On Friday 07 August 2009, Ian Campbell wrote: This patch just adds the generic support code: * CONF.sh: Add $(VARIANTS) configuration variable. * eash-build.sh: Add command line parameter to enable variants. * Makefile: Define VARIANT_xxx when preprocessing package list. * boot/?/common.sh: Add a function for checking if a variant is enabled. * generate_di_list: Allow variant overrides in udeb exclusion list. It would be nice to have the variants functionality documented a bit, especially as it adds syntax extentions in various existing files. Given the already fragmented state of the documentation, a separate document in the docs directory probably makes most sense. -- To UNSUBSCRIBE, email to debian-cd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
On Fri, 2009-08-07 at 16:08 +0200, Frans Pop wrote:
(No need to CC me on replies.)
Sorry about that.
On Friday 07 August 2009, Ian Campbell wrote:
show_usage() {
- echo Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all]
BC|NETINST|CD|DVD [ARCH ...]
+ echo Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] [-v
VARIANTS] BC|NETINST|CD|DVD [ARCH ...] }
This line is getting too long now. Suggest changing it to:
echo Usage: $(basename $0) [OPTIONS] BC|NETINST|CD|DVD [ARCH ...]
echo Options:
echo -d gnome|kde|lxde|xfce|light|all : desktop variant (task) to use
echo -v variant : ...
echo -h help
ACK.
@@ -25,7 +25,8 @@ if [ $# -eq 0 ]; then
fi
desktop=
-while getopts d:h OPT ; do
+VARIANTS=
+while getopts d:hV: OPT ; do
Why capital V instead of lower case v as shown in usage?
I started with one and changed my mind to use the other. I think I
intended to switch completely to -V in order to leave -v free for the
more common use of verbose if that ever became useful or necessary
(maybe unlikely).
Since fixing up the usage spans multiple patches I'll repost the entire
series with all the feedback so far.
Ian.
--
Ian Campbell
Marriage is the waste-paper basket of the emotions.
--
To UNSUBSCRIBE, email to debian-cd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
On Fri, 2009-08-07 at 16:13 +0200, Frans Pop wrote: On Friday 07 August 2009, Ian Campbell wrote: This patch just adds the generic support code: * CONF.sh: Add $(VARIANTS) configuration variable. * eash-build.sh: Add command line parameter to enable variants. * Makefile: Define VARIANT_xxx when preprocessing package list. * boot/?/common.sh: Add a function for checking if a variant is enabled. * generate_di_list: Allow variant overrides in udeb exclusion list. It would be nice to have the variants functionality documented a bit, especially as it adds syntax extentions in various existing files. Sure. Given the already fragmented state of the documentation, a separate document in the docs directory probably makes most sense. Do I need to html it up and wire it into the existing documents? Looks like that stuff is very incomplete, a bunch of the links are dead and a variants chapter doesn't really seem to fit in anywhere in the existing narrative (such as it is), would a simple standalone text document to acceptable? Ian. -- Ian Campbell Current Noise: Black Label Society - Genocide Junkies That wouldn't be good enough. -- Larry Wall in 199710131621.jaa14...@wall.org -- To UNSUBSCRIBE, email to debian-cd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
On Friday 07 August 2009, Ian Campbell wrote: On Fri, 2009-08-07 at 16:13 +0200, Frans Pop wrote: On Friday 07 August 2009, Ian Campbell wrote: This patch just adds the generic support code: * CONF.sh: Add $(VARIANTS) configuration variable. * eash-build.sh: Add command line parameter to enable variants. * Makefile: Define VARIANT_xxx when preprocessing package list. * boot/?/common.sh: Add a function for checking if a variant is enabled. * generate_di_list: Allow variant overrides in udeb exclusion list. It would be nice to have the variants functionality documented a bit, especially as it adds syntax extentions in various existing files. Sure. Given the already fragmented state of the documentation, a separate document in the docs directory probably makes most sense. Do I need to html it up and wire it into the existing documents? Looks like that stuff is very incomplete, a bunch of the links are dead and a variants chapter doesn't really seem to fit in anywhere in the existing narrative (such as it is), would a simple standalone text document to acceptable? Eh, that's why I wrote a separate document in the docs directory :-) I'd suggest a simple 'README.variants' text document. I'd also suggest adding a reference to that doc in the CONF.sh instead of the example, and documenting the supported variants in the README. -- To UNSUBSCRIBE, email to debian-cd-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
