Bug#607142: overwrites custom plymouth configuration

2010-12-15 Thread Yves-Alexis Perez
On mer., 2010-12-15 at 17:01 +0100, Michael Biebl wrote:
> On 15.12.2010 16:45, Michael Biebl wrote:
> > On 15.12.2010 08:33, Yves-Alexis Perez wrote:
> >> On mar., 2010-12-14 at 23:43 +0100, Michael Biebl wrote:
> >>> I'm using a custom theme for plymouth and desktop-base overwrites that
> >>> setting on each upgrade.
> >>
> >> The same is true for splashy and grub, was true in Lenny (and Etch, I
> >> guess).
> > 
> > I can't speak for splashy, but for grub the alternatives system is used, so 
> > my
> > changes are preserved on upgrades.
> 
> grub2, to be precise.
> 
> >>>
> >>> I'm filing this bug with severity serious as the package overwrites
> >>> custom configuration in /etc/ (/etc/plymouth/plymouthd.conf).
> >>
> >> To be precise, no, it doesn't overwrite the configuration. But yes, it
> >> sets the default theme (by calling the relevant plymouth command). 
> 
> I need to clarify that, as this is simply not true:
> plymouth-set-default-theme overwrites my custom configuration in
> /etc/plymouth/plymouthd.conf, this is not "setting a new default theme".
> Please keep in mind that /etc/plymouth/plymouthd.conf is even listed as 
> conffile
> of the plymouth package.
> 
> If it would change the value in /usr/share/plymouth/plymouthd.defaults, I'd
> agree with you, but it doesn't.

Yes, it's nitpicking, but desktop-base doesn't actually overwrite
anything, it just asks plymouth to set the theme. How it does it doesn't
really matter, in that case it replaces the /etc config file without
asking.

In this case, I guess it shouldn't be allowed to call
plymouth-set-default-theme from a package maintainer script.

The thing is, without further modifications to plymouth, we don't have
much solutions for Squeeze, even alternatives means way too much
modifications for the RT I think.
> 
> Daniel, aside from the alternatives idea I mentioned earlier, is there a way 
> to
> override the default values in /usr/share/plymouth/plymouthd.defaults while
> preserving local modifications?
> desktop-base could divert that file, but I'm not convinced yet that I like 
> this
> idea.

The same kind of thing done for Xfce, where we add an override directory
between /usr/share/ and /etc, would be nice. But I'm not sure it's
doable for Squeeze.

Regards,
-- 
Yves-Alexis


signature.asc
Description: This is a digitally signed message part


Bug#607142: overwrites custom plymouth configuration

2010-12-15 Thread Michael Biebl
On 15.12.2010 16:45, Michael Biebl wrote:
> On 15.12.2010 08:33, Yves-Alexis Perez wrote:
>> On mar., 2010-12-14 at 23:43 +0100, Michael Biebl wrote:
>>> I'm using a custom theme for plymouth and desktop-base overwrites that
>>> setting on each upgrade.
>>
>> The same is true for splashy and grub, was true in Lenny (and Etch, I
>> guess).
> 
> I can't speak for splashy, but for grub the alternatives system is used, so my
> changes are preserved on upgrades.

grub2, to be precise.

>>>
>>> I'm filing this bug with severity serious as the package overwrites
>>> custom configuration in /etc/ (/etc/plymouth/plymouthd.conf).
>>
>> To be precise, no, it doesn't overwrite the configuration. But yes, it
>> sets the default theme (by calling the relevant plymouth command). 

I need to clarify that, as this is simply not true:
plymouth-set-default-theme overwrites my custom configuration in
/etc/plymouth/plymouthd.conf, this is not "setting a new default theme".
Please keep in mind that /etc/plymouth/plymouthd.conf is even listed as conffile
of the plymouth package.

If it would change the value in /usr/share/plymouth/plymouthd.defaults, I'd
agree with you, but it doesn't.

Daniel, aside from the alternatives idea I mentioned earlier, is there a way to
override the default values in /usr/share/plymouth/plymouthd.defaults while
preserving local modifications?
desktop-base could divert that file, but I'm not convinced yet that I like this
idea.

Michael





-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Bug#607142: overwrites custom plymouth configuration

2010-12-15 Thread Michael Biebl
On 15.12.2010 08:33, Yves-Alexis Perez wrote:
> On mar., 2010-12-14 at 23:43 +0100, Michael Biebl wrote:
>> I'm using a custom theme for plymouth and desktop-base overwrites that
>> setting on each upgrade.
> 
> The same is true for splashy and grub, was true in Lenny (and Etch, I
> guess).

I can't speak for splashy, but for grub the alternatives system is used, so my
changes are preserved on upgrades.

>>
>> I'm filing this bug with severity serious as the package overwrites
>> custom configuration in /etc/ (/etc/plymouth/plymouthd.conf).
> 
> To be precise, no, it doesn't overwrite the configuration. But yes, it
> sets the default theme (by calling the relevant plymouth command). 
> 
> The whole point of desktop-base is to provide a theme for the whole
> desktop. For now, if you want to only use a subset of the themes, yes,
> you have to reconfigure that at each upgrade. If you have an idea on how
> to do that more smoothly, you're welcome to propose it.

We could also use alternatives here.

Say, plymouth ships with a default configuration that says
Theme=debian-plymouth-theme (or so), which is an alternative that by default
points to text.
desktop-base could install the new theme as alternative with a higher priority.

One neat thing of this approach would be (given we have different themes), that
we could use slaves to switch all alternatives in one go to a new theme [1]

Cheers,
Michael




[1] "It is often useful for a number of alternatives to be synchronised, so that
they are changed as a group; for example, when several versions of the vi(1)
editor are installed, the man page referenced by /usr/share/man/man1/vi.1 should
correspond to the executable referenced by /usr/bin/vi . update-alternatives
handles this by means of master and slave links; when the master is changed, any
associated slaves are changed too. A master link and its associated slaves make
up a link group"

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature