Bug#850181: plymouth theme(s) should provide fsck progress support

[Michael Biebl]

Am 11.01.2017 um 19:59 schrieb Michael Biebl:

> It's an external monitor (1920x1200) attached to my laptop (1366x768)
> via a docking station. The laptop internal display was turned off during
> boot (lid was closed).

I will retry with the laptop undocked later today. This should provide a
more "standard" 16x9 setup.

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#850181: plymouth theme(s) should provide fsck progress support

[Michael Biebl]

Hi

Am 11.01.2017 um 19:56 schrieb Aurélien COUDERC:
> Le mercredi 11 janvier 2017, 19:27:29 IST Michael Biebl a écrit :

>> Is this dependent on the aspect ratio?
> 
> And resolution. The font size is fixed whereas other theme elements are 
> scaled.

Urgh

> But I really don’t understand the softWaves screenshot, all the text elements 
> are supposed to be below the Debian text.
> I’ve tested on a laptop with this exact resolution and it was working as 
> intended, so… I’ll re-read the code and see if I can find something funny in 
> the positioning.
> 
> Do you have a second monitor plugged in ?

It's an external monitor (1920x1200) attached to my laptop (1366x768)
via a docking station. The laptop internal display was turned off during
boot (lid was closed).

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#850181: plymouth theme(s) should provide fsck progress support

[Aurélien COUDERC]

Le mercredi 11 janvier 2017, 19:27:29 IST Michael Biebl a écrit :
> Am 11.01.2017 um 18:51 schrieb Michael Biebl:
> > Am 11.01.2017 um 18:46 schrieb Aurélien COUDERC:
> >>
> >>
> >> Le 10 janvier 2017 17:28:46 GMT+05:30, Michael Biebl  a 
> >> écrit :
> >>
> >>> I've tested all three themes, they worked fine with one or multiple
> >>> fscks running at the same time. I've attached a screenshot for each of
> >>> them. A few suggestions:
> >>> a/ Joy looks ok
> >>> b/ Lines:
> >>>  - The text is not horizontally aligned (centered)
> >>> - The text should probably be moved lower so it doesn't intersect with
> >>> the lines graphic
> >>> c/ softwaves:
> >>> - The text should be moved lower so it doesn't intersect with the
> >>> circle
> >>
> >> Which resolution would that be ?
> > 
> > 1920x1200
> 
> 
> Is this dependent on the aspect ratio?

And resolution. The font size is fixed whereas other theme elements are scaled.

But I really don’t understand the softWaves screenshot, all the text elements 
are supposed to be below the Debian text.
I’ve tested on a laptop with this exact resolution and it was working as 
intended, so… I’ll re-read the code and see if I can find something funny in 
the positioning.

Do you have a second monitor plugged in ?


Cheers,
--Aurélien

Bug#850181: plymouth theme(s) should provide fsck progress support

[Michael Biebl]

Am 11.01.2017 um 18:51 schrieb Michael Biebl:
> Am 11.01.2017 um 18:46 schrieb Aurélien COUDERC:
>>
>>
>> Le 10 janvier 2017 17:28:46 GMT+05:30, Michael Biebl  a 
>> écrit :
>>
>>> I've tested all three themes, they worked fine with one or multiple
>>> fscks running at the same time. I've attached a screenshot for each of
>>> them. A few suggestions:
>>> a/ Joy looks ok
>>> b/ Lines:
>>>  - The text is not horizontally aligned (centered)
>>> - The text should probably be moved lower so it doesn't intersect with
>>> the lines graphic
>>> c/ softwaves:
>>> - The text should be moved lower so it doesn't intersect with the
>>> circle
>>
>> Which resolution would that be ?
> 
> 1920x1200


Is this dependent on the aspect ratio?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#850181: plymouth theme(s) should provide fsck progress support

[Michael Biebl]

Am 11.01.2017 um 18:46 schrieb Aurélien COUDERC:
> 
> 
> Le 10 janvier 2017 17:28:46 GMT+05:30, Michael Biebl  a 
> écrit :
> 
>> I've tested all three themes, they worked fine with one or multiple
>> fscks running at the same time. I've attached a screenshot for each of
>> them. A few suggestions:
>> a/ Joy looks ok
>> b/ Lines:
>>  - The text is not horizontally aligned (centered)
>> - The text should probably be moved lower so it doesn't intersect with
>> the lines graphic
>> c/ softwaves:
>> - The text should be moved lower so it doesn't intersect with the
>> circle
> 
> Which resolution would that be ?

1920x1200


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#850181: plymouth theme(s) should provide fsck progress support

[Aurélien COUDERC]

Le 10 janvier 2017 17:28:46 GMT+05:30, Michael Biebl  a écrit 
:

>I've tested all three themes, they worked fine with one or multiple
>fscks running at the same time. I've attached a screenshot for each of
>them. A few suggestions:
>a/ Joy looks ok
>b/ Lines:
>  - The text is not horizontally aligned (centered)
> - The text should probably be moved lower so it doesn't intersect with
>the lines graphic
>c/ softwaves:
>- The text should be moved lower so it doesn't intersect with the
>circle

Which resolution would that be ?


Thanks,
--Aurélien

Bug#850181: plymouth theme(s) should provide fsck progress support

[Aurélien COUDERC]

Sending to correct bug.

Le 9 janvier 2017 16:43:35 GMT+01:00, "Aurélien COUDERC"  a 
écrit :
>Hi
>
>Le 4 janvier 2017 14:37:25 GMT+01:00, Michael Biebl 
>a écrit :
>>Hi Aurélien,
>[…]
>>Do you know what is missing to have fsck progress support in plymouth?
>>Is that a theme issue or something which needs to be supported by
>>plymouth (or both)?
>
>Should be fixed in svn head, feel free to build the package for testing
>and report here.
>
>>I know, SSDs are more popular these days so long fsck times are not
>>that
>>common anymore. Would still be nice to have support for that in
>>plymouth, otherwise it's rather pointless to ship fsckd in systemd
>[1].
>
>I've given it a quick try by setting up an old machine with a rotating
>drive and it worked. More test confirmations will be welcome tough.
>
>
>Cheers,
>--Aurélien

Bug#850181: plymouth theme(s) should provide fsck progress support

[Michael Biebl]

Package: desktop-base
Version: 9.0.0

Am 04.01.2017 um 17:42 schrieb Didier Roche:
> Le 04/01/2017 à 17:28, Aurélien COUDERC a écrit :
>> Le 4 janvier 2017 16:50:51 GMT+01:00, Didier Roche 
>> a écrit :
>>> Indeed, I ensure we do have all bits needed in plymouth, and then, only
>>> the themes can hook up as they need and treat the prepending "fsckd:"
>>> message in a special way (took a look at what we do in the text and
>>> ubuntu-logo theme, it should be straightforward)
>>>
>>> Didier
>>
>>
>> Oh right, feel free to open a different bug then I'll have another look.

Agreed.
I'm quoting the full message here to include Didier's excellent reply.


>> I've already diffed against xenial logo-theme while working on this and
>> didn't notice meaningful differences.
>> But I may have missed the relevant bits, or the systemd/fsckd
>> integration may have been implemented post-xenial in Ubuntu.
> 
> For reference, I did try to be backward compatible (we did have this
> support some time ago for all flavors), but just added more messages
> type (I wouldn't say the ubuntu logo theme is the cleanest code-wise):
> 
> If my memory is correct (I didn't do the first implementation with
> upstart years ago, just modified to work with systemd-fsckd), but
> basically, there are 2 channels of messages that you hook in in your theme:
> 
> * an "update status" plymouth callback:
> systemd-fsckd pass fsckd:::
> 
> * another is a "message" plymouth callback prefixed by
> "fsckd-cancel-msg:l10n_string" with the cancel message to display when
> available.
> 
> The rest like handling Ctrl+C and such is done in plymouth side itself
> if my memory is correct (I don't remember if debian took it).
> 
> Didier
> 


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature