Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Friday 08 November 2013 01:06:01 gregor herrmann wrote: On Thu, 07 Nov 2013 22:37:01 +0100, Pali Rohár wrote: Again, after month I have not got any responce. CCing everybody from this thread. What to do? I'd say you got an email problem. If I were the recpient of this email I wouldn't know what you were asking. Ok, here is info: Months ago I sent patch for package netplug to ML. Someody wrote that I should send it to bugtracker. So I posted it to [1]. Which you haven't CC'd now ... I also sent that patch also to upstream project, but no response. Even no response from Debian package maintainer. Also bug page is without comments. Every month I send email to ML to this thread, asking for state. I totally understand your frustration, and I'm sorry that Debian at large can be quite bad at dealing with requests like this. But mailing debian-devel, which is a high-level meta discussion list around Debian development in general, read by thousands of people (and not a community of a handful people working on this or a couple of packages) and cc'ing unrelated people won't help either ... Ok, so where to send email(s) if debian-devel list is not good? Ideas: - always keep the bug in the loop - contact the MIA team, if you think the maintainers are inactive - prepare an NMU and ask for sponsorship on debian-mentors what MIA and NMU means? (As a personal note, I'm very appreciative about your great work in Maemo, and I'm very happy to see something from Maemo coming back to Debian, even if it's frustrating for your right now.) Cheers, gregor -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Sun, 10 Nov 2013 17:54:15 +0100, Pali Rohár wrote: Ok, here is info: Months ago I sent patch for package netplug to ML. Someody wrote that I should send it to bugtracker. So I posted it to [1]. Which you haven't CC'd now ... [..] But mailing debian-devel, which is a high-level meta discussion list around Debian development in general, read by thousands of people (and not a community of a handful people working on this or a couple of packages) and cc'ing unrelated people won't help either ... Ok, so where to send email(s) if debian-devel list is not good? To the bug report (CC'd again) and maybe: - always keep the bug in the loop - contact the MIA team, if you think the maintainers are inactive - prepare an NMU and ask for sponsorship on debian-mentors what MIA and NMU means? MIA: missing-in-action: https://wiki.debian.org/Teams/MIA https://wiki.debian.org/qa.debian.org/MIATeam http://www.debian.org/doc/manuals/developers-reference/beyond-pkging.html#mia-qa NMU: Non-maintainer upload: http://www.debian.org/doc/manuals/developers-reference/pkgs.html#nmu https://wiki.debian.org/NonMaintainerUpload Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Leonard Cohen: I Can't Forget signature.asc Description: Digital signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Monday 16 September 2013 11:40:00 Pali Rohár wrote: On Monday 16 September 2013 00:35:52 Paul Tagliamonte wrote: On Mon, Sep 16, 2013 at 12:15:20AM +0200, Pali Rohár wrote: Bump. Is there any problem? Hey there Pali, First of all, thank you for your hard work and persistence - I admire that a great deal! Keep that up! One interesting thing with Debian is that DDs can't go into another maintainer's package and change something (such as a new feature or upstream release) without the maintainer's consent. If you're able to get the maintainer of this package to sign off on the patch, and ack a NMU against it, I'm sure any number of us would be more than happy to sponsor the upload. However, doing this is frowned upon without the coordination of the current maintainer - so that's a pretty needed first step! Thank you so much for your work! Let's get your changes in the archive! Paul CCing Philipp Matthias Hahn, maintainer of netplug package. Again, after month I have not got any responce. CCing everybody from this thread. What to do? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thu, Nov 07, 2013 at 05:20:08PM +0100, Pali Rohár wrote: Again, after month I have not got any responce. CCing everybody from this thread. What to do? I'd say you got an email problem. If I were the recpient of this email I wouldn't know what you were asking. I get lots of emails and look after many packages. I assume you want a reply from these people. A simple To recap, package X needs package Y to do Z, further details are at W will mean more chance of a reply. The email as currently sent is a bit context-free to me. - Craig -- Craig Small VK2XLZ http://enc.com.au/ csmall at : enc.com.au Debian GNU/Linux http://www.debian.org/ csmall at : debian.org GPG fingerprint: 5D2F B320 B825 D939 04D2 0519 3938 F96B DF50 FEA5 -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20131107212342.gd19...@enc.com.au
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thursday 07 November 2013 22:23:42 Craig Small wrote: On Thu, Nov 07, 2013 at 05:20:08PM +0100, Pali Rohár wrote: Again, after month I have not got any responce. CCing everybody from this thread. What to do? I'd say you got an email problem. If I were the recpient of this email I wouldn't know what you were asking. I get lots of emails and look after many packages. I assume you want a reply from these people. A simple To recap, package X needs package Y to do Z, further details are at W will mean more chance of a reply. The email as currently sent is a bit context-free to me. - Craig Ok, here is info: Months ago I sent patch for package netplug to ML. Someody wrote that I should send it to bugtracker. So I posted it to [1]. I also sent that patch also to upstream project, but no response. Even no response from Debian package maintainer. Also bug page is without comments. Every month I send email to ML to this thread, asking for state. But still nobody wrote me if patch can be accepted or is definitely rejected. I would like to know state and what happening and if I need to provide something more... Or just Debian ignoring developers? From my point of view it looks like. [1] - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702495 -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thu, 07 Nov 2013 22:37:01 +0100, Pali Rohár wrote: Again, after month I have not got any responce. CCing everybody from this thread. What to do? I'd say you got an email problem. If I were the recpient of this email I wouldn't know what you were asking. Ok, here is info: Months ago I sent patch for package netplug to ML. Someody wrote that I should send it to bugtracker. So I posted it to [1]. Which you haven't CC'd now ... I also sent that patch also to upstream project, but no response. Even no response from Debian package maintainer. Also bug page is without comments. Every month I send email to ML to this thread, asking for state. I totally understand your frustration, and I'm sorry that Debian at large can be quite bad at dealing with requests like this. But mailing debian-devel, which is a high-level meta discussion list around Debian development in general, read by thousands of people (and not a community of a handful people working on this or a couple of packages) and cc'ing unrelated people won't help either ... Ideas: - always keep the bug in the loop - contact the MIA team, if you think the maintainers are inactive - prepare an NMU and ask for sponsorship on debian-mentors (As a personal note, I'm very appreciative about your great work in Maemo, and I'm very happy to see something from Maemo coming back to Debian, even if it's frustrating for your right now.) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones: Travelling signature.asc Description: Digital signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hello, On Thu, 7 Nov 2013 22:37:01 +0100 Pali Rohár pali.ro...@gmail.com wrote: Ok, here is info: Months ago I sent patch for package netplug to ML. Someody wrote that I should send it to bugtracker. So I posted it to [1]. I also sent that patch also to upstream project, but no response. Even no response from Debian package maintainer. Also bug page is without comments. Every month I send email to ML to this thread, asking for state. But still nobody wrote me if patch can be accepted or is definitely rejected. I would like to know state and what happening and if I need to provide something more... Or just Debian ignoring developers? From my point of view it looks like. That happens sometimes. I never got a response from Anthony J. Town regarding ifupdown, while I was certain he's on-line quite often (he did even post something here few times). At the end, I took it over completely. -- WBR, Andrew signature.asc Description: PGP signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Monday 16 September 2013 00:35:52 Paul Tagliamonte wrote: On Mon, Sep 16, 2013 at 12:15:20AM +0200, Pali Rohár wrote: Bump. Is there any problem? Hey there Pali, First of all, thank you for your hard work and persistence - I admire that a great deal! Keep that up! One interesting thing with Debian is that DDs can't go into another maintainer's package and change something (such as a new feature or upstream release) without the maintainer's consent. If you're able to get the maintainer of this package to sign off on the patch, and ack a NMU against it, I'm sure any number of us would be more than happy to sponsor the upload. However, doing this is frowned upon without the coordination of the current maintainer - so that's a pretty needed first step! Thank you so much for your work! Let's get your changes in the archive! Paul CCing Philipp Matthias Hahn, maintainer of netplug package. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Friday 26 July 2013 17:30:11 Pali Rohár wrote: On Sunday 21 April 2013 13:23:49 Paul Wise wrote: On Sun, Apr 21, 2013 at 6:11 PM, Pali Rohár wrote: But why Debian cannot review and include this my patch? Now is the time for fixing RC bugs, not for including patches, please wait until wheezy is released and then give the maintainer some time to review it and prepare a new package. Wheezy was already released. Can anybody look at my patch now? Bump. Is there any problem? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Mon, Sep 16, 2013 at 12:15:20AM +0200, Pali Rohár wrote: Bump. Is there any problem? Hey there Pali, First of all, thank you for your hard work and persistence - I admire that a great deal! Keep that up! One interesting thing with Debian is that DDs can't go into another maintainer's package and change something (such as a new feature or upstream release) without the maintainer's consent. If you're able to get the maintainer of this package to sign off on the patch, and ack a NMU against it, I'm sure any number of us would be more than happy to sponsor the upload. However, doing this is frowned upon without the coordination of the current maintainer - so that's a pretty needed first step! Thank you so much for your work! Let's get your changes in the archive! Paul -- .''`. Paul Tagliamonte paul...@debian.org : :' : Proud Debian Developer `. `'` 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87 `- http://people.debian.org/~paultag signature.asc Description: Digital signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Sunday 21 April 2013 13:23:49 Paul Wise wrote: On Sun, Apr 21, 2013 at 6:11 PM, Pali Rohár wrote: But why Debian cannot review and include this my patch? Now is the time for fixing RC bugs, not for including patches, please wait until wheezy is released and then give the maintainer some time to review it and prepare a new package. Wheezy was already released. Can anybody look at my patch now? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Tuesday 16 April 2013 01:07:37 Marcel Partap (unterwegs) wrote: What is needed to review my patch and include it? ...42 rainbow cupcakes, world peace + special star constellation. Heck it's true had it bfore - upstreaming a patch often takes lots of [f*ck knows what].. ^^ Well if it's worth it - just don't give up, don't get annoyed angry excited exhausted.. try again improve repeat and if all else fails - fork it :-D But why Debian cannot review and include this my patch? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Sun, Apr 21, 2013 at 6:11 PM, Pali Rohár wrote: But why Debian cannot review and include this my patch? Now is the time for fixing RC bugs, not for including patches, please wait until wheezy is released and then give the maintainer some time to review it and prepare a new package. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6hxjkn8nn2z4lefzz0tjvrjd7wcnzaeirdswuhm0hk...@mail.gmail.com
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Friday 05 April 2013 21:17:49 Pali Rohár wrote: On Wednesday 27 March 2013 12:41:03 Andrew Shadura wrote: Hello, On Wed, 27 Mar 2013 12:08:20 +0100 Pali Rohár pali.ro...@gmail.com wrote: So is my patch totally ignored? I sent it to upstream maintainer, next to debian mailinglist, attached to debian bug tracking system, sent to ubuntu mailinglist and also to launchpad ubuntu bug tracker. And nobody reviewed it until now... So where should be patches sent for review and for inclusion to system? I contacted upstream few days ago on IRC; it seems he's rather busy now. I think you need to wait for a while :) Hello again, what happened after week? Will be my patch included? Or is netplug totally dead? Bump. Anything new? What is needed to review my patch and include it? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
What is needed to review my patch and include it? ...42 rainbow cupcakes, world peace + special star constellation. Heck it's true had it bfore - upstreaming a patch often takes lots of [f*ck knows what].. ^^ Well if it's worth it - just don't give up, don't get annoyed angry excited exhausted.. try again improve repeat and if all else fails - fork it :-D
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Wednesday 27 March 2013 12:41:03 Andrew Shadura wrote: Hello, On Wed, 27 Mar 2013 12:08:20 +0100 Pali Rohár pali.ro...@gmail.com wrote: So is my patch totally ignored? I sent it to upstream maintainer, next to debian mailinglist, attached to debian bug tracking system, sent to ubuntu mailinglist and also to launchpad ubuntu bug tracker. And nobody reviewed it until now... So where should be patches sent for review and for inclusion to system? I contacted upstream few days ago on IRC; it seems he's rather busy now. I think you need to wait for a while :) Hello again, what happened after week? Will be my patch included? Or is netplug totally dead? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Saturday 23 March 2013 09:48:27 Raphael Hertzog wrote: On Sat, 23 Mar 2013, Philipp Matthias Hahn wrote: When I am in a similar situation, I tend to offer the person to join as co-maintainer. The patch is not very long and it should not be too hard to review. Or you can redirect him towards upstream if that's better. Upstream is dead: http://hg.serpentine.com/netplug 2010-06-26 So basically I would need to maintain that patch ad infinitum. And currently I don't have the time to become a new upstream, so my rather harsh reply. That's something that Pali deserved to know. He wrote a patch and he uses it, he could be the next upstream maintainer... who knows? I do the same mistake from time to time, but just because someone is on the other side of the bug report, doesn't mean that he should be considered only as a mere user. Cheers, So is my patch totally ignored? I sent it to upstream maintainer, next to debian mailinglist, attached to debian bug tracking system, sent to ubuntu mailinglist and also to launchpad ubuntu bug tracker. And nobody reviewed it until now... So where should be patches sent for review and for inclusion to system? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hello, On Wed, 27 Mar 2013 12:08:20 +0100 Pali Rohár pali.ro...@gmail.com wrote: So is my patch totally ignored? I sent it to upstream maintainer, next to debian mailinglist, attached to debian bug tracking system, sent to ubuntu mailinglist and also to launchpad ubuntu bug tracker. And nobody reviewed it until now... So where should be patches sent for review and for inclusion to system? I contacted upstream few days ago on IRC; it seems he's rather busy now. I think you need to wait for a while :) -- WBR, Andrew signature.asc Description: PGP signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hello Raphael, On Fri, Mar 22, 2013 at 07:55:56AM +0100, Raphael Hertzog wrote: There is: you can use experimental to continue working on the package until the wheezy release. Or you can accumulate stuff in the VCS. I know. So your patch will just stay in the BTS until I find some time to work the netplug again, which is very low on my current priority list. It's not a very rewarding answer to someone who invested time in your package... When I am in a similar situation, I tend to offer the person to join as co-maintainer. The patch is not very long and it should not be too hard to review. Or you can redirect him towards upstream if that's better. Upstream is dead: http://hg.serpentine.com/netplug 2010-06-26 So basically I would need to maintain that patch ad infinitum. And currently I don't have the time to become a new upstream, so my rather harsh reply. Sincerely Philipp -- Philipp Matthias Hahn pmh...@debian.org GPG/PGP: 9A540E39 @ keyrings.debian.org -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130323075820.ga29...@pmhahn.de
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Sat, 23 Mar 2013, Philipp Matthias Hahn wrote: When I am in a similar situation, I tend to offer the person to join as co-maintainer. The patch is not very long and it should not be too hard to review. Or you can redirect him towards upstream if that's better. Upstream is dead: http://hg.serpentine.com/netplug 2010-06-26 So basically I would need to maintain that patch ad infinitum. And currently I don't have the time to become a new upstream, so my rather harsh reply. That's something that Pali deserved to know. He wrote a patch and he uses it, he could be the next upstream maintainer... who knows? I do the same mistake from time to time, but just because someone is on the other side of the bug report, doesn't mean that he should be considered only as a mere user. Cheers, -- Raphaël Hertzog ◈ Debian Developer Get the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130323084827.gb17...@x230-buxy.home.ouaza.com
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hello,
Brian, could you please clarify the state of the upstream development?
(See below.)
On Sat, 23 Mar 2013 08:58:20 +0100
Philipp Matthias Hahn pmh...@pmhahn.de wrote:
On Fri, Mar 22, 2013 at 07:55:56AM +0100, Raphael Hertzog wrote:
There is: you can use experimental to continue working on the
package until the wheezy release. Or you can accumulate stuff in
the VCS.
I know.
So your patch will just stay in the BTS until I find some time to
work the netplug again, which is very low on my current priority
list.
It's not a very rewarding answer to someone who invested time in
your package...
When I am in a similar situation, I tend to offer the person to
join as co-maintainer. The patch is not very long and it should not
be too hard to review. Or you can redirect him towards upstream if
that's better.
Upstream is dead: http://hg.serpentine.com/netplug 2010-06-26
So basically I would need to maintain that patch ad infinitum.
And currently I don't have the time to become a new upstream, so my
rather harsh reply.
--
WBR, Andrew
diff -r aaebd52fac19 lib.c
--- a/lib.c Sat Jun 26 09:36:45 2010 -0700
+++ b/lib.c Sat Mar 02 02:38:19 2013 +0100
@@ -29,6 +29,7 @@
#include netplug.h
+const char *script_file = NP_SCRIPT_DIR /netplug;
void
do_log(int pri, const char *fmt, ...)
@@ -109,11 +110,11 @@
setpgrp(); /* become group leader */
do_log(LOG_INFO, %s %s %s - pid %d,
- NP_SCRIPT, ifname, action, getpid());
+ script_file, ifname, action, getpid());
-execl(NP_SCRIPT, NP_SCRIPT, ifname, action, NULL);
+execl(script_file, script_file, ifname, action, NULL);
-do_log(LOG_ERR, NP_SCRIPT : %m);
+do_log(LOG_ERR, %s: %m, script_file);
exit(1);
}
diff -r aaebd52fac19 main.c
--- a/main.c Sat Jun 26 09:36:45 2010 -0700
+++ b/main.c Sat Mar 02 02:38:19 2013 +0100
@@ -91,7 +91,7 @@
static void
usage(char *progname, int exitcode)
{
-fprintf(stderr, Usage: %s [-DFP] [-c config-file] [-i interface] [-p pid-file]\n,
+fprintf(stderr, Usage: %s [-DFP] [-c config-file] [-s script-file] [-i interface] [-p pid-file]\n,
progname);
fprintf(stderr, \t-D\t\t
@@ -102,6 +102,8 @@
do not autoprobe for interfaces (use with care)\n);
fprintf(stderr, \t-c config_file\t
read interface patterns from this config file\n);
+fprintf(stderr, \t-s script_file\t
+script file for probing interfaces, bringing them up or down\n);
fprintf(stderr, \t-i interface\t
only handle interfaces matching this pattern\n);
fprintf(stderr, \t-p pid_file\t
@@ -219,7 +221,7 @@
int probe = 1;
int c;
-while ((c = getopt(argc, argv, DFPc:hi:p:)) != EOF) {
+while ((c = getopt(argc, argv, DFPc:s:hi:p:)) != EOF) {
switch (c) {
case 'D':
debug = 1;
@@ -234,6 +236,9 @@
read_config(optarg);
cfg_read = 1;
break;
+case 's':
+script_file = optarg;
+break;
case 'h':
fprintf(stderr, netplugd version %s\n, NP_VERSION);
usage(argv[0], 0);
diff -r aaebd52fac19 man/man8/netplugd.8
--- a/man/man8/netplugd.8 Sat Jun 26 09:36:45 2010 -0700
+++ b/man/man8/netplugd.8 Sat Mar 02 02:38:19 2013 +0100
@@ -19,6 +19,7 @@
.Nm netplugd
.Op Fl FP
.Op Fl c Ar config_file
+.Op Fl s Ar script_file
.Op Fl i Ar interface_pattern
.Op Fl p Ar pid_file
.\
@@ -117,6 +118,9 @@
.Pa /dev/null
as a config file.
.\
+.It Fl s Ar script_file
+Specify an alternative script file path, override /etc/netplug.d/netplug
+.\
.It Fl i Ar interface_pattern
Specify a pattern that will be used to match interface names that
.Nm
diff -r aaebd52fac19 netplug.h
--- a/netplug.h Sat Jun 26 09:36:45 2010 -0700
+++ b/netplug.h Sat Mar 02 02:38:19 2013 +0100
@@ -26,8 +26,6 @@
#include linux/netlink.h
#include linux/rtnetlink.h
-#define NP_SCRIPT NP_SCRIPT_DIR /netplug
-
/* configuration */
void read_config(char *filename);
@@ -37,6 +35,8 @@
void probe_interfaces(void);
void close_on_exec(int fd);
+extern const char *script_file;
+
extern int debug;
/* netlink interfacing */
signature.asc
Description: PGP signature
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hi, On Thu, 21 Mar 2013, Philipp Matthias Hahn wrote: Debian is currently in the freeze period to get the next Debian release released. As your enhancement patch is not release critical for Debian, there is no chance to get a patched package included. There is: you can use experimental to continue working on the package until the wheezy release. Or you can accumulate stuff in the VCS. So your patch will just stay in the BTS until I find some time to work the netplug again, which is very low on my current priority list. It's not a very rewarding answer to someone who invested time in your package... When I am in a similar situation, I tend to offer the person to join as co-maintainer. The patch is not very long and it should not be too hard to review. Or you can redirect him towards upstream if that's better. Cheers, -- Raphaël Hertzog ◈ Debian Developer Get the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130322065556.ga25...@x230-buxy.home.ouaza.com
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thursday 07 March 2013 12:33:10 Pali Rohár wrote: On Thursday 07 March 2013 11:48:26 Paul Wise wrote: On Thu, Mar 7, 2013 at 5:18 PM, Pali Rohár wrote: I sent this email also to debian netplug maintainer, but he did not responce. So forwarding email to debian-devel mailinglist. Please file a bug so the patch does not get lost: http://www.debian.org/Bugs/Reporting Done, now patch is visible here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702495 Patch is there for two weeks but without response? Any problem? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
Hello, On Thu, Mar 21, 2013 at 06:06:57PM +0100, Pali Rohár wrote: On Thursday 07 March 2013 12:33:10 Pali Rohár wrote: ... Done, now patch is visible here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702495 Patch is there for two weeks but without response? Any problem? Debian is currently in the freeze period to get the next Debian release released. As your enhancement patch is not release critical for Debian, there is no chance to get a patched package included. So your patch will just stay in the BTS until I find some time to work the netplug again, which is very low on my current priority list. Sincerely Philipp -- Philipp Matthias Hahn pmh...@debian.org GPG/PGP: 9A540E39 @ keyrings.debian.org -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130321215046.ga11...@pmhahn.de
Fwd: [PATCH] netplug - Allow to specify custom script file via param '-s'
I sent this email also to debian netplug maintainer, but he did
not responce. So forwarding email to debian-devel mailinglist.
--
Pali Rohár
pali.ro...@gmail.com
---BeginMessage---
Hello,
I'm sending patch for netplug which allow to specify custom
script file via new param '-s'. It is usefull if you want to start
another instance of netplug, or want to start netplug with custom
script file (no with default which calling ifup/ifdown).
Patch is attached, generated by hg diff against repository on:
http://hg.serpentine.com/netplug
--
Pali Rohár
pali.ro...@gmail.com
diff -r aaebd52fac19 lib.c
--- a/lib.c Sat Jun 26 09:36:45 2010 -0700
+++ b/lib.c Sat Mar 02 02:38:19 2013 +0100
@@ -29,6 +29,7 @@
#include netplug.h
+const char *script_file = NP_SCRIPT_DIR /netplug;
void
do_log(int pri, const char *fmt, ...)
@@ -109,11 +110,11 @@
setpgrp(); /* become group leader */
do_log(LOG_INFO, %s %s %s - pid %d,
- NP_SCRIPT, ifname, action, getpid());
+ script_file, ifname, action, getpid());
-execl(NP_SCRIPT, NP_SCRIPT, ifname, action, NULL);
+execl(script_file, script_file, ifname, action, NULL);
-do_log(LOG_ERR, NP_SCRIPT : %m);
+do_log(LOG_ERR, %s: %m, script_file);
exit(1);
}
diff -r aaebd52fac19 main.c
--- a/main.c Sat Jun 26 09:36:45 2010 -0700
+++ b/main.c Sat Mar 02 02:38:19 2013 +0100
@@ -91,7 +91,7 @@
static void
usage(char *progname, int exitcode)
{
-fprintf(stderr, Usage: %s [-DFP] [-c config-file] [-i interface] [-p pid-file]\n,
+fprintf(stderr, Usage: %s [-DFP] [-c config-file] [-s script-file] [-i interface] [-p pid-file]\n,
progname);
fprintf(stderr, \t-D\t\t
@@ -102,6 +102,8 @@
do not autoprobe for interfaces (use with care)\n);
fprintf(stderr, \t-c config_file\t
read interface patterns from this config file\n);
+fprintf(stderr, \t-s script_file\t
+script file for probing interfaces, bringing them up or down\n);
fprintf(stderr, \t-i interface\t
only handle interfaces matching this pattern\n);
fprintf(stderr, \t-p pid_file\t
@@ -219,7 +221,7 @@
int probe = 1;
int c;
-while ((c = getopt(argc, argv, DFPc:hi:p:)) != EOF) {
+while ((c = getopt(argc, argv, DFPc:s:hi:p:)) != EOF) {
switch (c) {
case 'D':
debug = 1;
@@ -234,6 +236,9 @@
read_config(optarg);
cfg_read = 1;
break;
+case 's':
+script_file = optarg;
+break;
case 'h':
fprintf(stderr, netplugd version %s\n, NP_VERSION);
usage(argv[0], 0);
diff -r aaebd52fac19 man/man8/netplugd.8
--- a/man/man8/netplugd.8 Sat Jun 26 09:36:45 2010 -0700
+++ b/man/man8/netplugd.8 Sat Mar 02 02:38:19 2013 +0100
@@ -19,6 +19,7 @@
.Nm netplugd
.Op Fl FP
.Op Fl c Ar config_file
+.Op Fl s Ar script_file
.Op Fl i Ar interface_pattern
.Op Fl p Ar pid_file
.\
@@ -117,6 +118,9 @@
.Pa /dev/null
as a config file.
.\
+.It Fl s Ar script_file
+Specify an alternative script file path, override /etc/netplug.d/netplug
+.\
.It Fl i Ar interface_pattern
Specify a pattern that will be used to match interface names that
.Nm
diff -r aaebd52fac19 netplug.h
--- a/netplug.h Sat Jun 26 09:36:45 2010 -0700
+++ b/netplug.h Sat Mar 02 02:38:19 2013 +0100
@@ -26,8 +26,6 @@
#include linux/netlink.h
#include linux/rtnetlink.h
-#define NP_SCRIPT NP_SCRIPT_DIR /netplug
-
/* configuration */
void read_config(char *filename);
@@ -37,6 +35,8 @@
void probe_interfaces(void);
void close_on_exec(int fd);
+extern const char *script_file;
+
extern int debug;
/* netlink interfacing */
signature.asc
Description: This is a digitally signed message part.
---End Message---
signature.asc
Description: This is a digitally signed message part.
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thu, Mar 7, 2013 at 5:18 PM, Pali Rohár pali.ro...@gmail.com wrote: I sent this email also to debian netplug maintainer, but he did not responce. So forwarding email to debian-devel mailinglist. -- Pali Rohár pali.ro...@gmail.com -- Forwarded message -- From: Pali Rohár pali.ro...@gmail.com To: Bryan O'Sullivan b...@serpentine.com Cc: Philipp Matthias Hahn pmh...@debian.org Date: Sat, 2 Mar 2013 02:44:03 +0100 Subject: [PATCH] netplug - Allow to specify custom script file via param '-s' Hello, I'm sending patch for netplug which allow to specify custom script file via new param '-s'. It is usefull if you want to start another instance of netplug, or want to start netplug with custom script file (no with default which calling ifup/ifdown). Patch is attached, generated by hg diff against repository on: http://hg.serpentine.com/netplug -- Pali Rohár pali.ro...@gmail.com -- bye, pabs http://wiki.debian.org/PaulWise http://bonedaddy.net/pabs3/ -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6G4k--SwRa4Zk9x=6x1yJyCbwa1ZsbbaTHraPcsp64=j...@mail.gmail.com
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thu, Mar 7, 2013 at 5:18 PM, Pali Rohár wrote: I sent this email also to debian netplug maintainer, but he did not responce. So forwarding email to debian-devel mailinglist. Please file a bug so the patch does not get lost: http://www.debian.org/Bugs/Reporting -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6fd8zb9trfllqyf88-qsztoks2kgpw6_gtubfffeg5...@mail.gmail.com
Re: [PATCH] netplug - Allow to specify custom script file via param '-s'
On Thursday 07 March 2013 11:48:26 Paul Wise wrote: On Thu, Mar 7, 2013 at 5:18 PM, Pali Rohár wrote: I sent this email also to debian netplug maintainer, but he did not responce. So forwarding email to debian-devel mailinglist. Please file a bug so the patch does not get lost: http://www.debian.org/Bugs/Reporting Done, now patch is visible here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702495 -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
