Re: Bug#339658: should not call update-modules for module-init-tools
On Dec 05, Joey Hess [EMAIL PROTECTED] wrote: Anyway, if you add a depmod call to update-modules then debhelper could just run it and not worry about needing to run depmod. If OTOH you do want to eventually remove update-modules from module-init-tools then we will have to live with debhelper running depmod, possibly redundantly. Considering that nobody had better ideas, I'd rather remove the update-modules debianism in the future. Running depmod two times will not be a problem if you use -A, which checks the files timestamps before reading them. -- ciao, Marco signature.asc Description: Digital signature
Re: Bug#339658: should not call update-modules for module-init-tools
On Dec 05, Joey Hess [EMAIL PROTECTED] wrote: dh_installmodules generates code to run update-modules in the postinst and postrm, which are run when modules are installed or removed. Amoung other things, the depmod call in update-modules.modutils makes the newly installed modules in the postinst available for immediate use (if the kernel matches). Right, I did not remember that update-modules also runs depmod. This is interesting, because if modutils is not installed then depmod will not be run by the update-modules script of module-init-tools. Nobody ever reported this, so I wonder if the packages which install 2.6 modules already run depmod or what else. My goal was to prepare the update-modules phase-out, but now I am not so sure. What should I do, encourage the maintainers of modules for 2.6 kernels to just use depmod or make update-modules run it and keep the script forever? Comments are encouraged, I favour the first option. -- ciao, Marco signature.asc Description: Digital signature
Re: Bug#339658: should not call update-modules for module-init-tools
Marco d'Itri wrote: Right, I did not remember that update-modules also runs depmod. This is interesting, because if modutils is not installed then depmod will not be run by the update-modules script of module-init-tools. Nobody ever reported this, so I wonder if the packages which install 2.6 modules already run depmod or what else. Hmm, good point. It might be best for dh_installmodules to always depmod by hand, to make sure it gets run. Of course this will unfortuantly result in it being run twice if modutils is installed. My goal was to prepare the update-modules phase-out, but now I am not so sure. What should I do, encourage the maintainers of modules for 2.6 kernels to just use depmod or make update-modules run it and keep the script forever? Comments are encouraged, I favour the first option. debhelper takes care to only run update-modules if it is available, so it should not be a problem if it keeps adding the code to do that to postinsts even once update-modules is completly removed from debian. Of course once that happens it will be cruft and I will remove the call. Anyway, if you add a depmod call to update-modules then debhelper could just run it and not worry about needing to run depmod. If OTOH you do want to eventually remove update-modules from module-init-tools then we will have to live with debhelper running depmod, possibly redundantly. -- see shy jo signature.asc Description: Digital signature
