Re: Bug#850255: ITP: node-is-retry-allowed -- My prime module

2017-01-05 Thread Martin Bagge / brother 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2017-01-05 14:41, Stéphane Blondon wrote:
> 
> I think it would be nice to send a pull-request to fix it
> upstream.

I did.

https://github.com/floatdrop/is-retry-allowed/pull/1

- -- 
brother
http://sis.bthstudent.se
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEVlIsX3Eri6ICyZwJOIRDexPY/4sFAlhuXMkACgkQOIRDexPY
/4viaBAAkIoIbpWKvRBudhsvIAMxs8rsRr9G/EmtZnshevkaTews2toSmlREHlU0
g4f/BnIkJXotzcG4sQKid0RxctvSZ8gLwglArruVjWPGmxPCqXRX0HKs8rqleL4r
tj5gPy8pH3UosdOTq2X870WIBKewgOAktRewRjW9xYTHRhXt0Uj83vNq2BdQvwbG
8ygJzbU+w5anFBTdQFYIgInR2zM9u97chcx3rpP0EbIS/DqPLrpfOR5BSejURTbW
3j0OIVGY9hjocK8208xZQz1BohccUZ2aMCAy2NaS2zrDZ3CFvFQRh0WyKY123yTC
oox462CJ3KHvKa1tAiKh0WxBQ9r7Hs+S6PtHOS41SO54G/Yiif1xLgyOtlvqH1pI
0zUlPE0WExvenWunTZQOf9ThpOqPmdeOAekBbEVf8tHQgUJFYY6WgyumUbiMN868
fDQ76hgptdbX61ll9yo3mfUQDekMfdw5su5P7+9XsQhw6C/FFKvtSuNJR2HxuIee
2lTAIdlLDspe6GX9oxsPP0uhqY5XAVt0Wj/Kw76qLtmpqXGmccqYFTAz0Y2xXs8U
zVKuY7zZIIRZS23qil8PUZ5vuXXvANGB01VUQCWGA3my4kjsYXTJK/1NZE9SHF34
AkGQeBFoXPdH4P775d5+T66Zqo5T/NHk12EKh/45SIgJkpkY6M8=
=/N4y
-END PGP SIGNATURE-

Re: Bug#850255: ITP: node-is-retry-allowed -- My prime module

2017-01-05 Thread Stéphane Blondon 
2017-01-05 13:21 GMT+01:00 Christian Seiler :

> On 01/05/2017 01:18 PM, Martin Bagge / brother wrote:
> > "description": "My prime module",
>
> Yikes. My apologies, then at least now I get where that comes
> from.
>
> Still, the description on the github link appears to be the
> one that's preferable to "my prime module". So thanks for
> intending to fix this.
>
>
I think it would be nice to send a pull-request to fix it upstream.


-- 
Stéphane

Re: Bug#850255: ITP: node-is-retry-allowed -- My prime module

2017-01-05 Thread Christian Seiler 
On 01/05/2017 01:18 PM, Martin Bagge / brother wrote:
> On 2017-01-05 13:04, Christian Seiler wrote:
>> The official package description appears to be:
> 
>> "Is retry allowed for Error?"
> 
>> And while that is still a bit vague, it does at least give an 
>> indication what the module does, while I have no idea what "my
>> prime module" is supposed to mean?
> 
>> I would urge you to use upstream's description when packaging this
>> module.
> 
> Well. They did.
> 
> https://github.com/floatdrop/is-retry-allowed/blob/8ca0d01b/package.json
> #L4
> reads
> 
> "description": "My prime module",

Yikes. My apologies, then at least now I get where that comes
from.

Still, the description on the github link appears to be the
one that's preferable to "my prime module". So thanks for
intending to fix this.

Regards,
Christian

Re: Bug#850255: ITP: node-is-retry-allowed -- My prime module

2017-01-05 Thread Martin Bagge / brother 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 2017-01-05 13:04, Christian Seiler wrote:
> The official package description appears to be:
> 
> "Is retry allowed for Error?"
> 
> And while that is still a bit vague, it does at least give an 
> indication what the module does, while I have no idea what "my
> prime module" is supposed to mean?
> 
> I would urge you to use upstream's description when packaging this
> module.

Well. They did.

https://github.com/floatdrop/is-retry-allowed/blob/8ca0d01b/package.json
#L4
reads

"description": "My prime module",

- -- 
brother
http://sis.bthstudent.se
-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEVlIsX3Eri6ICyZwJOIRDexPY/4sFAlhuOZkACgkQOIRDexPY
/4uYvQ/7BiyOh0+4ubzf6VRuoUnQjhMX9NlnhjuTTGmS4BnYK6rKALuZ5FXtEmnd
Ht6Hh7a3FQh6c9G7a4PvEyJBdnJdPlc/2vk7szYKJC73ke+O1JFAsXBomF1IUeC9
LEcWV8oLYFcLO30qGfSfI08TsTx8yzlaG7gr9/5QV5jDTzDyNV7FEN1JZtrmvDS7
etLipBLxxoNFEyBlar8xO/fq+qzhrTWnlJ/YWilpLOZI9t/vsBxHGOicRwHuNbM9
6NCbMzIPrTE/rRus1GhjUGuPAgCYblV/BwXAqCxuBd4lesUsPQMB2+tQK0fJ6P2g
5Rk2HxN+FtUaWZD9G3g577cYkl1KDYZ0RJW4sSMX6A2zoWYWV2Ne6q/VH1/M/Qju
qD4yfdI4wfhg/Q87MZZtghZJNNfqHoC71BLjBP5uD/oduHsOclewyTu8er0oXp1k
odwKSuYUCnpPplNiUcjtZaNnrto8vor8Em3BOovEA8Cl4WGWjkv7Wg5iPsYa7uoB
NZYSSON6GGjVwIh6NmDE78urBfpHX5gg8aWKyPVYOJKofpCb6a1t6xomsv0h9Y/m
EkGN+labdO8tF+efa0Wh6WcgL7ZP8ITiHuUeQ4z6gdWy+qLFqoRBz8LsCxG+OtoP
E3BkxPfbIyYN+hjBnsa/PidT8vbc+oTQcSTluTEkBshyr2Mvh6Y=
=V2QQ
-END PGP SIGNATURE-

Re: Bug#850255: ITP: node-is-retry-allowed -- My prime module

2017-01-05 Thread Christian Seiler 
Hi there,

Let me nitpick a bit: ;-)

On 01/05/2017 12:52 PM, saurabhagra...@disroot.org wrote:
> * URL : https://github.com/floatdrop/is-retry-allowed#readme
>   Description : My prime module

The official package description appears to be:

"Is retry allowed for Error?"

And while that is still a bit vague, it does at least give an
indication what the module does, while I have no idea what
"my prime module" is supposed to mean?

I would urge you to use upstream's description when packaging
this module.

Regards,
Christian