Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Simon McVittie]

On Tue, 23 Jul 2019 at 18:22:58 +0200, Johannes Schauer wrote:
> Quoting Sean Whitton (2019-07-23 17:47:45)
> > ICBW but I am pretty sure that sbuild builds the source package *outside* of
> > the clean chroot.
> 
> that is correct. Indeed the source package is the way how the sources are
> copied into the chroot so sbuild cannot operate at all without having a source
> package first. And that source package is built *outside* the chroot.

Technically sbuild can also build source packages (with sbuild --source,
and optionally --no-arch-any --no-arch-all) - I use that in
, to make sure I get a pedantically
"clean" source package that is identical to what building in the target
distribution would have done. However, yes, that requires building
a temporary source package outside sbuild, and transferring that into the
build chroot in order to have sbuild rebuild it.

smcv

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Scott Kitterman]

Shengjing Zhu writes ("Re: Sorce only uploads with sbuild (was: Bits
>from the Release Team)"):
>> On Tue, Jul 23, 2019 at 11:18 PM Sean Whitton
> wrote:
>> > Just `git clean -xdff && dpkg-buildpackage -S` and dput the result,
>or
>> > (easier) `dgit push-source`.
>> 
>> Maybe I miss something, sbuild just calls `dpkg-buildpackage -S`. If
>> sbuild doesn't include orig tarball in -2 source.changes, then
>> `dpkg-buildpackage -S` doesn't either.
>> 
>> Is there any option of dpkg-buildpackage to include orig tarball in
>-2 changes?

There is. Use -sa as in -S -sa.

Scott K

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Ian Jackson]

Shengjing Zhu writes ("Re: Sorce only uploads with sbuild (was: Bits from the 
Release Team)"):
> On Tue, Jul 23, 2019 at 11:18 PM Sean Whitton  
> wrote:
> > Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> > (easier) `dgit push-source`.
> 
> Maybe I miss something, sbuild just calls `dpkg-buildpackage -S`. If
> sbuild doesn't include orig tarball in -2 source.changes, then
> `dpkg-buildpackage -S` doesn't either.
> 
> Is there any option of dpkg-buildpackage to include orig tarball in -2 
> changes?

Dunno, I'm afraid.  I quickly skimmed the FM and didn't see it.  But,
I want to point out (inexplicably Sean didn't mention this):

If you use `dgit push-source' to do your upload you do not need to
worry about this.  dgit knows how to ask the archive what .orig
tarballs are already there, and includes the .orig if it is going to
be needed, and not otherwise.  Ie dgit doesn't guess based on the
version number.  (It will also spot if the .orig you have is not the
same as the one in the archive.)

Ian.

-- 
Ian JacksonThese opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Mathias Behrle]

* W. Martin Borgert: " Re: Sorce only uploads with sbuild (was: Bits from the
  Release Team)" (Tue, 23 Jul 2019 17:30:22 +0200):

> Quoting Sean Whitton :
> > Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> > (easier) `dgit push-source`.  
> 
> I prefer to build only once, if possible, generating both binary and
> source .changes. Both in a clean chroot. Then I can try out my .debs
> and on success just sign and dput. 

That's exactly my use case, too.
Also I am building in parallel backports uploaded to a different mirror
(reprepro), where the (cleanly built) binaries are needed.


-- 

Mathias Behrle
PGP/GnuPG key availabable from any keyserver, ID: 0xD6D09BE48405BBF6
AC29 7E5C 46B9 D0B6 1C71  7681 D6D0 9BE4 8405 BBF6

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Shengjing Zhu]

On Wed, Jul 24, 2019 at 12:46 AM Shengjing Zhu  wrote:
>
> On Tue, Jul 23, 2019 at 11:18 PM Sean Whitton  
> wrote:
> > Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> > (easier) `dgit push-source`.
> >
>
> Maybe I miss something, sbuild just calls `dpkg-buildpackage -S`. If
> sbuild doesn't include orig tarball in -2 source.changes, then
> `dpkg-buildpackage -S` doesn't either.
>
> Is there any option of dpkg-buildpackage to include orig tarball in -2 
> changes?
>

Find it myself, it's in dpkg-genchanges(1) and -s{i,a,d} options.

-- 
Shengjing Zhu

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Shengjing Zhu]

On Tue, Jul 23, 2019 at 11:18 PM Sean Whitton  wrote:
> Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> (easier) `dgit push-source`.
>

Maybe I miss something, sbuild just calls `dpkg-buildpackage -S`. If
sbuild doesn't include orig tarball in -2 source.changes, then
`dpkg-buildpackage -S` doesn't either.

Is there any option of dpkg-buildpackage to include orig tarball in -2 changes?

-- 
Shengjing Zhu

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Julian Andres Klode]

On Tue, Jul 23, 2019 at 08:18:05AM -0700, Sean Whitton wrote:
> Hello,
> 
> On Tue 23 Jul 2019 at 03:53pm +02, Mathias Behrle wrote:
> 
> > Thanks a lot, could have found myself...:(
> > TBH I didn't assume that such a bug could exist when we make source-only
> > uploads manadatory.
> 
> I find it helpful to think of sbuild as a tool for producing binaries,
> and nothing else.
> 
> If I'm doing a source-only upload then binaries are not relevant, so
> there's no need to involve a tool as complex as sbuild.
> 
> Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> (easier) `dgit push-source`.

But we have to build inside a (clean) chroot for like stable
updates. Especially if you have native packages that generate
autotools foo, you want to generate that in stable, not in
unstable.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer  i speak de, en

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Sean Whitton]

Hello,

On Tue 23 Jul 2019 at 06:22PM +02, Johannes Schauer wrote:

> that is correct. Indeed the source package is the way how the sources are
> copied into the chroot so sbuild cannot operate at all without having a source
> package first. And that source package is built *outside* the chroot.
>
> That sbuild is able to build source packages itself is either a convenience
> feature or a misfeature (I'm leaning to toward the latter) because the source
> package is the *input* to sbuild, not the output.

Thanks for confirming.

I guess a possibly-helpful way to put this point would be that sbuild is
not intended to be a replacement for all of dpkg-buildpackage.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Johannes Schauer]

Hi,

Quoting Sean Whitton (2019-07-23 17:47:45)
> > I prefer to build only once, if possible, generating both binary and source
> > .changes. Both in a clean chroot. Then I can try out my .debs and on
> > success just sign and dput. Works fine for me with pbuilder.
> ICBW but I am pretty sure that sbuild builds the source package *outside* of
> the clean chroot.

that is correct. Indeed the source package is the way how the sources are
copied into the chroot so sbuild cannot operate at all without having a source
package first. And that source package is built *outside* the chroot.

That sbuild is able to build source packages itself is either a convenience
feature or a misfeature (I'm leaning to toward the latter) because the source
package is the *input* to sbuild, not the output.

Thanks!

cheers, josch


signature.asc
Description: signature

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Sean Whitton]

Hello,

On Tue 23 Jul 2019 at 11:23AM -04, Boyuan Yang wrote:

> To be honest, I *hate* building without clean chroot environment, no matter
> it's a source-only upload, a -2 upload or anything else. Think of this: when
> invoking sbuild, some command line options like "--source-only-changes --
> force-orig-source" have already been added but the output still does not
> contain a source tarball... why? It's certainly a bug from user's perspective.

On Tue 23 Jul 2019 at 05:30PM +02, W. Martin Borgert wrote:

> I prefer to build only once, if possible, generating both binary and
> source .changes. Both in a clean chroot. Then I can try out my .debs
> and on success just sign and dput. Works fine for me with pbuilder.

ICBW but I am pretty sure that sbuild builds the source package
*outside* of the clean chroot.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[W. Martin Borgert]

Quoting Sean Whitton :

Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
(easier) `dgit push-source`.


I prefer to build only once, if possible, generating both binary and
source .changes. Both in a clean chroot. Then I can try out my .debs
and on success just sign and dput. Works fine for me with pbuilder.

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Boyuan Yang]

在 2019-07-23二的 08:18 -0700，Sean Whitton写道：
> Hello,
> 
> On Tue 23 Jul 2019 at 03:53pm +02, Mathias Behrle wrote:
> 
> > Thanks a lot, could have found myself...:(
> > TBH I didn't assume that such a bug could exist when we make source-only
> > uploads manadatory.
> 
> I find it helpful to think of sbuild as a tool for producing binaries,
> and nothing else.
> 
> If I'm doing a source-only upload then binaries are not relevant, so
> there's no need to involve a tool as complex as sbuild.
> 
> Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
> (easier) `dgit push-source`.

To be honest, I *hate* building without clean chroot environment, no matter
it's a source-only upload, a -2 upload or anything else. Think of this: when
invoking sbuild, some command line options like "--source-only-changes --
force-orig-source" have already been added but the output still does not
contain a source tarball... why? It's certainly a bug from user's perspective.

Thanks,
Boyuan Yang


signature.asc
Description: This is a digitally signed message part

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Sean Whitton]

Hello,

On Tue 23 Jul 2019 at 03:53pm +02, Mathias Behrle wrote:

> Thanks a lot, could have found myself...:(
> TBH I didn't assume that such a bug could exist when we make source-only
> uploads manadatory.

I find it helpful to think of sbuild as a tool for producing binaries,
and nothing else.

If I'm doing a source-only upload then binaries are not relevant, so
there's no need to involve a tool as complex as sbuild.

Just `git clean -xdff && dpkg-buildpackage -S` and dput the result, or
(easier) `dgit push-source`.

-- 
Sean Whitton

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Mathias Behrle]

* Andrey Rahmatullin: " Re: Sorce only uploads with sbuild (was: Bits from the
  Release Team)" (Tue, 23 Jul 2019 15:46:08 +0500):

> On Tue, Jul 23, 2019 at 12:22:02PM +0200, Mathias Behrle wrote:
> > I tried that building as usual with sbuild with additional option
> > --source-only-changes and uploaded, but now get REJECTS with e.g.
> > 
> > tryton-server_5.0.6-2.dsc: Refers to non-existing file
> > 'tryton-server_5.0.6.orig.tar.gz'
> > Perhaps you need to include the file in your upload?
> > 
> > That's basically true, because this is a build on a version, that due to the
> > freeze wasn't uploaded yet to unstable. The version 5.0.6 got amendments,
> > thus propagating to version 5.0.6-2.  
> If it wasn't uploaded just reuse the version.

It was uploaded to a different mirror, so no option.

> > So I tried with
> > $ sbuild -A -s -d unstable --force-orig-source --source-only-changes
> > 
> > with the result, that the orig.tar.gz is included in the *amd64.changes
> > file, but it is still missing from the *source.changes file.
> > 
> > What am I missing? Did I hit a bug in sbuild?  
> Yes, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884428

Thanks a lot, could have found myself...:( 
TBH I didn't assume that such a bug could exist when we make source-only
uploads manadatory. 



-- 

Mathias Behrle
PGP/GnuPG key availabable from any keyserver, ID: 0xD6D09BE48405BBF6
AC29 7E5C 46B9 D0B6 1C71  7681 D6D0 9BE4 8405 BBF6

Re: Sorce only uploads with sbuild (was: Bits from the Release Team)

[Andrey Rahmatullin]

On Tue, Jul 23, 2019 at 12:22:02PM +0200, Mathias Behrle wrote:
> I tried that building as usual with sbuild with additional option
> --source-only-changes and uploaded, but now get REJECTS with e.g.
> 
> tryton-server_5.0.6-2.dsc: Refers to non-existing file
> 'tryton-server_5.0.6.orig.tar.gz'
> Perhaps you need to include the file in your upload?
> 
> That's basically true, because this is a build on a version, that due to the
> freeze wasn't uploaded yet to unstable. The version 5.0.6 got amendments, thus
> propagating to version 5.0.6-2.
If it wasn't uploaded just reuse the version.

> So I tried with
> $ sbuild -A -s -d unstable --force-orig-source --source-only-changes
> 
> with the result, that the orig.tar.gz is included in the *amd64.changes file,
> but it is still missing from the *source.changes file.
> 
> What am I missing? Did I hit a bug in sbuild?
Yes, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884428

-- 
WBR, wRAR


signature.asc
Description: PGP signature