Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi, On Thu, 01 Aug 2019, Domenico Andreoli wrote: > >Questions to be answered: > >- Is the setting only a default applied to new projects? > >- If yes, how do you inform users that a new project with > > /.gitlab-ci.yml will not work? > >- If no, how do you inform users that an existing project with > > /.gitlab-ci.yml will stop working? > > I don't like any of these questions, I would prefer not having to answer to > them. The first question seems a legitimate question in order to evaluate the impact. I guess however that the setting is a default applied to all (existing) projects that have not overridden the setting. IOW, changing the value will break legitimate users of .gitlab-ci.yml. I am such a user for the "distro-tracker" and "debian-handbook" repositories. And I will have to reconfigure my projects, but I also agree with the request expressed here. It is much more painful to have to reconfigure this for all the other packaging repositories that we regularly create... To the second question I would say that it's enough to document it in the wiki where all other salsa-specific documentation is. To the third question, I would say that an email to debian-devel-announce ought be enough. > Having a salsa global default different from the gitlab one is just > surprising indeed, would "patch in" a solution for a quite specific case > (plain debian package with default salsa-ci.yml) and would still leave > diverging settings dead in the water at first clone. > > I did not follow most closely this thread, is setting cloning being explored > already? Filed upstream already: https://gitlab.com/gitlab-org/gitlab-ce/issues/48180 https://gitlab.com/gitlab-org/gitlab-ce/issues/64805 Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
> "Bastian" == Bastian Blank writes: >> Anyway, I think the best alternative for making this change less >> disruptive is going to be group-level definitions[0] of this kind >> of configurations. Bastian> Maybe it would be better to fix stuff to work with Bastian> /.gitlab-ci.yml than trying to hack around global settings? Bastian> Salsa is not Debian-only, we already have several upstream Bastian> stuff on it. Simon has explained why this (.gitlab-ci.yml in a debian packaging repository) is challenging. If you think that making things work with .gitlab-ci.yml for Debian packaging repositories is the right answer, how would you respond to the issues Simon has raised? --Sam
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On August 1, 2019 7:10:14 PM UTC, Bastian Blank wrote: >On Thu, Aug 01, 2019 at 08:21:31PM +0200, Inaki Malerba wrote: >> On 27/7/19 09:40, Bastian Blank wrote: >> > The setting is per project, so it is available. For now I say that >> > changing this globally is too disruptive. >> Of course it's a disruptive change, but what is the purpose of Salsa? > >It is a project management platform. > >> I think it's a tool *for* Debian and Debian Developers. Most of the >> users surely will prefer that the default path for the CI >configuration >> on Debian projects is a Debian compatible path. Maybe we could open a >> thread to discuss this on d-devel, if some day we have the feature to >> make this change, but it's is not even planned yet. > >Maybe someone can come up with code to see how it works. > >Questions to be answered: >- Is the setting only a default applied to new projects? >- If yes, how do you inform users that a new project with > /.gitlab-ci.yml will not work? >- If no, how do you inform users that an existing project with > /.gitlab-ci.yml will stop working? I don't like any of these questions, I would prefer not having to answer to them. My instinct for the most predictable and least surprising solution is to leave /.gitlab-ci.yml as default, per-project configurable and _clonable_ so that clones would simply inherit the original setting whatever it is. > >> Anyway, I think the best alternative for making this change less >> disruptive is going to be group-level definitions[0] of this kind of >> configurations. > >Maybe it would be better to fix stuff to work with /.gitlab-ci.yml than >trying to hack around global settings? Salsa is not Debian-only, we >already have several upstream stuff on it. > Having a salsa global default different from the gitlab one is just surprising indeed, would "patch in" a solution for a quite specific case (plain debian package with default salsa-ci.yml) and would still leave diverging settings dead in the water at first clone. I did not follow most closely this thread, is setting cloning being explored already? >Regards, >Bastian Regards, Domenico
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On Thu, Aug 01, 2019 at 08:21:31PM +0200, Inaki Malerba wrote: > On 27/7/19 09:40, Bastian Blank wrote: > > The setting is per project, so it is available. For now I say that > > changing this globally is too disruptive. > Of course it's a disruptive change, but what is the purpose of Salsa? It is a project management platform. > I think it's a tool *for* Debian and Debian Developers. Most of the > users surely will prefer that the default path for the CI configuration > on Debian projects is a Debian compatible path. Maybe we could open a > thread to discuss this on d-devel, if some day we have the feature to > make this change, but it's is not even planned yet. Maybe someone can come up with code to see how it works. Questions to be answered: - Is the setting only a default applied to new projects? - If yes, how do you inform users that a new project with /.gitlab-ci.yml will not work? - If no, how do you inform users that an existing project with /.gitlab-ci.yml will stop working? > Anyway, I think the best alternative for making this change less > disruptive is going to be group-level definitions[0] of this kind of > configurations. Maybe it would be better to fix stuff to work with /.gitlab-ci.yml than trying to hack around global settings? Salsa is not Debian-only, we already have several upstream stuff on it. Regards, Bastian -- Change is the essential process of all existence. -- Spock, "Let That Be Your Last Battlefield", stardate 5730.2
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On 27/7/19 09:40, Bastian Blank wrote: > On Fri, Jul 26, 2019 at 06:01:07PM +0100, Simon McVittie wrote: >> This was requested in the past in >> https://salsa.debian.org/salsa/support/issues/26, and some people >> (including me) interpreted the reply as "no, but only because upstream >> doesn't have that feature". Was that interpretation wrong? > >> The default of ./.gitlab.yml is problematic for Salsa *because* it's >> the upstream default, and git repositories on Salsa are most commonly >> used for Debian packaging where we try to minimize delta vs upstream >> source code: > > The setting is per project, so it is available. For now I say that > changing this globally is too disruptive. Of course it's a disruptive change, but what is the purpose of Salsa? I think it's a tool *for* Debian and Debian Developers. Most of the users surely will prefer that the default path for the CI configuration on Debian projects is a Debian compatible path. Maybe we could open a thread to discuss this on d-devel, if some day we have the feature to make this change, but it's is not even planned yet. Anyway, I think the best alternative for making this change less disruptive is going to be group-level definitions[0] of this kind of configurations. Please, everyone interested on discussing this feature please comment the issue on the Gitlab issue tracker. 0_ https://gitlab.com/gitlab-org/gitlab-ce/issues/41764#note_54911766 -- - ina
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On Thu, Aug 01, 2019 at 10:10:24AM +0200, Michael Kesper wrote:
> Hi all,
>
> On 27.07.19 20:11, Ian Jackson wrote:
> > Bastian Blank writes ("Re: Salsa.d.o: Please support the implementation
> > request for a global config option to change the default for "Custom CI
> > config path" in Gitlab"):
> >> The setting is per project, so it is available. For now I say that
> >> changing this globally is too disruptive.
>
> Could you please elaborate why you think so?
>
> >> But as I wanted to try this something: Please describe why we _should not_
> >> set such an option globally. This is just helping to see if you
> >> understand both sides.
> >
> > The main downside I can think of making this change is that existing
> > salsa gitlab ci users will have to either rename their file
> > (preferred) or change their repo config.
>
> I think as it's only a default, it should not influence already set values?
The problem will be in the projects that already rely on the default
configuration.
>
> My 2 cents
> Michael
>
But making a transition were the default is set for all projects that
has not specific configuration may be possible and not disruptive.
Just an idea:
```
import gitlab
cli = gitlab.Gitlab('https://salsa.debian.org', private_token=private_token)
cli.auth()
for project in cli.projects.list():
if project.ci_config_path is None:
project.ci_config_path = '.gitlab-ci.yml'
project.save()
```
Joa
signature.asc
Description: PGP signature
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi all,
On 27.07.19 20:11, Ian Jackson wrote:
> Bastian Blank writes ("Re: Salsa.d.o: Please support the implementation
> request for a global config option to change the default for "Custom CI
> config path" in Gitlab"):
>> The setting is per project, so it is available. For now I say that
>> changing this globally is too disruptive.
Could you please elaborate why you think so?
>> But as I wanted to try this something: Please describe why we _should not_
>> set such an option globally. This is just helping to see if you
>> understand both sides.
>
> The main downside I can think of making this change is that existing
> salsa gitlab ci users will have to either rename their file
> (preferred) or change their repo config.
I think as it's only a default, it should not influence already set values?
My 2 cents
Michael
signature.asc
Description: OpenPGP digital signature
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Bastian Blank writes ("Re: Salsa.d.o: Please support the implementation request
for a global config option to change the default for "Custom CI config path" in
Gitlab"):
> The setting is per project, so it is available. For now I say that
> changing this globally is too disruptive.
...
> But as I wanted to try this something: Please describe why we _should not_
> set such an option globally. This is just helping to see if you
> understand both sides.
The main downside I can think of making this change is that existing
salsa gitlab ci users will have to either rename their file
(preferred) or change their repo config.
Ie, the disruption you refer to above.
However:
gitlab is still quite new, and those projects with a gitlab ci yml
file are still rather "leading-edge" and will probably not find this a
big problem. This would be a one-off change to a fairly new
interface.
Conversely, retaining the current default setting will cause needless
friction for all new projects forever (or, at least, so long as gitlab
and salsa exist).
Ian.
(maintainer of a package with an upstream .gitlab.yml which therefore
causes trouble in salsa)
--
Ian JacksonThese opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Simon McVittie writes ("Re: Salsa.d.o: Please support the implementation
request for a global config option to change the default for "Custom CI config
path" in Gitlab"):
> The default of ./.gitlab.yml is problematic for Salsa *because* it's
> the upstream default, and git repositories on Salsa are most commonly
> used for Debian packaging where we try to minimize delta vs upstream
> source code:
Thanks for this lucid explanation of the technical reasons why we
should be using our own yml path for this.
Ian.
--
Ian JacksonThese opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On Fri, Jul 26, 2019 at 06:01:07PM +0100, Simon McVittie wrote: > This was requested in the past in > https://salsa.debian.org/salsa/support/issues/26, and some people > (including me) interpreted the reply as "no, but only because upstream > doesn't have that feature". Was that interpretation wrong? > The default of ./.gitlab.yml is problematic for Salsa *because* it's > the upstream default, and git repositories on Salsa are most commonly > used for Debian packaging where we try to minimize delta vs upstream > source code: The setting is per project, so it is available. For now I say that changing this globally is too disruptive. But as I wanted to try this something: Please describe why we _should not_ set such an option globally. This is just helping to see if you understand both sides. Bastian -- I object to intellect without discipline; I object to power without constructive purpose. -- Spock, "The Squire of Gothos", stardate 2124.5
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Simon McVittie writes: > For those reasons I think something in debian/ would be a better default. > The request in #26 was for debian/.gitlab-ci.yml. I personally think > a non-hidden file (debian/salsa-ci.yml or debian/gitlab-ci.yml) would > make more sense than a hidden file, but that's just bikeshedding > really. The salsa-ci.yml name has the distinct advantage that it is kind to our downstreams, as it makes it obvious where that file is supposed to work. Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg,GERMANY signature.asc Description: PGP signature
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
On Fri, 26 Jul 2019 at 17:17:02 +0200, Bastian Blank wrote: > On Thu, Jul 25, 2019 at 02:31:55PM +0200, Daniel Leidert wrote: > > Therefor some time ago it had > > been requested to instead change the default at salsa.d.o system wide. > > Why do you think we would change it _if_ this option would exist? This was requested in the past in https://salsa.debian.org/salsa/support/issues/26, and some people (including me) interpreted the reply as "no, but only because upstream doesn't have that feature". Was that interpretation wrong? The default of ./.gitlab.yml is problematic for Salsa *because* it's the upstream default, and git repositories on Salsa are most commonly used for Debian packaging where we try to minimize delta vs upstream source code: - Upstream projects developed on a Gitlab instance often include a ./.gitlab.yml that is designed to run on their infrastructure, not ours. If it works on our infrastructure, it's a waste of runner time: we want to test our packages, not the unmodified upstream source code. If it doesn't work on our infrastructure then it just gets in the way. - We can't remove ./.gitlab.yml from branches that match the upstream source code (e.g. upstream/* in DEP-14) because that would make those branches not match the upstream source code any more. - Anyone who wants to preserve the dgit-like property that the contents of git match the contents of the source package, and is using a patches-applied repository layout, can't remove ./.gitlab.yml without having a somewhat pointless commit in the source package that deletes it. - Anyone who wants to preserve the dgit-like property that the contents of git match the contents of the source package, and is using a patches-unapplied repository layout (e.g. gbp pq), can't remove ./.gitlab.yml at all. For those reasons I think something in debian/ would be a better default. The request in #26 was for debian/.gitlab-ci.yml. I personally think a non-hidden file (debian/salsa-ci.yml or debian/gitlab-ci.yml) would make more sense than a hidden file, but that's just bikeshedding really. Obviously the maintainers of individual packages can always configure their individual Gitlab projects, but that's an extra step to remember to take when creating a new package, the fact that it's per-project means there is no obvious value for what the different setting should be (reducing consistency between packages), and the fact that it's out-of-band Gitlab configuration conflicts with the general principle of keeping as much as possible in a VCS. smcv
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi, On 19-07-26 17:17:02, Bastian Blank wrote: > Why do you think we would change it _if_ this option would exist? Because, chances are, you want to test if the package builds fine, for example, instead of running the upstream CI config. (Yes, I'm aware that it's possible to make this change per repo.) Cheers, Georg
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi Daniel On Thu, Jul 25, 2019 at 02:31:55PM +0200, Daniel Leidert wrote: > Therefor some time ago it had > been requested to instead change the default at salsa.d.o system wide. Why do you think we would change it _if_ this option would exist? Bastian Salsa admin -- Women professionals do tend to over-compensate. -- Dr. Elizabeth Dehaver, "Where No Man Has Gone Before", stardate 1312.9.
Re: Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi, On Thu, 25 Jul 2019, Daniel Leidert wrote: > it has become quiet around this issue. So if you think such a configuration > option is useful too please support > > https://gitlab.com/gitlab-org/gitlab-ce/issues/41764 I added my +1. Another request that is important to have proper CI result in merge requests are those two (they are duplicate really but got triaged differently): https://gitlab.com/gitlab-org/gitlab-ce/issues/48180 https://gitlab.com/gitlab-org/gitlab-ce/issues/64805 Go ahead and add thumbs up! ;) Cheers, -- Raphaël Hertzog ◈ Debian Developer Support Debian LTS: https://www.freexian.com/services/debian-lts.html Learn to master Debian: https://debian-handbook.info/get/ signature.asc Description: PGP signature
Salsa.d.o: Please support the implementation request for a global config option to change the default for "Custom CI config path" in Gitlab
Hi everybody, the Salsa CI team is doing a great job and enabling CI to build our packages at salsa.d.o and test them with lintian & Co is working like a charm. Unfortunately it requires for each project to change/set the default path for the configuration file to debian/gitlab-ci.yml. Therefor some time ago it had been requested to instead change the default at salsa.d.o system wide. The request had been denied, because Gitlab doesn't offer such a configuration. Instead salsa admins encouraged the reporter to issue a feature request to Gitlab. This has been done, and has received positive feedback. Unfortunately it has become quiet around this issue. So if you think such a configuration option is useful too please support https://gitlab.com/gitlab-org/gitlab-ce/issues/41764 Regards, Daniel signature.asc Description: This is a digitally signed message part
