RE: [PATCH] i18n.c: add dependency on xlocale.h for DarwinBSD
Why does my temp gauge have this language message in it? ;)Thanks for the help guys.D-- Don Gould5 Cargill PlaceRichmondChristchurch, New ZealandMobile/Telegram: + 64 21 114 0699www.bowenvale.co.nz Original message From: Sirio Balmelli Date: 16/05/20 4:13 am (GMT+12:00) To: debian-dpkg@lists.debian.org Subject: [PATCH] i18n.c: add dependency on xlocale.h for DarwinBSD >From afca7b4ae1db7926698f7a5ff47ce0f03f42c663 Mon Sep 17 00:00:00 2001From: Sirio Balmelli Date: Wed, 13 May 2020 20:02:48 +0200Subject: [PATCH] i18n.c: add dependency on xlocale.h for DarwinBSDTo: debian-dpkg@lists.debian.orgFixes build failures starting with: i18n.c:27:8: error: unknown type name 'locale_t'Signed-off-by: Sirio Balmelli --- lib/dpkg/i18n.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/lib/dpkg/i18n.c b/lib/dpkg/i18n.cindex 495270003..d98392783 100644--- a/lib/dpkg/i18n.c+++ b/lib/dpkg/i18n.c@@ -24,6 +24,9 @@ #include #ifdef HAVE_USELOCALE+#if __APPLE__+#include +#endif static locale_t dpkg_C_locale; #endif--2.26.2
[PATCH] i18n.c: add dependency on xlocale.h for DarwinBSD
>From afca7b4ae1db7926698f7a5ff47ce0f03f42c663 Mon Sep 17 00:00:00 2001 From: Sirio Balmelli Date: Wed, 13 May 2020 20:02:48 +0200 Subject: [PATCH] i18n.c: add dependency on xlocale.h for DarwinBSD To: debian-dpkg@lists.debian.org Fixes build failures starting with: i18n.c:27:8: error: unknown type name 'locale_t' Signed-off-by: Sirio Balmelli --- lib/dpkg/i18n.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dpkg/i18n.c b/lib/dpkg/i18n.c index 495270003..d98392783 100644 --- a/lib/dpkg/i18n.c +++ b/lib/dpkg/i18n.c @@ -24,6 +24,9 @@ #include #ifdef HAVE_USELOCALE +#if __APPLE__ +#include +#endif static locale_t dpkg_C_locale; #endif -- 2.26.2
Re: More man page improvements
Hello Guillem, On Fri, May 15, 2020 at 02:57:28PM +0200, Guillem Jover wrote: > On Tue, 2020-05-12 at 19:42:02 +0200, Helge Kreutzmann wrote: > > after your recent push the man pages no longer build, i.e. > > git clean -d -X -f > > autoreconf -f -i > > ./configure > > make -C man update-po > > > > fails with: > > Fehler: »msginit -i po/dpkg-man.pot --locale add_de -o ?po/de.add > > --no-translator« endete mit dem Wert 1. > > > > If I remove the "?", this line suceedes: > > > > helge@samd:/tmp/dpkg/man$ msginit -i po/dpkg-man.pot --locale add_de -o > > po/de.add --no-translator > > po/de.add wurde erstellt. > > > > I'm workin on stable, if this matters. > > Hmm, right that would not work entirely. :/ The latest po4a release > changed the default for the --porefs option, and removed the old way > to change that default, so code that changed the default cannot > specify it in a way that is backwards compatible. This should mostly > affect wrapping, so I guess I could also relax the Build-Depends, but > I assume we'll get flip-flops in the .po depending on where it got > updated. Ok, then I run this in a sid chroot. > I'm also wondering about the addenda, which I refactored to specify > them only once in the config, but that only works in testing/sid. We > removed references to man page authors some time ago, so was > considering whether to do the same for the addenda and remove them to > match the upstream part, which would also remove that problem entirely. > Not sure how that would fly with translators though? I would rather keep the translators, because when translation issues arise they should be known as first point of contact. Also translation is a significant effort often overlooked so having the names there is also a way to acknowledge that effort and saying "thank you". (And except this hopefully temporary issue the maintenance effort for your side is almost zero). Greetings Helge P.S. I'll start working on updateing the German man page translation tomorrow, might take a few days. -- Dr. Helge Kreutzmann deb...@helgefjell.de Dipl.-Phys. http://www.helgefjell.de/debian.php 64bit GNU powered gpg signed mail preferred Help keep free software "libre": http://www.ffii.de/ signature.asc Description: PGP signature
Re: More man page improvements
Hi! On Tue, 2020-05-12 at 19:42:02 +0200, Helge Kreutzmann wrote: > after your recent push the man pages no longer build, i.e. > git clean -d -X -f > autoreconf -f -i > ./configure > make -C man update-po > > fails with: > Fehler: »msginit -i po/dpkg-man.pot --locale add_de -o ?po/de.add > --no-translator« endete mit dem Wert 1. > > If I remove the "?", this line suceedes: > > helge@samd:/tmp/dpkg/man$ msginit -i po/dpkg-man.pot --locale add_de -o > po/de.add --no-translator > po/de.add wurde erstellt. > > I'm workin on stable, if this matters. Hmm, right that would not work entirely. :/ The latest po4a release changed the default for the --porefs option, and removed the old way to change that default, so code that changed the default cannot specify it in a way that is backwards compatible. This should mostly affect wrapping, so I guess I could also relax the Build-Depends, but I assume we'll get flip-flops in the .po depending on where it got updated. I'm also wondering about the addenda, which I refactored to specify them only once in the config, but that only works in testing/sid. We removed references to man page authors some time ago, so was considering whether to do the same for the addenda and remove them to match the upstream part, which would also remove that problem entirely. Not sure how that would fly with translators though? Thanks, Guillem
