Re: xournal FTBFS: wrongly declared R³

2020-11-16 Thread Barak A. Pearlmutter
"Rules-Requires-Root?"
"No"
"You Worm. You Scum. You Lowly User. REJECTED!!! Upper Case Is
Reserved For Your Betters. Do You Think You Are My Equal?"
"no."
"What Was That? Did You Just Use Punctuation? Do You Deserve To Use
Punctuation?"
"nope"
"What!?!? You Need Discipline. A GNU Kind Of Discipline! Now Rewrite
This Package In Gnat Ada. Using Ed(1)."



Re: xournal FTBFS: wrongly declared R³

2020-11-16 Thread Johannes Schauer
Quoting Barak A. Pearlmutter (2020-11-16 10:06:05)
> "That's Better. Now I'm Sending You For A Session With The Multi-Arch Hinter.
> I Expect You To Be On Your Best Behavior."

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759099

;)

signature.asc
Description: signature


Re: xournal FTBFS: wrongly declared R³

2020-11-16 Thread Barak A. Pearlmutter
"Rules-Requires-Root?"
"No"
"You Worm. You Scum. You Lowly User. REJECTED!!! Upper Case Is
Reserved For Your Betters. Do You Think You Are My Equal?"
"no."
"What Was That? Did You Just Use Punctuation? Do You Deserve To Use
Punctuation?"
"no"
"That's Better. Now I'm Sending You For A Session With The Multi-Arch
Hinter. I Expect You To Be On Your Best Behavior."

Seriously, requiring each word in the control key to be capitalized
but the subsequent value to be lower case does seem just a teenly
little bit counterintuitive.

Just saying.

--Barak.

"Be conservative in what you send, be liberal in what you accept."
---Postel's law



Re: xournal FTBFS: wrongly declared R³

2020-11-15 Thread Niels Thykier
Guillem Jover:
> Hi!
> 
> On Sat, 2020-10-24 at 11:54:54 +0200, Niels Thykier wrote:
>> Rather, I suspect the issue is that Rules-Requires-Root is set to "No"
>> rather than "no".  AFAICT, only "no" has been defined and it is
>> interpreted case sensitively.
> 
> Right, and even though this is described in the deb822(5) man page, it
> is not explicitly spelled out in the various specific file format man
> pages, so I've clarified that there. Also added more clear references
> to deb822(5) in the relevant man pages. Patches attached.
> 
>> @Guillem/Dpkg Maintainers: Should we provide stricter validation for
>> this to stop this at dpkg-source build time ?
> 
> Yeah, I think that make sense, as dpkg-buildpackage is already
> erroring out on unknown values for «dpkg/» namespaced keywords. So I
> prepared the attached patch to do this too.
> 
> Thanks,
> Guillem
> 

Thanks.

My pedantic nit would be to have dpkg-buildpackage be explicit in what
it expects if it already knows the right answer (which it does in this
case).  E.g.

"R³ field keyword No is uppercase.  Please use no instead"

Saves people a round-trip through the manual if they are unsure about
how to fix the error.

We should probably also add a special-case check for "yes" which I have
seen in the wild.

~Niels



Re: xournal FTBFS: wrongly declared R³

2020-11-15 Thread Guillem Jover
Hi!

On Sat, 2020-10-24 at 11:54:54 +0200, Niels Thykier wrote:
> Rather, I suspect the issue is that Rules-Requires-Root is set to "No"
> rather than "no".  AFAICT, only "no" has been defined and it is
> interpreted case sensitively.

Right, and even though this is described in the deb822(5) man page, it
is not explicitly spelled out in the various specific file format man
pages, so I've clarified that there. Also added more clear references
to deb822(5) in the relevant man pages. Patches attached.

> @Guillem/Dpkg Maintainers: Should we provide stricter validation for
> this to stop this at dpkg-source build time ?

Yeah, I think that make sense, as dpkg-buildpackage is already
erroring out on unknown values for «dpkg/» namespaced keywords. So I
prepared the attached patch to do this too.

Thanks,
Guillem
From 4eb8dbf07cf77229db2413ad1cf6a424e6cbfb3d Mon Sep 17 00:00:00 2001
From: Guillem Jover 
Date: Sun, 15 Nov 2020 19:32:08 +0100
Subject: [PATCH] =?UTF-8?q?doc,=20man:=20Clarify=20that=20R=C2=B3=20values?=
 =?UTF-8?q?=20are=20case=20sensitive?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This is clear from the deb822(5) man page, but we can make this clear on
the brief format description for each of these file formats.

Prompted-by: Niels Thykier 
---
 doc/rootless-builds.txt | 2 +-
 man/deb-buildinfo.pod   | 3 ++-
 man/deb-changes.pod | 3 ++-
 man/deb-control.pod | 3 ++-
 man/deb-src-control.pod | 3 ++-
 man/dsc.pod | 3 ++-
 6 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/doc/rootless-builds.txt b/doc/rootless-builds.txt
index 3298768ec..af0a32836 100644
--- a/doc/rootless-builds.txt
+++ b/doc/rootless-builds.txt
@@ -25,7 +25,7 @@ We add a new field to the "Source" stanza of debian/control:
 
   Rules-Requires-Root: no | binary-targets | 
 
-The values are defined as:
+The case sensitive values are defined as:
 
  * If "no", then "debian/rules binary" will not require root at all (not even
fakeroot).
diff --git a/man/deb-buildinfo.pod b/man/deb-buildinfo.pod
index 79894bd8a..8b3e9ffd4 100644
--- a/man/deb-buildinfo.pod
+++ b/man/deb-buildinfo.pod
@@ -35,7 +35,8 @@ Each field begins with a tag, such as
 B
 or
 B
-(case insensitive), followed by a colon, and the body of the field.
+(case insensitive), followed by a colon, and the body of the field
+(case sensitive unless stated otherwise).
 Fields are delimited only by field tags.
 In other words, field text may be multiple lines in length, but the
 installation tools will generally join lines when processing the body
diff --git a/man/deb-changes.pod b/man/deb-changes.pod
index 5b7aad78d..797a4a56a 100644
--- a/man/deb-changes.pod
+++ b/man/deb-changes.pod
@@ -35,7 +35,8 @@ Each field begins with a tag, such as
 B
 or
 B
-(case insensitive), followed by a colon, and the body of the field.
+(case insensitive), followed by a colon, and the body of the field
+(case sensitive unless stated otherwise).
 Fields are delimited only by field tags.
 In other words, field text may be multiple lines in length, but the
 installation tools will generally join lines when processing the body
diff --git a/man/deb-control.pod b/man/deb-control.pod
index 645905920..216f1cd02 100644
--- a/man/deb-control.pod
+++ b/man/deb-control.pod
@@ -40,7 +40,8 @@ Each field begins with a tag, such as
 B
 or
 B
-(case insensitive), followed by a colon, and the body of the field.
+(case insensitive), followed by a colon, and the body of the field
+(case sensitive unless stated otherwise).
 Fields are delimited only by field tags. In other words, field text
 may be multiple lines in length, but the installation tools will
 generally join lines when processing the body of the field (except
diff --git a/man/deb-src-control.pod b/man/deb-src-control.pod
index 9f7b4121e..45130beee 100644
--- a/man/deb-src-control.pod
+++ b/man/deb-src-control.pod
@@ -41,7 +41,8 @@ least one field. A field starts with a fieldname, such as
 B
 or
 B
-(case insensitive), followed by a colon, the body of the field and a newline.
+(case insensitive), followed by a colon, the body of the field
+(case sensitive unless stated otherwise) and a newline.
 Multi-line fields are also allowed, but each supplementary line, without a
 fieldname, should start with at least one space. The content of the multi-line
 fields is generally joined to a single line by the tools (except in the case of
diff --git a/man/dsc.pod b/man/dsc.pod
index e78eff043..34428bbd5 100644
--- a/man/dsc.pod
+++ b/man/dsc.pod
@@ -34,7 +34,8 @@ Each field begins with a tag, such as
 B
 or
 B
-(case insensitive), followed by a colon, and the body of the field.
+(case insensitive), followed by a colon, and the body of the field
+(case sensitive unless stated otherwise).
 Fields are delimited only by field tags.
 In other words, field text may be multiple lines in length, but the
 installation tools will generally join lines when processing the body
-- 
2.29.2

From 

Re: xournal FTBFS: wrongly declared R³

2020-10-24 Thread Barak A. Pearlmutter
ack



Re: xournal FTBFS: wrongly declared R³

2020-10-24 Thread Niels Thykier
On Sat, 24 Oct 2020 11:49:46 +0200 Helmut Grohne  wrote:
> Source: xournal
> Version: 1:0.4.8.2016-6
> Severity: serious
> Tags: ftbfs
> 
> xournal fails to build from source on buildds, because it wrongly
> declares that it doesn't need root while in fact it does issue
> dh_testroot. Dropping the R³ line from control should fix that.
> 
> Helmut
> 
> 
> 

Rather, I suspect the issue is that Rules-Requires-Root is set to "No"
rather than "no".  AFAICT, only "no" has been defined and it is
interpreted case sensitively.

Presumably, this could also be fixed by using the correct case for "no".

@Guillem/Dpkg Maintainers: Should we provide stricter validation for
this to stop this at dpkg-source build time ?

~Niels