Bug#1046055: mpfr4: Fails to build source after successful build

[Vincent Lefevre]

On 2023-08-28 11:51:17 +0200, Vincent Lefevre wrote:
> On 2023-08-28 11:15:15 +0200, Matthias Klose wrote:
> > the package is built in a separate build dir. shouldn't the upstream
> > makefile also build the info file in the build tree?
> 
> I'm not sure. The issue is that the info file may already be available
> in the source tree (this is always the case for tarballs), so that
> there could be some confusion. We're using
> 
> info_TEXINFOS = mpfr.texi
> 
> and the Makeinfo manual says:
> 
>It is worth noting that, contrary to what happens with the other
> formats, the generated ‘.info’ files are by default placed in ‘srcdir’
> rather than in the ‘builddir’.  This can be changed with the
> ‘info-in-builddir’ option.
> 
> So the question is whether we should use this option. Is it common
> among other software?

According to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=11034#65
we must not use info-in-builddir if we distribute info files
(in tarballs). Since distributing them is recommended (as not
everyone has the necessary tools to rebuild them), we will not
be able to use info-in-builddir.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Bug#1046055: mpfr4: Fails to build source after successful build

[Vincent Lefevre]

On 2023-08-28 11:15:15 +0200, Matthias Klose wrote:
> > Apparently this is due to the fact that the upstream mpfr.info file
> > is rebuilt.
> 
> the package is built in a separate build dir. shouldn't the upstream
> makefile also build the info file in the build tree?

I'm not sure. The issue is that the info file may already be available
in the source tree (this is always the case for tarballs), so that
there could be some confusion. We're using

info_TEXINFOS = mpfr.texi

and the Makeinfo manual says:

   It is worth noting that, contrary to what happens with the other
formats, the generated ‘.info’ files are by default placed in ‘srcdir’
rather than in the ‘builddir’.  This can be changed with the
‘info-in-builddir’ option.

So the question is whether we should use this option. Is it common
among other software?

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Bug#1046055: mpfr4: Fails to build source after successful build

[Vincent Lefevre]

On 2023-08-13 21:21:00 +0200, Lucas Nussbaum wrote:
> > dpkg-source: error: aborting due to unexpected upstream changes, see 
> > /tmp/mpfr4_4.2.0-1.diff.v1TRvW

The diff contains the following:

--- mpfr4-4.2.0.orig/doc/mpfr.info
+++ mpfr4-4.2.0/doc/mpfr.info
@@ -1,4 +1,4 @@
-This is mpfr.info, produced by makeinfo version 6.8 from mpfr.texi.
+This is mpfr.info, produced by makeinfo version 7.0.3 from mpfr.texi.
 This manual documents how to install and use the Multiple Precision
 Floating-Point Reliable Library, version 4.2.0.

Apparently this is due to the fact that the upstream mpfr.info file
is rebuilt.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Bug#1046055: mpfr4: Fails to build source after successful build

[Lucas Nussbaum]

Source: mpfr4
Version: 4.2.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian...@lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<> && runuser -u user42 -- dpkg-buildpackage --sanitize-env 
> -us -uc -rfakeroot -S
> -
> 
> dpkg-buildpackage: info: source package mpfr4
> dpkg-buildpackage: info: source version 4.2.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Matthias Klose 
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> rm -f doc/texinfo.tex
> dh_autoreconf_clean
> rm -rf stamps
> dh_testdir
> dh_testroot
> rm -rf build
> dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building mpfr4 using existing ./mpfr4_4.2.0.orig.tar.xz
> dpkg-source: warning: ignoring deletion of file INSTALL, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file ltmain.sh, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file configure, use 
> --include-removal to override
> dpkg-source: warning: ignoring deletion of file doc/texinfo.tex, use 
> --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  mpfr4-4.2.0/doc/mpfr.info
> dpkg-source: error: aborting due to unexpected upstream changes, see 
> /tmp/mpfr4_4.2.0-1.diff.v1TRvW
> dpkg-source: info: Hint: make sure the version in debian/changelog matches 
> the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source 
> --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<> && runuser -u user42 -- dpkg-buildpackage 
> --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/mpfr4_4.2.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.