Bug#982360: test all passes before failing the build (in case of regressions)

2021-02-09 Thread Matthias Klose 
Package: src:glibc
Version: 2.31-9
Tags: patch

test all passes before failing the build (in case of regressions). I'd like to
see everything which probably needs fixing, not just the first failure.

  * Run checks for every pass before failing the build.

diff --git a/debian/rules b/debian/rules
index cc11e6d2..b6fde574 100755
--- a/debian/rules
+++ b/debian/rules
@@ -203,7 +203,24 @@ clean:: unpatch
 # Required Debian targets
 build-arch: $(stamp)info \
 	$(patsubst %,$(stamp)build_%,$(GLIBC_PASSES)) \
-	$(patsubst %,$(stamp)check_%,$(GLIBC_PASSES))
+	$(patsubst %,$(stamp)check_%,$(GLIBC_PASSES)) \
+	post-check
+post-check: $(patsubst %,$(stamp)check_%,$(GLIBC_PASSES))
+	@echo "CHECK SUMMARY"
+	@for pass in $(patsubst %,$(stamp)check_%,$(GLIBC_PASSES)); do \
+	  if [ -f $${pass}_passed ]; then \
+	echo "check for $$(basename $$pass) passed"; \
+	  fi; \
+	done
+	@fail=0; \
+	for pass in $(patsubst %,$(stamp)check_%,$(GLIBC_PASSES)); do \
+	  if [ -f $${pass}_failed ]; then \
+	echo "check for $$(basename $$pass) failed"; \
+	fail=1; \
+	  fi; \
+	done; \
+	exit $$fail
+
 ifeq ($(filter stage1,$(DEB_BUILD_PROFILES)),)
 build-arch: $(stamp)build_C.UTF-8 \
 	$(stamp)build_locales-all
diff --git a/debian/rules.d/build.mk b/debian/rules.d/build.mk
index 3ede4f5d..74c7a2f1 100644
--- a/debian/rules.d/build.mk
+++ b/debian/rules.d/build.mk
@@ -170,12 +170,13 @@ $(stamp)check_%: $(stamp)build_%
 	echo "+-+" ; \
 	grep -E '^FAIL:' $(DEB_BUILDDIR)/tests.sum | sort ; \
 	if ! dpkg-parsechangelog | egrep -q '^Version:.*\+deb[0-9]+u[0-9]+' ; then \
-	exit 1 ; \
+	touch $@_failed ; \
 	fi ; \
 	  else \
 	echo "+-+" ; \
 	echo "| Passed regression testing.  Give yourself a hearty pat on the back. |" ; \
 	echo "+-+" ; \
+	touch $@_passed ; \
 	  fi ; \
 	fi
 	touch $@

Bug#979970: marked as done (libselinux1: dependency to newer libc6 ignored by/missing for aptitude)

2021-02-09 Thread Debian Bug Tracking System 
Your message dated Tue, 09 Feb 2021 10:03:18 +
with message-id 
and subject line Bug#979970: fixed in libselinux 3.1-3
has caused the Debian Bug report #979970,
regarding libselinux1: dependency to newer libc6 ignored by/missing for aptitude
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
979970: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979970
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libselinux1
Version: 2.8-1+b1
Severity: grave

Right now, an update from buster to bullseye on amd64 completely
bricks the system because libselinux1 is requiring a libc6 which is
not yet installed on the system:

Preparing to unpack .../0-libselinux1_3.1-2+b2_amd64.deb ...
De-configuring libselinux1:i386 (2.8-1+b1) ...
Unpacking libselinux1:amd64 (3.1-2+b2) over (2.8-1+b1) ...
tar: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.30' not
found (required by /lib/x86_64-linux-gnu/libselinux.so.1)
dpkg-deb: error: tar subprocess returned error exit status 1

It is then not possible anymore to recover the system because dpkg
(mv, ...) is no longer working.

There is most likely some kind dependency missing to let aptitude
known that it must first update libc6 before it can update
libselinux1. At least on this system, the installed version of libc6
for amd64 and i386 was still 2.28-10 when this happened
--- End Message ---
--- Begin Message ---
Source: libselinux
Source-Version: 3.1-3
Done: Laurent Bigonville 

We believe that the bug you reported is fixed in the latest version of
libselinux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 979...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laurent Bigonville  (supplier of updated libselinux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Tue, 09 Feb 2021 10:19:50 +0100
Source: libselinux
Architecture: source
Version: 3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian SELinux maintainers 
Changed-By: Laurent Bigonville 
Closes: 979970
Changes:
 libselinux (3.1-3) unstable; urgency=medium
 .
   [ Christian Göttsche ]
   * d/gitlab-ci.yml: Use Debian recipe
   * d/README: Drop note about ancient SELinux mount point
   * d/control: Bump debhelper compat to level 13
   * d/control: Bump Standards-Version to 4.5.1 (no further changes)
   * d/control: Update homepage
   * d/rules: Enable -Wall and -Werror
   * d/rules: Enable build hardening
   * d/control: Drop cute fields
 .
   [ Laurent Bigonville ]
   * Do not use gettid() for Bullseye and use syscall() instead (Closes: 
#979970)
Checksums-Sha1:
 7b4281e68745ba1ec71147098f6cd68a5128d264 2300 libselinux_3.1-3.dsc
 9a409aeb6eae48fdf720aff83dad97eaf766be82 24176 libselinux_3.1-3.debian.tar.xz
 7dde60bdb758b96d050e0f058bc65196cc43078b 12344 
libselinux_3.1-3_source.buildinfo
Checksums-Sha256:
 42810484f3776af09a2e0ab726e3be877fc8a54d6bf51702e46c22f945ab5177 2300 
libselinux_3.1-3.dsc
 7170ab6914f0d2e93de169da312df961f799f5d58cc0a4c552e3f8a7882f3c81 24176 
libselinux_3.1-3.debian.tar.xz
 09b13fd1b342662e62994df391a7b9eba01f26de4c40707e52a23678da998c80 12344 
libselinux_3.1-3_source.buildinfo
Files:
 c6c5f358742e281e27045e7589d685c8 2300 libs optional libselinux_3.1-3.dsc
 963bf4bb91c9abfa0684f497e32d2983 24176 libs optional 
libselinux_3.1-3.debian.tar.xz
 f58ef684a1da99a80e433971d2011a46 12344 libs optional 
libselinux_3.1-3_source.buildinfo

-BEGIN PGP SIGNATURE-

iQFFBAEBCAAvFiEEmRrdqQAhuF2x31DwH8WJHrqwQ9UFAmAiVlQRHGJpZ29uQGRl
Ymlhbi5vcmcACgkQH8WJHrqwQ9UkdQgAmEbylqb6JtS7CwahGBPYwpxORsNoxkk9
IVGnj+dTa6x27t9xEh1VHyBh437dO8+RkjhBNDgasZRRctqS1CBd8XN6/pgJsvN5
O3VOQ+DlziEqfnY7ceW6izQW7JHMkSf6KoLv8Dda1E/dRM6Q96otEsL/pKqwNBMC
SyYP8bH75V64BeF4HwUKsm1vmkVvuU05pe0TjAcoVOiCXkFl6jd9tfAydNSaiips
6wsTbiyBa/tFYQULmgC0VuIuq7VjJmcH9FGcSQSG6kbHfpS0nES4YjS95WfeURXc
zRIT9V7Axm7udXWsmnw7M23MDDjjjVaIUgUp/le6K4uuO6ANIKe5mg==
=J9Ku
-END PGP SIGNATURE End Message ---