Bug#577577: O_FSYNC used but not defined on some archs
On Mon, Apr 12, 2010 at 02:14:39PM -0600, dann frazier wrote: Package: libc6-dev Version: 2.10.2-6 Severity: important On some archs (hppa and sparc at least), there is no O_FSYNC define in bits/fcntl.h. However, even on these archs, we have this block of defines: #ifdef __USE_BSD # define FAPPEND O_APPEND # define FFSYNC O_FSYNC # define FASYNC O_ASYNC # define FNONBLOCKO_NONBLOCK # define FNDELAY O_NDELAY #endif /* Use BSD. */ This makes code with an #ifdef FFSYNC do the wrong thing, as FFSYNC gets literally defined to the string O_FSYNC. Perhaps we could use O_SYNC instead, since this is defined on both hppa and sparc. -- To UNSUBSCRIBE, email to debian-glibc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100413131556.ga29...@scru.org
Bug#577577: Info received (Bug#577577: O_FSYNC used but not defined on some archs)
forwarded 577577 http://sourceware.org/bugzilla/show_bug.cgi?id=11494 quit We can try that this way. --- a/sysdeps/unix/sysv/linux/sparc/bits/fcntl.h +++ b/sysdeps/unix/sysv/linux/sparc/bits/fcntl.h @@ -208,7 +208,7 @@ BSD systems which did not managed to hide these kernel macros. */ #ifdef __USE_BSD # define FAPPEND O_APPEND -# define FFSYNC O_FSYNC +# define FFSYNC O_SYNC # define FASYNC O_ASYNC # define FNONBLOCK O_NONBLOCK # define FNDELAY O_NDELAY --- a/ports/sysdeps/unix/sysv/linux/hppa/bits/fcntl.h +++ b/ports/sysdeps/unix/sysv/linux/hppa/bits/fcntl.h @@ -162,7 +162,7 @@ BSD systems which did not managed to hide these kernel macros. */ #ifdef __USE_BSD # define FAPPEND O_APPEND -# define FFSYNC O_FSYNC +# define FFSYNC O_SYNC # define FASYNC O_ASYNC # define FNONBLOCK O_NONBLOCK # define FNDELAY O_NDELAY
Processed: Re: Bug#577577: Info received (Bug#577577: O_FSYNC used but not defined on some archs)
Processing commands for cont...@bugs.debian.org: forwarded 577577 http://sourceware.org/bugzilla/show_bug.cgi?id=11494 Bug #577577 [libc6-dev] O_FSYNC used but not defined on some archs Set Bug forwarded-to-address to 'http://sourceware.org/bugzilla/show_bug.cgi?id=11494'. quit Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-glibc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.127116543917725.transcr...@bugs.debian.org
Bug#577577: O_FSYNC used but not defined on some archs
Package: libc6-dev Version: 2.10.2-6 Severity: important On some archs (hppa and sparc at least), there is no O_FSYNC define in bits/fcntl.h. However, even on these archs, we have this block of defines: #ifdef __USE_BSD # define FAPPENDO_APPEND # define FFSYNC O_FSYNC # define FASYNC O_ASYNC # define FNONBLOCK O_NONBLOCK # define FNDELAYO_NDELAY #endif /* Use BSD. */ This makes code with an #ifdef FFSYNC do the wrong thing, as FFSYNC gets literally defined to the string O_FSYNC. This results in a FTBFS for libexplian, see #559959. (Creating a new bug instead of reassigning because, presumably, that bug could also be worked around in libexplain). -- To UNSUBSCRIBE, email to debian-glibc-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100412201439.gk13...@ldl.fc.hp.com
