Re: Bug#768188: Jessie Installer hangs after processing DHCPv6 stateful addressing

2015-02-19 Thread Philipp Kern
On Wed, Feb 18, 2015 at 10:05:27PM +, Steven Chamberlain wrote:
 We did expect that during freeze, some regressions may be introduced
 that affect only GNU/kFreeBSD, and we'd have to fix things up in our
 unofficial release, perhaps rolling packages back to an older version,
 or uploading a patched version with +kfreebsd suffix.  So, I'm happy if
 you decide to revert this.
 
 At first glance, it reads like a limitation of udhcpc/dhcp6c only?
 Killing it sounds like a workaround (which perhaps creates other
 issues), and an ifdef linux also seems wrong in this context (and for
 Ubuntu).
 
 kill-all-dhcp could be told never to kill ISC dhclient, but that too is
 wrong, as this is also used to implement the 'Cancel' button in the
 netcfg dialogs.
 
 Maybe there is still a better solution?
 
 Or perhaps we could add something that kills *only* udhcpc/dhcp6c, could
 clearly annotate it as this is a workaround for bug #768188.  Then it
 shouldn't affect Ubuntu, or derivatives/ports using ISC DHCP at all.
 And if many years pass before someone comes back to look at this, they
 should understand why it's there.

Not killing the DHCP clients is the right thing to do. Leases really
should be refreshed during d-i, everything else is madness. But that's
not even what's happening with dhclient because it's being run in
one-shot mode (-1) and will exit after it acquired a lease successfully.

The revert I supposed would've been for jessie as the DHCPv6 hang is
quite a nasty regression on Linux. But for the future we should really
a) use one client on all the platforms and b) let it renew the lease
properly.

Kind regards
Philipp Kern


signature.asc
Description: Digital signature


Re: Bug#768188: Jessie Installer hangs after processing DHCPv6 stateful addressing

2015-02-19 Thread Steven Chamberlain
Philipp Kern wrote:
 one-shot mode (-1) and will exit after it acquired a lease successfully.

dhclient isn't doing that, at least on kfreebsd.  I'm not sure that's
what -1 means.  It will try only once to get a lease, initially.  If
successful it stays running - I assumed it continues to refresh the
lease - and starting in the jessie version, will also give up the lease
on SIGINT (that was #757711).

I think reverting to what we had before reintroduces bugs, and would
break downstream Ubuntu.  I think a workaround should be more
targetted at udhcpc/dhcp6c.

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org


-- 
To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150219112053.ga25...@squeeze.pyro.eu.org



Re: Bug#768188: Jessie Installer hangs after processing DHCPv6 stateful addressing

2015-02-19 Thread Samuel Thibault
Hello,

Thanks for the notice,

Cyril Brulebois, le Wed 18 Feb 2015 22:29:23 +0100, a écrit :
 Philipp Kern pk...@debian.org (2015-02-18):
  So now I guess the question is if we revert the change that broke it:
  
Don't kill_dhcp_client without reason (Closes: #757711, #757988)
 
Do not kill_dhcp_client after setting the hostname and
domain, otherwise Linux udhcpc will stop renewing its lease, and
on other platforms dhclient will de-configure the network interface
(Closes: #757711, #757988)
 
 (No idea about hurd; anyway, adding both porter lists to Cc.)

dhclient gets killed indeed, but for some reason the interface is not
deconfigured, so it's fine for the hurd port.  We already have to ship
our own version of netcfg already anyway because of #769189 which
introduces a 1-minute sleep.

Samuel


-- 
To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/2015022551.gm2...@type.youpi.perso.aquilenet.fr