Re: RFS: sqlline

2008-08-18 Thread Cyril Brulebois
Damien Raude-Morvan [EMAIL PROTECTED] (13/08/2008):
 Cyril, did you have time to sponsor this package (if it's ok for you,
 of course)?

Here are some comments:
 - I assume libjline-java will pull the needed java machinery so you
   don't have to depend on a java runtime environment; is that correct?
 - I assume ant doesn't call any java-ish stuff in the clean target;
   otherwise you would have to move java-gcj-compat-dev to B-D.
 - Please add full stops at the end of the sentences of your long
   description. The other dots are only here for “folding” (see RFC
   (2)822).
 - Nothing important, but you have trailing spaces in debian/copyright,
   you may want to use show-wspace.el if you're an Emacs user.
 - Not sure whether you're pointing at the BSD license is sufficient,
   usually (at least for GPL), a blurb is needed (3 paragraphs). But if
   you're confident enough, I leave that up to ftpmasters. :)
 - Also, when packaging something under a “liberal” license (like the
   BSD licenses), you may want to license the packaging under the same
   license, that might help upstream integrate patches, and so on.
 - I'd s/(C)/©/ in your copyright statement (about Debian packaging)
   since only “Copyright”, “Copr.”, and “©” are legally recognized.
 - You may want to limit the line length of your README.Debian to = 80
   characters; might improve readibility, especially on servers with
   only the default 80x25 console.
 - No space before “:”, “;”, “!”, etc. in English (same file).
 - Also, s/take/takes/.
 - README.source (whitespaces again) can disappear. All copyright info
   must be in debian/copyright, so please move its contents there.
 - debian/rules:
- whitespaces line 2.
- if you're using dh_install in “install/sqlline:”, no need to add
  this directory to the “dirs” file.
- you could modify this target like that:
   - put the jar file and its location in an “install” file.
   - do the same for the wrapper.
   - only do a “mv” in this target.
   - the “dirs” file can go away.
 - I think we already discussed the presence of svn-deblayout so I won't
   insist on it. :)

That was only a review of the most important things of the source part,
I'll have a look at the build/binary part once you've addressed some of
those points. ;-)

Mraw,
KiBi.


signature.asc
Description: Digital signature


Re: packages with build dependencies on openjdk-6-jdk

2008-08-18 Thread Julien Cristau
On Sun, Aug 17, 2008 at 19:25:52 +0200, Matthias Klose wrote:

  - build dependencies should be of the form openjdk-6-jdk |
cacao-oj6-jdk, or else builds will fail on s390.
 
Why would that make a difference?  Alternatives in build-deps aren't
considered by sbuild.

Cheers,
Julien


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



freeze exception for cacao-oj6

2008-08-18 Thread Matthias Klose
proposing a freeze exception for cacao-oj6 for testing. cacao-oj6 is a
copy of the openjdk-6 package with the cacao sources
included. Compared to openjdk-6 on architectures without the Hotspot
JIT support, cacao-oj6 (including a JIT) is a much faster JVM on the
architectures where it does build (powerpc, s390, armel for
now). Discussed this at Debconf with some people. I was told to get
agreement with debian-security about the maintainability (because of
the duplicate sources). See #495256 as well.

  Matthias


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



packages with build dependencies on openjdk-6-jdk

2008-08-18 Thread Matthias Klose
Unfortunately there is a lot of packages with build dependencies on
openjdk-6-jdk directly, which is a bit unfortunate. Most likely all
packages build depending on openjdk-6-jdk should have RC bug reports
because they may contain 1.6 bytecode. The following should be checked
for the release:

 - if a package build-depends on openjdk-6-jdk or cacao-oj6-jdk,
   it should be compiled with `-target 1.4' (or 1.5?).

 - if no target option is used, it should only depend on 
   java-runtime6 or java-runtime6-headless.

 - build dependencies should be of the form openjdk-6-jdk |
   cacao-oj6-jdk, or else builds will fail on s390.

Matthias


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Update of fop package

2008-08-18 Thread Sylvestre Ledru
Hello, 

Needing a more recent version of fop for jeuclid package [1], I updated
the package and in the meantime closed a few bugs.

If I can do anything more to help on this, don't hesitate!

Thanks!
Sylvestre

[1] http://jeuclid.sourceforge.net/

Index: debian/control
===
--- debian/control	(révision 6912)
+++ debian/control	(copie de travail)
@@ -5,7 +5,7 @@
 Uploaders: Arnaud Vandyck [EMAIL PROTECTED], Michael Koch [EMAIL PROTECTED]
 Build-Depends: debhelper (= 5), cdbs (= 0.4.27)
 Build-Depends-Indep: ant-optional, libbatik-java (= 1.5.1-1), libavalon-framework-java (=4.1.2-2), libxalan2-java, libxerces2-java, java-gcj-compat-dev, libcommons-io-java, libcommons-logging-java, junit, libxmlgraphics-commons-java (= 1.2), libservlet2.4-java
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
 
 Package: fop
 Architecture: all
Index: debian/changelog
===
--- debian/changelog	(révision 6912)
+++ debian/changelog	(copie de travail)
@@ -1,9 +1,18 @@
-fop (1:0.94.dfsg-3) UNRELEASED; urgency=low
+fop (1:0.95.dfsg-1) UNRELEASED; urgency=low
 
+  [ Sylvestre Ledru ]
+  * New upstream version (Closes: #494041)
+  * Section change in fop-doc.doc-base from contrib/libs = Text to make 
+lintian happier
+  * Dependencies removed (Closes: #229079 #271654)
+  * Update of the JAVA_HOME in debian/ant.properties (Closes: #492322)
+  * Updated Standards-Version to 3.8.0
+
+  [ Michael Koch ]
   * Fixed watch file for changed upstream location.
+	
+ -- Sylvestre Ledru [EMAIL PROTECTED]  Thu, 14 Aug 2008 15:45:50 +0200
 
- -- Michael Koch [EMAIL PROTECTED]  Sat, 29 Mar 2008 12:16:39 +0100
-
 fop (1:0.94.dfsg-2) unstable; urgency=low
 
   * Fixed name of versioned jar.
Index: debian/rules
===
--- debian/rules	(révision 6912)
+++ debian/rules	(copie de travail)
@@ -6,7 +6,7 @@
 include /usr/share/cdbs/1/class/ant.mk
 
 JAVA_HOME:= /usr/lib/jvm/java-gcj
-DEB_JARS := $(ANT_HOME)/lib/ant-trax.jar batik avalon-framework xercesImpl xmlParserAPIs xalan2 junit commons-io commons-logging xmlgraphics-commons servlet-api-2.4 /usr/local/jimi-1.0.jar /usr/local/jai_core.jar /usr/local/jai_codec.jar
+DEB_JARS := $(ANT_HOME)/lib/ant-trax.jar batik avalon-framework xercesImpl xmlParserAPIs xalan2 junit commons-io commons-logging xmlgraphics-commons servlet-api-2.4
 DEB_ANT_BUILD_TARGET := package javadocs #docs
 DEB_ANT_CLEAN_TARGET := distclean
 DEB_ANT_ARGS := -verbose
@@ -16,6 +16,7 @@
 install/fop::
 	cp build/fop.jar debian/fop/usr/share/java/fop-${DEB_UPSTREAM_VERSION}.jar
 	dh_link usr/share/java/fop-${DEB_UPSTREAM_VERSION}.jar usr/share/java/fop.jar
+
 	cp -a debian/fop.sh debian/fop/usr/bin/fop
 	cp -a debian/fop-ttfreader.sh debian/fop/usr/bin/fop-ttfreader
 	pod2man --section=1 \
Index: debian/fop-doc.doc-base
===
--- debian/fop-doc.doc-base	(révision 6912)
+++ debian/fop-doc.doc-base	(copie de travail)
@@ -3,7 +3,7 @@
 Author: FOP Development Team
 Abstract: This manual describes what fop is
  and how it can be used.
-Section: contrib/libs
+Section: Text
 
 Format: HTML
 Index: /usr/share/doc/fop-doc/html/api/index.html
Index: debian/ant.properties
===
--- debian/ant.properties	(révision 6912)
+++ debian/ant.properties	(copie de travail)
@@ -1,2 +1,2 @@
-javahome.jdk14=/usr/lib/jvm/java-6-sun
+javahome.jdk14=/usr/lib/jvm/java-gcj
 #runtime.classpath=xercesImpl.jar xml-apis.jar xalan2.jar batik.jar avalon-framework.jar


Re: packages with build dependencies on openjdk-6-jdk

2008-08-18 Thread Michael Tautschnig
[...]
 
  - build dependencies should be of the form openjdk-6-jdk |
cacao-oj6-jdk, or else builds will fail on s390.
 

Shouldn't instead architecture specific build-depends be used?

Best,
Michael



pgpIi2Z9VR8GP.pgp
Description: PGP signature


Re: selecting a java runtime

2008-08-18 Thread Matthew Johnson
On Mon Aug 18 18:40, peter green wrote:
 are there any scripts in debian for locating a java runtime based on a set 
 of criteria such as java versions supported and whether or not it is a 
 sun/sun based runtime.

 or to put it another way what should packages that cannot run acceptablly 
 with gcj be doing to ensure they run with a sun based runtime.

One solution would be to depend on just a specific runtime and then call
that explicitly.

More generally, if you only work with a subset of the available runtimes
then to get a policy-compliant depends line you need to have some
enumeration of working VMs anyway, so this can be used in the wrapper
script.

Having said all that, we do need to sort out the virtual packages. I
think that having a virtual package for 'any of the sun ones (sun, open
or icedtea)' is sensible.

I don't think there is such a script at the moment.

Matt

-- 
Matthew Johnson
www.matthew.ath.cx


signature.asc
Description: Digital signature


Re: Bug#491805: RFS: sqlline

2008-08-18 Thread Damien Raude-Morvan
Hi,

Le Sunday 17 August 2008 17:42:18 Cyril Brulebois, vous avez écrit :
  - I assume libjline-java will pull the needed java machinery so you
don't have to depend on a java runtime environment; is that correct?

As said by Matthew, sqlline is an application so it must depends on JRE.
I've added that to debian/control, see changelog.

  - I assume ant doesn't call any java-ish stuff in the clean target;
otherwise you would have to move java-gcj-compat-dev to B-D.

Ant call build.xml clean target during debian/rules clean rules, so I need  
java-gcj-compat-dev in B-D. Done.

  - debian/rules:
 - whitespaces line 2.
   - if you're using dh_install in “install/sqlline:”, no need to add
 this directory to the “dirs” file.
   - you could modify this target like that:
  - put the jar file and its location in an “install” file.
  - do the same for the wrapper.
  - only do a “mv” in this target.
  - the “dirs” file can go away.

Done.

  - Please add full stops at the end of the sentences of your long
description. The other dots are only here for “folding” (see RFC
(2)822).
  - Nothing important, but you have trailing spaces in debian/copyright,
you may want to use show-wspace.el if you're an Emacs user.
  - You may want to limit the line length of your README.Debian to = 80
characters; might improve readibility, especially on servers with
only the default 80x25 console.
  - No space before “:”, “;”, “!”, etc. in English (same file).
  - Also, s/take/takes/.
  - README.source (whitespaces again) can disappear. All copyright info
must be in debian/copyright, so please move its contents there.
  - I'd s/(C)/©/ in your copyright statement (about Debian packaging)
since only “Copyright”, “Copr.”, and “©” are legally recognized.

I've corrected all those tiny things.

  - Also, when packaging something under a “liberal” license (like the
BSD licenses), you may want to license the packaging under the same
license, that might help upstream integrate patches, and so on.

You're right. Done.

I've uploaded a new version (same revision) to mentors so you can have a look.

Good night,
-- 
Damien Raude-Morvan / www.drazzib.com




signature.asc
Description: This is a digitally signed message part.