RFS: trang 20030619-7 (QA upload, second try)
Hi everyone, Could any of you, preferably with more Java packaging experience than me, have a look at my proposed trang revision 20030619-7? Uploading it would close #478187 (G); the error described there is caused by gcj hiding an internal package of trang behind a built-in one. I’ve posted an RFS two weeks ago [1], but only one non-DD responded, which is why I’m adding -qa. The source package can be downloaded from: http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc It builds fine in pbuilder, the binary package as well as the source is lintian clean, and debdiff against the binary package from 6.1 shows no unexpected changes. I would greatly appreciate if someone could comment on what I’ve done and eventually upload it. [1] http://lists.debian.org/debian-java/2008/09/msg3.html Cheers, -- Michael Schutte <[EMAIL PROTECTED]> signature.asc Description: Digital signature
Re: RFS: trang 20030619-7 (QA upload)
Pushing. On Fri, Sep 05, 2008 at 08:28:03PM +, Michael Schutte wrote: > Hi Javaists, > > [Please Cc me on replies, I’m not subscribed] > > Could one of you be so kind and check my proposed QA upload of trang > fixing #478187? The error occurs because gcj hides an internal package > of trang behind a built-in one, which causes the very fancy message > described in the bug report. The source package is at: > > http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc > > It builds fine in pbuilder, the binary package as well as the source is > lintian clean, and debdiff against the binary package from 6.1 shows no > unexpected changes. > > I originally converted the package to javahelper instead of implementing > the current fix, but then noticed that java-gcj-compat fails on the JAR > as well. From a release point of view, I guess it is okay to not change > the package too much, anyway. > > Could anyone of you have a look and comment on the package (and probably > consider uploading it)? -- Michael Schutte <[EMAIL PROTECTED]> signature.asc Description: Digital signature
Re: RFS: trang 20030619-7 (QA upload)
Michael Schutte wrote: > On Sat, Sep 06, 2008 at 02:23:51PM +0100, Andrew Haley wrote: >> Michael Schutte wrote: >>> Hi Javaists, >>> >>> [Please Cc me on replies, I’m not subscribed] >>> >>> Could one of you be so kind and check my proposed QA upload of trang >>> fixing #478187? The error occurs because gcj hides an internal package >>> of trang behind a built-in one, which causes the very fancy message >>> described in the bug report. The source package is at: >>> >>> http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc >>> […] >> I'm guessing that there was a missing -findirect-dispatch -Bsymbolic. > > Thanks for the tip, but -findirect-dispatch was already there, and > adding -Bsymbolic does not fix the problem. OK. I still don't really understand what was causing the problem. There must be something peculiar about the way that it was being built. As long as the classes are compiled with -findirect-dispatch -Bsymbolic, built into a shared library, the library added to the database, and the bootclasspath pointed at the jarfiles, everything should be fine. I'm guessing that what happens here is that the org.relaxng classes are compiled into an executable in the hope that these classes will be preferred to the ones of the same name in libgcj. >> I'd be quite interested to see what you've changed and what broke, but >> sadly my Debian smarts are inadequate to decude that URL. > > # aptitude install devscripts > $ dget -xu http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc > $ cd trang-20030619 > > For your convenience, I’ve also attached a patch between the buggy -6.1 > and my -7. Yeah, I see that you've renamed the classes to avoid gcj finding its own versions. Andrew. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: trang 20030619-7 (QA upload)
Andrew, On Sat, Sep 06, 2008 at 02:23:51PM +0100, Andrew Haley wrote: > Michael Schutte wrote: > > Hi Javaists, > > > > [Please Cc me on replies, I’m not subscribed] > > > > Could one of you be so kind and check my proposed QA upload of trang > > fixing #478187? The error occurs because gcj hides an internal package > > of trang behind a built-in one, which causes the very fancy message > > described in the bug report. The source package is at: > > > > http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc > > […] > > I'm guessing that there was a missing -findirect-dispatch -Bsymbolic. Thanks for the tip, but -findirect-dispatch was already there, and adding -Bsymbolic does not fix the problem. > I'd be quite interested to see what you've changed and what broke, but > sadly my Debian smarts are inadequate to decude that URL. # aptitude install devscripts $ dget -xu http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc $ cd trang-20030619 For your convenience, I’ve also attached a patch between the buggy -6.1 and my -7. Cheers, -- Michael Schutte <[EMAIL PROTECTED]> diff -u trang-20030619/Makefile trang-20030619/Makefile --- trang-20030619/Makefile +++ trang-20030619/Makefile @@ -501,7 +501,7 @@ src/META-INF/services/com.thaiopensource.validate.auto.SchemaReceiverFactory.o \ src/META-INF/services/com.thaiopensource.validate.SchemaReaderFactory.o \ src/META-INF/services/javax.xml.parsers.SAXParserFactory.o \ - src/META-INF/services/org.relaxng.datatype.DatatypeLibraryFactory.o \ + src/META-INF/services/com.thaiopensource.relaxng.datatype.DatatypeLibraryFactory.o \ src/com/thaiopensource/datatype/xsd/resources/Messages.properties.o \ src/com/thaiopensource/relaxng/parse/compact/resources/Messages.properties.o \ src/com/thaiopensource/relaxng/parse/sax/resources/Messages.properties.o \ diff -u trang-20030619/debian/rules trang-20030619/debian/rules --- trang-20030619/debian/rules +++ trang-20030619/debian/rules @@ -39,6 +39,7 @@ dh_testdir # Add here commands to compile the package. + mv src/org/relaxng/datatype src/com/thaiopensource/relaxng/ $(MAKE) #/usr/bin/docbook-to-man debian/trang.sgml > trang.1 @@ -50,6 +51,8 @@ rm -f build-stamp # Add here commands to clean up after the build process. + [ ! -d src/com/thaiopensource/relaxng/datatype ] || \ + mv src/com/thaiopensource/relaxng/datatype src/org/relaxng/ [ ! -f config.status ] || [ ! -f Makefile ] || $(MAKE) distclean rm -f config.sub config.guess test_trang diff -u trang-20030619/debian/control trang-20030619/debian/control --- trang-20030619/debian/control +++ trang-20030619/debian/control @@ -3,7 +3,7 @@ Priority: optional Maintainer: Debian QA Group <[EMAIL PROTECTED]> Build-Depends: debhelper (>> 5), autotools-dev, gcj [!alpha !arm !hppa !hurd-i386] -Standards-Version: 3.7.3 +Standards-Version: 3.8.0 Homepage: http://www.thaiopensource.com/relaxng/trang.html Package: trang diff -u trang-20030619/debian/changelog trang-20030619/debian/changelog --- trang-20030619/debian/changelog +++ trang-20030619/debian/changelog @@ -1,3 +1,14 @@ +trang (20030619-7) unstable; urgency=low + + * QA upload. + * Before running make, move the org.relaxng.datatype directory to +com.thaiopensource.relaxng.datatype and adjust the affected import +statements. This avoids that gcj erroneously uses its built-in version of +this package and closes: #478187. + * Bump Standards-Version to 3.8.0 (no changes needed). + + -- Michael Schutte <[EMAIL PROTECTED]> Fri, 05 Sep 2008 22:07:08 +0200 + trang (20030619-6.1) unstable; urgency=low * Non-maintainer upload. only in patch2: unchanged: --- trang-20030619.orig/Makefile.in +++ trang-20030619/Makefile.in @@ -447,16 +447,16 @@ $(srcdir)/src/com/thaiopensource/xml/infer/ElementDeclInferrer.java \ $(srcdir)/src/com/thaiopensource/xml/infer/ContentModelInferrerImpl.java \ $(srcdir)/src/com/thaiopensource/xml/infer/ContentModelInferrer.java \ - $(srcdir)/src/org/relaxng/datatype/helpers/DatatypeLibraryLoader.java \ - $(srcdir)/src/org/relaxng/datatype/helpers/ParameterlessDatatypeBuilder.java \ - $(srcdir)/src/org/relaxng/datatype/helpers/StreamingValidatorImpl.java \ - $(srcdir)/src/org/relaxng/datatype/Datatype.java \ - $(srcdir)/src/org/relaxng/datatype/DatatypeBuilder.java \ - $(srcdir)/src/org/relaxng/datatype/DatatypeException.java \ - $(srcdir)/src/org/relaxng/datatype/DatatypeLibrary.java \ - $(srcdir)/src/org/relaxng/datatype/DatatypeLibraryFactory.java \ - $(srcdir)/src/org/relaxng/datatype/DatatypeStreamingValidator.java \ - $(srcdir)/src/org/relaxng/datatype/ValidationContext.java \ + $(srcdir)/src/com/thaiopensource/relaxng/datatype/helpers/DatatypeLibraryLoader.java \ + $(srcdir)/src/com/thaiopensource/relaxng/datatype/helpers/ParameterlessDatatypeBuilder.java \ + $(srcdir)/src/com/thaiopensource/relax
Re: RFS: trang 20030619-7 (QA upload)
Michael Schutte wrote: > Hi Javaists, > > [Please Cc me on replies, I’m not subscribed] > > Could one of you be so kind and check my proposed QA upload of trang > fixing #478187? The error occurs because gcj hides an internal package > of trang behind a built-in one, which causes the very fancy message > described in the bug report. The source package is at: > > http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc > > It builds fine in pbuilder, the binary package as well as the source is > lintian clean, and debdiff against the binary package from 6.1 shows no > unexpected changes. > > I originally converted the package to javahelper instead of implementing > the current fix, but then noticed that java-gcj-compat fails on the JAR > as well. From a release point of view, I guess it is okay to not change > the package too much, anyway. > > Could anyone of you have a look and comment on the package (and probably > consider uploading it)? I'm guessing that there was a missing -findirect-dispatch -Bsymbolic. I'd be quite interested to see what you've changed and what broke, but sadly my Debian smarts are inadequate to decude that URL. Andrew. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
RFS: trang 20030619-7 (QA upload)
Hi Javaists, [Please Cc me on replies, I’m not subscribed] Could one of you be so kind and check my proposed QA upload of trang fixing #478187? The error occurs because gcj hides an internal package of trang behind a built-in one, which causes the very fancy message described in the bug report. The source package is at: http://alioth.debian.org/~michi-guest/packages/trang_20030619-7.dsc It builds fine in pbuilder, the binary package as well as the source is lintian clean, and debdiff against the binary package from 6.1 shows no unexpected changes. I originally converted the package to javahelper instead of implementing the current fix, but then noticed that java-gcj-compat fails on the JAR as well. From a release point of view, I guess it is okay to not change the package too much, anyway. Could anyone of you have a look and comment on the package (and probably consider uploading it)? Thanks in advance, -- Michael Schutte <[EMAIL PROTECTED]> signature.asc Description: Digital signature
