Bug#732282: Removing openjdk-7 for kfreebsd and sparc
please see http://bugs.debian.org/732282 Is there anybody who wants to maintain openjdk for these architectures? If not, I'll go ahead and make gcj-jdk the default again on those architectures and request removal of the kfreebsd and sparc binaries. Matthias -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52bf3db0.9040...@ubuntu.com
Re: openjdk-7 for kfreebsd
On 23/11/13 14:10, Sylvestre Ledru wrote: > [...] I uploaded java-common > 0.50 which defaults to openjdk under kfreebsd. Thanks for that. But I'm seeing something strange though on the buildds. [Cc'ing Debian FTP Masters for advice]. This change means that build-depends for bouncycastle and mpj are now satisfied on kfreebsd-* but something odd is happening. https://buildd.debian.org/status/package.php?p=bouncycastle is repeatedly failing on kfreebsd-* with: > Checking available source versions... > Can't find source for bouncycastle_1.48+dfsg-2 > (only different version(s) bouncycastle 1.49+dfsg-2 found) where 1.49+dfsg-2 is indeed the latest in sid, but the buildd status page talks about 1.48+dfsg-2? https://buildd.debian.org/status/package.php?p=mpj is repeatedly failing on kfreebsd-* with: > Checking available source versions... > Can't find source for mpj_0.38~dfsg-1 > (only different version(s) mpj 0.38+dfsg-2 found) What does this mean? Thanks, Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/529167a1.4020...@pyro.eu.org
Re: openjdk-7 for kfreebsd
Hello, On 13/11/2013 20:45, Steven Chamberlain wrote: > Sorry to jump in on a thread about mips, but on kfreebsd we are also > looking to switch to openjdk-7 as soon as possible. And we were advised > to send our patches upstream also. I'd appreciate any advice on how to > go about doing that. > > Ideally we could consistently have openjdk-7 as default on all of > Debian's release arches and be moving *away* from gcj-jdk. > Taking the opportunity to chat with Niels from the release team, I uploaded java-common 0.50 which defaults to openjdk under kfreebsd. Sylvestre -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5290b75f.3090...@debian.org
Re: openjdk-7 for kfreebsd
On 14/11/2013 12:53, Steven Chamberlain wrote: > -#ifdef __linux__ > +#if defined(__linux__) || defined(__GLIBC__) > > We have dozens of these for example - that kind of ifdef is ambiguous as > to whether it expects "the Linux kernel" or just "a Linux-like userland" > which is true also of GNU/kFreeBSD, GNU/Hurd and potentially other glibc > ports. If you want to check for a Glibc feature (regardless of which kernel we're using), the following is enough: #ifdef __GLIBC__ However note that what usually happens is that other libraries which are used on Linux and are similar to Glibc implement the same features and will want to match this #ifdef too. Thus removing the "__linux__" although it might be strictly correct may cause a regression. I usually just avoid causing the regression by leaving the __linux__ in, even if the feature we're checking has nothing to do with kernel. -- Robert Millan -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52850eb9.5070...@debian.org
Re: openjdk-7 for kfreebsd
On 11/14/2013 11:53 AM, Steven Chamberlain wrote: > Hi Andrew, > > On 14/11/13 09:26, Andrew Haley wrote: >>> [...] on kfreebsd we are also looking to switch to openjdk-7 as >>> soon as possible. And we were advised to send our patches >>> upstream also. I'd appreciate any advice on how to go about doing >>> that. >> >> Talk to me. > > Thank you! > > Debian applies four patches to openjdk-7 for kfreebsd support, including > some bits I don't expect to be appropriate for upstream, but I propose > to split some bits out: > > -#ifdef __linux__ > +#if defined(__linux__) || defined(__GLIBC__) > > We have dozens of these for example - that kind of ifdef is ambiguous as > to whether it expects "the Linux kernel" or just "a Linux-like userland" > which is true also of GNU/kFreeBSD, GNU/Hurd and potentially other glibc > ports. > > We also have a handful of these in the patches mentioned below - though > I propose to match on startsWith("GNU"), in anticipation that GNU/Hurd > (osname="GNU"?) may someday want to use the same code: > > if (osname.startsWith("SunOS") || > + osname.startsWith("GNU/kFreeBSD") || > osname.startsWith("Linux")) { > > > These two patches are fairly straightforward, enabling build system support: > > http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-corba.diff > http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-jamvm.diff > > The final two patches consist of largely the ifdef changes mentioned > above. Some other parts look clearly objectionable. e.g. I expect you > don't want to add large blocks of (largely duplicated) kfreebsd-specific > code to src/os/linux/*: > > http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-hotspot.diff > http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-jdk.diff Hmm. Some of these are simple enough, but others require more careful handling. To begin with: anything not utterly trivial in OpenJDK requires copyright assignment. I can push simple patches, but this doesn't look so simple. If someone is prepared to sign Oracle's contributor agreement and submit these patches, it can be done. Andrew. -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5284c71f.3040...@redhat.com
Re: openjdk-7 for kfreebsd
Hi Andrew, On 14/11/13 09:26, Andrew Haley wrote: >> [...] on kfreebsd we are also looking to switch to openjdk-7 as soon as >> possible. And we were advised to send our patches upstream also. I'd >> appreciate any advice on how to go about doing that. > > Talk to me. Thank you! Debian applies four patches to openjdk-7 for kfreebsd support, including some bits I don't expect to be appropriate for upstream, but I propose to split some bits out: -#ifdef __linux__ +#if defined(__linux__) || defined(__GLIBC__) We have dozens of these for example - that kind of ifdef is ambiguous as to whether it expects "the Linux kernel" or just "a Linux-like userland" which is true also of GNU/kFreeBSD, GNU/Hurd and potentially other glibc ports. We also have a handful of these in the patches mentioned below - though I propose to match on startsWith("GNU"), in anticipation that GNU/Hurd (osname="GNU"?) may someday want to use the same code: if (osname.startsWith("SunOS") || + osname.startsWith("GNU/kFreeBSD") || osname.startsWith("Linux")) { These two patches are fairly straightforward, enabling build system support: http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-corba.diff http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-jamvm.diff The final two patches consist of largely the ifdef changes mentioned above. Some other parts look clearly objectionable. e.g. I expect you don't want to add large blocks of (largely duplicated) kfreebsd-specific code to src/os/linux/*: http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-hotspot.diff http://patch-tracker.debian.org/patch/series/view/openjdk-7/7u25-2.3.12-4/kfreebsd-support-jdk.diff Thanks again, Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5284b9b6.9090...@pyro.eu.org
Re: openjdk-7 for kfreebsd
On 11/13/2013 07:45 PM, Steven Chamberlain wrote: >> On 11/13/2013 12:29 AM, Aurelien Jarno wrote: >>> I have finally been able to fix openjdk-7 on mips and mipsel. > > Brilliant! > > On 13/11/13 09:10, Andrew Haley wrote: >> That's an odd patch. > > FWIW it looks right to me that something like this would trigger SIGBUS when > hotspot is run during mips(el) builds or possibly sparc. > >> I'd like to get this fixed upstream. > > Debian Java maintainers might also insist on that, before considering > openjdk-7 as default java. > > Sorry to jump in on a thread about mips, but on kfreebsd we are also looking > to switch to openjdk-7 as soon as possible. And we were advised to send our > patches upstream also. I'd appreciate any advice on how to go about doing > that. Talk to me. > Ideally we could consistently have openjdk-7 as default on all of Debian's > release arches and be moving *away* from gcj-jdk. Sure. So, what have you got? Andrew. -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52849762.6020...@redhat.com
openjdk-7 for kfreebsd (was: Replacing openjdk-6 with gcj-jdk as default java for mips{,el})
> On 11/13/2013 12:29 AM, Aurelien Jarno wrote: >> I have finally been able to fix openjdk-7 on mips and mipsel. Brilliant! On 13/11/13 09:10, Andrew Haley wrote: > That's an odd patch. FWIW it looks right to me that something like this would trigger SIGBUS when hotspot is run during mips(el) builds or possibly sparc. > I'd like to get > this fixed upstream. Debian Java maintainers might also insist on that, before considering openjdk-7 as default java. Sorry to jump in on a thread about mips, but on kfreebsd we are also looking to switch to openjdk-7 as soon as possible. And we were advised to send our patches upstream also. I'd appreciate any advice on how to go about doing that. Ideally we could consistently have openjdk-7 as default on all of Debian's release arches and be moving *away* from gcj-jdk. Regards, -- Steven Chamberlain ste...@pyro.eu.org signature.asc Description: OpenPGP digital signature