Bug#836894: Please add support for LXDE desktop

2016-09-06 Thread Raphaël Halimi
Package: qt4-x11
Version: 4:4.8.7+dfsg-8
Severity: wishlist
Tags: upstream patch

Hi,

Same rationale as #825769, here is a small patch to allow Qt4 to detect
when they're running under LXDE desktop, and behave like they're run
under Gnome (mainly, use the current GTK theme).

I tested it under LXDE and it seems to work; it's also quite simple and
thus unlikely to change anything under other desktops.

Regards,

-- 
Raphaël Halimi

Description: Add support for LXDE desktop
 This patch checks for an environment variable set by LXDE desktop, in order to
 make Qt4 applications natively use the GTK+ style when run on this desktop
Author: Raphaël Halimi <raphael.hal...@gmail.com>
Origin: other
Last-Update: 2016-09-06
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/src/gui/kernel/qapplication_x11.cpp
+++ b/src/gui/kernel/qapplication_x11.cpp
@@ -2355,6 +2355,11 @@
 break;
 }
 
+if (qgetenv("DESKTOP_SESSION") == "LXDE") {
+X11->desktopEnvironment = DE_GNOME;
+break;
+}
+
 // GNOME_DESKTOP_SESSION_ID is deprecated for some reason, but still check it
 if (!qgetenv("GNOME_DESKTOP_SESSION_ID").isEmpty()) {
 X11->desktopEnvironment = DE_GNOME;


signature.asc
Description: OpenPGP digital signature


Bug#825769: Please add support for MATE desktop

2016-05-29 Thread Raphaël Halimi
Package: qt4-x11
Version: 4:4.8.7+dfsg-7
Severity: wishlist
Tags: upstream patch

Hi,

Qt4 applications are smart enough to detect when they're run under GNOME
or XFCE, and use the GTK+ theme unless configured otherwise, thanks to a
bunch of tests that determine which desktop the application is running on.

Unfortunately, these tests don't include the MATE desktop; Qt5 does
include such a test, but a lot of applications still use Qt4 (for
example, on my system, I have avidemux, bitcoin-qt, clementine, and
skype which depend on Qt4 libs).

To determine if GNOME 2 is running, Qt4 checks for the presence of an
environment variable named GNOME_DESKTOP_SESSION_ID (which is said to be
deprecated, but Qt4 acknowledges this fact in its comments and still
uses it nevertheless). Since MATE is a fork of GNOME 2, it sets an
equivalent variable named MATE_DESKTOP_SESSION_ID, so I wrote a small
patch that simply duplicates the test with the new variable name.

I'm sure it could be made more elegant and check for both variables
names within the same test, but since I'm no C coder, I didn't want to
mess with the code so I chose the safe path. If you can rework the patch
in this way, this would be even better; the basic idea is to check for
MATE_DESKTOP_SESSION_ID (like the GNOME 2 test does) and if found,
pretend we're under GNOME (like the XFCE test does).

Anyway, here's the patch. I compiled Qt4 packages with it for my
personal use and they work as expected: Qt4 applications now use the
GTK+ theme natively when run under MATE, without any specific user
configuration (I removed ~/.config/Trolltech.conf to test that), whereas
with the unpatched version, it used to fall back on the "Default" (in
qt4-qtconfig) theme (the one which looks like Windows 9x).

Regards,

-- 
Raphaël Halimi
Description: Add support for MATE desktop
 This patch checks for an environment variable set by MATE desktop, in order to
 make Qt4 applications natively use the GTK+ style when run on this desktop
Author: Raphaël Halimi <raphael.hal...@gmail.com>
Origin: other
Last-Update: 2016-05-29
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/src/gui/kernel/qapplication_x11.cpp
+++ b/src/gui/kernel/qapplication_x11.cpp
@@ -2361,6 +2361,12 @@
 break;
 }
 
+// Check the equivalent environment variable set by MATE
+if (!qgetenv("MATE_DESKTOP_SESSION_ID").isEmpty()) {
+X11->desktopEnvironment = DE_GNOME;
+break;
+}
+
 rc = XGetWindowProperty(X11->display, QX11Info::appRootWindow(), ATOM(_DT_SAVE_MODE),
 0, 2, False, XA_STRING, , , ,
 , );


signature.asc
Description: OpenPGP digital signature


Bug#690291: Amarok randomly stops playing sound when song automatically changes using phonon-backend-gstreamer

2012-10-21 Thread Raphaël HALIMI
I just tried to remove gstreamer0.10-plugins-ugly (and had to install 
gstreamer0.10-fluendo-mp3 to make phonon able to play mp3 files again) : 
no change, Amarok just stops on the same songs (the bug is not so random 
as I first thought, see below).


I'll send you a full report of Amarok's debug output but for now, I 
noticed that it stops everytime it tried to play an ogg file after one 
or several mp3 files. It didn't stop between several ogg files, or 
several mp3 files, or if it played an mp3 file after an ogg file.


After noticing that, I inserted other file types in the same playlist 
(flac and wma - I have no aac). Here are my findings :


- a flac file is played correctly after an mp3 file
- Amarok stopped if it tried to play an ogg file after a flac file, or a 
flac file after an ogg file


(note that at this point, I had to reinstall gstreamer0.10-plugins-ugly 
to play wma files)


- a wma file is played correctly after an mp3 file or an ogg file
- Amarok stopped if it tried to play an ogg file after a wma file

So, at least with the dozen files I made my tests with, the problem 
really occurs only if Amarok tries to play an ogg file after any other 
type of file, or some types of file after on ogg file (mp3, flac, but 
not wma).


I briefly tried bangarang, and it had similar problems, but with flac 
files this time. I need to test it further to give you precise results 
like the ones about Amarok.


With these new clues, it's obvious that this bugreport should at least 
be renamed.


Regards,

--
Raphaël HALIMI


--
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/5083d901.30...@gmail.com



Bug#690291: Amarok randomly stops playing sound when song automatically changes using phonon-backend-gstreamer

2012-10-21 Thread Raphaël HALIMI

I'm glad I could help :)

Regards,

--
Raphaël HALIMI


--
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/50843275.2010...@gmail.com



Bug#690294: phonon-backend-vlc breaks replaygain and fade in Amarok

2012-10-16 Thread Raphaël HALIMI

Le 13/10/2012 08:35, David Smith a écrit :

phonon-backend-vlc seems unable to manipulate the sound volume at some point;
manually changing it (with the little speaker icon near the time counter) still
works, but replaygain and fade are broken.




Can you be more specific about unable to manipulate the sound volume
at some point?


Sorry, I couldn't see how to describe this problem better : what I 
thought to be the software volume can be manipulated with Amarok's 
little speaker icon. But now, I'm not sure anymore that this icon 
represents software volume, because I just noticed that the volume 
buttons on my keyboard change both the master volume in veromix' 
plasmoid and on this little speaker icon in Amarok, which rather seems 
to represent VLC's volume in pulseaudio. Being a long-time Amarok user, 
I wrongly thought that this icon had the same function as the little 
volume slider that was at the same place in Amarok 1.



fade is not (yet) supported by VLC phonon backend for Amarok.  VLC is
simply lacking the implementation for the feature.  See here:
https://bugs.kde.org/show_bug.cgi?id=287124

Since fade is not supported by the VLC phonon backend, it's
recommended to disable fade-out in Amarok when you use the VLC phonon
backend.


I see. sorry, I didn't know. Now that you mention it, fade doesn't work 
with Gstreamer backend either (but replaygain does).



For ReplayGain, can you make sure you don't have conflicting gain
tags?  Check if your files have a replaygain_track_peak tag, and if
so, remove it.

As far as I know, Amarok itself does not calculate ReplayGain values,
you need to have a 3rd party app calculate it and store the
information in a ID3 tag.

I have just tested using mp3gain from Wheezy with the Amarok from
Wheezy and the ReplayGain feature in Amarok works fine for me here
with both the gstreamer and vlc backends.  Of course, I made sure
ReplayGain was enabled in Amarok in the menu.  If you've used older
mp3gain versions, it's very possible you could end up with conflicting
ReplayGain tags which is known to cause problems as Amarok doesn't
know which tag to use and may decide to use the wrong one (or
neither). Also, if you use a very old version of mp3gain, the tag
might get ignored by Amarok completely.


Most of my files are Ogg, but neither my MP3 files nor my Ogg files have 
any replaygain tags in them (clementine, which can use replaygain values 
stored in files as tags but can't calculate them - just as you say 
Amarok 2 does - doesn't adjust the volume either).


IIRC Amarok 1 did calculate replaygain values (either by itself or by 
calling mp3gain/vorbisgain, I'm not sure) and stored them in its config 
directory. Since replaygain works in Amarok 2 with the Gstreamer 
backend, I think Amarok 2 imported these values from Amarok 1's 
configuration during first launch.


If you think this is normal behavior, feel free to close the bug, but 
again, Amarok 2 with gstreamer backend seems to actually use those 
replaygain values, which would indicate that they were correctly 
imported from Amarok 1, and that the VLC backend indeed have a problem 
using them.


To be honest, I don't really use phonon-backend-vlc, but back then, when 
I tried both backends in order to decide which one to use, I noticed 
this behavior, and now I decided to file a bugreport only to help the 
Debian project, so I reinstalled it solely to do some tests for this 
bugreport, but normally I use phonon-backend-gstreamer, I'm just waiting 
for #690291 to be fixed.


I admit this is weird that I seem to be the only one in the Debian users 
community to have these problems with both backends : I noticed them for 
a long time, but no one ever reported them, could they both be caused by 
another tool in the chain ? pulseaudio maybe ?


If you need more info, feel free to ask.

Regards,

--
Raphaël HALIMI


--
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/507d27be.2010...@gmail.com



Bug#690291: Amarok randomly stops playing sound when song automatically changes using phonon-backend-gstreamer

2012-10-12 Thread Raphaël HALIMI
Package: phonon-backend-gstreamer
Version: 4:4.6.0.0-2
Severity: critical

When using phonon-backend-gstreamer, Amarok randomly stops playing sound at
song change. In that case, the time counter goes on for 3 seconds, then stops.

It seems completely random : it can happen at every song, or can play several
songs without stopping. Also, it occured only on automatic song change so far,
not on manual song change.

Note that only the sound output stops, all the rest of Amarok's interface is
still responsive; and sometimes, if you wait a couple of minutes or so, the
beginning of the song briefly plays for a second, and then both the sound and
the time counter abruptly jump quite precisely to where the time counter really
should be. In any case, manually changing song or position in the time counter
makes the music play again instantly.

This makes Amarok really unusable for music listening (let alone be used for a
party) thus breaking it severely as a music player. Using phonon-backend-vlc
gets rid of this problem, but it's not a satisfying workaround either, since it
have other problems : the impossibility of manipulating sound output volume -
completely breaking both replaygain and fade - and some crackling at the
beginning of playback. Both problems affect every software based on VLC (I
intend to submit another bug report about these issues if it hasn't been done
already).

Also please note that it doesn't seem to be a hardware-related problem, since
the two computers I use Amarok on (a manually assembled desktop PC, and a
Lenovo ThinkPad X200s laptop) present the same behavior.



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages phonon-backend-gstreamer depends on:
ii  gstreamer0.10-alsa   0.10.36-1
ii  gstreamer0.10-plugins-base   0.10.36-1
ii  libc62.13-35
ii  libgl1-mesa-glx [libgl1] 8.0.4-2
ii  libglib2.0-0 2.32.3-1
ii  libgstreamer-plugins-base0.10-0  0.10.36-1
ii  libgstreamer0.10-0   0.10.36-1
ii  libphonon4   4:4.6.0.0-2
ii  libqt4-opengl4:4.8.2+dfsg-2
ii  libqtcore4   4:4.8.2+dfsg-2
ii  libqtgui44:4.8.2+dfsg-2
ii  libstdc++6   4.7.1-7
ii  multiarch-support2.13-35

Versions of packages phonon-backend-gstreamer recommends:
ii  gstreamer0.10-plugins-good  0.10.31-3

Versions of packages phonon-backend-gstreamer suggests:
ii  gstreamer0.10-plugins-ugly  0.10.19-2+b2

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20121012064850.13411.63991.report...@solaris.inside.sanctuaire.net



Bug#690294: phonon-backend-vlc breaks replaygain and fade in Amarok

2012-10-12 Thread Raphaël HALIMI
Package: phonon-backend-vlc
Version: 0.6.0-1
Severity: normal

phonon-backend-vlc seems unable to manipulate the sound volume at some point;
manually changing it (with the little speaker icon near the time counter) still
works, but replaygain and fade are broken.

Sorry but I don't know how to better describe this problem. If you need more
info, please ask.



-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages phonon-backend-vlc depends on:
ii  libc62.13-35
ii  libphonon4   4:4.6.0.0-2
ii  libqtcore4   4:4.8.2+dfsg-2
ii  libqtgui44:4.8.2+dfsg-2
ii  libstdc++6   4.7.1-7
ii  libvlc5  1:2.0.3-dmo4
ii  libvlccore5  1:2.0.3-dmo4
ii  vlc-nox  1:2.0.3-dmo4

Versions of packages phonon-backend-vlc recommends:
ii  vlc  1:2.0.3-dmo4

phonon-backend-vlc suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20121012073553.16078.72956.report...@solaris.inside.sanctuaire.net



Bug#690294: phonon-backend-vlc breaks replaygain and fade in Amarok

2012-10-12 Thread Raphaël HALIMI
I downgraded (and rebooted to be sure) and this didn't change anything. 
I'm really sorry, I admit that I completely forgot to check the version 
of packages before submitting the bug report.


I downgraded putting this :

Package: *
Pin: release o=Debian
Pin-Priority: 1001

... in /etc/apt-preferences.d/pure-debian. Then, apt-get dist-upgrade 
downgraded a small bunch of packages, including some vlc-related 
packages (vlc, vlc-nox, libvlc5...).


Correct me if I'm wrong, but with these APT preferences, I shouldn't 
have anything that doesn't come from Debian; but both this bug and the 
crackling one (information I added to #644901) are still happening, so 
these bugs are not specific to dmo's version of vlc.


If there is anything else you want me to do to spot the origin of this 
bug, feel free to tell me.



Le 12/10/2012 17:40, Modestas Vainius a écrit :

Control: tags -1 unreproducible

Hello,

2012.10.12 10:35, Raphaël HALIMI rašė:

ii libc6 2.13-35
ii libphonon4 4:4.6.0.0-2
ii libqtcore4 4:4.8.2+dfsg-2
ii libqtgui4 4:4.8.2+dfsg-2
ii libstdc++6 4.7.1-7
ii libvlc5 1:2.0.3-dmo4
ii libvlccore5 1:2.0.3-dmo4
ii vlc-nox 1:2.0.3-dmo4

Versions of packages phonon-backend-vlc recommends:
ii vlc 1:2.0.3-dmo4


Please use vlc from Debian, not from deb-multimedia.org



--
Raphaël HALIMI


--
To UNSUBSCRIBE, email to debian-qt-kde-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/5078482a.6020...@gmail.com