Re: Novena open laptop
On Sun, Dec 16, 2012 at 01:58:22PM +, Ben Hutchings wrote: Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. Would anyone care to get involved in this and work out what's needed to support this in Debian? I would be willing to do this. I may be able to get funded to purchase a unit for testing. The SoC is a Freescale i.MX6Q, which should be able to run the armhf port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. I've poked at iMX 5 kernels and such, I've also worked a bit on iMX 6 so I may be able to help here as well. What type of work do you expect? Testing Debian kernels and such? Regards, Jeremiah -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217105907.GA8274@localhost.localdomain
Bug#696150: linux-image-3.2.0-4-amd64: External disk connected with FireWire can only be used read-only
Package: src:linux Version: 3.2.32-1 Severity: normal An external LaCie hard disk, connected with FireWire, can only be used read-only with this kernel. The same was true for the kernel linux-image-2.6.39-2-amd64. With the exact same external disk and machine, and the kernel linux-image-2.6.32-5-amd64, everything is fine. If the disk is mounted read-only, then it can be accessed without problem with the three kernels. If the disk is mounted read-write, and if I try to save a big file on it (big does not mean huge, a file of a few megabytes is enough), then the disk stops working, although fsck will not report any error afterwards. A typical log of this crash with dmesg is: [ 675.012302] scsi6 : SBP-2 IEEE-1394 [ 675.012397] firewire_core: created device fw1: GUID 00d04ba116053366, S800, 5 config ROM retries [ 675.012403] firewire_core: phy config: card 0, new root=ffc0, gap_count=5 [ 675.654321] firewire_sbp2: fw1.0: logged in to LUN (0 retries) [ 675.661487] scsi 6:0:0:0: Direct-Access LaCieHardDrive Quadra PQ: 0 ANSI: 4 [ 675.661987] sd 6:0:0:0: Attached scsi generic sg2 type 0 [ 675.667031] sd 6:0:0:0: [sdb] 3907029168 512-byte logical blocks: (2.00 TB/1.81 TiB) [ 675.670317] sd 6:0:0:0: [sdb] Write Protect is off [ 675.670322] sd 6:0:0:0: [sdb] Mode Sense: 10 00 00 00 [ 675.672493] sd 6:0:0:0: [sdb] Cache data unavailable [ 675.672497] sd 6:0:0:0: [sdb] Assuming drive cache: write through [ 675.682144] sd 6:0:0:0: [sdb] Cache data unavailable [ 675.682148] sd 6:0:0:0: [sdb] Assuming drive cache: write through [ 675.689498] sdb: sdb1 sdb2 [ 675.722316] sd 6:0:0:0: [sdb] Cache data unavailable [ 675.722321] sd 6:0:0:0: [sdb] Assuming drive cache: write through [ 675.722329] sd 6:0:0:0: [sdb] Attached SCSI disk [ 756.534370] kjournald starting. Commit interval 5 seconds [ 756.534795] EXT3-fs (sdb2): mounted filesystem with ordered data mode [ 783.750569] kjournald starting. Commit interval 5 seconds [ 783.75] EXT3-fs (sdb2): warning: checktime reached, running e2fsck is recommended [ 783.751919] EXT3-fs (sdb2): using internal journal [ 783.751924] EXT3-fs (sdb2): mounted filesystem with ordered data mode [ 1070.825582] sd 6:0:0:0: [sdb] Unhandled error code [ 1070.825586] sd 6:0:0:0: [sdb] Result: hostbyte=DID_BUS_BUSY driverbyte=DRIVER_OK [ 1070.825591] sd 6:0:0:0: [sdb] CDB: Write(10): 2a 00 c3 cb 36 1a 00 04 00 00 [ 1070.825602] end_request: I/O error, dev sdb, sector 3284874778 [ 1070.825607] Buffer I/O error on device sdb2, logical block 407986736 [ 1070.825610] lost page write due to I/O error on sdb2 [ 1070.825615] Buffer I/O error on device sdb2, logical block 407986737 [ 1070.825618] lost page write due to I/O error on sdb2 [ 1070.825621] Buffer I/O error on device sdb2, logical block 407986738 [ 1070.825624] lost page write due to I/O error on sdb2 [ 1070.825633] Buffer I/O error on device sdb2, logical block 407986739 [ 1070.825635] lost page write due to I/O error on sdb2 [ 1070.825637] Buffer I/O error on device sdb2, logical block 407986740 [ 1070.825639] lost page write due to I/O error on sdb2 [ 1070.825641] Buffer I/O error on device sdb2, logical block 407986741 [ 1070.825643] lost page write due to I/O error on sdb2 [ 1070.825645] Buffer I/O error on device sdb2, logical block 407986742 [ 1070.825647] lost page write due to I/O error on sdb2 [ 1070.825650] Buffer I/O error on device sdb2, logical block 407986743 [ 1070.825651] lost page write due to I/O error on sdb2 [ 1070.825654] Buffer I/O error on device sdb2, logical block 407986744 [ 1070.825656] lost page write due to I/O error on sdb2 [ 1070.825658] Buffer I/O error on device sdb2, logical block 407986745 [ 1070.825660] lost page write due to I/O error on sdb2 [ 1074.883780] sd 6:0:0:0: [sdb] Unhandled error code [ 1074.883784] sd 6:0:0:0: [sdb] Result: hostbyte=DID_BUS_BUSY driverbyte=DRIVER_OK [ 1074.883789] sd 6:0:0:0: [sdb] CDB: Write(10): 2a 00 c3 c9 01 8a 00 04 00 00 [ 1074.883800] end_request: I/O error, dev sdb, sector 3284730250 [ 1080.694026] JBD: Detected IO errors while flushing file data on sdb2 -- Package-specific info: ** Version: Linux version 3.2.0-4-amd64 (debian-kernel@lists.debian.org) (gcc version 4.6.3 (Debian 4.6.3-12) ) #1 SMP Debian 3.2.32-1 ** Command line: BOOT_IMAGE=Linux-3.2.0-4 ro root=/dev/mapper/lvmvg-root quiet loglevel=3 single ** Tainted: PO (4097) * Proprietary module has been loaded. * Out-of-tree module has been loaded. ** Kernel log: [4.012042] usb 4-1.3: New USB device strings: Mfr=0, Product=0, SerialNumber=0 [5.326082] udevd[394]: starting version 175 [6.226672] input: Lid Switch as /devices/LNXSYSTM:00/device:00/PNP0C0D:00/input/input0 [6.226728] ACPI: Lid Switch [LID0] [6.226797] input: Power Button as /devices/LNXSYSTM:00/device:00/PNP0C0C:00/input/input1 [6.226803] ACPI: Power Button [PWRB] [6.226870] input: Sleep Button as
Re: Novena open laptop
Ben Hutchings b...@decadent.org.uk writes: Hi, Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. I've seen theses pages but from what I understand, it's still in early stages, right ? Would anyone care to get involved in this and work out what's needed to support this in Debian? well, there's still a possibility that some components change over the time. At least, we can look at the files on the wiki for the current list. As concerns the imx6, on recent enough kernels, I think most of the support is there but for the IPU(v3) part, we may run into troubles if there's a controller between the screen and the SoC (I've not yet look at the components/schematics). The SoC is a Freescale i.MX6Q, which should be able to run the armhf imx6q or dual lite according to them, which is a little weird, as they're talking of sata and there's no sata on dual lite. port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. It can be added into the mx5 flavour but as it's DT-only in the kernel, it should rather be part of a multiplatform kernel flavour. It's on my todo list but I was mainly waiting 3.7 to see how it goes. Arnaud -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/8738z5dk1f@lebrac.rtp-net.org
Re: Novena open laptop
On Mon, 2012-12-17 at 11:56 +0100, Arnaud Patard wrote: Ben Hutchings b...@decadent.org.uk writes: Hi, Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. I've seen theses pages but from what I understand, it's still in early stages, right ? Yes. Would anyone care to get involved in this and work out what's needed to support this in Debian? well, there's still a possibility that some components change over the time. At least, we can look at the files on the wiki for the current list. As concerns the imx6, on recent enough kernels, I think most of the support is there but for the IPU(v3) part, we may run into troubles if there's a controller between the screen and the SoC (I've not yet look at the components/schematics). The SoC is a Freescale i.MX6Q, which should be able to run the armhf imx6q or dual lite according to them, which is a little weird, as they're talking of sata and there's no sata on dual lite. Well there are other ways to attach storage. port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. It can be added into the mx5 flavour but as it's DT-only in the kernel, it should rather be part of a multiplatform kernel flavour. It's on my todo list but I was mainly waiting 3.7 to see how it goes. It would be great if we could get all or armhf using DT and just provide UP and SMP flavours (and then maybe add RT if people are interested). Ben. -- Ben Hutchings Life is like a sewer: what you get out of it depends on what you put into it. signature.asc Description: This is a digitally signed message part
Re: Novena open laptop
On Mon, 2012-12-17 at 11:59 +0100, Jeremiah C. Foster wrote: On Sun, Dec 16, 2012 at 01:58:22PM +, Ben Hutchings wrote: Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. Would anyone care to get involved in this and work out what's needed to support this in Debian? I would be willing to do this. I may be able to get funded to purchase a unit for testing. It may be a bit early for that. The SoC is a Freescale i.MX6Q, which should be able to run the armhf port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. I've poked at iMX 5 kernels and such, I've also worked a bit on iMX 6 so I may be able to help here as well. What type of work do you expect? Testing Debian kernels and such? Talk to them and find out how where they are with software, what Debian porters and maintainers could do to help them. I assume they will be able to get any necessary kernel changes upstream themselves, but if they have trouble with that then some of us might be able to help. Ben. -- Ben Hutchings Life is like a sewer: what you get out of it depends on what you put into it. signature.asc Description: This is a digitally signed message part
Re: Novena open laptop
Ben Hutchings b...@decadent.org.uk writes: [...] The SoC is a Freescale i.MX6Q, which should be able to run the armhf imx6q or dual lite according to them, which is a little weird, as they're talking of sata and there's no sata on dual lite. Well there are other ways to attach storage. what would be the point of using an extra pci* / usb sata bridge while you can get one for free ? [ if they want dualcore, they could have used the imx6 dual, which does have sata ]. port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. It can be added into the mx5 flavour but as it's DT-only in the kernel, it should rather be part of a multiplatform kernel flavour. It's on my todo list but I was mainly waiting 3.7 to see how it goes. It would be great if we could get all or armhf using DT and just provide UP and SMP flavours (and then maybe add RT if people are interested). I'm not sure that all armhf boards have been converted atm (at least on imx side), so I guess we'll have to keep the actual flavours until they've all been converted. Oh, and while we're at counting flavours, we may even need at least one more for LPAE. Arnaud -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87wqwgbw2p@lebrac.rtp-net.org
Re: Novena open laptop
Ben Hutchings b...@decadent.org.uk writes: Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. I'm very interested in this chipset and may have access to a prototype of the Novena in late January for a couple days. I'd like to do what I can to help get Debian running on it in a headless no-blob configuration, or at least document any problems (assuming the hardware team hasn't already finished the work at that point). I'm not subscribed to debian-kernel@, but will post what I learn here. --bryan bnewbold at robocracy dot org -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.deb.2.02.1212171522280.23...@ziggy.robocracy.org
Re: Novena open laptop
On Mon, Dec 17, 2012 at 03:19:10PM +0100, Arnaud Patard wrote: Ben Hutchings b...@decadent.org.uk writes: [...] The SoC is a Freescale i.MX6Q, which should be able to run the armhf imx6q or dual lite according to them, which is a little weird, as they're talking of sata and there's no sata on dual lite. Well there are other ways to attach storage. what would be the point of using an extra pci* / usb sata bridge while you can get one for free ? [ if they want dualcore, they could have used the imx6 dual, which does have sata ]. I was thinking about the built-in SD and USB non-SATA devices. Obviously for a typical laptop you would want built-in SATA. port. We currently have an mx5 kernel flavour for Freescale's previous generation, but it looks like it would be possible to support both with a single configuration (plus DT) now. It can be added into the mx5 flavour but as it's DT-only in the kernel, it should rather be part of a multiplatform kernel flavour. It's on my todo list but I was mainly waiting 3.7 to see how it goes. It would be great if we could get all or armhf using DT and just provide UP and SMP flavours (and then maybe add RT if people are interested). I'm not sure that all armhf boards have been converted atm (at least on imx side), so I guess we'll have to keep the actual flavours until they've all been converted. Oh, and while we're at counting flavours, we may even need at least one more for LPAE. Oh yes, forgot that one. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217155803.gn13...@decadent.org.uk
Re: Novena open laptop
On Mon, Dec 17, 2012 at 03:30:16PM +0100, bnewb...@robocracy.org wrote: Ben Hutchings b...@decadent.org.uk writes: Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. I'm very interested in this chipset and may have access to a prototype of the Novena in late January for a couple days. I'd like to do what I can to help get Debian running on it in a headless no-blob configuration, or at least document any problems (assuming the hardware team hasn't already finished the work at that point). Is the GPU blob needed even for setting up a dumb framebuffer and display generators, or is it only needed for accelerated rendering by the GPU? Ben. I'm not subscribed to debian-kernel@, but will post what I learn here. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217160421.go13...@decadent.org.uk
Re: Novena open laptop
Ben Hutchings b...@decadent.org.uk writes: On Mon, Dec 17, 2012 at 03:30:16PM +0100, bnewb...@robocracy.org wrote: Ben Hutchings b...@decadent.org.uk writes: Bunnie Huang and others are working on a ARM-based laptop 'Novena' with open hardware and mostly open firmware: http://www.bunniestudios.com/blog/?p=2686, http://www.kosagi.com/w/index.php?title=Novena_Main_Page. I'm very interested in this chipset and may have access to a prototype of the Novena in late January for a couple days. I'd like to do what I can to help get Debian running on it in a headless no-blob configuration, or at least document any problems (assuming the hardware team hasn't already finished the work at that point). Is the GPU blob needed even for setting up a dumb framebuffer and display generators, or is it only needed for accelerated rendering by the GPU? I don't have a imx6 but my imx51/53 can run framebuffer (but no acceleration) without any blob and imx6 should work in a same way afaik. That's handled by the imx-drm IPUv3 driver in staging. Arnaud -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87hankbqvm@lebrac.rtp-net.org
[bts-link] source package linux-2.6
# # bts-link upstream status pull for source package linux-2.6 # see http://lists.debian.org/debian-devel-announce/2006/05/msg1.html # user bts-link-upstr...@lists.alioth.debian.org # remote status report for #627372 (http://bugs.debian.org/627372) # Bug title: linux-image-2.6.38-2-686: Console turns black during boot # * https://bugs.freedesktop.org/show_bug.cgi?id=44156 # * remote status changed: ASSIGNED - NEEDINFO usertags 627372 - status-ASSIGNED usertags 627372 + status-NEEDINFO # remote status report for #627372 (http://bugs.debian.org/627372) # Bug title: linux-image-2.6.38-2-686: Console turns black during boot # * https://bugs.freedesktop.org/show_bug.cgi?id=44156 # * remote status changed: ASSIGNED - NEEDINFO usertags 627372 - status-ASSIGNED usertags 627372 + status-NEEDINFO thanks -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217164018.23979.96433.btsl...@sonntag.debian.org
Bug#677472: [3.1-3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51
On Thu, 13 Dec 2012 00:45:05 -0800, Lan Tianyu tianyu@intel.com
wrote:
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f034716..9335f1b 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2509,7 +2509,8 @@ int usb_add_hcd(struct usb_hcd *hcd,
* they only forward requests from the root hub. Therefore
* controllers should always be enabled for remote wakeup.
*/
- device_wakeup_enable(hcd-self.controller);
+ if (!usb_hcd_wakeup_quirks(hcd-self.controller))
+ device_wakeup_enable(hcd-self.controller);
return retval;
error_create_attr_group:
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index fdefd9c..ba847d3 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -12,6 +12,7 @@
*/
#include linux/usb.h
+#include linux/pci.h
#include linux/usb/quirks.h
#include usb.h
@@ -226,3 +227,33 @@ void usb_detect_interface_quirks(struct usb_device
*udev)
quirks);
udev-quirks |= quirks;
}
+
+struct pci_hcd {
+ u32 vendor;
+ u32 device;
+};
+
+static struct pci_hcd hcd_wakeup_qrk[] = {
+ {PCI_VENDOR_ID_NVIDIA, 0x026d}, /* MCP51 OHCI */
+ {PCI_VENDOR_ID_NVIDIA, 0x0aa5}, /* MCP79 OHCI */
+ {PCI_VENDOR_ID_NVIDIA, 0x0aa7}, /* MCP79 OHCI */
+ { }
+};
+
+int usb_hcd_wakeup_quirks(struct device *dev)
+{
+ struct pci_dev *pdev;
+ int i;
+
+ if (dev-bus != (struct bus_type *)pci_bus_type)
+ return 0;
+
+ pdev = to_pci_dev(dev);
+ for (i = 0; hcd_wakeup_qrk[i].vendor || hcd_wakeup_qrk[i].device; i++)
+ if ((hcd_wakeup_qrk[i].vendor == pdev-vendor)
+ (hcd_wakeup_qrk[i].device == pdev-device)) {
+ return 1;
+ }
+
+ return 0;
+}
I would informing the user via dmesg output about the applied quirk
and a point him to relevant documentation. Something like this:
Detected OHCI controller ID :, which requires no-wakeup quirk.
See Documentation/quirks/ohci-no-wakeup.txt
--
Octavio.
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/op.wpg0f4q36g6bxc@alvarezp-samsung
Bug#696182: linux-image-3.2.0-4-versatile: Module i2c-versatile is missing
Package: src:linux Version: 3.2.32-1 Severity: normal Per subject. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217170729.5959.32735.reportbug@debian
Bug#696059: linux: PATCH required for server interrupt load balancing/irqbalance (tested)
On Sun, 16 Dec 2012, Ben Hutchings wrote: On Sun, 2012-12-16 at 11:24 -0200, Henrique de Moraes Holschuh wrote: Package: linux Version: 3.2.35-1 Severity: important Tags: patch Please include the attached patch in Wheezy, without it, irqbalance fails to do its job properly on any server (actually any multi-core system with MSI/MSI-X irqs). It is important to have irqbalance work properly out-of-the-box, since it is the only trivial way to get better network/storage behaviour out of the MSI-X capable NUMA systems that are 95% of the post-2010 server market. Would be nice, but it has been broken for so long that 'everyone knows' to disable irqbalance. Yeah, and nobody knows how to use hwloc either, so they probably leave it at whatever the kernel/BIOS/EFI default mapping is. And since the kernel doesn't irqbalance by itself anymore, it will either be round-robin if you're lucky, or all-in-the-first-core if you're unlucky... I've tested the attached patch on stock (kernel.org) 3.2.34 on production, and it works fine. The patch is very simple, it just publishes the MSI IRQ vector information to sysfs, which irqbalance uses. Changes ABI, so will have to wait if we apply it at all. It is a new ABI, actually, so it has no ill effects on existing applications. And this new ABI is already stable, too. git commit upstream: b50cac55bf859d5b2fdcc1803a553a251b703456 Alternatively, we might want to add it to -stable series upstream, on the grounds that it is widely desired functionality (i.e. useful for all distros). This doesn't suddenly become urgent because you just noticed it. I don't recall claiming for urgency anywhere, unless you mean the request that it should be added to the Wheezy kernel. -- One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie. -- The Silicon Valley Tarot Henrique Holschuh -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20121217183738.gb32...@khazad-dum.debian.net
Bug#677472: [3.1-3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51
On Mon, 17 Dec 2012, Octavio Alvarez wrote:
On Thu, 13 Dec 2012 00:45:05 -0800, Lan Tianyu tianyu@intel.com
wrote:
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f034716..9335f1b 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2509,7 +2509,8 @@ int usb_add_hcd(struct usb_hcd *hcd,
* they only forward requests from the root hub. Therefore
* controllers should always be enabled for remote wakeup.
*/
- device_wakeup_enable(hcd-self.controller);
+ if (!usb_hcd_wakeup_quirks(hcd-self.controller))
+ device_wakeup_enable(hcd-self.controller);
return retval;
error_create_attr_group:
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index fdefd9c..ba847d3 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -12,6 +12,7 @@
*/
#include linux/usb.h
+#include linux/pci.h
#include linux/usb/quirks.h
#include usb.h
@@ -226,3 +227,33 @@ void usb_detect_interface_quirks(struct usb_device
*udev)
quirks);
udev-quirks |= quirks;
}
+
+struct pci_hcd {
+ u32 vendor;
+ u32 device;
+};
+
+static struct pci_hcd hcd_wakeup_qrk[] = {
+ {PCI_VENDOR_ID_NVIDIA, 0x026d}, /* MCP51 OHCI */
+ {PCI_VENDOR_ID_NVIDIA, 0x0aa5}, /* MCP79 OHCI */
+ {PCI_VENDOR_ID_NVIDIA, 0x0aa7}, /* MCP79 OHCI */
+ { }
+};
+
+int usb_hcd_wakeup_quirks(struct device *dev)
+{
+ struct pci_dev *pdev;
+ int i;
+
+ if (dev-bus != (struct bus_type *)pci_bus_type)
+ return 0;
+
+ pdev = to_pci_dev(dev);
+ for (i = 0; hcd_wakeup_qrk[i].vendor || hcd_wakeup_qrk[i].device; i++)
+ if ((hcd_wakeup_qrk[i].vendor == pdev-vendor)
+ (hcd_wakeup_qrk[i].device == pdev-device)) {
+ return 1;
+ }
+
+ return 0;
+}
I would informing the user via dmesg output about the applied quirk
and a point him to relevant documentation. Something like this:
Detected OHCI controller ID :, which requires no-wakeup quirk.
See Documentation/quirks/ohci-no-wakeup.txt
Incidentally, this patch should be written differently. Instead of a
quirks routine, there should simply be a bad_wakeup bitflag added to
the usb_hcd structure. The flag should be set in ohci-pci.c by
matching against nVidia's PCI vendor ID.
Alan Stern
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/pine.lnx.4.44l0.1212171500020.1409-100...@iolanthe.rowland.org
