Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset
Dear Linux folks, Unfortunately, commit 2fee61d22e (i2c: piix4: Add support for multiplexed main adapter in SB800) [1] caused a regression. Tim reported that to the Linux Kernel Bugtracker as bug #170741 last September [2], but it looks like the affected subsystems don’t use it. So I just copy his report in here, and put all the people in CC mentioned in the commit, the bug report, and in the subsystems I2C/SMBUS CONTROLLER DRIVERS FOR PC and WATCHDOG DEVICE DRIVERS mentioned in the file `MAINTAINERS`. > On the AMD Turion N40L and other related SoCs, the i2c-piix4 driver > now claims the 0xcd6 ioport, preventing the sp5100_tco watchdog > driver from loading: > > piix4_smbus :00:14.0: SMBus Host Controller at 0xb00, revision 0 > piix4_smbus :00:14.0: Using register 0x2c for SMBus port selection > piix4_smbus :00:14.0: Auxiliary SMBus Host Controller at 0xb20 > sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver v0.05 > sp5100_tco: PCI Vendor ID: 0x1002, Device ID: 0x4385, Revision ID: 0x42 > sp5100_tco: I/O address 0x0cd6 already in use > > > This breaks watchdog operation on existing systems on upgrade and new > deployments unless the i2c-piix4 driver is blacklisted. > > See: > > drivers/watchdog/sp5100_tco.c > > tco_timer_enable(void) > > (SB800_IO_PM_INDEX_REG is defined in drivers/watchdog/sp5100_tco.h) > > This is the commit which prevents the watchdog driver from loading: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2fee61d22e606fc99ade9079fda15fdee83ec33e > > See also AMD docs > > 45483_sb800_bdg_pub_3.03 > > Perhaps a fix is to switch both drivers from static to dynamic > allocation of the IO ports in question, since the watchdog driver > only accesses the port during initialisation (with backoff/retry > maybe to avoid races?). Is there somebody having the resources to implement the dynamic allocation to solve this regression? Thanks, Paul [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2fee61d22e606fc99ade9079fda15fdee83ec33e [2] https://bugzilla.kernel.org/show_bug.cgi?id=170741 signature.asc Description: This is a digitally signed message part
Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset
> Unfortunately, commit 2fee61d22e (i2c: piix4: Add support for > multiplexed main adapter in SB800) [1] caused a regression. Tim > reported that to the Linux Kernel Bugtracker as bug #170741 last > September [2], but it looks like the affected subsystems don’t use it. Jean Delvare pointed out this issue amongst others[1] last year already. Let me quote: === 5* The I/O ports used for SMBus configuration and port switching are also needed by a watchdog driver, sp5100_tco. Both drivers request the region, so the first one wins, and the other driver can't be loaded. sp5100_tco was there first, so the changes done to the i2c-piix4 driver recently will cause a regression for some users by preventing them from using the sp5100_tco and i2c-piix4 drivers at the same time. In the long run I guess we will need a helper module to handle this shared resource. Unless IORESOURCE_MUXED can be used for that. Either way, that's more work than I can put into this before kernel v4.5 is released. For the time being, I think we should simply make it non-fatal if the I/O ports can't be requested, and continue without multiplexing (as before.) === Seems nobody had the resources, so far. I don't have the HW and not much experience with non-embedded platforms. I wonder, though, if we really need to convert the drivers to MFD ones, or if we could use the simpler MFD_SYSCON mechanism which helps in exactly such cases for embedded platforms. But I am really lacking details here and am afraid this is probably all the input I can give currently. Regards, Wolfram [1] http://www.spinics.net/lists/linux-i2c/msg23437.html signature.asc Description: PGP signature
Re: linux_4.9.13-1~bpo8+1_amd64.changes is NEW
> > If you have any questions, you may reply to this email. > Is there a new linux-latest for bpo8 as well? Regards Harri
Processed: Re: module hpsa no longer detects MSL2024 tape changer
Processing control commands: > fixed -1 4.9.2-2~bpo8+1 Bug #767389 [src:linux] linux-image-3.16-0.bpo.2-amd64 module hpsa does not recognize /dev/changer Marked as fixed in versions linux/4.9.2-2~bpo8+1. -- 767389: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767389 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#767389: module hpsa no longer detects MSL2024 tape changer
control: fixed -1 4.9.2-2~bpo8+1 I confirm that the latest kernel in jessie-backports does not suffer from this problem. Am building a patched 3.16.39 (it compiles OK) but won't be able to test it until the next maintenance window for the affected system.
Re: linux_4.9.13-1~bpo8+1_amd64.changes is NEW
On Fri, 2017-03-03 at 13:17 +0100, Harald Dunkel wrote: > > > > If you have any questions, you may reply to this email. > > > > Is there a new linux-latest for bpo8 as well? linux is still in NEW for all other architectures, and linux-latest and linux-signed are waiting for that. Ben. -- Ben Hutchings Hoare's Law of Large Problems: Inside every large problem is a small problem struggling to get out. signature.asc Description: This is a digitally signed message part
Re: linux_4.9.13-1~bpo8+1_amd64.changes is NEW
On Fri, 2017-03-03 at 15:54 +, Ben Hutchings wrote: > On Fri, 2017-03-03 at 13:17 +0100, Harald Dunkel wrote: > > > > > > If you have any questions, you may reply to this email. > > > > > > > Is there a new linux-latest for bpo8 as well? > > linux is still in NEW for all other architectures, and linux-latest and > linux-signed are waiting for that. Actually, it just got accepted, so the other two can be uploaded. Ben. -- Ben Hutchings Hoare's Law of Large Problems: Inside every large problem is a small problem struggling to get out. signature.asc Description: This is a digitally signed message part
Processing of linux-signed_4.3~bpo8+1_multi.changes
linux-signed_4.3~bpo8+1_multi.changes uploaded successfully to localhost along with the files: linux-signed_4.3~bpo8+1.dsc linux-signed_4.3~bpo8+1.tar.xz linux-signed_4.3~bpo8+1_source.buildinfo linux-image-4.9.0-0.bpo.2-amd64_4.9.13-1~bpo8+1_amd64.deb linux-image-4.9.0-0.bpo.2-rt-amd64_4.9.13-1~bpo8+1_amd64.deb kernel-image-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nic-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nic-wireless-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nic-shared-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb serial-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb usb-serial-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb ppp-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb pata-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb cdrom-core-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb firewire-core-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb scsi-core-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb scsi-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb loop-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb btrfs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb ext4-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb isofs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb jfs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb ntfs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb xfs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb fat-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb md-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb multipath-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb usb-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb usb-storage-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb pcmcia-storage-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb fb-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb input-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb event-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb mouse-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nic-pcmcia-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb pcmcia-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nic-usb-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb sata-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb acpi-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb i2c-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb crc-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb crypto-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb crypto-dm-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb efi-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb ata-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb mmc-core-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb mmc-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb nbd-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb squashfs-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb speakup-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb virtio-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb uinput-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb sound-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb hyperv-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb udf-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb fuse-modules-4.9.0-0.bpo.2-amd64-di_4.9.13-1~bpo8+1_amd64.udeb Greetings, Your Debian queue daemon (running on host usper.debian.org)
linux-signed_4.3~bpo8+1_multi.changes is NEW
binary:acpi-modules-4.9.0-0.bpo.2-686-di is NEW. binary:acpi-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:acpi-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:affs-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:affs-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-686-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:ata-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-686-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:btrfs-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-686-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:cdrom-core-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-686-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:crc-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-686-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:crypto-dm-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-686-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:crypto-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:dasd-extra-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:dasd-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:efi-modules-4.9.0-0.bpo.2-686-di is NEW. binary:efi-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:efi-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:efi-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:efi-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:event-modules-4.9.0-0.bpo.2-686-di is NEW. binary:event-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:event-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:event-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:event-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:event-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:event-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:event-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-686-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:ext4-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:fancontrol-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:fancontrol-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-686-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-amd64-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-arm64-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-armmp-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-powerpc-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-powerpc64-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-powerpc64le-di is NEW. binary:fat-modules-4.9.0-0.bpo.2-s390x-di is NEW. binary:fb-modules-4.9.0-0.bpo.2-686-di is NEW. binary:fb-modules-4.9.0-0.bpo.2-686-pae-di is NEW. binary:fb-modules-4.9.0-0.b
Processed: Re: Bug#856474: stap: include runtime_defines.h not found
Processing control commands: > reassign -1 linux Bug #856474 [systemtap] stap: include runtime_defines.h not found Bug reassigned from package 'systemtap' to 'linux'. No longer marked as found in versions systemtap/3.0-7. Ignoring request to alter fixed versions of bug #856474 to the same values previously set -- 856474: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856474 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: reassign 856474 to src:linux, severity of 856474 is important, affects 856474
Processing commands for cont...@bugs.debian.org: > reassign 856474 src:linux 4.9.13-1 Bug #856474 [linux] stap: include runtime_defines.h not found Bug reassigned from package 'linux' to 'src:linux'. Ignoring request to alter found versions of bug #856474 to the same values previously set Ignoring request to alter fixed versions of bug #856474 to the same values previously set Bug #856474 [src:linux] stap: include runtime_defines.h not found Marked as found in versions linux/4.9.13-1. > severity 856474 important Bug #856474 [src:linux] stap: include runtime_defines.h not found Severity set to 'important' from 'grave' > affects 856474 systemtap Bug #856474 [src:linux] stap: include runtime_defines.h not found Added indication that 856474 affects systemtap > thanks Stopping processing here. Please contact me if you need assistance. -- 856474: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856474 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#856474: stap: include runtime_defines.h not found
I modified systemtap buildrun.cxx so that the Makefile it produces during Pass 3 doesn't have quotes around the include path, i.e.: Before: EXTRA_CFLAGS += -I"/usr/share/systemtap/runtime" After: EXTRA_CFLAGS += -I/usr/share/systemtap/runtime Then stap works fine against the Debian kernel, running 4.10-1~exp1 at the moment. I cannot fathom how Debian's linux-headers packages would affect this argument, but for the record, here's systemtap running gcc in Pass 3, elided: gcc-6 ... -I/usr/src/linux-headers-4.10.0-trunk-common/"/usr/share/systemtap/runtime" ... And with buildrun.cxx modified so that quotations are removed from the Makefile: gcc-6 ... -I/usr/share/systemtap/runtime ... How is /usr/src/linux-headers-4.10.0-trunk-common/ getting interpolated into that path argument? Attached a Makefile produced by stap - maybe somebody could guess why that interpolation occurs at line 125? Apologies if I'm adding more noise than signal to the bug report. Frank Ch. Eigler already addressed the quotation issue earlier in this bug report. -- Gerald Turner Encrypted mail preferred! OpenPGP: 4096R / CA89 B27A 30FA 66C5 1B80 3858 EC94 2276 FDB8 716D --- systemtap-3.1.orig/buildrun.cxx +++ systemtap-3.1/buildrun.cxx @@ -495,7 +495,7 @@ compile_pass (systemtap_session& s) #if CHECK_POINTER_ARITH_PR5947 o << "EXTRA_CFLAGS += -Wpointer-arith" << endl; #endif - o << "EXTRA_CFLAGS += -I\"" << s.runtime_path << "\"" << endl; + o << "EXTRA_CFLAGS += -I" << s.runtime_path << endl; // XXX: this may help ppc toc overflow // o << "CFLAGS := $(subst -Os,-O2,$(CFLAGS)) -fminimal-toc" << endl; o << "obj-m := " << s.module_name << ".o" << endl; _KBUILD_CFLAGS := $(call flags,KBUILD_CFLAGS) stap_check_gcc = $(shell set -x; if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi) CHECK_BUILD := $(CC) $(NOSTDINC_FLAGS) $(KBUILD_CPPFLAGS) $(CPPFLAGS) $(LINUXINCLUDE) $(_KBUILD_CFLAGS) $(CFLAGS_KERNEL) $(EXTRA_CFLAGS) $(CFLAGS) -DKBUILD_BASENAME=\"stap_1008\" -Werror -S -o /dev/null -xc stap_check_build = $(shell set -x; if $(CHECK_BUILD) $(1) > /dev/null 2>&1 ; then echo "$(2)"; else echo "$(3)"; fi) SYSTEMTAP_RUNTIME = "/usr/share/systemtap/runtime" CONFIG_MODULE_SIG := n EXTRA_CFLAGS := EXTRA_CFLAGS += -Iinclude2/asm/mach-default EXTRA_CFLAGS += -I/lib/modules/4.10.0-trunk-amd64/build STAPCONF_HEADER := /tmp/stapmZGYID/stapconf_0c48b85f89be3e4d6b5ccca7b814cb38_755.h $(STAPCONF_HEADER): @> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-hrtimer-rel.c > /dev/null 2>&1; then echo "#define STAPCONF_HRTIMER_REL 1"; fi >> $@ >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-generated-compile.c > /dev/null 2>&1; then echo "#define STAPCONF_GENERATED_COMPILE 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-hrtimer-getset-expires.c > /dev/null 2>&1; then echo "#define STAPCONF_HRTIMER_GETSET_EXPIRES 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-inode-private.c > /dev/null 2>&1; then echo "#define STAPCONF_INODE_PRIVATE 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-inode-rwsem.c > /dev/null 2>&1; then echo "#define STAPCONF_INODE_RWSEM 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-constant-tsc.c > /dev/null 2>&1; then echo "#define STAPCONF_CONSTANT_TSC 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-ktime-get-real.c > /dev/null 2>&1; then echo "#define STAPCONF_KTIME_GET_REAL 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-x86-uniregs.c > /dev/null 2>&1; then echo "#define STAPCONF_X86_UNIREGS 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-nameidata.c > /dev/null 2>&1; then echo "#define STAPCONF_NAMEIDATA_CLEANUP 1"; fi >> $@ echo "#define STAPCONF_UNREGISTER_KPROBES 1">> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-kprobe-symbol-name.c > /dev/null 2>&1; then echo "#define STAPCONF_KPROBE_SYMBOL_NAME 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-real-parent.c > /dev/null 2>&1; then echo "#define STAPCONF_REAL_PARENT 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-uaccess.c > /dev/null 2>&1; then echo "#define STAPCONF_LINUX_UACCESS_H 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-oneachcpu-retry.c > /dev/null 2>&1; then echo "#define STAPCONF_ONEACHCPU_RETRY 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-dpath-path.c > /dev/null 2>&1; then echo "#define STAPCONF_DPATH_PATH 1"; fi >> $@ >> $@ >> $@ echo "#define STAPCONF_SYNCHRONIZE_SCHED 1">> $@ if $(CHECK_BUILD) $(SYSTEMTAP_RUNTIME)/linux/autoconf-task-uid.c > /dev/null 2>&1; then echo "#define STAPCONF_TASK_UID 1"; fi >> $@ if $(CHECK_BUILD) $(SYSTEMTA
Processed: Re: initramfs-tools: mkinitramfs fails to run on systems with tmpfs on /
Processing commands for cont...@bugs.debian.org: > tags 856589 + patch Bug #856589 [initramfs-tools] initramfs-tools: mkinitramfs fails to run on systems with tmpfs on / Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 856589: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856589 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#856589: initramfs-tools: mkinitramfs fails to run on systems with tmpfs on /
tags 856589 + patch
thanks
The solution is quite simple: Just return from dep_add_modules_mount()
when tmpfs is detected as fstype. A tested patch is attached.
--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Email: benjamin.dr...@profitbricks.com
URL: http://www.profitbricks.com
Sitz der Gesellschaft: Berlin.
Registergericht: Amtsgericht Charlottenburg, HRB 125506B.
Geschäftsführer: Andreas Gauger, Achim Weiss.From 7b6c9871e04e4d2304b99b14fe313d7b4ab35698 Mon Sep 17 00:00:00 2001
From: Benjamin Drung
Date: Fri, 3 Mar 2017 17:08:38 +0100
Subject: [PATCH] Fix failure when / uses tmpfs
When initramfs-tools is run on a system with a tmpfs based root mount
point, it will fail:
root@host:~$ /etc/kernel/postinst.d/kdump-tools $(uname -r)
kdump-tools: Generating /var/lib/kdump/initrd.img-4.4.36-2
mkinitramfs: failed to determine device for /
mkinitramfs: workaround is MODULES=most, check:
grep -r MODULES /etc/initramfs-tools/
Error please report bug on initramfs-tools
Include the output of 'mount' and 'cat /proc/mounts'
update-initramfs: failed for with 1.
Bug-Debian: #856589
---
hook-functions | 5 +
1 file changed, 5 insertions(+)
diff --git a/hook-functions b/hook-functions
index fa6862f..3fc6c5b 100644
--- a/hook-functions
+++ b/hook-functions
@@ -297,6 +297,11 @@ dep_add_modules_mount()
return
fi
+ # Handle tmpfs which uses memory instead of a block devices.
+ if [ "${FSTYPE}" = "tmpfs" ]; then
+ return
+ fi
+
if [ "$dir" = / ] && [ "${dev_node}" = "/dev/root" ] ; then
if [ -b "${dev_node}" ]; then
# Match it to the canonical device name by UUID
--
2.9.3
Bug#856474: stap: include runtime_defines.h not found
Control: tag -1 upstream patch On Fri, 03 Mar 2017 23:10:56 +0530 Ritesh Raj Sarraf wrote: [...] > Dear (Linux) Kernel Team: > > We currently have systemtap 3.0 in Debian testing where this problem was > reported. > > In Experimental, I have also pushed the 3.1 release. The 3.1 release is > reported > to work perfectly in our tests with the custom built kernel. The problem is > only > seen with the Debian built Linux kernels. [...] I investigated this and found that it occurs when the kernel source and object trees are separate (an "out-of-tree" build, not to be confused with out-of-tree modules). We separate them in Debian kernel header packages to avoid duplicating source files for each flavour. When this is the case, the compiler is called in the root of the object tree, and the kernel build system adjusts -I options in the compiler flags to refer to subdirectories of the source tree if necessary. Any directory name beginning with /, ./ or ../ is excluded from this adjustment. systemtap uses -I"/usr/share/systemtap/runtime", which ought to be excluded... but make has no understanding of shell quoting, so it is wrongly adjusted to something like -I/usr/src/linux-headers-4.9.0-2-common/"/usr/share/systemtap/runtime" and runtime_defines.h cannot be found. So my fix is to delete quotes before checking for the exclusions: --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -206,7 +206,7 @@ hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj # Prefix -I with $(srctree) if it is not an absolute path. # skip if -I has no parameter addtree = $(if $(patsubst -I%,%,$(1)), \ -$(if $(filter-out -I/% -I./% -I../%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))) +$(if $(filter-out -I/% -I./% -I../%,$(subst $(quote),,$(subst $(squote),,$(1,$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))) # Find all -I options and call addtree flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o))) --- END --- Ben. -- Ben Hutchings All the simple programs have been written, and all the good names taken. signature.asc Description: This is a digitally signed message part
Processed: Re: Bug#856474: stap: include runtime_defines.h not found
Processing control commands: > tag -1 upstream patch Bug #856474 [src:linux] stap: include runtime_defines.h not found Added tag(s) patch and upstream. -- 856474: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856474 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#856474: stap: include runtime_defines.h not found
On Sat, 2017-03-04 at 01:39 +, Ben Hutchings wrote: [...] > I investigated this and found that it occurs when the kernel source and > object trees are separate (an "out-of-tree" build, not to be confused > with out-of-tree modules). We separate them in Debian kernel header > packages to avoid duplicating source files for each flavour. > > When this is the case, the compiler is called in the root of the > object tree, and the kernel build system adjusts -I options in the > compiler flags to refer to subdirectories of the source tree if > necessary. Any directory name beginning with /, ./ or ../ is excluded > from this adjustment. > > systemtap uses -I"/usr/share/systemtap/runtime", which ought to be > excluded... but make has no understanding of shell quoting, so it is > wrongly adjusted to something like > -I/usr/src/linux-headers-4.9.0-2-common/"/usr/share/systemtap/runtime" > and runtime_defines.h cannot be found. By the way, kbuild has been doing this ever since it started supporting out-of-tree builds (around Linux 2.6.0). However, both the adjusted and original -I options were used. Since Linux 4.8 only the adjusted option is used. Ben. -- Ben Hutchings All the simple programs have been written, and all the good names taken. signature.asc Description: This is a digitally signed message part
Bug#856474: stap: include runtime_defines.h not found
On Sat, 04 Mar 2017 01:39:58 + Ben Hutchings wrote: > So my fix is to delete quotes before checking for the exclusions: Wow Ben, that was a really quick fix! I'll test it on Monday and report back. signature.asc Description: OpenPGP digital signature
