Processed: bug 962254 is forwarded to https://lore.kernel.org/linux-nfs/20200616052835.ga19...@lorien.valinor.li/T/#m9c41f33123a7c44cdd7fa07611c678c1b0dace61
Processing commands for cont...@bugs.debian.org: > forwarded 962254 > https://lore.kernel.org/linux-nfs/20200616052835.ga19...@lorien.valinor.li/T/#m9c41f33123a7c44cdd7fa07611c678c1b0dace61 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Set Bug forwarded-to-address to 'https://lore.kernel.org/linux-nfs/20200616052835.ga19...@lorien.valinor.li/T/#m9c41f33123a7c44cdd7fa07611c678c1b0dace61'. > thanks Stopping processing here. Please contact me if you need assistance. -- 962254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962254 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: reassign 934160 to src:linux, forcibly merging 962254 934160 ..., tagging 962254
Processing commands for cont...@bugs.debian.org: > reassign 934160 src:linux Bug #934160 [nfs-common] nfs-common: Umask ignored, all files created world-writable on NFS Bug reassigned from package 'nfs-common' to 'src:linux'. No longer marked as found in versions nfs-utils/1:1.3.4-2.5. Ignoring request to alter fixed versions of bug #934160 to the same values previously set > forcemerge 962254 934160 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Set Bug forwarded-to-address to 'https://lore.kernel.org/linux-nfs/20200616052835.ga19...@lorien.valinor.li/T/#m9c41f33123a7c44cdd7fa07611c678c1b0dace61'. Marked as found in versions linux/4.19.118-2. Merged 934160 962254 > forwarded 962254 > https://lore.kernel.org/linux-nfs/20200616052835.ga19...@lorien.valinor.li/T/#m9c41f33123a7c44cdd7fa07611c678c1b0dace61 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Ignoring request to change the forwarded-to-address of bug#962254 to the same value Ignoring request to change the forwarded-to-address of bug#934160 to the same value > tags 962254 + upstream Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Added tag(s) upstream. Added tag(s) upstream. > thanks Stopping processing here. Please contact me if you need assistance. -- 934160: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934160 962254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962254 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: your mail
Processing commands for cont...@bugs.debian.org:
> severity 956221 wishlist
Bug #956221 [firmware-misc-nonfree] firmware-misc-nonfree: missing firmware
i915/{icl_dmc_ver1_09,tgl_dmc_ver2_04,{skl,bxt,kbl,glk,cml,icl,ehl,tgl…
Severity set to 'wishlist' from 'normal'
> merge 956221 931930
Bug #956221 [firmware-misc-nonfree] firmware-misc-nonfree: missing firmware
i915/{icl_dmc_ver1_09,tgl_dmc_ver2_04,{skl,bxt,kbl,glk,cml,icl,ehl,tgl…
Bug #931930 [firmware-misc-nonfree] firmware-misc-nonfree: Please, include
i915/icl_dmc_ver1_07.bin
Marked as found in versions firmware-nonfree/20190717-2.
Bug #956221 [firmware-misc-nonfree] firmware-misc-nonfree: missing firmware
i915/{icl_dmc_ver1_09,tgl_dmc_ver2_04,{skl,bxt,kbl,glk,cml,icl,ehl,tgl…
Marked as found in versions firmware-nonfree/20190717-1 and
firmware-nonfree/20190114-1.
Merged 931930 956221
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
931930: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931930
956221: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956221
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#931930: Workaround ? [Re: firmware-misc-nonfree: Please, include i915/icl_dmc_ver1_07.bin]
> Does someone has a woraround ? The Debian source package doesn't have > the right version of the files. You can pull the current version from Salsa and build the .deb yourself: https://salsa.debian.org/kernel-team/firmware-nonfree Just be aware that you have to manually replace your locally built package when the package is uploaded to the Debian servers, as it will have the same version. > BTW, do the maintainer(s) have acknowledged the problem ? I'm not sure... Maybe raise the severity of the issue a bit?
Processed: found 962254 in 5.6.14-2, found 962254 in 5.7~rc5-1~exp1
Processing commands for cont...@bugs.debian.org: > found 962254 5.6.14-2 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Marked as found in versions linux/5.6.14-2. Marked as found in versions linux/5.6.14-2. > found 962254 5.7~rc5-1~exp1 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Marked as found in versions linux/5.7~rc5-1~exp1. Marked as found in versions linux/5.7~rc5-1~exp1. > thanks Stopping processing here. Please contact me if you need assistance. -- 934160: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934160 962254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962254 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#962254: Umask ignored when mounting NFSv4.2 share of an exported Filesystem with noacl (was: Re: Bug#962254: NFS(v4) broken at 4.19.118-2)
Hi Bruce,
On Mon, Jun 15, 2020 at 10:42:12PM -0400, J. Bruce Fields wrote:
> On Mon, Jun 15, 2020 at 10:38:20PM -0400, J. Bruce Fields wrote:
> > Thanks for the detailed reproducer.
> >
> > It's weird, as the server is basically just setting the transmitted
> > umask and then calling into the vfs to handle the rest, so it's not much
> > different from any other user. But the same reproducer run just on the
> > ext4 filesystem does give the right permissions
> >
> > Oh, but looking at the system call, fs_namei.c:do_mkdirat(), it does:
> >
> > if (!IS_POSIXACL(path.dentry->d_inode))
> > mode &= ~current_umask();
> > error = security_path_mkdir(&path, dentry, mode);
> > if (!error)
> > error = vfs_mkdir(path.dentry->d_inode, dentry, mode);
> >
> > whereas nfsd just calls into vfs_mkdir().
> >
> > And that IS_POSIXACL() check is exactly a check whether the filesystem
> > supports ACLs. So I guess it's the responsibility of the caller of
> > vfs_mkdir() to handle that case.
>
> But, that's unsatisfying: why isn't vfs_mkdir() taking care of this
> itself? And what about that security_path_mkdir() call? And are the
> other cases of that switch in fs/nfsd/vfs.c:nfsd_create_locked()
> correct? I think there may be some more cleanup here called for, I'll
> poke around tomorrow.
This might be unneeded to test but as additional datapoint which
confirms the suspect: I tried check the commit around 47057abde515
("nfsd: add support for the umask attribute") in 4.10-rc1
A kernel built with 47057abde515~1, and mounting from an enough recent
client which has at least dff25ddb4808 ("nfs: add support for the
umask attribute") does not show the observed behaviour, the server
built with 47057abde515 does.
Regards,
Salvatore
Processed: found 962254 in 4.10-1~exp1
Processing commands for cont...@bugs.debian.org: > found 962254 4.10-1~exp1 Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Marked as found in versions linux/4.10-1~exp1. Marked as found in versions linux/4.10-1~exp1. > thanks Stopping processing here. Please contact me if you need assistance. -- 934160: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934160 962254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962254 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Re: linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright
Processing control commands: > found -1 5.3.2-1~exp1 Bug #962588 [linux-image-amd64] linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright Marked as found in versions linux-signed-amd64/5.3.2+1~exp1. -- 962588: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962588 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#962588: linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright
Control: found -1 5.3.2-1~exp1 On Wed, 10 Jun 2020 13:55:17 +0200 Thorsten Glaser wrote: > Package: linux-image-amd64 > Version: 5.6.14-2 > Severity: serious > Justification: Policy 2.3 > > tglase@tglase:~ $ ll /usr/share/doc/linux-image-amd64/ > total 0 > tglase@tglase:~ $ ll -d /usr/share/doc/linux-image-amd64 > drwxr-xr-x 2 root root 4096 Okt 21 2019 /usr/share/doc/linux-image-amd64/ This is the dpkg bug where it fails to replace a directory with a symlink. For some reason that requires workarounds in every other package instead of being fixed in dpkg. This instance was introduced by: commit 70af1a4e805ba7f355fb69b3a041b3fdb9b977dd Author: Ben Hutchings Date: Tue Oct 1 22:27:29 2019 +0100 Require metapackage dependencies to be the same version, and link doc dirs Ben. -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. signature.asc Description: This is a digitally signed message part
Processed: unarchiving 942861
Processing commands for cont...@bugs.debian.org:
> unarchive 942861
Bug #942861 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Unarchived Bug 942861
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
942861: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942861
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#962972: firmware-realtek: unable to load firmware patch rtl_nic/rtl8153a-2.fw (-2)
Package: firmware-realtek Version: 20190717-2 Severity: important TL;DR Please update rtl_nic. This will solve most of the issues reported against rtl815x devices. Linux gggnuc6 5.6.0-2-amd64 #1 SMP Debian 5.6.14-1 (2020-05-23) x86_64 GNU/Linux Errors that an update will fix: [79912.317675] r8152 2-2.4:1.0: firmware: failed to load rtl_nic/rtl8153a-2.fw (-2) [79912.317683] r8152 2-2.4:1.0: Direct firmware load for rtl_nic/rtl8153a-2.fw failed with error -2 AND [79912.458292] r8152 2-2.1:1.0: firmware: failed to load rtl_nic/rtl8153b-2.fw (-2) [79912.458296] r8152 2-2.1:1.0: Direct firmware load for rtl_nic/rtl8153b-2.fw failed with error -2 "modprobe r8152" results in the following dmesg output: [78645.896245] r8152 2-2.1:1.0 enx00e04cf007a4: carrier on [79887.986255] usbcore: deregistering interface driver r8152 [79887.986552] r8152 2-2.1:1.0 enx00e04cf007a4: Stop submitting intr, status -108 [79888.042247] r8152 2-2.4:1.0 enx0023568c0143: Stop submitting intr, status -108 [79912.294537] usb 2-2.4: reset SuperSpeed Gen 1 USB device number 4 using xhci_hcd [79912.317675] r8152 2-2.4:1.0: firmware: failed to load rtl_nic/rtl8153a-2.fw (-2) [79912.317683] r8152 2-2.4:1.0: Direct firmware load for rtl_nic/rtl8153a-2.fw failed with error -2 [79912.317687] r8152 2-2.4:1.0: unable to load firmware patch rtl_nic/rtl8153a-2.fw (-2) [79912.351441] r8152 2-2.4:1.0 eth0: v1.11.11 [79912.354955] r8152 2-2.4:1.0 enx0023568c0143: renamed from eth0 [79912.434704] usb 2-2.1: reset SuperSpeed Gen 1 USB device number 5 using xhci_hcd [79912.458292] r8152 2-2.1:1.0: firmware: failed to load rtl_nic/rtl8153b-2.fw (-2) [79912.458296] r8152 2-2.1:1.0: Direct firmware load for rtl_nic/rtl8153b-2.fw failed with error -2 [79912.458298] r8152 2-2.1:1.0: unable to load firmware patch rtl_nic/rtl8153b-2.fw (-2) [79912.491249] r8152 2-2.1:1.0 eth0: v1.11.11 [79912.491294] usbcore: registered new interface driver r8152 [79912.496221] r8152 2-2.1:1.0 enx00e04cf007a4: renamed from eth0 [79915.982266] IPv6: ADDRCONF(NETDEV_CHANGE): enx0023568c0143: link becomes ready [79915.982925] r8152 2-2.4:1.0 enx0023568c0143: carrier on [79916.304655] IPv6: ADDRCONF(NETDEV_CHANGE): enx00e04cf007a4: link becomes ready [79916.305100] r8152 2-2.1:1.0 enx00e04cf007a4: carrier on The rtl8153a-2 and rtl8153a-3 devices are widely used and Realtek finally upstreamed the firmware patching mechanism they had in their inhouse driver around Q4 2019: https://lore.kernel.org/netdev/1394712342-15778-335-taiwan-albe...@realtek.com/ These patches helped chrome OS reliably detect and use RTL8153 devices. However, the rtl8153a-3.fw file Realtek original submitted was broken and was updated in Feb 2020 and ChromeOS picked up this update in April, 2020: https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+log/refs/heads/master/rtl_nic https://chromium.googlesource.com/chromiumos/third_party/linux-firmware/+/db0430c080d38e3055aec81f44b4c84012dba079 While I'm using a personal email to request this update, I am also grund...@chromium.org and have extensively tested these patches. They work. -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.6.0-2-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_WARN, TAINT_FIRMWARE_WORKAROUND Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8), LANGUAGE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled firmware-realtek depends on no packages. firmware-realtek recommends no packages. Versions of packages firmware-realtek suggests: ii initramfs-tools 0.137 -- no debconf information
Bug#962588: linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright
Control: notfixed 942861 5.3.9-1 Control: forcemerge 942861 -1 On Tue, 2020-06-16 at 17:44 +0100, Ben Hutchings wrote: > Control: found -1 5.3.2-1~exp1 > > On Wed, 10 Jun 2020 13:55:17 +0200 Thorsten Glaser wrote: > > Package: linux-image-amd64 > > Version: 5.6.14-2 > > Severity: serious > > Justification: Policy 2.3 > > > > tglase@tglase:~ $ ll /usr/share/doc/linux-image-amd64/ > > total 0 > > tglase@tglase:~ $ ll -d /usr/share/doc/linux-image-amd64 > > drwxr-xr-x 2 root root 4096 Okt 21 2019 /usr/share/doc/linux-image-amd64/ > > This is the dpkg bug where it fails to replace a directory with a > symlink. For some reason that requires workarounds in every other > package instead of being fixed in dpkg. > > This instance was introduced by: > > commit 70af1a4e805ba7f355fb69b3a041b3fdb9b977dd > Author: Ben Hutchings > Date: Tue Oct 1 22:27:29 2019 +0100 > > Require metapackage dependencies to be the same version, and link doc dirs Actually you already reported this as #942861 and I applied the workaround, but it looks like I specified the wrong prior-version to dpkg-maintscript-helper. Ben. -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. signature.asc Description: This is a digitally signed message part
Processed: Re: linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright
Processing control commands:
> notfixed 942861 5.3.9-1
Bug #942861 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
No longer marked as fixed in versions linux/5.3.9-1.
> forcemerge 942861 -1
Bug #942861 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Bug #962588 [linux-image-amd64] linux-image-amd64:amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Marked Bug as done
Marked as found in versions linux-signed-amd64/5.3.7+1.
Bug #942861 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Marked as found in versions linux-signed-amd64/5.3.2+1~exp1 and
linux-signed-amd64/5.6.14+2.
Merged 942861 962588
--
942861: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942861
962588: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962588
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Processed: reopening 962588
Processing commands for cont...@bugs.debian.org:
> reopen 962588
Bug #962588 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64:amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Bug #942861 {Done: Ben Hutchings } [linux-image-amd64]
linux-image-amd64: missing-copyright-file
/usr/share/doc/linux-image-amd64/copyright
Bug reopened
Ignoring request to alter fixed versions of bug #962588 to the same values
previously set
Ignoring request to alter fixed versions of bug #942861 to the same values
previously set
> thanks
Stopping processing here.
Please contact me if you need assistance.
--
942861: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942861
962588: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962588
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#962972: workaround until firmware-realtek is updated
sudo bash cd /lib/firmware/rtl_nic wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtl_nic/rtl8153b-2.fw wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtl_nic/rtl8153a-4.fw wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtl_nic/rtl8153a-3.fw wget https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/plain/rtl_nic/rtl8153a-2.fw ^D Kudos to Sedat Dilek in comment #30 of bug 947356 for "pointing out the obvious". :) https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947356#30
Bug#962588: linux-image-amd64:amd64: missing-copyright-file /usr/share/doc/linux-image-amd64/copyright
Ben Hutchings dixit: >This is the dpkg bug where it fails to replace a directory with a >symlink. For some reason that requires workarounds in every other >package instead of being fixed in dpkg. Yeah, this is annoying, but AIUI they call it a feature; a local admin can symlink directories around if they suddenly lack space on a partition (this was before bind mounts existed). Thanks, //mirabilos -- Beware of ritual lest you forget the meaning behind it. yeah but it means if you really care about something, don't ritualise it, or you will lose it. don't fetishise it, don't obsess. or you'll forget why you love it in the first place.
Bug#962254: Umask ignored when mounting NFSv4.2 share of an exported Filesystem with noacl (was: Re: Bug#962254: NFS(v4) broken at 4.19.118-2)
On Tue, Jun 16, 2020 at 06:16:58PM +0200, Salvatore Bonaccorso wrote:
> This might be unneeded to test but as additional datapoint which
> confirms the suspect: I tried check the commit around 47057abde515
> ("nfsd: add support for the umask attribute") in 4.10-rc1
>
> A kernel built with 47057abde515~1, and mounting from an enough recent
> client which has at least dff25ddb4808 ("nfs: add support for the
> umask attribute") does not show the observed behaviour, the server
> built with 47057abde515 does.
Thanks for the confirmation!
I think I'll send the following upstream.
--b.
commit 595ccdca9321
Author: J. Bruce Fields
Date: Tue Jun 16 16:43:18 2020 -0400
nfsd: apply umask on fs without ACL support
The server is failing to apply the umask when creating new objects on
filesystems without ACL support.
To reproduce this, you need to use NFSv4.2 and a client and server
recent enough to support umask, and you need to export a filesystem that
lacks ACL support (for example, ext4 with the "noacl" mount option).
Filesystems with ACL support are expected to take care of the umask
themselves (usually by calling posix_acl_create).
For filesystems without ACL support, this is up to the caller of
vfs_create(), vfs_mknod(), or vfs_mkdir().
Reported-by: Elliott Mitchell
Reported-by: Salvatore Bonaccorso
Fixes: 47057abde515 ("nfsd: add support for the umask attribute")
Signed-off-by: J. Bruce Fields
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 0aa02eb18bd3..8fa3e0ff3671 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1225,6 +1225,9 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh
*fhp,
iap->ia_mode = 0;
iap->ia_mode = (iap->ia_mode & S_IALLUGO) | type;
+ if (!IS_POSIXACL(dirp))
+ iap->ia_mode &= ~current_umask();
+
err = 0;
host_err = 0;
switch (type) {
@@ -1457,6 +1460,9 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
goto out;
}
+ if (!IS_POSIXACL(dirp))
+ iap->ia_mode &= ~current_umask();
+
host_err = vfs_create(dirp, dchild, iap->ia_mode, true);
if (host_err < 0) {
fh_drop_write(fhp);
Processed: retitle 962254 to NFSv4.2: umask not applied on filesystem without ACL support
Processing commands for cont...@bugs.debian.org: > retitle 962254 NFSv4.2: umask not applied on filesystem without ACL support Bug #962254 [src:linux] NFS v4.2 broken between 4.9 and 4.15 Bug #934160 [src:linux] nfs-common: Umask ignored, all files created world-writable on NFS Changed Bug title to 'NFSv4.2: umask not applied on filesystem without ACL support' from 'NFS v4.2 broken between 4.9 and 4.15'. Changed Bug title to 'NFSv4.2: umask not applied on filesystem without ACL support' from 'nfs-common: Umask ignored, all files created world-writable on NFS'. > thanks Stopping processing here. Please contact me if you need assistance. -- 934160: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934160 962254: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=962254 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#962254: Umask ignored when mounting NFSv4.2 share of an exported Filesystem with noacl
Hi,
On Tue, Jun 16, 2020 at 08:58:49PM -0400, J. Bruce Fields wrote:
> On Tue, Jun 16, 2020 at 06:16:58PM +0200, Salvatore Bonaccorso wrote:
> > This might be unneeded to test but as additional datapoint which
> > confirms the suspect: I tried check the commit around 47057abde515
> > ("nfsd: add support for the umask attribute") in 4.10-rc1
> >
> > A kernel built with 47057abde515~1, and mounting from an enough recent
> > client which has at least dff25ddb4808 ("nfs: add support for the
> > umask attribute") does not show the observed behaviour, the server
> > built with 47057abde515 does.
>
> Thanks for the confirmation!
>
> I think I'll send the following upstream.
>
> --b.
>
> commit 595ccdca9321
> Author: J. Bruce Fields
> Date: Tue Jun 16 16:43:18 2020 -0400
>
> nfsd: apply umask on fs without ACL support
>
> The server is failing to apply the umask when creating new objects on
> filesystems without ACL support.
>
> To reproduce this, you need to use NFSv4.2 and a client and server
> recent enough to support umask, and you need to export a filesystem that
> lacks ACL support (for example, ext4 with the "noacl" mount option).
>
> Filesystems with ACL support are expected to take care of the umask
> themselves (usually by calling posix_acl_create).
>
> For filesystems without ACL support, this is up to the caller of
> vfs_create(), vfs_mknod(), or vfs_mkdir().
>
> Reported-by: Elliott Mitchell
> Reported-by: Salvatore Bonaccorso
> Fixes: 47057abde515 ("nfsd: add support for the umask attribute")
> Signed-off-by: J. Bruce Fields
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 0aa02eb18bd3..8fa3e0ff3671 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1225,6 +1225,9 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct
> svc_fh *fhp,
> iap->ia_mode = 0;
> iap->ia_mode = (iap->ia_mode & S_IALLUGO) | type;
>
> + if (!IS_POSIXACL(dirp))
> + iap->ia_mode &= ~current_umask();
> +
> err = 0;
> host_err = 0;
> switch (type) {
> @@ -1457,6 +1460,9 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh
> *fhp,
> goto out;
> }
>
> + if (!IS_POSIXACL(dirp))
> + iap->ia_mode &= ~current_umask();
> +
> host_err = vfs_create(dirp, dchild, iap->ia_mode, true);
> if (host_err < 0) {
> fh_drop_write(fhp);
Thank you, could test this on my test setup and seem to work properly.
Should it also be CC'ed to sta...@vger.kernel.org so it is picked up
by the current supported stable series?
Regards,
Salvatore
