Re: Bug#1056056: Acknowledgement (linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640)
I tried the following: * latest kernel from debian-testing (6.5.10+1) * adding "reboot=(efi|cold|bios)" to the kernel command line Can I try anything else? Are there any relevant module-parameters to try?
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Some searching and some trial and error later I find that adding a "reboot=p"
to the kernel command line will result in en rebootable system. It looks like
this system ("HP t640 Thin Client") should be added to the list of boot quirks
in 'arch/x86/kernel/reboot.c'?
For the record, "c,p", "g,p" and "p" work, all other combinations fail to do a
functional reboot.
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
The attached patch works on my systems. Is there a way to get this in?
--- arch/x86/kernel/reboot.c.orig 2023-12-14 08:25:10.033382061 +0100
+++ arch/x86/kernel/reboot.c 2023-12-14 08:31:10.394325941 +0100
@@ -469,6 +469,14 @@
DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
},
},
+ { /* Handle problems with rebooting HP t640 thin-clients */
+ .callback = set_pci_reboot,
+ .ident = "HP t640",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "HP"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP t640 Thin Client"),
+ },
+ },
{ /* PCIe Wifi card isn't detected after reboot otherwise */
.callback = set_pci_reboot,
Bug#1056056: linux-image-6.1.0-13-amd64: After a 'warm' reboot the disk is missing (not detected by the bios) on a HP t640
Van: Salvatore Bonaccorso
> Hi Ben,
>
> On Thu, Dec 14, 2023 at 09:16:48AM +0000, Ben Mesman | Spark Narrowcasting
> wrote:
> > The attached patch works on my systems. Is there a way to get this in?
>
> ...
>
> We cannot pick changes which are not going to land in Linux upstream
> and then backported to the stable series. So the way to go here is to
> report the bug upstream, along with your proposed change. Candidates
> to reach out are:
>
> ...
>
> as it is affecting 6.1.y mention that the fix needs to be backported to
> various
> stable series at least back 6.1.y and describe which testing you have
> performed.
>
> Feel free to keep as well the Debian bug in the loop for the report.
>
> Hope this helps?
Small update on this bug: I reached out and Fred Ai made a patch which is now
in the mainline kernel:
commit 58aeb5623c2ebdadefe6352b14f8076a7073fea0
Author: Fred Ai
Date: Sat Feb 3 02:29:08 2024 -0800
mmc: sdhci-pci-o2micro: Fix a warm reboot issue that disk can't be detected
by BIOS
Driver shall switch clock source from DLL clock to
OPE clock when power off card to ensure that card
can be identified with OPE clock by BIOS.
Signed-off-by: Fred Ai
Fixes:4be33cf18703 ("mmc: sdhci-pci-o2micro: Improve card input timing at
SDR104/HS200 mode")
Cc: sta...@vger.kernel.org
Link:
https://lore.kernel.org/r/20240203102908.4683-1-fredaibayhubt...@126.com
Signed-off-by: Ulf Hansson
I'm still waiting for the patch to land in the stable kernel series (both 6.1
and 6.6)
Regards,
Ben Mesman.
