Bug#972794: linux-image-4.19.0-12-amd64: amdgpu-dkms 19.50-20.40 fails to build with error: implicit declaration of function ‘pci _platform_rom’ ;

[Dr. Nagy Elemér Kár oly]

Dear All,

For amdgpu 20.10, patching amd/amdgpu/amdgpu_bios.c in 
/usr/src/amdgpu-5.4.7.53-1048554/ with the attached patch (posted 
by Mikel Rychliski at https://lore.kernel.org/amd-gfx/20200319021623.5426-1-
mi...@mikelr.com/#Z30drivers:gpu:drm:amd:amdgpu:amdgpu_bios.c) fixes the issue.

Best wishes:
Elemér K. Nagy
--- a/amd/amdgpu/amdgpu_bios.c
+++ b/amd/amdgpu/amdgpu_bios.c
@@ -192,30 +192,35 @@ static bool amdgpu_read_bios_from_rom(struct amdgpu_device *adev)
 
 static bool amdgpu_read_platform_bios(struct amdgpu_device *adev)
 {
-	uint8_t __iomem *bios;
-	size_t size;
+	phys_addr_t rom = adev->pdev->rom;
+	size_t romlen = adev->pdev->romlen;
+	void __iomem *bios;
 
 	adev->bios = NULL;
 
-	bios = pci_platform_rom(adev->pdev, );
-	if (!bios) {
+	if (!rom || romlen == 0)
 		return false;
-	}
 
-	adev->bios = kzalloc(size, GFP_KERNEL);
-	if (adev->bios == NULL)
+	adev->bios = kzalloc(romlen, GFP_KERNEL);
+	if (!adev->bios)
 		return false;
 
-	memcpy_fromio(adev->bios, bios, size);
+	bios = ioremap(rom, romlen);
+	if (!bios)
+		goto free_bios;
 
-	if (!check_atom_bios(adev->bios, size)) {
-		kfree(adev->bios);
-		return false;
-	}
+	memcpy_fromio(adev->bios, bios, romlen);
+	iounmap(bios);
 
-	adev->bios_size = size;
+	if (!check_atom_bios(adev->bios, romlen))
+		goto free_bios;
+
+	adev->bios_size = romlen;
 
 	return true;
+free_bios:
+	kfree(adev->bios);
+	return false;
 }
 
 #ifdef CONFIG_ACPI

Bug#883938: RFT: Candidate fix for boot failure of Debian 8.10 on various x86 systems

[Dr. Nagy Elemér Kár oly]

Dear Ben,

Thank you, the fix works for me, both Sun Fires (X2200M2 and X4200M2) boot with 
3.16.51-3~a.test (2017-12-11).

Best wishes:
Elemér

Bug#883938: Sun Fire X4200 M2 Xen

[Dr. Nagy Elemér Kár oly]

Hi,

The non-booting machines have multiple CPUs:
 * X4200M2: 2 AMD 2220, no Xen, LVM
 * X2200M2: 2 AMD 2347HE

The booting machine has multiple CPUs as well, but Xen is configured to give 
only 1 vCPU to Doms.
 * X4200M2: 2 AMD 2220, Xen

The freezing machine might have a HW problem or might be hit by Debian bug 
#880554 as even after downgrading all DomU and 
Dom0 kernels, the freeze still occurs, even though it boots.

Elmar

Bug#883938: Sun Fire X4200 M2 Xen

[Dr. Nagy Elemér Kár oly]

Hi,

Update: probably reproduced the bug in Xen on a Sun Fire X4200 M2 ;(

After 4.5 hours, it froze so hard that I could not power it off via the iLOM, 
even Num Lock wouldn't work. After 
rebooting, lock-ups occurred in about 5-30 minutes. There is nothing in the 
syslog.

After downgrading the Dom0+Xen kernel, the problem persisted.

Downgraded all Dom0 kernels as well, waiting for next lockup :I

Elmar

Bug#883938: Sun Fire X4200 M2 too

[Dr. Nagy Elemér Kár oly]

Hi,

Reproduced it on a Sun Fire X4200 M2 too, screenshot attached.

Could we increase the severity to critical like Debian bug #883294? It downed a 
production server ;(

Downgrading to "3.16.43-2+deb8u5 (2017-09-19)" fixed it.

Elmar