Bug#673391: Revised patches for be2net
Ben, I am sorry I missed this mail. Is your comment with respect to these two patches or are you asking me why I haven’t given any further updates? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Monday, June 25, 2012 8:59 AM To: Bandi,Sarveshwar Cc: 673...@bugs.debian.org Subject: Re: Bug#673391: Revised patches for be2net On Thu, 2012-05-31 at 06:45 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. I don't see the point. But do let us know (in a new bug report) if and when there are substantial bug fixes or new hardware support. Ben. -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it needed replacing anyway.
Bug#673391: Revised patches for be2net
Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Sunday, May 27, 2012 5:27 AM To: Bandi,Sarveshwar; 673...@bugs.debian.org Subject: Re: Bug#673391: Revised patches for be2net On Fri, 2012-05-25 at 09:30 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the revised patches as per your comments. I was not sure how to handle patches (4 of them) which involved changes to other drivers too. I intend to open separate bugs for each of them and send them. Hope that is ok. No, there's no need to open more bugs. I have also taken care of your comment to not change the return value in ndo_vlan_rx_[add/kill]_vid (8e586137e6b63af1e881b328466ab5ffbe562510). The patches also contain the upstream commit id thanks to your git-format-patch-for-backport script. Thanks. So the remaining 4 changes are: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const It's absolutely fine to apply just the parts of these that affect your driver, as in your original series. 8e58613 net: make vlan ndo_vlan_rx_[add/kill]_vid return error value This should not be applied at all, as we don't want to change the kernel API. 786f528 ethtool: Null-terminate filename passed to ethtool_ops::flash_device I think this is an important bug fix (well I would do :-) so I'll apply it and also propose to David Miller that it goes into stable updates. Ben. -- Ben Hutchings The obvious mathematical breakthrough [to break modern encryption] would be development of an easy way to factor large prime numbers. - Bill Gates 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch Description: 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch 0027-netdev-make-net_device_ops-const.patch Description: 0027-netdev-make-net_device_ops-const.patch
Bug#673391: Bug to update be2net driver in Debian 7.0
Ben, I thought I was supposed to give changes only for be2net driver. Should have asked. Sorry about that. I have some quick question on the issues you have pointed. May be I am stating the obvious but I just want to be sure, I assume that you have not applied any of the patches in the series till I get all of them right? Sarvesh Since the following patches have changes to other drivers as well, not only be2net, Should send you a patch list without these changes, (and only contain changes to be2net driver) and open separate bugs to get these changes into all drivers ? Also you want 31/61 to go into 3.2 stable right? Do you want me to do that first before I give it for debian? Sarvesh 1/61 'sweep the floors and convert some .get_drvinfo routines to strlcpy' (commit 68aad78c5023b8aa82da99b47f9d8cf40e8ca453 upstream) applied to many drivers; please note in the patch header that you've filtered it to just be2net. Same for 27/61 'netdev: make net_device_ops const'. 31/61 'ethtool: Null-terminate filename passed to ethtool_ops::flash_device' (commit 786f528119722f564a22ad953411374e06116333 upstream) is wrong; by filtering to only drivers/net/emulex/benet/ you've lost the essential part of it! Actually that fix should maybe go to stable, not just Debian. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80eecc94...@exmail.ad.emulex.com
Bug#673391: Bug to update be2net driver in Debian 7.0
Package: src:linux-2.6 Version: 3.2.17-1 Severity: important X-Debbugs-CC: debian-kernel@lists.debian.org Opening bug to update be2net driver in Debian 7.0 with latest fixes and patches in net-next. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80d16d37...@exmail.ad.emulex.com
RE: Basic question on debian kernel versions
Will you be able to give me the last commit details (or net-next-commit id) that happened in the 3.2 tree for the be2net driver ? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Wednesday, May 16, 2012 6:30 AM To: Bandi,Sarveshwar Cc: u.kleine-koe...@pengutronix.de; debian-kernel@lists.debian.org Subject: RE: Basic question on debian kernel versions On Tue, 2012-05-15 at 07:35 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I have not been successful in getting access to the 3.2 source tree. However I have linux-source-3.2_3.2.17-1_all.deb package. Can I patches for be2net driver against this source base? Or can I just cut patches against linux 3.2.17 stable tree? Would that work? Please use the Debian packaged source as the baseline. Ben. -- Ben Hutchings The two most common things in the universe are hydrogen and stupidity.
RE: Basic question on debian kernel versions
Ben, I have not been successful in getting access to the 3.2 source tree. However I have linux-source-3.2_3.2.17-1_all.deb package. Can I patches for be2net driver against this source base? Or can I just cut patches against linux 3.2.17 stable tree? Would that work? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Thursday, May 10, 2012 9:55 PM To: Uwe Kleine-König Cc: Bandi,Sarveshwar; debian-kernel@lists.debian.org Subject: Re: Basic question on debian kernel versions On Thu, 2012-05-10 at 14:58 +0100, Ben Hutchings wrote: On Thu, 2012-05-10 at 13:06 +0200, Uwe Kleine-König wrote: On Thu, May 10, 2012 at 03:37:38AM -0700, sarveshwar.ba...@emulex.com wrote: I get a connection timed out. root@debian:~# svn co svn://anonscm.debian.org/svn/kernel/dists/trunk/linux-2.6 svn: Can't connect to host 'anonscm.debian.org': Connection timed out root@debian:~# ping anonscm.debian.org PING anonscm.debian.org (217.196.43.132) 56(84) bytes of data. 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=1 ttl=37 time=168 ms 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=2 ttl=37 time=165 ms ^C --- anonscm.debian.org ping statistics --- 2 packets transmitted, 2 received, 0% packet loss, time 1001ms rtt min/avg/max/mdev = 165.589/166.816/168.043/1.227 ms Still works for me, maybe you're behind a firewall blocking svn:// ? Does accessing http://anonscm.debian.org/ work for you (with a browser, not svn). I don't know if there is http access available for the svn repositories?! Alioth does not support svn over HTTP, or at least it's not listed at http://alioth.debian.org/scm/?group_id=30428. Sarveshwar, you will need to find some way round the proxy, or use the That should be 'find some way round the firewall, or configure svn to use a suitable proxy'. Ben. alternate git repository which *is* available over HTTP at http://anonscm.debian.org/git/kernel/linux-2.6.git. Ben. -- Ben Hutchings Life is what happens to you while you're busy making other plans. - John Lennon
RE: Basic question on debian kernel versions
Ben, I do not find the wheezy branch in the repo (http://anonscm.debian.org/git/kernel/linux-2.6.git.). Did i miss anything! sbandi@sbandi:~/debian-7.0/linux-2.6$ git branch -a * master remotes/origin/HEAD - origin/master remotes/origin/debian-trunk remotes/origin/etch remotes/origin/etchnhalf remotes/origin/lenny remotes/origin/linux-2.6.32-drm33 remotes/origin/master remotes/origin/squeeze Thanks, Sarvesh From: Ben Hutchings [b...@decadent.org.uk] Sent: Thursday, May 10, 2012 7:30 PM To: Bandi,Sarveshwar Cc: u.kleine-koe...@pengutronix.de; debian-kernel@lists.debian.org Subject: RE: Basic question on debian kernel versions On Thu, 2012-05-10 at 04:17 -0700, sarveshwar.ba...@emulex.com wrote: Uwe, I am able to access the http site and able to ping it too. Also, what is the way to get linux-3.2 rc sources that are under development. apt-get source linux-2.6 gives me sources of linux 2.6.32. I am trying to figure out how to generate patches for linux-3.2 debian sources. All instructions that I have come across only talk about linux-2.6.32. They're both in svn and (occasionally) converted to git. Our patched Linux 3.2 can be found on the 'wheezy' branch in the git repository I mentioned. Ben. -- Ben Hutchings Life is what happens to you while you're busy making other plans. - John Lennon -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80d16ed3...@exmail.ad.emulex.com
RE: Basic question on debian kernel versions
I get a connection timed out. root@debian:~# svn co svn://anonscm.debian.org/svn/kernel/dists/trunk/linux-2.6 svn: Can't connect to host 'anonscm.debian.org': Connection timed out root@debian:~# ping anonscm.debian.org PING anonscm.debian.org (217.196.43.132) 56(84) bytes of data. 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=1 ttl=37 time=168 ms 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=2 ttl=37 time=165 ms ^C --- anonscm.debian.org ping statistics --- 2 packets transmitted, 2 received, 0% packet loss, time 1001ms rtt min/avg/max/mdev = 165.589/166.816/168.043/1.227 ms -Original Message- From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] Sent: Wednesday, May 09, 2012 11:22 PM To: Bandi,Sarveshwar Cc: b...@decadent.org.uk; debian-kernel@lists.debian.org Subject: Re: Basic question on debian kernel versions On Wed, May 09, 2012 at 09:09:01AM -0700, sarveshwar.ba...@emulex.com wrote: Ben, Was trying to get the latest debian kernel sources for 3.2.15-1. In the link you provided, the following step: svn co svn://anonscm.debian.org/svn/kernel/dists/sid/linux-2.6 What doesn't work exactly. The command works for me. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80d16d36...@exmail.ad.emulex.com
RE: Basic question on debian kernel versions
Uwe, I am able to access the http site and able to ping it too. Also, what is the way to get linux-3.2 rc sources that are under development. apt-get source linux-2.6 gives me sources of linux 2.6.32. I am trying to figure out how to generate patches for linux-3.2 debian sources. All instructions that I have come across only talk about linux-2.6.32. Thanks, Sarvesh -Original Message- From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] Sent: Thursday, May 10, 2012 4:36 PM To: Bandi,Sarveshwar Cc: b...@decadent.org.uk; debian-kernel@lists.debian.org Subject: Re: Basic question on debian kernel versions On Thu, May 10, 2012 at 03:37:38AM -0700, sarveshwar.ba...@emulex.com wrote: I get a connection timed out. root@debian:~# svn co svn://anonscm.debian.org/svn/kernel/dists/trunk/linux-2.6 svn: Can't connect to host 'anonscm.debian.org': Connection timed out root@debian:~# ping anonscm.debian.org PING anonscm.debian.org (217.196.43.132) 56(84) bytes of data. 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=1 ttl=37 time=168 ms 64 bytes from wagner.debian.org (217.196.43.132): icmp_req=2 ttl=37 time=165 ms ^C --- anonscm.debian.org ping statistics --- 2 packets transmitted, 2 received, 0% packet loss, time 1001ms rtt min/avg/max/mdev = 165.589/166.816/168.043/1.227 ms Still works for me, maybe you're behind a firewall blocking svn:// ? Does accessing http://anonscm.debian.org/ work for you (with a browser, not svn). I don't know if there is http access available for the svn repositories?! Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80d16d36...@exmail.ad.emulex.com
RE: Basic question on debian kernel versions
Ben, Was trying to get the latest debian kernel sources for 3.2.15-1. In the link you provided, the following step: svn co svn://anonscm.debian.org/svn/kernel/dists/sid/linux-2.6 does not seem to work. Is this the only way to get the sources? Am I missing something? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Friday, April 20, 2012 7:14 AM To: Bandi,Sarveshwar Cc: Debian kernel maintainers Subject: RE: Basic question on debian kernel versions On Thu, 2012-04-19 at 00:55 -0700, sarveshwar.ba...@emulex.com wrote: Ben, Thanks that clarifies a lot. I do intend to provide updates to driver. Some quick questions. I know need to figure this myself but am running round In circles. - Can you give me a pointer to latest debian kernel tree? I assume I will be able figure out the latest commit id that was taken for debian from that. Depending on which form you prefer to work with, you can use: 1. A git repository containing branches tracking each of the releases/suites. This is *not* the working repository (that's option 2) and is not always up-to-date, but may be preferable as a way to view and prepare patches: http://anonscm.debian.org/gitweb/?p=kernel/linux-2.6.git 2. The source package 'linux-2.6' contains upstream source and all the patches we apply to it. You can check out the development branch for each release/suite with Subversion: http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official-vcs 3. The package 'linux-source-2.6.32' or 'linux-source-3.2' (depending on which release you are targetting) contains the source with all Debian patches applied: http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-getting - Is it sufficient to give you commit id (from net-next) that need to be taken into debian or do I need to give patches Against the latest tree? If the driver source in net-next can just be dropped into the older kernel version and still work, then the commit ID is probably OK. But very often that isn't the case due to API changes (and I can't believe it's true for Debian 6.0, i.e. Linux 2.6.32). I personally prefer to see a patch series with upstream references (as you see in the kernel.org stable/longterm branches) and any necessary fix-ups for API differences made in those individual patches. As an example, see my own backport of tg3 at http://anonscm.debian.org/gitweb/?p=kernel/linux-2.6.git;a=shortlog;h=refs/heads/squeeze;pg=1. It's OK to backport the addition of new functions, e.g. the series of commits 'net: Add netdev_alloc_skb_ip_align() helper' up to 'err.h: add helper function to simplify pointer error checking' that you can see at http://anonscm.debian.org/gitweb/?p=kernel/linux-2.6.git;a=shortlog;h=refs/heads/squeeze;pg=7. But this has to be done with care to avoid affecting other drivers! - Whats the process, Do I just post these on this list or do I need to open bugs first? Or just point me to a faq. Do open a bug, requesting addition of new hardware support. Start with: Package: src:linux-2.6 Version: current version Severity: important If you want Debian 6.0 to be updated then specify the latest version there (2.6.32-43); if you only want this to go into Debian 7.0 then specify the latest version there (3.2.15-1). Patches should be sent to the bug address, which will forward to the debian-kernel mailing list. If you end up with a very long patch series it may be better to send it as a tarball. But if there's any thing that needs significant changes in the process of backporting, it might still be worth sending that individually so it's easier to review. Ben. -- Ben Hutchings This sentence contradicts itself - no actually it doesn't.
RE: Basic question on debian kernel versions
Hi, I have tried installing different version of debain kernels from CDs in the archive. For ex: I tried Debian 6.0.0, 6.0.3, 6.0.4. After installation all installations show /etc/debian_version as 6.0.4 and the same output for uname -r (2.6.32-5-686). How does one differentiate which version of debian kernel is installed? If all the version of debian installation have same value for uname -a, then will driver compiled for 6.0.0, load on 6.0.3 as is? I am sure I am missing something basic here. Thanks, Sarvesh
RE: Basic question on debian kernel versions
Then, give that 6.0.0, 6.03 and 6.0.4, since uname -a output is the same, can I assume that kernel image is the same and building driver for any of these debian version will give me the same driver binary? -Original Message- From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] Sent: Wednesday, April 18, 2012 12:45 PM To: Bandi,Sarveshwar Cc: debian-kernel@lists.debian.org Subject: Re: Basic question on debian kernel versions On Tue, Apr 17, 2012 at 11:56:00PM -0700, sarveshwar.ba...@emulex.com wrote: Hi, I have tried installing different version of debain kernels from CDs in the archive. For ex: I tried Debian 6.0.0, 6.0.3, 6.0.4. After installation all installations show /etc/debian_version as 6.0.4 and the same output for uname -r (2.6.32-5-686). How does one differentiate which version of debian kernel is installed? If all the version of debian installation have same value for uname -a, then will driver compiled for 6.0.0, load on 6.0.3 as is? I am sure I am missing something basic here. No you don't. All updates to the kernel are checked for binary incompatibilities. If it's possible to maintain compatibility it's done. Otherwise the abi version (the 5 in 2.6.32-5-686) is bumped and then you need to recompile your external modules. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b411ec5497e7bf439cd9ba21ceac8cb80b4936e...@exmail.ad.emulex.com
RE: Basic question on debian kernel versions
I installed linux headers in both my installations (one of which I installed using 6.0.0 cd and other using 6.0.4 cd) using apt-get install and dpkg --list shows same output on both the systems: root@debian:~# dpkg --list |grep headers ii linux-headers-2.6.32-5-686 2.6.32-41squeeze2 Header files for Linux 2.6.32-5-686 ii linux-headers-2.6.32-5-common2.6.32-41squeeze2 Common header files for Linux 2.6.32-5 When I build driver against the two versions the modinfo output is identical. So I am back to the question: How do I know which driver was built for which version of debian? And even more basic question, how do I know which version of kernel I am running now? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Wednesday, April 18, 2012 7:11 PM To: debian-kernel@lists.debian.org Subject: RE: Basic question on debian kernel versions On Wed, 2012-04-18 at 06:32 -0700, sarveshwar.ba...@emulex.com wrote: Then, give that 6.0.0, 6.03 and 6.0.4, since uname -a output is the same, can I assume that kernel image is the same No, there are new drivers and bug fixes. Some of the bug fixes will affect modules. and building driver for any of these debian version will give me the same driver binary? A driver module built using an older version of linux-headers-kversion should run against a newer version of linux-image-kversion. But the reverse is not generally true. Also, there have been cases where we have accidentally broken compatibility. Ben. -- Ben Hutchings This sentence contradicts itself - no actually it doesn't.
RE: Basic question on debian kernel versions
Well. I have tried everything possible to avoid updates. But no matter which CD I install from I always land up in same version of kernel (6.0.4). The alternate way is for me to get linux-kernel source package for the version I need to use and re-compile the kernel and build the driver against it. But what is the best way to know the which is kernel source package for given version of debian? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Wednesday, April 18, 2012 7:54 PM To: debian-kernel@lists.debian.org Subject: RE: Basic question on debian kernel versions On Wed, 2012-04-18 at 07:13 -0700, sarveshwar.ba...@emulex.com wrote: I installed linux headers in both my installations (one of which I installed using 6.0.0 cd and other using 6.0.4 cd) using apt-get install and dpkg --list shows same output on both the systems: root@debian:~# dpkg --list |grep headers ii linux-headers-2.6.32-5-686 2.6.32-41squeeze2 Header files for Linux 2.6.32-5-686 ii linux-headers-2.6.32-5-common2.6.32-41squeeze2 Common header files for Linux 2.6.32-5 This is because the installer automatically installs updates by default. When I build driver against the two versions the modinfo output is identical. Yes, because you used exactly the same package versions. If you really want to test Debian 6.0.0, you have to tell the installer not to install updates. So I am back to the question: How do I know which driver was built for which version of debian? Unfortunately, I don't think there is an obvious way to distinguish modules built against different versions of the same linux-headers-kversion package. And even more basic question, how do I know which version of kernel I am running now? cat /proc/version Ben. -- Ben Hutchings This sentence contradicts itself - no actually it doesn't.
