Re: Bug#1024082: Bug#1022172: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

2022-11-25 Thread Salvatore Bonaccorso 
Hi Marco,

On Mon, Nov 14, 2022 at 07:06:30PM +0100, Marco d'Itri wrote:
> 
> Try something like this in /lib/udev/rules.d/60-nfs.rules:
> 
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
>   RUN+="/sbin/sysctl -q --pattern ^sunrpc --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="rpcrdma", \
>   RUN+="/sbin/sysctl -q --pattern ^sunrpc.svc_rdma --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="lockd", \
>   RUN+="/sbin/sysctl -q --pattern ^fs.nfs.n[sl]m --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfsv4", \
>   RUN+="/sbin/sysctl -q --pattern 
> ^fs.nfs.(nfs_callback_tcpport|idmap_cache_timeout) --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfs", \
>   RUN+="/sbin/sysctl -q --pattern ^fs.nfs --system"
> 
> Differently from the original file I tired anchoring the patterns, which 
> looks more correct to me.

I have posted the patch(es) upstream implementing your proposal at
https://lore.kernel.org/linux-nfs/20221125130725.1977606-1-car...@debian.org/T/
.

Regards,
Salvatore

Bug#1024082: Bug#1022172: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

2022-11-18 Thread Andras Korn 
On Tue, Nov 15, 2022 at 10:00:43PM +0100, Salvatore Bonaccorso wrote:

Hi,

> > Try something like this in /lib/udev/rules.d/60-nfs.rules:
> > 
> > ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
> >   RUN+="/sbin/sysctl -q --pattern ^sunrpc --system"
> > ACTION=="add", SUBSYSTEM=="module", KERNEL=="rpcrdma", \
> >   RUN+="/sbin/sysctl -q --pattern ^sunrpc.svc_rdma --system"
> > ACTION=="add", SUBSYSTEM=="module", KERNEL=="lockd", \
> >   RUN+="/sbin/sysctl -q --pattern ^fs.nfs.n[sl]m --system"
> > ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfsv4", \
> >   RUN+="/sbin/sysctl -q --pattern 
> > ^fs.nfs.(nfs_callback_tcpport|idmap_cache_timeout) --system"
> > ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfs", \
> >   RUN+="/sbin/sysctl -q --pattern ^fs.nfs --system"
> > 
> > Differently from the original file I tired anchoring the patterns, which 
> > looks more correct to me.
> 
> Thanks, I will try to test this and bring to nfs-utils upstream.
> Michael or Andras, if you can help testing it in your use cases that
> would be helpful.

I don't have a real world test case for this; I don't set any of those sysctls.

Incidentally, busybox sysctl doesn't support --pattern, so if this 
functionality is important, nfs-kernel-server needs to force inclusion of the 
"big" /sbin/sysctl in the initramfs.

András

-- 
 To understand recursion, we must first understand recursion.

Re: Bug#1022172: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

2022-11-15 Thread Salvatore Bonaccorso 
Hi Marco,

On Mon, Nov 14, 2022 at 07:06:30PM +0100, Marco d'Itri wrote:
> 
> Try something like this in /lib/udev/rules.d/60-nfs.rules:
> 
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
>   RUN+="/sbin/sysctl -q --pattern ^sunrpc --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="rpcrdma", \
>   RUN+="/sbin/sysctl -q --pattern ^sunrpc.svc_rdma --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="lockd", \
>   RUN+="/sbin/sysctl -q --pattern ^fs.nfs.n[sl]m --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfsv4", \
>   RUN+="/sbin/sysctl -q --pattern 
> ^fs.nfs.(nfs_callback_tcpport|idmap_cache_timeout) --system"
> ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfs", \
>   RUN+="/sbin/sysctl -q --pattern ^fs.nfs --system"
> 
> Differently from the original file I tired anchoring the patterns, which 
> looks more correct to me.

Thanks, I will try to test this and bring to nfs-utils upstream.
Michael or Andras, if you can help testing it in your use cases that
would be helpful.

Regards,
Salvatore

Re: Bug#1022172: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

2022-11-14 Thread Marco d'Itri 

Try something like this in /lib/udev/rules.d/60-nfs.rules:

ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
  RUN+="/sbin/sysctl -q --pattern ^sunrpc --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="rpcrdma", \
  RUN+="/sbin/sysctl -q --pattern ^sunrpc.svc_rdma --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="lockd", \
  RUN+="/sbin/sysctl -q --pattern ^fs.nfs.n[sl]m --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfsv4", \
  RUN+="/sbin/sysctl -q --pattern 
^fs.nfs.(nfs_callback_tcpport|idmap_cache_timeout) --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfs", \
  RUN+="/sbin/sysctl -q --pattern ^fs.nfs --system"

Differently from the original file I tired anchoring the patterns, which 
looks more correct to me.

-- 
ciao,
Marco


signature.asc
Description: PGP signature