Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-09-06 Thread Luís Picciochi Oliveira
Hi,

I just tested the status of the support for this card using the Debian
kernel packages. Here are the updated results:

-> Squeeze's kernel (2.6.32-5-686 / 2.6.32-21):
It still does not work, either with network-manager or without it.

-> Kernel at experimental (2.6.35-trunk-686 / 2.6.35-1~experimental.2):
It *is* working. If I use if/iwconfig (with n-m disabled/uninstalled), a
backtrace is still printed to the syslog, but the adapter seems to be
working.

The driver doesn't seem to be crashing when I plug in the device anymore.
The problems now only occur when I try to configure it.

Please see the attached logs for more details.

Best regards,
Pitxyoki

Kernel currently at the squeeze repositories (linux-image-2.6.32-5-686 / 
2.6.32-21):

Without network-manager:
1. Plugged in the device:
Sep  6 12:42:50 C-5 kernel: [  600.568024] usb 2-2: new full speed USB device 
using uhci_hcd and address 3
Sep  6 12:42:50 C-5 kernel: [  600.743785] usb 2-2: New USB device found, 
idVendor=13b1, idProduct=000e
Sep  6 12:42:50 C-5 kernel: [  600.743790] usb 2-2: New USB device strings: 
Mfr=1, Product=2, SerialNumber=3
Sep  6 12:42:50 C-5 kernel: [  600.743794] usb 2-2: Product: Linksys Wireless-G 
USB Network Adapter with SpeedBooster
Sep  6 12:42:50 C-5 kernel: [  600.743797] usb 2-2: Manufacturer: Cisco-Linksys
Sep  6 12:42:50 C-5 kernel: [  600.743800] usb 2-2: SerialNumber: 
Sep  6 12:42:50 C-5 kernel: [  600.743927] usb 2-2: configuration #1 chosen 
from 1 choice
Sep  6 12:42:50 C-5 kernel: [  600.840076] usbcore: registered new interface 
driver cdc_ether
Sep  6 12:42:50 C-5 kernel: [  600.977837] usbcore: registered new interface 
driver rndis_host
Sep  6 12:42:50 C-5 kernel: [  601.031500] cfg80211: Using static regulatory 
domain info
Sep  6 12:42:50 C-5 kernel: [  601.031506] cfg80211: Regulatory domain: US
Sep  6 12:42:50 C-5 kernel: [  601.031509]  (start_freq - end_freq @ 
bandwidth), (max_antenna_gain, max_eirp)
Sep  6 12:42:50 C-5 kernel: [  601.031515]  (2402000 KHz - 2472000 KHz @ 
4 KHz), (600 mBi, 2700 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031520]  (517 KHz - 519 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031525]  (519 KHz - 521 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031536]  (521 KHz - 523 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031536]  (523 KHz - 533 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031538]  (5735000 KHz - 5835000 KHz @ 
4 KHz), (600 mBi, 3000 mBm)
Sep  6 12:42:50 C-5 kernel: [  601.031890] cfg80211: Calling CRDA for country: 
US
Sep  6 12:42:50 C-5 kernel: [  601.097776] usb%d: media disconnect
Sep  6 12:42:50 C-5 kernel: [  601.283712] wlan0: register 'rndis_wlan' at 
usb-:00:1d.1-2, Wireless RNDIS device, BCM4320a based, 00:12:17:a0:b9:7c
Sep  6 12:42:50 C-5 kernel: [  601.283742] usbcore: registered new interface 
driver rndis_wlan


2.
[13:09:20] C-5:~# iwconfig wlan0 essid MYESSID
[13:09:41] C-5:~# iwconfig wlan0 key XX
[13:09:44] C-5:~# dhclient wlan0

Sep  6 13:09:53 C-5 kernel: [  114.730225] ADDRCONF(NETDEV_UP): wlan0: link is 
not ready
Sep  6 13:09:53 C-5 kernel: [  114.731999] wlan0: couldn't set packet filter: 
000d
Sep  6 13:09:53 C-5 kernel: [  114.733999] wlan0: couldn't set packet filter: 
000d
Sep  6 13:09:53 C-5 kernel: [  114.735997] wlan0: setting infra mode failed 
(FFEA)
Sep  6 13:09:53 C-5 kernel: [  114.737998] wlan0: setting infra mode failed 
(FFEA)
Sep  6 13:09:53 C-5 kernel: [  114.738995] wlan0: setting SSID failed (FFEA)
Sep  6 13:09:53 C-5 kernel: [  114.741018] wlan0: couldn't set packet filter: 
000d
Sep  6 13:09:53 C-5 kernel: [  114.743002] wlan0: couldn't set packet filter: 
000d
Sep  6 13:09:54 C-5 dhclient: DHCPREQUEST on wlan0 to 255.255.255.255 port 67
Sep  6 13:10:00 C-5 dhclient: DHCPREQUEST on wlan0 to 255.255.255.255 port 67
Sep  6 13:10:07 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 7
Sep  6 13:10:14 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 15
Sep  6 13:10:29 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 9
Sep  6 13:10:38 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 11
Sep  6 13:10:49 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 11
Sep  6 13:11:00 C-5 dhclient: DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 
interval 8
Sep  6 13:11:08 C-5 dhclient: No DHCPOFFERS received.
Sep  6 13:11:08 C-5 dhclient: Trying recorded lease 192.168.2.115
Sep  6 13:11:08 C-5 kernel: [  189.560861] wlan0: couldn't set packet filter: 
000d
Sep  6 13:11:08 C-5 kernel: [  189.563076] wlan0: couldn't set packet filter: 
000d
Sep  6 13:11:11 C-5 dhclient: No working leases in persistent database - 
sleeping.
Sep  6 13:11:11 C-5 kernel: [  192.585036] wlan0: couldn't se

Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-07-30 Thread Luís Picciochi Oliveira
On Sat, Jul 17, 2010 at 4:05 PM, Ben Hutchings  wrote:
> On Sat, 2010-07-03 at 14:04 +0100, Ben Hutchings wrote:
>> On Thu, 2010-07-01 at 15:07 +0100, Luís Picciochi Oliveira wrote:
>> > Hi
>> > This patch seems to have fixed it. Here are the results of my testing:
> [...]
>> Right.  So I'll need to do something a bit smarter to cover all devices.
>
> Can you test the attached patch against the Debian package of 2.6.32?

Just tested this.
There was no crash but something is not right: the interface is
identified as "eth1" instead of the usual wlan0, and ifconfig says it
has "no wireless extensions".

I patched the kernel with both patches:
rndis_host-Poll-status-channel-before-control-channel and
rndis_host-Poll-status-and-control-channels-concurre.patch


I'm attaching the syslog corresponding to the moment I plugged in the device.


I'm sorry, but I will not be available until near September to further
test this.


Best regards,
Pitxyoki
Jul 30 09:15:30 C-5 kernel: [  862.704021] usb 2-2: new full speed USB device 
using uhci_hcd and address 5
Jul 30 09:15:30 C-5 kernel: [  862.879533] usb 2-2: New USB device found, 
idVendor=13b1, idProduct=000e
Jul 30 09:15:30 C-5 kernel: [  862.879538] usb 2-2: New USB device strings: 
Mfr=1, Product=2, SerialNumber=3
Jul 30 09:15:30 C-5 kernel: [  862.879542] usb 2-2: Product: Linksys Wireless-G 
USB Network Adapter with SpeedBooster
Jul 30 09:15:30 C-5 kernel: [  862.879545] usb 2-2: Manufacturer: Cisco-Linksys
Jul 30 09:15:30 C-5 kernel: [  862.879548] usb 2-2: SerialNumber: 
Jul 30 09:15:30 C-5 kernel: [  862.879672] usb 2-2: configuration #1 chosen 
from 1 choice
Jul 30 09:15:30 C-5 kernel: [  862.915061] usbcore: registered new interface 
driver cdc_ether
Jul 30 09:15:30 C-5 kernel: [  863.103625] eth1: register 'rndis_host' at 
usb-:00:1d.1-2, RNDIS device, 00:12:17:a0:b9:7c
Jul 30 09:15:30 C-5 kernel: [  863.103776] usbcore: registered new interface 
driver rndis_host
Jul 30 09:15:30 C-5 kernel: [  863.125533] cfg80211: Using static regulatory 
domain info
Jul 30 09:15:30 C-5 kernel: [  863.125538] cfg80211: Regulatory domain: US
Jul 30 09:15:30 C-5 kernel: [  863.125541]  (start_freq - end_freq @ 
bandwidth), (max_antenna_gain, max_eirp)
Jul 30 09:15:30 C-5 kernel: [  863.125547]  (2402000 KHz - 2472000 KHz @ 
4 KHz), (600 mBi, 2700 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.125553]  (517 KHz - 519 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.125558]  (519 KHz - 521 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.125563]  (521 KHz - 523 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.125567]  (523 KHz - 533 KHz @ 
4 KHz), (600 mBi, 2300 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.125572]  (5735000 KHz - 5835000 KHz @ 
4 KHz), (600 mBi, 3000 mBm)
Jul 30 09:15:30 C-5 kernel: [  863.126078] cfg80211: Calling CRDA for country: 
US
Jul 30 09:15:30 C-5 kernel: [  863.134315] usbcore: registered new interface 
driver rndis_wlan


# ifconfig eth1
eth1  Link encap:Ethernet  HWaddr 00:12:17:a0:b9:7c  
  BROADCAST MULTICAST  MTU:1500  Metric:1
  RX packets:0 errors:0 dropped:0 overruns:0 frame:0
  TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
  collisions:0 txqueuelen:1000 
  RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)

# iwconfig eth1
eth1  no wireless extensions.



Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-07-17 Thread Ben Hutchings
On Sat, 2010-07-03 at 14:04 +0100, Ben Hutchings wrote:
> On Thu, 2010-07-01 at 15:07 +0100, Luís Picciochi Oliveira wrote:
> > Hi
> > This patch seems to have fixed it. Here are the results of my testing:
[...]
> Right.  So I'll need to do something a bit smarter to cover all devices.

Can you test the attached patch against the Debian package of 2.6.32?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
From d67957b9696ed37425244ce25b2b9ed61df1de87 Mon Sep 17 00:00:00 2001
From: Ben Hutchings 
Date: Sat, 17 Jul 2010 15:49:58 +0100
Subject: [PATCH] rndis_host: Poll status and control channels concurrently

---
 drivers/net/usb/rndis_host.c |   42 +-
 1 files changed, 29 insertions(+), 13 deletions(-)

diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
index 52faca1..e0f1399 100644
--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c
@@ -90,6 +90,11 @@ static void rndis_msg_indicate(struct usbnet *dev, struct rndis_indicate *msg,
 	}
 }
 
+static void rndis_notif_complete(struct urb *urb)
+{
+	/* don't care */
+}
+
 /*
  * RPC done RNDIS-style.  Caller guarantees:
  * - message is properly byteswapped
@@ -104,9 +109,9 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
 {
 	struct cdc_state	*info = (void *) &dev->data;
 	struct usb_cdc_notification notification;
+	struct urb		*notif_urb;
 	int			master_ifnum;
 	int			retval;
-	int			partial;
 	unsigned		count;
 	__le32			rsp;
 	u32			xid = 0, msg_len, request_id;
@@ -135,14 +140,19 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
 		return retval;
 
 	/* Some devices don't respond on the control channel until
-	 * polled on the status channel, so do that first. */
-	retval = usb_interrupt_msg(
-		dev->udev,
-		usb_rcvintpipe(dev->udev, dev->status->desc.bEndpointAddress),
-		¬ification, sizeof(notification), &partial,
-		RNDIS_CONTROL_TIMEOUT_MS);
-	if (unlikely(retval < 0))
-		return retval;
+	 * polled on the status channel, so poll that as well. */
+	notif_urb = usb_alloc_urb(0, GFP_KERNEL);
+	if (!notif_urb)
+		return -ENOMEM;
+	usb_fill_int_urb(notif_urb, dev->udev,
+			 usb_rcvintpipe(dev->udev,
+	dev->status->desc.bEndpointAddress),
+			 ¬ification, sizeof(notification),
+			 rndis_notif_complete, NULL,
+			 dev->status->desc.bInterval);
+	retval = usb_submit_urb(notif_urb, GFP_KERNEL);
+	if (retval)
+		goto out_free;
 
 	/* Poll the control channel; the request probably completed immediately */
 	rsp = buf->msg_type | RNDIS_MSG_COMPLETION;
@@ -161,14 +171,15 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
 			if (likely(buf->msg_type == rsp)) {
 if (likely(request_id == xid)) {
 	if (unlikely(rsp == RNDIS_MSG_RESET_C))
-		return 0;
+		goto out_kill;
 	if (likely(RNDIS_STATUS_SUCCESS
 			== buf->status))
-		return 0;
+		goto out_kill;
 	dev_dbg(&info->control->dev,
 		"rndis reply status %08x\n",
 		le32_to_cpu(buf->status));
-	return -EL3RST;
+	retval = -EL3RST;
+	goto out_kill;
 }
 dev_dbg(&info->control->dev,
 	"rndis reply id %d expected %d\n",
@@ -211,7 +222,12 @@ int rndis_command(struct usbnet *dev, struct rndis_msg_hdr *buf, int buflen)
 		msleep(20);
 	}
 	dev_dbg(&info->control->dev, "rndis response timeout\n");
-	return -ETIMEDOUT;
+	retval = -ETIMEDOUT;
+out_kill:
+	usb_kill_urb(notif_urb);
+out_free:
+	usb_free_urb(notif_urb);
+	return retval;
 }
 EXPORT_SYMBOL_GPL(rndis_command);
 
-- 
1.7.1



signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-07-03 Thread Ben Hutchings
On Thu, 2010-07-01 at 15:07 +0100, Luís Picciochi Oliveira wrote:
> Hi
> This patch seems to have fixed it. Here are the results of my testing:
> 
> 
> kernel.org's 2.6.34:
> => with the usbnet-Set-parent-device-early-for-netdev_printk patch:
> Seems to work without any problems

OK, that should be fixed in a stable update.

> Debian's 2.6.34 from experimental:
> => with both patches:
>   usbnet-Set-parent-device-early-for-netdev_printk
>   rndis_host-Poll-status-channel-before-control-channel
> 
> The module is loaded without any apparent problems. I get this on the
> syslog when I try to configure the device:
> 
> # ifconfig wlan0 up
> Jun 30 16:09:00 C-5 kernel: [   79.184493] rndis_wlan 2-2:1.0: wlan0:
> couldn't set packet filter: 000d
> 
> NetworkManager also makes that line appear on syslog and doesn't seem
> to be able to configure it.
[...]

Right.  So I'll need to do something a bit smarter to cover all devices.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-07-01 Thread Luís Picciochi Oliveira
Hi
This patch seems to have fixed it. Here are the results of my testing:


kernel.org's 2.6.34:
=> with the usbnet-Set-parent-device-early-for-netdev_printk patch:
Seems to work without any problems


Debian's 2.6.34 from experimental:
=> with both patches:
  usbnet-Set-parent-device-early-for-netdev_printk
  rndis_host-Poll-status-channel-before-control-channel

The module is loaded without any apparent problems. I get this on the
syslog when I try to configure the device:

# ifconfig wlan0 up
Jun 30 16:09:00 C-5 kernel: [   79.184493] rndis_wlan 2-2:1.0: wlan0:
couldn't set packet filter: 000d

NetworkManager also makes that line appear on syslog and doesn't seem
to be able to configure it.


=> _only_ with usbnet-Set-parent-device-early-for-netdev_printk
(rndis_host-Poll-status... removed)
Seems to work without any problems.



The attachment has a more complete syslog with the moment I plugged
the device and NetworkManager tried to configure it.


Best regards,
Pitxyoki


On Tue, Jun 29, 2010 at 2:18 AM, Ben Hutchings  wrote:
(...)
>
> I think the attached patch will fix this.  Please test it.
>

#
kernel.org 2.6.34
#
> with usbnet-Set-parent-device-early-for-netdev_printk.patch:
Seems to work without any problems.



Debian's 2.6.34-1~experimental.2

with both:
-> usbnet-Set-parent-device-early-for-netdev_printk.patch
-> rndis_host-Poll-status-channel-before-control-channel.patch

Jun 30 16:08:59 C-5 kernel: [   78.264019] usb 2-2: new full speed USB device 
using uhci_hcd and address 3
Jun 30 16:08:59 C-5 kernel: [   78.443509] usb 2-2: New USB device found, 
idVendor=13b1, idProduct=000e
Jun 30 16:08:59 C-5 kernel: [   78.443516] usb 2-2: New USB device strings: 
Mfr=1, Product=2, SerialNumber=3
Jun 30 16:08:59 C-5 kernel: [   78.443521] usb 2-2: Product: Linksys Wireless-G 
USB Network Adapter with SpeedBooster
Jun 30 16:08:59 C-5 kernel: [   78.443525] usb 2-2: Manufacturer: Cisco-Linksys
Jun 30 16:08:59 C-5 kernel: [   78.443529] usb 2-2: SerialNumber: 
Jun 30 16:09:00 C-5 kernel: [   78.515161] usbcore: registered new interface 
driver cdc_ether
Jun 30 16:09:00 C-5 kernel: [   78.655691] usbcore: registered new interface 
driver rndis_host
Jun 30 16:09:00 C-5 kernel: [   78.714723] cfg80211: Calling CRDA to update 
world regulatory domain
Jun 30 16:09:00 C-5 kernel: [   78.777501] rndis_wlan 2-2:1.0: (unregistered 
net_device): media disconnect
Jun 30 16:09:00 C-5 NetworkManager:   Found wlan radio killswitch rfkill0 
(at /sys/devices/pci:00/:00:1d.1/usb2/2-2/ieee80211/phy0/rfkill0) 
(driver )
Jun 30 16:09:00 C-5 kernel: [   78.967795] rndis_wlan 2-2:1.0: wlan0: register 
'rndis_wlan' at usb-:00:1d.1-2, Wireless RNDIS device, BCM4320a based, 
00:12:17:a0:b9:7c
Jun 30 16:09:00 C-5 kernel: [   78.967837] usbcore: registered new interface 
driver rndis_wlan
Jun 30 16:09:00 C-5 NetworkManager:SCPlugin-Ifupdown: devices added (path: 
/sys/devices/pci:00/:00:1d.1/usb2/2-2/2-2:1.0/net/wlan0, iface: wlan0)
Jun 30 16:09:00 C-5 NetworkManager:SCPlugin-Ifupdown: device added (path: 
/sys/devices/pci:00/:00:1d.1/usb2/2-2/2-2:1.0/net/wlan0, iface: wlan0): 
no ifupdown configuration found.
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): driver supports SSID scans 
(scan_capa 0x01).
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): new 802.11 WiFi device 
(driver: 'rndis_wlan')
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): exported as 
/org/freedesktop/NetworkManager/Devices/1
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): now managed
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): device state change: 1 -> 
2 (reason 2)
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): bringing up device.
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): preparing device.
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): deactivating device 
(reason: 2).
Jun 30 16:09:00 C-5 kernel: [   79.180877] ADDRCONF(NETDEV_UP): wlan0: link is 
not ready
Jun 30 16:09:00 C-5 kernel: [   79.184493] rndis_wlan 2-2:1.0: wlan0: couldn't 
set packet filter: 000d
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): supplicant interface 
state:  starting -> ready
Jun 30 16:09:00 C-5 NetworkManager:   (wlan0): device state change: 2 -> 
3 (reason 42)
Jun 30 16:09:00 C-5 wpa_supplicant[1451]: Failed to initiate AP scan.

# ifconfig wlan0 up
Jun 30 16:10:11 C-5 kernel: [  150.019724] rndis_wlan 2-2:1.0: wlan0: couldn't 
set packet filter: 000d


with:
-> usbnet-Set-parent-device-early-for-netdev_printk.patch
and without:
-> rndis_host-Poll-status-channel-before-control-channel.patch
Seems to work without any problems.






Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-28 Thread Ben Hutchings
On Thu, 2010-06-24 at 02:51 +0100, Luís Picciochi Oliveira wrote:
> On Thu, Jun 24, 2010 at 2:27 AM, Ben Hutchings  wrote:
> > Please can you confirm or correct the following summary of your results
> > so far:
> >
> > Debian 2.6.32-15: fails to pass traffic
> 
> Correct.
> 
> > Debian 2.6.32-15 with patch reverted: good
> I had no crashes since Monday (June 21st). So, apparently yes.
> It used to take a while to crash: minutes to hours. But so far it hasn't 
> failed.
> 
> > Debian 2.6.34-1~experimental.2: fails to pass traffic
> > Debian 2.6.34-1~experimental.2 with patch reverted: driver crashes!
> 
> The driver crashes as soon as I plug the adapter with both versions.
> Now that I compare them, the crash logs with and without the patch
> seem to be exactly the same crash.
> 
> I just rebooted to test with a vanilla 2.6.34 kernel from kernel.org:
> it also crashes with the same error. I'm attaching the log from that
> kernel.

I think the attached patch will fix this.  Please test it.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
From 97b812bf3f4abd5d554f38bc67a8d7fd6ab97d6d Mon Sep 17 00:00:00 2001
From: Ben Hutchings 
Date: Tue, 29 Jun 2010 02:15:48 +0100
Subject: [PATCH] usbnet: Set parent device early for netdev_printk()

netdev_printk() follows the net_device's parent device pointer, so
we must set that earlier than we previously did.
---
 drivers/net/usb/usbnet.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index a95c73d..81c76ad 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1293,6 +1293,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 		goto out;
 	}
 
+	/* netdev_printk() needs this so do it as early as possible */
+	SET_NETDEV_DEV(net, &udev->dev);
+
 	dev = netdev_priv(net);
 	dev->udev = xdev;
 	dev->intf = udev;
@@ -1377,8 +1380,6 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
 		dev->rx_urb_size = dev->hard_mtu;
 	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
 
-	SET_NETDEV_DEV(net, &udev->dev);
-
 	if ((dev->driver_info->flags & FLAG_WLAN) != 0)
 		SET_NETDEV_DEVTYPE(net, &wlan_type);
 	if ((dev->driver_info->flags & FLAG_WWAN) != 0)
-- 
1.7.1



signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-23 Thread Luís Picciochi Oliveira
On Thu, Jun 24, 2010 at 2:27 AM, Ben Hutchings  wrote:
> Please can you confirm or correct the following summary of your results
> so far:
>
> Debian 2.6.32-15: fails to pass traffic

Correct.

> Debian 2.6.32-15 with patch reverted: good
I had no crashes since Monday (June 21st). So, apparently yes.
It used to take a while to crash: minutes to hours. But so far it hasn't failed.

> Debian 2.6.34-1~experimental.2: fails to pass traffic
> Debian 2.6.34-1~experimental.2 with patch reverted: driver crashes!

The driver crashes as soon as I plug the adapter with both versions.
Now that I compare them, the crash logs with and without the patch
seem to be exactly the same crash.

I just rebooted to test with a vanilla 2.6.34 kernel from kernel.org:
it also crashes with the same error. I'm attaching the log from that
kernel.

Regards,
Pitxyoki


rndis_wlan - vanilla 2.6.34
Description: Binary data


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-23 Thread Ben Hutchings
On Thu, 2010-06-24 at 02:09 +0100, Luís Picciochi Oliveira wrote:
> On Thu, Jun 24, 2010 at 1:44 AM, Ben Hutchings  wrote:
> > On Mon, 2010-06-21 at 22:31 +0100, Luís Picciochi Oliveira wrote:
> >
> > Please do test that as soon as possible.  This change is included in
> > release candidates for 2.6.35 and will need to be reverted there as well
> > if it caused this regression.
> 
> Please see my previous answer on this bug report (I also sent it to
> you, you should have received that on your mailbox as well).

Yes, sorry.

> I have also compiled the "vanilla" 2.6.34 kernel from kernel.org,
> which I'll test tomorrow.
> Should I also test the current 2.6.35 rc?

Please can you confirm or correct the following summary of your results
so far:

Debian 2.6.32-15: fails to pass traffic
Debian 2.6.32-15 with patch reverted: good
Debian 2.6.34-1~experimental.2: fails to pass traffic
Debian 2.6.34-1~experimental.2 with patch reverted: driver crashes!

Testing either or both of those additional versions should provide
useful information.  Unfortunately it looks like there may be a second
bug here.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-23 Thread Luís Picciochi Oliveira
On Thu, Jun 24, 2010 at 1:44 AM, Ben Hutchings  wrote:
> On Mon, 2010-06-21 at 22:31 +0100, Luís Picciochi Oliveira wrote:
>
> Please do test that as soon as possible.  This change is included in
> release candidates for 2.6.35 and will need to be reverted there as well
> if it caused this regression.

Please see my previous answer on this bug report (I also sent it to
you, you should have received that on your mailbox as well).

I have also compiled the "vanilla" 2.6.34 kernel from kernel.org,
which I'll test tomorrow.
Should I also test the current 2.6.35 rc?

Best regards,
Pitxyoki



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktimzlj9kaqajt89hbuotrcqgykmr8hyjwswnh...@mail.gmail.com



Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-23 Thread Ben Hutchings
On Mon, 2010-06-21 at 22:31 +0100, Luís Picciochi Oliveira wrote:
> Possibily you are right. :)
> It seems to be working for 2.6.32. I'll compile 2.6.34 today or
> tomorrow without the patch and see if it also works.

Please do test that as soon as possible.  This change is included in
release candidates for 2.6.35 and will need to be reverted there as well
if it caused this regression.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-23 Thread Luís Picciochi Oliveira
It doesn't seem to work on 2.6.34. See attachment.
I had no problems on 2.6.32-5 yet.

Regards,
Pitxyoki


rndis_wlan - 2.6.34-1 (without rndis_host patch)
Description: Binary data


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-21 Thread Luís Picciochi Oliveira
Possibily you are right. :)
It seems to be working for 2.6.32. I'll compile 2.6.34 today or
tomorrow without the patch and see if it also works.

Thanks,
Pitxyoki


On Sun, Jun 20, 2010 at 11:29 PM, Ben Hutchings  wrote:
(...)
>
> Or possibly this bug fix is bad for that device:
>
> debian/patches/bugfix/all/rndis_host-Poll-status-channel-before-control-channel.patch
>
> Could you try reverting that in either of the Debian kernel packages?
>
> Ben.
>
> --
> Ben Hutchings
> Once a job is fouled up, anything done to improve it makes it worse.
>



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktin7ecsp2bcrjx112ugtxtvtstmiydwsaziqd...@mail.gmail.com



Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-20 Thread Ben Hutchings
On Fri, 2010-06-18 at 00:55 +0100, Luís Picciochi Oliveira wrote:
> As I told you I would, I tested WUSB54GS support on the kernels
> shipped by Debian: 2.6.32 (2.6.32-15) from Squeeze and 2.6.34
> (2.6.34-1~experimental.2) from sid. Unfortunately, none of them
> worked. :(
> 
> I'm attaching the output at syslog with network-manager and with an
> /etc/network/interfaces file (and no n-m installed).
> 
> 
> Perhaps there's some patch missing that I didn't point out... I'm
> sorry but I can't tell what can it be now.
> 
> 
> I'm using the vanilla 2.6.33-rc1 kernel again, which works.

Or possibly this bug fix is bad for that device:

debian/patches/bugfix/all/rndis_host-Poll-status-channel-before-control-channel.patch

Could you try reverting that in either of the Debian kernel packages?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-06-17 Thread Luís Picciochi Oliveira
As I told you I would, I tested WUSB54GS support on the kernels
shipped by Debian: 2.6.32 (2.6.32-15) from Squeeze and 2.6.34
(2.6.34-1~experimental.2) from sid. Unfortunately, none of them
worked. :(

I'm attaching the output at syslog with network-manager and with an
/etc/network/interfaces file (and no n-m installed).


Perhaps there's some patch missing that I didn't point out... I'm
sorry but I can't tell what can it be now.


I'm using the vanilla 2.6.33-rc1 kernel again, which works.



Regards,
Pitxyoki


rndis_wlan - 2.6.32-5 ifup
Description: Binary data


rndis_wlan - 2.6.32-5 n-m
Description: Binary data


rndis_wlan - ifup 2.6.34
Description: Binary data


rndis_wlan - n-m 2.6.34
Description: Binary data


Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-02-17 Thread maximilian attems
On Wed, Feb 17, 2010 at 03:21:36PM +, Luís Picciochi Oliveira wrote:
> 
> The relevant patches were the ones resulting from bug #12794 at the
> kernel.org buzilla [1]. This resulted in three commits to the mainline
> kernel: [2,3,4].
> 
> Regards,
> Pitxyoki
> 
> [1] http://bugzilla.kernel.org/show_bug.cgi?id=12794
> [2] 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=634a555ce3ee5ea1fdcaee8b4ac9ce7b54f301ac
> [3] 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c1f8ca1d837148bf061d6ffa2038366e3cf0e4d7
> [4] 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=77593ae28c4c134eaf28ef34ecac3cd4464ecd6e

cool, that was helpful!

sent request to sta...@kernel.org as they are small enough to apply
for such. if in the unlikely case they wouldn't get taken, we will
add them to debian linux-2.6. let's first see and wait.

good evening



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100217163158.gn19...@baikonur.stro.at



Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-02-17 Thread Luís Picciochi Oliveira
Hello,

On Wed, Feb 17, 2010 at 10:43 AM, maximilian attems  wrote:
>
> please be specific which commits (sha1sums) are needed, the more info you give
> us the quicker we can backport those or feed upstream stable.
>
> thanks for giving feedback.
>

The relevant patches were the ones resulting from bug #12794 at the
kernel.org buzilla [1]. This resulted in three commits to the mainline
kernel: [2,3,4].

Regards,
Pitxyoki

[1] http://bugzilla.kernel.org/show_bug.cgi?id=12794
[2] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=634a555ce3ee5ea1fdcaee8b4ac9ce7b54f301ac
[3] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c1f8ca1d837148bf061d6ffa2038366e3cf0e4d7
[4] 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=77593ae28c4c134eaf28ef34ecac3cd4464ecd6e



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/99598f621002170721n40ca9d6ag450d0e6c906ec...@mail.gmail.com



Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-02-17 Thread maximilian attems
hello

On Wed, Feb 17, 2010 at 10:28:55AM +0100, Julian Andres Klode wrote:
> Am Samstag, den 06.02.2010, 17:00 + schrieb Luís Picciochi Oliveira:
> > 
> > However, I have been using linux kernel 2.6.33-rc1 because this card
> > is now supported and works well on it. So, I don't need ndiswrapper
> > anymore.

please be specific which commits (sha1sums) are needed, the more info you give
us the quicker we can backport those or feed upstream stable.

thanks for giving feedback.



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100217104302.ga12...@baikonur.stro.at



Re: Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-02-17 Thread Julian Andres Klode
reassign 520468 linux-2.6
severity 520468 normal
retitle  520468 Incorporate fixes for WUSB54GS support from 2.6.33
thanks

Am Samstag, den 06.02.2010, 17:00 + schrieb Luís Picciochi Oliveira:
> Hello,
> I just tested ndiswrapper 1.55. It is still giving the same output as
> before.
> 
> However, I have been using linux kernel 2.6.33-rc1 because this card
> is now supported and works well on it. So, I don't need ndiswrapper
> anymore.
> Notice that with 2.6.32 (currently at the testing repositories) this
> card is detected by the kernel but there are some problems with the
> module that were only resolved with 2.6.33, so people using it might
> still need to resort to ndiswrapper.
> 
> Regards,
> Pitxyoki

I am reassigning this bug to linux-2.6 with the request to incorporate
fixes for the issues in wusb54gs support into the native module; as I do
not support ndiswrapper for cards which have native drivers in mainline.

Regards,
Julian

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/1266398935.2729.3.ca...@hp



Processed: Re: Bug#520468: Incorporate fixes for WUSB54GS support from 2.6.33

2010-02-17 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> reassign 520468 linux-2.6
Bug #520468 [ndiswrapper-source] ndiswrapper-source: ndiswrapper does not show 
device with kernel > 2.6.26
Bug reassigned from package 'ndiswrapper-source' to 'linux-2.6'.
Bug No longer marked as found in versions ndiswrapper/1.54-1.
> severity 520468 normal
Bug #520468 [linux-2.6] ndiswrapper-source: ndiswrapper does not show device 
with kernel > 2.6.26
Severity set to 'normal' from 'important'

> retitle  520468 Incorporate fixes for WUSB54GS support from 2.6.33
Bug #520468 [linux-2.6] ndiswrapper-source: ndiswrapper does not show device 
with kernel > 2.6.26
Changed Bug title to 'Incorporate fixes for WUSB54GS support from 2.6.33' from 
'ndiswrapper-source: ndiswrapper does not show device with kernel > 2.6.26'
> thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.126639899012106.transcr...@bugs.debian.org