Bug#521553: rt2860 driver contains non-free firmware
I demand that Ben Hutchings may or may not have written... > On Fri, 2009-04-10 at 00:28 +0100, Darren Salt wrote: [snip] >> [ http://alioth.debian.org/~dsalt-guest/rt2860sta-fw.tar.gz ] is now, I >> believe, completed; at least, it Works For Me. (I think that it's in a >> suitable form for forwarding upstream, though they may want to retain the >> option of embedding the firmware. This should be reasonably easy to >> accomodate.) > [...] > Here's a patch which makes slightly smaller changes and also eliminates the > duplicate CRC function. I would like to apply this and submit it upstream, > but could you test it for me before I do that? Fails due to (at least) CRC errors. The content of the buffer is, as far as the CRC calculation is concerned, *entirely* bit-reversed. (Yes, I missed that too at first.) So I've added a CRC calculation patch and modified my patch (which, though it has more changes, should be a bit cleaner) to use the new CRC code; URL as above. -- | Darren Salt| linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + Output less CO2 => avoid boiling weather. TIME IS RUNNING OUT *FAST*. I will not forget me. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#521553: rt2860 driver contains non-free firmware
I demand that Damyan Ivanov may or may not have written... [snip] > Darren Salt is working on porting rt2860 to use the standard firmware > loading mechanism. In my understanding, that would allow the driver to > remain in the tree (enabled) and the formware moved to the firmware-linux > package. > The current state is at > http://alioth.debian.org/~dsalt-guest/rt2860sta-fw.tar.gz This is now, I believe, completed; at least, it Works For Me. (I think that it's in a suitable form for forwarding upstream, though they may want to retain the option of embedding the firmware. This should be reasonably easy to accomodate.) rt2870 seems to follow much the same pattern. I may yet choose to convert it but, lacking such hardware, I cannot test it. [snip] -- | Darren Salt| linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + Output *more* particulate pollutants. BUFFER AGAINST GLOBAL WARMING. Don't worry, I'm fluent in weirdo... -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#521553: rt2860 driver contains non-free firmware
-=| maximilian attems, Sun, Mar 29, 2009 at 07:05:49PM +0200 |=- > On Sat, 28 Mar 2009, Ben Hutchings wrote: > > > I'd like to commit the following change. Obviously this disables the > > drivers and they will have to be modified to work with external firmware. > > But I don't see why we should wait for that. > > ok for committing to trunk, so that can be sorted for 2.6.30. > > don't see the need to have to rush that for 2.6.29, > who just happened to be uploaded. Darren Salt is working on porting rt2860 to use the standard firmware loading mechanism. In my understanding, that would allow the driver to remain in the tree (enabled) and the formware moved to the firmware-linux package. The current state is at http://alioth.debian.org/~dsalt-guest/rt2860sta-fw.tar.gz It is still a work in progress, but proves that the idea is feasible. Could you consider incorporating that patch for rt2860 instead of cutting it off completely? I hope Darren finishes it before 2.6.30 is out. That would make the life of us owners of EeePC with the rt2860 wireless card a lot easier. -- damJabberID: d...@jabber.minus273.org signature.asc Description: Digital signature
Bug#521553: rt2860 driver contains non-free firmware
On Sat, 28 Mar 2009, Ben Hutchings wrote: > I'd like to commit the following change. Obviously this disables the > drivers and they will have to be modified to work with external firmware. > But I don't see why we should wait for that. > > Ben. ok for committing to trunk, so that can be sorted for 2.6.30. don't see the need to have to rush that for 2.6.29, who just happened to be uploaded. > Index: debian/changelog > === > --- debian/changelog (revision 13283) > +++ debian/changelog (working copy) > @@ -1,4 +1,4 @@ > -linux-2.6 (2.6.29-2) UNRELEASED; urgency=low > +linux-2.6 (2.6.29.dfsg.1-2) UNRELEASED; urgency=low > >[ Martin Michlmayr ] >* [arm/ixp4xx] Build in LEDS_TRIGGER_TIMER (closes: #521141). > @@ -6,8 +6,12 @@ >[ maximilian attems ] >* linux-libc-dev: Bump versioned replaces libdrm-dev. > > - -- Martin Michlmayr Wed, 25 Mar 2009 08:57:14 +0100 > + [ Ben Hutchings ] > + * Remove firmware from driver/staging (closes: #521553) > +- Disable affected drivers: rt2860, rt2870 > > + -- Ben Hutchings Sat, 28 Mar 2009 10:42:00 -0500 > + > linux-2.6 (2.6.29-1) unstable; urgency=low > >* New upstream release > Index: debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch > === > --- debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch > (revision 0) > +++ debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch > (revision 0) > @@ -0,0 +1,11 @@ > +diff --git a/drivers/staging/slicoss/Kconfig > b/drivers/staging/slicoss/Kconfig > +index d2993d3..2b510e0 100644 > +--- a/drivers/staging/slicoss/Kconfig > b/drivers/staging/slicoss/Kconfig > +@@ -1,5 +1,6 @@ > + config SLICOSS > + tristate "Alacritech Gigabit IS-NIC support" > ++depends on BROKEN > + depends on PCI && X86 && NETDEV_1000 > + default n > + help > Index: debian/patches/debian/dfsg/drivers-staging-otus-disable.patch > === > --- debian/patches/debian/dfsg/drivers-staging-otus-disable.patch > (revision 0) > +++ debian/patches/debian/dfsg/drivers-staging-otus-disable.patch > (revision 0) > @@ -0,0 +1,11 @@ > +diff --git a/drivers/staging/otus/Kconfig b/drivers/staging/otus/Kconfig > +index d549d08..fef9785 100644 > +--- a/drivers/staging/otus/Kconfig > b/drivers/staging/otus/Kconfig > +@@ -1,5 +1,6 @@ > + config OTUS > + tristate "Atheros OTUS 802.11n USB wireless support" > ++depends on BROKEN > + depends on USB && WLAN_80211 && MAC80211 > + default N > + ---help--- > Index: debian/patches/debian/dfsg/files-1 > === > --- debian/patches/debian/dfsg/files-1(revision 13283) > +++ debian/patches/debian/dfsg/files-1(working copy) > @@ -57,5 +57,15 @@ > > rm drivers/scsi/qlogicpti_asm.c > > +rm drivers/staging/me4000/me*_firmware.h > + > +rm drivers/staging/otus/hal/hp*fw*.c > + > +rm drivers/staging/rt2860/common/firmware.h > + > +rm drivers/staging/rt2870/common/firmware.h > + > +rm drivers/staging/slicoss/*ucode.h > + > rm sound/pci/cs46xx/cs46xx_image.h > rm sound/pci/cs46xx/imgs > Index: debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch > === > --- debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch > (revision 0) > +++ debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch > (revision 0) > @@ -0,0 +1,12 @@ > +diff --git a/drivers/staging/me4000/Kconfig b/drivers/staging/me4000/Kconfig > +index 5e6c9de..45d2ea9 100644 > +--- a/drivers/staging/me4000/Kconfig > b/drivers/staging/me4000/Kconfig > +@@ -1,6 +1,7 @@ > + config ME4000 > + tristate "Meilhaus ME-4000 support" > + default n > ++depends on BROKEN > + depends on PCI > + help > + This driver supports the Meilhaus ME-4000 family of boards > Index: debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch > === > --- debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch > (revision 0) > +++ debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch > (revision 0) > @@ -0,0 +1,11 @@ > +diff --git a/drivers/staging/rt2860/Kconfig b/drivers/staging/rt2860/Kconfig > +index 7f44e5e..9fb130d 100644 > +--- a/drivers/staging/rt2860/Kconfig > b/drivers/staging/rt2860/Kconfig > +@@ -1,5 +1,6 @@ > + config RT2860 > + tristate "Ralink 2860 wireless support" > ++depends on BROKEN > + depends on PCI && X86 && WLAN_80211 > + ---help--- > + This is an experimental driver for the Ralink 2860 wireless chip. > Index: debian/patches/debian/dfsg/drivers-staging-rt2870-disable.patch > === > --- de
Re: Bug#521553: rt2860 driver contains non-free firmware
On Sat, Mar 28, 2009 at 04:23:41PM +, Ben Hutchings wrote: > I'd like to commit the following change. This is okay for trunk. However not for sid. Bastian -- A Vulcan can no sooner be disloyal than he can exist without breathing. -- Kirk, "The Menagerie", stardate 3012.4 -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#521553: rt2860 driver contains non-free firmware
On Sat, Mar 28, 2009 at 02:34:14PM +, Ben Hutchings wrote: > On Sat, 2009-03-28 at 15:03 +0200, Damyan Ivanov wrote: > > Package: linux-2.6 > > Version: 2.6.29 > > Severity: serious > > > > [cc-ed to debian-eeepc-devel as the affected network controller is uused in > > several eeepc models] > > > > Hi, > > > > The file drivers/staging/rt2860/common/firmware.h contains the following > > text: > [...] > > There was me thinking we'd finally got rid of the firmware, and more of > it pops up in drivers/staging. Another reason to hate that directory. > A quick search finds the following additional firmware files: > > drivers/staging/me4000/me4000_firmware.h > drivers/staging/me4000/me4610_firmware.h > drivers/staging/otus/hal/hp*fw*.c > drivers/staging/rt2870/common/firmware.h > drivers/staging/slicoss/gbrcvucode.h > drivers/staging/slicoss/oasisrcvucode.h > > Of these, only rt2860 and rt2870 are enabled in Debian. I'd like to commit the following change. Obviously this disables the drivers and they will have to be modified to work with external firmware. But I don't see why we should wait for that. Ben. Index: debian/changelog === --- debian/changelog(revision 13283) +++ debian/changelog(working copy) @@ -1,4 +1,4 @@ -linux-2.6 (2.6.29-2) UNRELEASED; urgency=low +linux-2.6 (2.6.29.dfsg.1-2) UNRELEASED; urgency=low [ Martin Michlmayr ] * [arm/ixp4xx] Build in LEDS_TRIGGER_TIMER (closes: #521141). @@ -6,8 +6,12 @@ [ maximilian attems ] * linux-libc-dev: Bump versioned replaces libdrm-dev. - -- Martin Michlmayr Wed, 25 Mar 2009 08:57:14 +0100 + [ Ben Hutchings ] + * Remove firmware from driver/staging (closes: #521553) +- Disable affected drivers: rt2860, rt2870 + -- Ben Hutchings Sat, 28 Mar 2009 10:42:00 -0500 + linux-2.6 (2.6.29-1) unstable; urgency=low * New upstream release Index: debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch === --- debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch (revision 0) +++ debian/patches/debian/dfsg/drivers-staging-slicoss-disable.patch (revision 0) @@ -0,0 +1,11 @@ +diff --git a/drivers/staging/slicoss/Kconfig b/drivers/staging/slicoss/Kconfig +index d2993d3..2b510e0 100644 +--- a/drivers/staging/slicoss/Kconfig b/drivers/staging/slicoss/Kconfig +@@ -1,5 +1,6 @@ + config SLICOSS + tristate "Alacritech Gigabit IS-NIC support" ++ depends on BROKEN + depends on PCI && X86 && NETDEV_1000 + default n + help Index: debian/patches/debian/dfsg/drivers-staging-otus-disable.patch === --- debian/patches/debian/dfsg/drivers-staging-otus-disable.patch (revision 0) +++ debian/patches/debian/dfsg/drivers-staging-otus-disable.patch (revision 0) @@ -0,0 +1,11 @@ +diff --git a/drivers/staging/otus/Kconfig b/drivers/staging/otus/Kconfig +index d549d08..fef9785 100644 +--- a/drivers/staging/otus/Kconfig b/drivers/staging/otus/Kconfig +@@ -1,5 +1,6 @@ + config OTUS + tristate "Atheros OTUS 802.11n USB wireless support" ++ depends on BROKEN + depends on USB && WLAN_80211 && MAC80211 + default N + ---help--- Index: debian/patches/debian/dfsg/files-1 === --- debian/patches/debian/dfsg/files-1 (revision 13283) +++ debian/patches/debian/dfsg/files-1 (working copy) @@ -57,5 +57,15 @@ rm drivers/scsi/qlogicpti_asm.c +rm drivers/staging/me4000/me*_firmware.h + +rm drivers/staging/otus/hal/hp*fw*.c + +rm drivers/staging/rt2860/common/firmware.h + +rm drivers/staging/rt2870/common/firmware.h + +rm drivers/staging/slicoss/*ucode.h + rm sound/pci/cs46xx/cs46xx_image.h rm sound/pci/cs46xx/imgs Index: debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch === --- debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch (revision 0) +++ debian/patches/debian/dfsg/drivers-staging-me4000-disable.patch (revision 0) @@ -0,0 +1,12 @@ +diff --git a/drivers/staging/me4000/Kconfig b/drivers/staging/me4000/Kconfig +index 5e6c9de..45d2ea9 100644 +--- a/drivers/staging/me4000/Kconfig b/drivers/staging/me4000/Kconfig +@@ -1,6 +1,7 @@ + config ME4000 + tristate "Meilhaus ME-4000 support" + default n ++ depends on BROKEN + depends on PCI + help + This driver supports the Meilhaus ME-4000 family of boards Index: debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch === --- debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch (revision 0) +++ debian/patches/debian/dfsg/drivers-staging-rt2860-disable.patch (revision 0) @@ -0,0 +1,11 @@ +diff --git a/drivers/staging/rt2860/K
Bug#521553: rt2860 driver contains non-free firmware
On Sat, 2009-03-28 at 15:03 +0200, Damyan Ivanov wrote: > Package: linux-2.6 > Version: 2.6.29 > Severity: serious > > [cc-ed to debian-eeepc-devel as the affected network controller is uused in > several eeepc models] > > Hi, > > The file drivers/staging/rt2860/common/firmware.h contains the following > text: [...] There was me thinking we'd finally got rid of the firmware, and more of it pops up in drivers/staging. Another reason to hate that directory. A quick search finds the following additional firmware files: drivers/staging/me4000/me4000_firmware.h drivers/staging/me4000/me4610_firmware.h drivers/staging/otus/hal/hp*fw*.c drivers/staging/rt2870/common/firmware.h drivers/staging/slicoss/gbrcvucode.h drivers/staging/slicoss/oasisrcvucode.h Of these, only rt2860 and rt2870 are enabled in Debian. Ben. On Sat, 2009-03-28 at 15:03 +0200, Damyan Ivanov wrote: Package: linux-2.6 Version: 2.6.29 Severity: serious [cc-ed to debian-eeepc-devel as the affected network controller is uused in several eeepc models] Hi, The file drivers/staging/rt2860/common/firmware.h contains the following text: [...] There was me thinking we'd finally got rid of the firmware, and more of it pops up in drivers/staging. Another reason to hate that directory. A quick search finds the following additional firmware files: drivers/staging/me4000/me4000_firmware.h drivers/staging/me4000/me4610_firmware.h drivers/staging/otus/hal/hp*fw*.c drivers/staging/rt2870/common/firmware.h drivers/staging/slicoss/gbrcvucode.h drivers/staging/slicoss/oasisrcvucode.h Of these, only rt2860 and rt2870 are enabled in Debian. Ben. signature.asc Description: Digital signature
Bug#521553: rt2860 driver contains non-free firmware
Package: linux-2.6
Version: 2.6.29
Severity: serious
[cc-ed to debian-eeepc-devel as the affected network controller is uused in
several eeepc models]
Hi,
The file drivers/staging/rt2860/common/firmware.h contains the following
text:
/*
Copyright (c) 2007, Ralink Technology Corporation
All rights reserved.
Redistribution. Redistribution and use in binary form, without
modification, are permitted provided that the following conditions are
met:
* Redistributions must reproduce the above copyright notice and the
following disclaimer in the documentation and/or other materials
provided with the distribution.
* Neither the name of Ralink Technology Corporation nor the names of its
suppliers may be used to endorse or promote products derived from this
software without specific prior written permission.
* No reverse engineering, decompilation, or disassembly of this software
is permitted.
Limited patent license. Ralink Technology Corporation grants a world-wide,
royalty-free, non-exclusive license under patents it now or hereafter
owns or controls to make, have made, use, import, offer to sell and
sell ("Utilize") this software, but solely to the extent that any
such patent is necessary to Utilize the software alone, or in
combination with an operating system licensed under an approved Open
Source license as listed by the Open Source Initiative at
http://opensource.org/licenses. The patent license shall not apply to
any other combinations which include this software. No hardware per
se is licensed hereunder.
DISCLAIMER. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.
*/
/* AUTO GEN PLEASE DO NOT MODIFY IT */
(followed by a big array of bytes)
This fails several of the DFSG:
Redistribution is allowed only without modification. This breaks the "Derived
Works" requirement.
"No reverse engineering, decompilation, or disassembly of this software is
permitted." breaks the "No Discrimination Against Fields of Endeavor"
requirement.
There is no source code so it breaks the "Source Code" requirement. The byte
array is just a C equivalent of the binary image. It is explicitly prohibited
to decompile the image, suggesting it is a result of some compilation from e.g.
some source code (which is not provided).
Thanks,
dam
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable'), (450, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.29-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
