Bug#617488: [linux-2.6] No input device for IR remote on Pinnacle PCTV 110i (saa7133) video board

2011-03-20 Thread Ben Hutchings 
On Sat, 2011-03-19 at 13:09 +0500, Alex Volkov wrote:
 Version 2.6.38-1 seems to have the same issue. Slightly modifed patch follows:

Thanks for the patch, but I am not qualified to review this change
myself.  Please can you submit it upstream first, with the explanation
and the proper sign-off (see Documentation/SubmittingPatches)?  You
should send mail to Mauro Carvalho Chehab mche...@infradead.org
and cc David Hardeman da...@hardeman.nu, linux-me...@vger.kernel.org,
617...@bugs.debian.org.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part

Bug#617488: [linux-2.6] No input device for IR remote on Pinnacle PCTV 110i (saa7133) video board

2011-03-19 Thread Alex Volkov 
Version 2.6.38-1 seems to have the same issue. Slightly modifed patch follows:
diff -U 3 -H -B -d -p -r -N -- a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
--- a/drivers/media/video/saa7134/saa7134-input.c	2011-03-15 06:20:32.0 +0500
+++ b/drivers/media/video/saa7134/saa7134-input.c	2011-03-18 23:29:13.0 +0500
@@ -820,6 +820,7 @@ void saa7134_probe_i2c_ir(struct saa7134
 	memset(info, 0, sizeof(struct i2c_board_info));
 	memset(dev-init_data, 0, sizeof(dev-init_data));
 	strlcpy(info.type, ir_video, I2C_NAME_SIZE);
+	dev-init_data.type = RC_TYPE_OTHER;
 
 	switch (dev-board) {
 	case SAA7134_BOARD_PINNACLE_PCTV_110i:

Bug#617488: [linux-2.6] No input device for IR remote on Pinnacle PCTV 110i (saa7133) video board

2011-03-09 Thread Alex Volkov 
Package: linux-2.6
Version: 2.6.37-2
Severity: normal
Tags: patch

--- Please enter the report below this line. ---
Hello.

Pinnacle PCTV 110i TV-tuner board has IR remote control, which was recognized
by kernel as input device before this (http://goo.gl/U3Fal) upstream patch. 
Since then, ir-kbd-i2c module fails to probe it with the following debug 
message:

ir-kbd-i2c: : Unsupported device at address 0x47

which is probably due to some uninitialized structure member. I tried to look 
for fix in the upstream, but cannot find any yet (they did a lot of code 
rearranging). Well, don't know how useful is this patch for upstream, but it 
fixes the problem anyway:

diff -uNr a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
--- a/drivers/media/video/saa7134/saa7134-input.c	2011-01-05 05:50:19.0 +0500
+++ b/drivers/media/video/saa7134/saa7134-input.c	2011-03-09 14:17:05.0 +0500
@@ -936,6 +936,7 @@
 	memset(info, 0, sizeof(struct i2c_board_info));
 	memset(dev-init_data, 0, sizeof(dev-init_data));
 	strlcpy(info.type, ir_video, I2C_NAME_SIZE);
+	dev-init_data.type = IR_TYPE_OTHER;
 
 	switch (dev-board) {
 	case SAA7134_BOARD_PINNACLE_PCTV_110i: