Bug#632923: [PATCH] perf: do not look at ./config for configuration

2011-08-05 Thread Jonathan Nieder
In addition to /etc/perfconfig and $HOME/.perfconfig, perf looks for
configuration in the file ./config, imitating git which looks at
$GIT_DIR/config.  If ./config is not a perf configuration file, it
fails, or worse, treats it as a configuration file and changes
behavior in some unexpected way.

"config" is not an unusual name for a file to be lying around and perf
does not have a private directory dedicated for its own use, so let's
just stop looking for configuration in the cwd.  Callers needing
context-sensitive configuration can use the PERF_CONFIG environment
variable.

Requested-by: Christian Ohm 
Signed-off-by: Jonathan Nieder 
---
Thoughts?

 tools/perf/util/config.c |7 ---
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index e02d78ca..6c86eca8 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -399,7 +399,6 @@ static int perf_config_global(void)
 int perf_config(config_fn_t fn, void *data)
 {
int ret = 0, found = 0;
-   char *repo_config = NULL;
const char *home = NULL;
 
/* Setting $PERF_CONFIG makes perf read _only_ the given config file. */
@@ -421,12 +420,6 @@ int perf_config(config_fn_t fn, void *data)
free(user_config);
}
 
-   repo_config = perf_pathdup("config");
-   if (!access(repo_config, R_OK)) {
-   ret += perf_config_from_file(fn, repo_config, data);
-   found += 1;
-   }
-   free(repo_config);
if (found == 0)
return -1;
return ret;
-- 
1.7.6




-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110805165838.ga7...@elie.gateway.2wire.net



Bug#632923: [PATCH] perf: do not look at ./config for configuration

2011-08-05 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 05, 2011 at 06:58:38PM +0200, Jonathan Nieder escreveu:
> In addition to /etc/perfconfig and $HOME/.perfconfig, perf looks for
> configuration in the file ./config, imitating git which looks at
> $GIT_DIR/config.  If ./config is not a perf configuration file, it
> fails, or worse, treats it as a configuration file and changes
> behavior in some unexpected way.
> 
> "config" is not an unusual name for a file to be lying around and perf
> does not have a private directory dedicated for its own use, so let's
> just stop looking for configuration in the cwd.  Callers needing
> context-sensitive configuration can use the PERF_CONFIG environment
> variable.

Thanks, I'll apply this one.

- Arnaldo



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110805173447.gc14...@ghostprotocols.net