Bug#673391: Revised patches for be2net
On Mon, 2012-07-09 at 22:14 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am sorry I missed this mail. Is your comment with respect to these two patches or are you asking me why I haven’t given any further updates? Just those specific two patches. Ben. Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Monday, June 25, 2012 8:59 AM To: Bandi,Sarveshwar Cc: 673...@bugs.debian.org Subject: Re: Bug#673391: Revised patches for be2net On Thu, 2012-05-31 at 06:45 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. I don't see the point. But do let us know (in a new bug report) if and when there are substantial bug fixes or new hardware support. Ben. -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it needed replacing anyway. -- Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap. signature.asc Description: This is a digitally signed message part
Bug#673391: Revised patches for be2net
Ben, I am sorry I missed this mail. Is your comment with respect to these two patches or are you asking me why I haven’t given any further updates? Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Monday, June 25, 2012 8:59 AM To: Bandi,Sarveshwar Cc: 673...@bugs.debian.org Subject: Re: Bug#673391: Revised patches for be2net On Thu, 2012-05-31 at 06:45 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. I don't see the point. But do let us know (in a new bug report) if and when there are substantial bug fixes or new hardware support. Ben. -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it needed replacing anyway.
Bug#673391: Revised patches for be2net
On Thu, 2012-05-31 at 06:45 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. I don't see the point. But do let us know (in a new bug report) if and when there are substantial bug fixes or new hardware support. Ben. -- Ben Hutchings Lowery's Law: If it jams, force it. If it breaks, it needed replacing anyway. signature.asc Description: This is a digitally signed message part
Bug#673391: Revised patches for be2net
Ben, I am attaching the remaining to patches: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const Please apply them too. Thanks, Sarvesh -Original Message- From: Ben Hutchings [mailto:b...@decadent.org.uk] Sent: Sunday, May 27, 2012 5:27 AM To: Bandi,Sarveshwar; 673...@bugs.debian.org Subject: Re: Bug#673391: Revised patches for be2net On Fri, 2012-05-25 at 09:30 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the revised patches as per your comments. I was not sure how to handle patches (4 of them) which involved changes to other drivers too. I intend to open separate bugs for each of them and send them. Hope that is ok. No, there's no need to open more bugs. I have also taken care of your comment to not change the return value in ndo_vlan_rx_[add/kill]_vid (8e586137e6b63af1e881b328466ab5ffbe562510). The patches also contain the upstream commit id thanks to your git-format-patch-for-backport script. Thanks. So the remaining 4 changes are: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const It's absolutely fine to apply just the parts of these that affect your driver, as in your original series. 8e58613 net: make vlan ndo_vlan_rx_[add/kill]_vid return error value This should not be applied at all, as we don't want to change the kernel API. 786f528 ethtool: Null-terminate filename passed to ethtool_ops::flash_device I think this is an important bug fix (well I would do :-) so I'll apply it and also propose to David Miller that it goes into stable updates. Ben. -- Ben Hutchings The obvious mathematical breakthrough [to break modern encryption] would be development of an easy way to factor large prime numbers. - Bill Gates 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch Description: 0001-sweep-the-floors-and-convert-some-.get_drvinfo-routi.patch 0027-netdev-make-net_device_ops-const.patch Description: 0027-netdev-make-net_device_ops-const.patch
Bug#673391: Revised patches for be2net
On Fri, 2012-05-25 at 09:30 -0700, sarveshwar.ba...@emulex.com wrote: Ben, I am attaching the revised patches as per your comments. I was not sure how to handle patches (4 of them) which involved changes to other drivers too. I intend to open separate bugs for each of them and send them. Hope that is ok. No, there's no need to open more bugs. I have also taken care of your comment to not change the return value in ndo_vlan_rx_[add/kill]_vid (8e586137e6b63af1e881b328466ab5ffbe562510). The patches also contain the upstream commit id thanks to your git-format-patch-for-backport script. Thanks. So the remaining 4 changes are: 68aad78 sweep the floors and convert some .get_drvinfo routines to strlcpy e5686ad netdev: make net_device_ops const It's absolutely fine to apply just the parts of these that affect your driver, as in your original series. 8e58613 net: make vlan ndo_vlan_rx_[add/kill]_vid return error value This should not be applied at all, as we don't want to change the kernel API. 786f528 ethtool: Null-terminate filename passed to ethtool_ops::flash_device I think this is an important bug fix (well I would do :-) so I'll apply it and also propose to David Miller that it goes into stable updates. Ben. -- Ben Hutchings The obvious mathematical breakthrough [to break modern encryption] would be development of an easy way to factor large prime numbers. - Bill Gates signature.asc Description: This is a digitally signed message part
